coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[M] Change in coreboot[master]: nb/intel/i945/rcven.c: Use enum cb_err for static functions
by Elyes Haouas (Code Review) 03 Oct '22

03 Oct '22

Elyes Haouas has restored this change. ( https://review.coreboot.org/c/coreboot/+/61802 ) Change subject: nb/intel/i945/rcven.c: Use enum cb_err for static functions ...................................................................... Restored -- To view, visit https://review.coreboot.org/c/coreboot/+/61802 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia8f5e92fec20fe9a9c9b8615c40fc3e7378d3513 Gerrit-Change-Number: 61802 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: restore

1 0

[S] Change in coreboot[master]: mb/google/brya/var/mithrax: adjust I2C5 times for TP
by Tarun Tuli (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Frank Wu, John Su, YH Lin, Subrata Banik, Paul Menzel, Tim Wawrzynczak, Nick Vaccaro. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67920 ) Change subject: mb/google/brya/var/mithrax: adjust I2C5 times for TP ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/67920/comment/99f0c772_a6b4634a PS4, Line 17: TEST=emerge-brya coreboot chromeos-bootimage Could we add some details of what was tested/presumably we confirmed touchpad was still functional? Building the image doesn't tell us too much here. Thanks! -- To view, visit https://review.coreboot.org/c/coreboot/+/67920 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5977f0dbba8924cc8a1c72c36358d6ba6f2de940 Gerrit-Change-Number: 67920 Gerrit-PatchSet: 4 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Mon, 03 Oct 2022 13:42:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: drivers/generic/cbfs-uuid: Add driver to include UUID from CBFS
by Angel Pons (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Michał Żygowski, Paul Menzel, Krystian Hebel. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64639 ) Change subject: drivers/generic/cbfs-uuid: Add driver to include UUID from CBFS ...................................................................... Patch Set 10: (1 comment) File src/drivers/generic/cbfs-uuid/cbfs-uuid.c: https://review.coreboot.org/c/coreboot/+/64639/comment/4ecce217_14b2ab89 PS10, Line 18: obsolete > Obsolete means out of date, please use another word. I'd replace "all obsolete characters" with "any trailing whitespace". However, looks like the code simply expects the UUID to have a predefined length and will merely truncate anything that comes after the first N bytes. -- To view, visit https://review.coreboot.org/c/coreboot/+/64639 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22f22f4e8742716283d2fcaba4894c06cef3a4bf Gerrit-Change-Number: 64639 Gerrit-PatchSet: 10 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Comment-Date: Mon, 03 Oct 2022 13:33:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim/port_descriptors: update DDI for MDN
by Jason Nein (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Matt DeVillier, Martin Roth, Fred Reitberger, Felix Held. Jason Nein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66847 ) Change subject: mb/google/skyrim/port_descriptors: update DDI for MDN ...................................................................... Patch Set 7: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/66847/comment/cd24217e_69ed98cd PS1, Line 7: > indent Done File src/mainboard/google/skyrim/port_descriptors.c: https://review.coreboot.org/c/coreboot/+/66847/comment/a98140c0_3c33f94a PS1, Line 71: { /* DDI4 - Unused */ > i'm a bit surprised that we don't need the 5th DDI descriptor to be set to unused, since the default […] Done File src/vendorcode/amd/fsp/mendocino/platform_descriptors.h: https://review.coreboot.org/c/coreboot/+/66847/comment/d501309d_c572fd84 PS1, Line 147: DDI_DP_W_TYPEC > i think at the time i looked at the reference code those weren't there, but might be that i just loo […] Yes. I confirmed it's match now https://review.coreboot.org/c/coreboot/+/66847/comment/11002047_3350e8a6 PS1, Line 148: DDI_DP_WO_TYPEC > Can you add a comment to each of them Done -- To view, visit https://review.coreboot.org/c/coreboot/+/66847 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I02793f032f9855dac202a5aca8666c26426d6cb2 Gerrit-Change-Number: 66847 Gerrit-PatchSet: 7 Gerrit-Owner: Jason Nein <finaljason(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 03 Oct 2022 13:16:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim/port_descriptors: update DDI for MDN
by build bot (Jenkins) (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Matt DeVillier, Martin Roth, Fred Reitberger. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66847 ) Change subject: mb/google/skyrim/port_descriptors: update DDI for MDN ...................................................................... Patch Set 7: (6 comments) File src/mainboard/google/skyrim/port_descriptors.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159593): https://review.coreboot.org/c/coreboot/+/66847/comment/a1a8a3df_eacf08e4 PS7, Line 71: { /* DDI4 - Unused */ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159593): https://review.coreboot.org/c/coreboot/+/66847/comment/3a354cfd_367d373b PS7, Line 71: { /* DDI4 - Unused */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159593): https://review.coreboot.org/c/coreboot/+/66847/comment/7f694f60_4deab88e PS7, Line 71: { /* DDI4 - Unused */ please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159593): https://review.coreboot.org/c/coreboot/+/66847/comment/dfe9ff9a_58846a3d PS7, Line 72: .connector_type = DDI_UNUSED_TYPE, code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159593): https://review.coreboot.org/c/coreboot/+/66847/comment/e6226485_72300032 PS7, Line 72: .connector_type = DDI_UNUSED_TYPE, please, no space before tabs Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159593): https://review.coreboot.org/c/coreboot/+/66847/comment/b8ab6cc3_1244764b PS7, Line 72: .connector_type = DDI_UNUSED_TYPE, please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/66847 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I02793f032f9855dac202a5aca8666c26426d6cb2 Gerrit-Change-Number: 66847 Gerrit-PatchSet: 7 Gerrit-Owner: Jason Nein <finaljason(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Mon, 03 Oct 2022 13:12:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim/port_descriptors: update DDI for MDN
by build bot (Jenkins) (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Matt DeVillier, Martin Roth, Fred Reitberger. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66847 ) Change subject: mb/google/skyrim/port_descriptors: update DDI for MDN ...................................................................... Patch Set 6: (6 comments) File src/mainboard/google/skyrim/port_descriptors.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159592): https://review.coreboot.org/c/coreboot/+/66847/comment/6dc6b801_a9d152a5 PS6, Line 71: { /* DDI4 - Unused */ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159592): https://review.coreboot.org/c/coreboot/+/66847/comment/4c17def7_fe2dcfd2 PS6, Line 71: { /* DDI4 - Unused */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159592): https://review.coreboot.org/c/coreboot/+/66847/comment/e6f2e525_66e0b3e7 PS6, Line 71: { /* DDI4 - Unused */ please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159592): https://review.coreboot.org/c/coreboot/+/66847/comment/1c30ddda_0ccf6423 PS6, Line 72: .connector_type = DDI_UNUSED_TYPE, code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159592): https://review.coreboot.org/c/coreboot/+/66847/comment/55df07c7_e6bb3bae PS6, Line 72: .connector_type = DDI_UNUSED_TYPE, please, no space before tabs Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159592): https://review.coreboot.org/c/coreboot/+/66847/comment/1ae8ca04_d7bc403c PS6, Line 72: .connector_type = DDI_UNUSED_TYPE, please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/66847 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I02793f032f9855dac202a5aca8666c26426d6cb2 Gerrit-Change-Number: 66847 Gerrit-PatchSet: 6 Gerrit-Owner: Jason Nein <finaljason(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Mon, 03 Oct 2022 13:11:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in libgfxinit[master]: hw-gfx-gma: Update BDSM register offset for TGL onwards
by Sean Rhodes (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Nico Huber, Tim Wawrzynczak, Angel Pons. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/65178 ) Change subject: hw-gfx-gma: Update BDSM register offset for TGL onwards ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/65178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I0a3e7a92dcb08ea33e08c9f2c5135d4269c9e0b9 Gerrit-Change-Number: 65178 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 03 Oct 2022 11:56:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in libgfxinit[master]: common: Begin Tiger Lake integration
by Sean Rhodes (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Nico Huber, Tim Wawrzynczak, Angel Pons, Arthur Heymans. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/65087 ) Change subject: common: Begin Tiger Lake integration ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/65087 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Ic8d32598e5611453ce53f1deaeab981b9f2a952f Gerrit-Change-Number: 65087 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 03 Oct 2022 11:56:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: drivers/generic/cbfs-uuid: Add driver to include UUID from CBFS
by Krystian Hebel (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Michał Żygowski, Paul Menzel, Angel Pons. Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64639 ) Change subject: drivers/generic/cbfs-uuid: Add driver to include UUID from CBFS ...................................................................... Patch Set 10: (2 comments) File Documentation/drivers/cbfs_smbios.md: https://review.coreboot.org/c/coreboot/+/64639/comment/8e90e1c5_2a6a83c8 PS10, Line 60: 2 `up to 2` File src/drivers/generic/cbfs-uuid/cbfs-uuid.c: https://review.coreboot.org/c/coreboot/+/64639/comment/ea2c9d49_95975a72 PS10, Line 18: obsolete Obsolete means out of date, please use another word. -- To view, visit https://review.coreboot.org/c/coreboot/+/64639 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22f22f4e8742716283d2fcaba4894c06cef3a4bf Gerrit-Change-Number: 64639 Gerrit-PatchSet: 10 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 03 Oct 2022 11:29:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/yaviks: Config I2C frequency
by Wisley Chen (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Kangheui Won, Chen Wisley, Reka Norman, Tim Wawrzynczak, Shou-Chieh Hsu. Wisley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68082 ) Change subject: mb/google/nissa/var/yaviks: Config I2C frequency ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/68082/comment/e2065a4b_80e493ed PS4, Line 10: After applied this patch, the meaused the I2C frequency are as follows: > nit: measured Thanks -- To view, visit https://review.coreboot.org/c/coreboot/+/68082 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I33c2891f17bc3c572bbfcbf30bbbdef9eb850ce7 Gerrit-Change-Number: 68082 Gerrit-PatchSet: 5 Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Comment-Date: Mon, 03 Oct 2022 11:26:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022