coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[XL] Change in coreboot[master]: mb/protectli/vault_cml: Add Comet Lake 6 port board support
by Michał Żygowski (Code Review) 03 Oct '22

03 Oct '22

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67940 ) Change subject: mb/protectli/vault_cml: Add Comet Lake 6 port board support ...................................................................... Patch Set 6: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/67940 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If1b4f9c8245a082ff875ae9c6102a1c45e677d0b Gerrit-Change-Number: 67940 Gerrit-PatchSet: 6 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 03 Oct 2022 14:51:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim: Enable amdfw separation
by Karthik Ramasubramanian (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Robert Zieba, Raul Rangel, Jason Nien, Martin Roth, Tim Van Patten. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67261 ) Change subject: mb/google/skyrim: Enable amdfw separation ...................................................................... Patch Set 15: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/67261/comment/5dc4f9c4_65e04834 PS14, Line 17: Before this patch series: > > Possible unwrapped commit description (prefer a maximum 72 chars per line) […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/67261 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I78ec6d28b4c5fc40bdade47489d58180a54dee4d Gerrit-Change-Number: 67261 Gerrit-PatchSet: 15 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Robert Zieba <robertzieba(a)google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Comment-Date: Mon, 03 Oct 2022 14:50:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim/port_descriptors: update DDI for MDN
by Raul Rangel (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Jason Glenesk, Marshall Dawson, Matt DeVillier, Jason Nein, Martin Roth, Fred Reitberger, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66847 ) Change subject: mb/google/skyrim/port_descriptors: update DDI for MDN ...................................................................... Patch Set 7: Code-Review+1 (1 comment) File src/mainboard/google/skyrim/port_descriptors.c: https://review.coreboot.org/c/coreboot/+/66847/comment/6c12f105_1cb35cb4 PS7, Line 71: { /* DDI4 - Unused */ > please, no space before tabs Please fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/66847 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I02793f032f9855dac202a5aca8666c26426d6cb2 Gerrit-Change-Number: 66847 Gerrit-PatchSet: 7 Gerrit-Owner: Jason Nein <finaljason(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Jason Nein <finaljason(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 03 Oct 2022 14:49:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim: Enable amdfw separation
by Karthik Ramasubramanian (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Robert Zieba, Raul Rangel, Jason Nien, Tim Van Patten, Karthik Ramasubramanian. Hello build bot (Jenkins), Robert Zieba, Raul Rangel, Jason Nien, Jon Murphy, Martin Roth, Tim Van Patten, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/67261 to look at the new patch set (#15). Change subject: mb/google/skyrim: Enable amdfw separation ...................................................................... mb/google/skyrim: Enable amdfw separation Select the config to separate the AMDFW binary from the verified boot section. BUG=b:203597980 TEST=Build Skyrim BIOS image and boot to OS with PSP verstage passing the hash table and PSP verifying the binaries against the hash table. Observe boot time improvement of ~120 ms while operating SPI bus at 66 MHz with PSP verstage enabled. Before this patch series: 508:finished loading body 1,978,053,432 (201,518) After this patch series: 508:finished loading body 7,948,797,849 (83,460) Change-Id: I78ec6d28b4c5fc40bdade47489d58180a54dee4d Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com> --- M src/mainboard/google/skyrim/Kconfig M src/mainboard/google/skyrim/chromeos.fmd 2 files changed, 26 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/67261/15 -- To view, visit https://review.coreboot.org/c/coreboot/+/67261 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I78ec6d28b4c5fc40bdade47489d58180a54dee4d Gerrit-Change-Number: 67261 Gerrit-PatchSet: 15 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Robert Zieba <robertzieba(a)google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/cannonlake: Report missing CML-U IGD devices
by Michał Żygowski (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Angel Pons. Hello build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68019 to look at the new patch set (#2). Change subject: soc/intel/cannonlake: Report missing CML-U IGD devices ...................................................................... soc/intel/cannonlake: Report missing CML-U IGD devices Report the Comet Lake IGD device IDs added in patch CB:67975. Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: I5357a14103cc823c03e434e01e6873e538ffa280 --- M src/soc/intel/cannonlake/bootblock/report_platform.c 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/68019/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68019 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5357a14103cc823c03e434e01e6873e538ffa280 Gerrit-Change-Number: 68019 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/cmn/gfx: Add missing CML-U IGD device IDs
by Michał Żygowski (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Angel Pons. Hello build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/67975 to look at the new patch set (#4). Change subject: soc/intel/cmn/gfx: Add missing CML-U IGD device IDs ...................................................................... soc/intel/cmn/gfx: Add missing CML-U IGD device IDs Intel Core i5-10210U can have the following IGD Device IDs 0x9B21/0x9B41/0x9BAC/0x9BCA/0x9BCC according to Intel ARK. Some of these ID were not present in coreboot source nor hooked to the common graphics driver. Add the missing IDs so that the graphics driver will probe on the mentioned processor and detect the framebuffer. TEST=Boot Protectli VP4650 with i5-1021U and see framebuffer is detected when using FSP GOP and libgfxinit. Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: Iee720a272367aead31c8c8fa712bade1b6e53948 --- M src/include/device/pci_ids.h M src/soc/intel/common/block/graphics/graphics.c 2 files changed, 24 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/67975/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/67975 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee720a272367aead31c8c8fa712bade1b6e53948 Gerrit-Change-Number: 67975 Gerrit-PatchSet: 4 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: nb/intel/i945/rcven.c: Use 'enum cb_err' instead of 'int'
by Elyes Haouas (Code Review) 03 Oct '22

03 Oct '22

Hello build bot (Jenkins), Arthur Heymans, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/61802 to look at the new patch set (#5). Change subject: nb/intel/i945/rcven.c: Use 'enum cb_err' instead of 'int' ...................................................................... nb/intel/i945/rcven.c: Use 'enum cb_err' instead of 'int' Change-Id: Ia8f5e92fec20fe9a9c9b8615c40fc3e7378d3513 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/northbridge/intel/i945/rcven.c 1 file changed, 35 insertions(+), 25 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/61802/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/61802 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia8f5e92fec20fe9a9c9b8615c40fc3e7378d3513 Gerrit-Change-Number: 61802 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: nb/intel/i945/rcven.c: Use 'enum cb_err' instead of 'int'.
by build bot (Jenkins) (Code Review) 03 Oct '22

03 Oct '22

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61802 ) Change subject: nb/intel/i945/rcven.c: Use 'enum cb_err' instead of 'int'. ...................................................................... Patch Set 2: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159595): https://review.coreboot.org/c/coreboot/+/61802/comment/ac8dd034_7090672d PS2, Line 6: Subject line should not end with a period. -- To view, visit https://review.coreboot.org/c/coreboot/+/61802 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia8f5e92fec20fe9a9c9b8615c40fc3e7378d3513 Gerrit-Change-Number: 61802 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 03 Oct 2022 13:56:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: nb/intel/i945/rcven.c: Use read32p()
by Elyes Haouas (Code Review) 03 Oct '22

03 Oct '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68087 ) Change subject: nb/intel/i945/rcven.c: Use read32p() ...................................................................... nb/intel/i945/rcven.c: Use read32p() Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: I1935308cc50abd651b52d6290d66180905c6a521 --- M src/northbridge/intel/i945/rcven.c 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/68087/1 diff --git a/src/northbridge/intel/i945/rcven.c b/src/northbridge/intel/i945/rcven.c index 03b56f1..b8df348 100644 --- a/src/northbridge/intel/i945/rcven.c +++ b/src/northbridge/intel/i945/rcven.c @@ -29,8 +29,8 @@ } for (i = 0; i < 28; i++) { - read32((void *)addr); - read32((void *)(addr + 0x80)); + read32p(addr); + read32p(addr + 0x80); } reg32 = mchbar_read32(RCVENMT); -- To view, visit https://review.coreboot.org/c/coreboot/+/68087 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1935308cc50abd651b52d6290d66180905c6a521 Gerrit-Change-Number: 68087 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: nb/intel/i945/rcven.c: Use 'enum cb_err' instead of 'int'.
by Elyes Haouas (Code Review) 03 Oct '22

03 Oct '22

Hello build bot (Jenkins), Arthur Heymans, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/61802 to look at the new patch set (#2). Change subject: nb/intel/i945/rcven.c: Use 'enum cb_err' instead of 'int'. ...................................................................... nb/intel/i945/rcven.c: Use 'enum cb_err' instead of 'int'. Change-Id: Ia8f5e92fec20fe9a9c9b8615c40fc3e7378d3513 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/northbridge/intel/i945/rcven.c 1 file changed, 35 insertions(+), 25 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/61802/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/61802 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia8f5e92fec20fe9a9c9b8615c40fc3e7378d3513 Gerrit-Change-Number: 61802 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022