coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[S] Change in coreboot[master]: vboot: change name of the GCVD root pub key file
by Vadim Bendebury (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Julius Werner, Yu-Ping Wu. Vadim Bendebury has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68057 ) Change subject: vboot: change name of the GCVD root pub key file ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/68057/comment/4b3bfa8d_55d39a10 PS2, Line 11: vboot reference > I still see `tests/devkeys/arv_root.vbpubk` (and not `root_key_arv_root.vbpubk`) in vboot_reference. […] There is a change coming in vboot reference which will change the key name, upstream coreboot does not have to work with vboot_reference, right? Once this is cherry-picked for merging internally I would submit a vboot reference change and set cq-depends. This is needed to match the dev key names with ones automatically generated by the HSM, just as a good housekeeping. -- To view, visit https://review.coreboot.org/c/coreboot/+/68057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia98438719adcb4b9b99b8823c8d5c04a0f381a0e Gerrit-Change-Number: 68057 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 03 Oct 2022 21:48:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/alderlake: Fix unknown voltage in SMBIOS
by Jérémy Compostella (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Zhixing Ma, Bora Guvendik, Tim Wawrzynczak, Nick Vaccaro. Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68023 ) Change subject: soc/intel/alderlake: Fix unknown voltage in SMBIOS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/68023 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I77712b72fa47bdcb56ffddeff15cff9f3b3bbe86 Gerrit-Change-Number: 68023 Gerrit-PatchSet: 1 Gerrit-Owner: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Mon, 03 Oct 2022 21:39:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/apollolake/acpi: Add PCIEXBAR to MCHC
by Sean Rhodes (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Arthur Heymans, Andrey Petrov. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66230 ) Change subject: soc/intel/apollolake/acpi: Add PCIEXBAR to MCHC ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: Anyone for the +2? 😊 -- To view, visit https://review.coreboot.org/c/coreboot/+/66230 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14c5933b9022703c8951da7c6a26eb703258ec37 Gerrit-Change-Number: 66230 Gerrit-PatchSet: 7 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Mon, 03 Oct 2022 20:40:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/apollolake/acpi: Tidy the Legacy video RAM
by Sean Rhodes (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Paul Menzel, Andrey Petrov. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66240 ) Change subject: soc/intel/apollolake/acpi: Tidy the Legacy video RAM ...................................................................... Patch Set 14: (1 comment) File src/soc/intel/apollolake/acpi/northbridge.asl: https://review.coreboot.org/c/coreboot/+/66240/comment/780c0d4e_65b5e11e PS14, Line 60: 0x00020000,,, LGB1) > Why is this useful? Easy referencing, I can remove it if needs be? -- To view, visit https://review.coreboot.org/c/coreboot/+/66240 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie6572638c6bbe910745de55afa44458fb6b8db9c Gerrit-Change-Number: 66240 Gerrit-PatchSet: 14 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Mon, 03 Oct 2022 20:39:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/apollolake: Remove SD Card interrupt for GLK
by Matt DeVillier (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Sean Rhodes, Andrey Petrov. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67679 ) Change subject: soc/intel/apollolake: Remove SD Card interrupt for GLK ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67679 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6921fc3db430c76ec54cf832ce51c627a507385c Gerrit-Change-Number: 67679 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Mon, 03 Oct 2022 20:38:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/apollolake: Add UFS Interrupt
by Matt DeVillier (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Sean Rhodes, Andrey Petrov. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67680 ) Change subject: soc/intel/apollolake: Add UFS Interrupt ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67680 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I68bac590bd1a9a0b8213440e882c8f431f06c95f Gerrit-Change-Number: 67680 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Mon, 03 Oct 2022 20:37:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/starlabs/starbook/tgl: Remove PCIEXP_HOTPLUG_PREFETCH_MEM_BELOW_4G
by Sean Rhodes (Code Review) 03 Oct '22

03 Oct '22

Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68084 ) Change subject: mb/starlabs/starbook/tgl: Remove PCIEXP_HOTPLUG_PREFETCH_MEM_BELOW_4G ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/68084 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82841c2114ceb5e7a46ce228fce63d24822098d2 Gerrit-Change-Number: 68084 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 03 Oct 2022 20:04:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/starlabs/starbook/tgl: Configure PMC mux
by Sean Rhodes (Code Review) 03 Oct '22

03 Oct '22

Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68083 ) Change subject: mb/starlabs/starbook/tgl: Configure PMC mux ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/68083 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I297d5446e43357d97357f345668cf40dcd28502d Gerrit-Change-Number: 68083 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 03 Oct 2022 20:04:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/apollolake: Remove SD Card interrupt for GLK
by Sean Rhodes (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Matt DeVillier, Andrey Petrov. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67679 ) Change subject: soc/intel/apollolake: Remove SD Card interrupt for GLK ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > assuming this is coming from the public datasheet? If so, note in commit msg? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/67679 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6921fc3db430c76ec54cf832ce51c627a507385c Gerrit-Change-Number: 67679 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Mon, 03 Oct 2022 20:03:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/apollolake: Add UFS Interrupt
by Sean Rhodes (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Matt DeVillier, Andrey Petrov. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67680 ) Change subject: soc/intel/apollolake: Add UFS Interrupt ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > assuming this is coming from the public datasheet? If so, note in commit msg? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/67680 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I68bac590bd1a9a0b8213440e882c8f431f06c95f Gerrit-Change-Number: 67680 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Mon, 03 Oct 2022 20:03:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022