coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[M] Change in coreboot[master]: spd/lp5: Add new memory configuration of H9JCNNNFA5MLYR-N6E
by 9elements QA (Code Review) 20 Oct '22

20 Oct '22

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68154 ) Change subject: spd/lp5: Add new memory configuration of H9JCNNNFA5MLYR-N6E ...................................................................... Patch Set 7: Automatic boot test returned (PASS/FAIL/TOTAL): 15 / 1 / 16 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES_ and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/129115 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/129114 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/129113 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/129112 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload TianoCore : https://lava.9esec.io/r/129111 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/129110 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload TianoCore : https://lava.9esec.io/r/129109 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/129108 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload TianoCore : https://lava.9esec.io/r/129107 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload SeaBIOS : https://lava.9esec.io/r/129106 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload TianoCore : https://lava.9esec.io/r/129105 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload SeaBIOS : https://lava.9esec.io/r/129104 FAIL: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/129103 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/129102 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/129101 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/129100 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/68154 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9926a5859cf060e0bfa903f47d8a98c8d6115579 Gerrit-Change-Number: 68154 Gerrit-PatchSet: 7 Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Chao Gui <chaogui(a)google.com> Gerrit-Reviewer: Isaac Lee <isaaclee(a)google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-CC: Reka Norman <rekanorman(a)chromium.org> Gerrit-CC: Rob Barnes <robbarnes(a)google.com> Gerrit-Comment-Date: Thu, 20 Oct 2022 21:03:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: cbfstool: Expand the max size of image to 32M
by Julius Werner (Code Review) 20 Oct '22

20 Oct '22

Attention is currently required from: Bao Zheng, Zheng Bao. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68389 ) Change subject: cbfstool: Expand the max size of image to 32M ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: This is not what you think it is, and it would break existing boards. 32M images are already possible and being used (see e.g. google/volteer/chromeos.fmd). The problem is that on Intel chipsets, for flash sizes >16MB the flash is no longer memory-mapped in one contiguous block. Instead, the top 16MB are mapped at 0xff000000-0xffffffff, and the rest is mapped at a separate, chipset-specific "extended window" location. You have to supply the --ext-win-base and --ext-win-size options to cbfstool to specify that location (see CONFIG_EXT_BIOS_WIN_BASE and related options). -- To view, visit https://review.coreboot.org/c/coreboot/+/68389 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I91e3488e6bf5748346c249ded723d3aa7b6f11b9 Gerrit-Change-Number: 68389 Gerrit-PatchSet: 1 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Zheng Bao Gerrit-Comment-Date: Thu, 20 Oct 2022 20:53:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: util/scripts: Add script to show platforms, CPU, type, and date added
by build bot (Jenkins) (Code Review) 20 Oct '22

20 Oct '22

Attention is currently required from: Felix Singer, Raul Rangel, Martin L Roth, Stefan Reinauer, Nicholas Chin. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63799 ) Change subject: util/scripts: Add script to show platforms, CPU, type, and date added ...................................................................... Patch Set 4: (3 comments) File util/scripts/show_platforms.sh: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-160918): https://review.coreboot.org/c/coreboot/+/63799/comment/56d545cf_d28d5dea PS4, Line 26: grep -v "SUBTYPE\|COMMON\|SOCKET\|ENABLE\|CONSOLE\|SMU\|depends on\|ESPI\|INTEL_CSE\|NORTHBRIDGE_AMD_AGESA\|INTEL_SLOT\|REBOOT\|DISABLE" | line length of 142 exceeds 96 columns Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-160918): https://review.coreboot.org/c/coreboot/+/63799/comment/7786c51b_ea22a5a3 PS4, Line 39: platform_type="$(sed -nE -e 's/Category: (.*)/\1/p' "${file/Kconfig/board_info.txt}" 2>/dev/null)" line length of 100 exceeds 96 columns Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-160918): https://review.coreboot.org/c/coreboot/+/63799/comment/85be18cc_9db1ee13 PS4, Line 42: printf "| %-29s | %-22s | %-10s | %-9s |\n" "${platformname}" "${chip}" "${create_date}" "${platform_type}" line length of 111 exceeds 96 columns -- To view, visit https://review.coreboot.org/c/coreboot/+/63799 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f7265d95df31f3a74aa2aa164f6a094c1139750 Gerrit-Change-Number: 63799 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Thu, 20 Oct 2022 20:51:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: util/scripts: Add script to show platforms, CPU, type, and date added
by Martin L Roth (Code Review) 20 Oct '22

20 Oct '22

Attention is currently required from: Felix Singer, Raul Rangel, Martin L Roth, Stefan Reinauer, Nicholas Chin. Hello Felix Singer, build bot (Jenkins), Raul Rangel, Stefan Reinauer, Nicholas Chin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63799 to look at the new patch set (#4). Change subject: util/scripts: Add script to show platforms, CPU, type, and date added ...................................................................... util/scripts: Add script to show platforms, CPU, type, and date added This is the script used to generate the list of platforms that were removed from the master branch at each release. Generate a list for the old branch, another for the new, and compare the two. Representative output: ```eval_rst +-------------------------+-------------------+------------+----------+ | Vendor/Board | Processor | Date added | Brd type | +=========================+===================+============+==========+ | 51nb/x210 | INTEL_KABYLAKE | 2020-03-16 | laptop | | acer/aspire_vn7_572g | INTEL_SKYLAKE | 2022-01-28 | laptop | | acer/g43t-am3 | INTEL_X4X | 2020-09-28 | desktop | | amd/bilby | AMD_PICASSO | 2021-02-17 | eval | | amd/birman | AMD_MORGANA | 2022-10-10 | eval | | system76/whl-u | INTEL_WHISKEYLAKE | 2021-04-14 | laptop | | ti/beaglebone | TI_AM335X | 2013-05-26 | sbc | | up/squared | INTEL_APOLLOLAKE | 2019-05-22 | mini | +-------------------------+-------------------+------------+----------+ ``` Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I4f7265d95df31f3a74aa2aa164f6a094c1139750 --- M util/scripts/description.md A util/scripts/show_platforms.sh 2 files changed, 80 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/63799/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/63799 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f7265d95df31f3a74aa2aa164f6a094c1139750 Gerrit-Change-Number: 63799 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: util/scripts: Add script to show platforms, CPU, type, and date added
by Martin Roth (Code Review) 20 Oct '22

20 Oct '22

Attention is currently required from: Felix Singer, Raul Rangel, Martin L Roth, Stefan Reinauer, Nicholas Chin. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63799 ) Change subject: util/scripts: Add script to show platforms, CPU, type, and date added ...................................................................... Patch Set 3: (7 comments) File util/scripts/show_platforms.sh: https://review.coreboot.org/c/coreboot/+/63799/comment/38f08442_0df3f7c2 PS3, Line 20: ${platforms} > You could use an array instead to avoid any strange shell expansion: […] Done https://review.coreboot.org/c/coreboot/+/63799/comment/05b88320_10e02ef6 PS3, Line 21: echo > If you wanted to avoid the echo you could do the following: […] Done https://review.coreboot.org/c/coreboot/+/63799/comment/334d3de2_6958e013 PS3, Line 22: ${file/Kconfig/board_info.txt} > "${file}/Kconfig/board_info. […] This is actually a replacement operator, replacing Kconfig with board_info.txt. But you're right about the quotes - it's the one thing that I don't like about shfmt - it removes the quotes from around things when it doesn't feel like they're needed. https://review.coreboot.org/c/coreboot/+/63799/comment/c9728246_9fe17fc2 PS3, Line 27: s|\s\+select\s\+||; s|\s\+if.*||; > If you wanted to make this easier to read you can pass each expressing in with -e. […] Done https://review.coreboot.org/c/coreboot/+/63799/comment/8101a6f0_05997fc2 PS3, Line 29: file > same as above Ack https://review.coreboot.org/c/coreboot/+/63799/comment/ff7ff8d3_474ab439 PS3, Line 33: file > Same Ack https://review.coreboot.org/c/coreboot/+/63799/comment/55e2b9fe_2e203ef0 PS3, Line 33: grep "Category: " "${file/Kconfig/board_info.txt}" 2>/dev/null | sed 's/Category: //' > You could do this all with sed: […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/63799 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f7265d95df31f3a74aa2aa164f6a094c1139750 Gerrit-Change-Number: 63799 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Thu, 20 Oct 2022 20:50:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/craask: Remove SAR Proximity Sensor
by 9elements QA (Code Review) 20 Oct '22

20 Oct '22

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68564 ) Change subject: mb/google/nissa/var/craask: Remove SAR Proximity Sensor ...................................................................... Patch Set 2: Automatic boot test returned (PASS/FAIL/TOTAL): 15 / 1 / 16 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES_ and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/129098 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/129097 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/129096 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/129095 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload TianoCore : https://lava.9esec.io/r/129094 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/129093 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload TianoCore : https://lava.9esec.io/r/129092 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/129091 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload TianoCore : https://lava.9esec.io/r/129090 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload SeaBIOS : https://lava.9esec.io/r/129089 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload TianoCore : https://lava.9esec.io/r/129088 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload SeaBIOS : https://lava.9esec.io/r/129087 FAIL: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/129086 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/129085 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/129084 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/129083 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/68564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia0e3eb6dba82594ca27040d6ab0197da6095f510 Gerrit-Change-Number: 68564 Gerrit-PatchSet: 2 Gerrit-Owner: Victor Ding <victording(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Thu, 20 Oct 2022 20:48:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Docs/releases: Finalize relnotes for the 4.18 release
by Felix Singer (Code Review) 20 Oct '22

20 Oct '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68467 ) Change subject: Docs/releases: Finalize relnotes for the 4.18 release ...................................................................... Docs/releases: Finalize relnotes for the 4.18 release The coreboot 4.18 release has been tagged, so the release notes can now be finalized. Updated with known issues. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I77676ddc42488e9635f1e6f995386490dca441c0 Reviewed-on: https://review.coreboot.org/c/coreboot/+/68467 Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> --- M Documentation/releases/coreboot-4.18-relnotes.md 1 file changed, 56 insertions(+), 15 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved diff --git a/Documentation/releases/coreboot-4.18-relnotes.md b/Documentation/releases/coreboot-4.18-relnotes.md index fbc4bd5..d4bfa0e 100644 --- a/Documentation/releases/coreboot-4.18-relnotes.md +++ b/Documentation/releases/coreboot-4.18-relnotes.md @@ -1,11 +1,11 @@ -Upcoming release - coreboot 4.18 release +coreboot 4.18 release ======================================================================== -The 4.18 release is quite late, but is now planned for October 16, 2022. +The 4.18 release was quite late, but was completed on October 16, 2022. -In the past 4 months since the 4.17 release, the coreboot project has -merged more than 1800 commits from over 200 different authors. Over 50 -of those authors submitted their first patches. +In the 4 months since the 4.17 release, the coreboot project has merged +more than 1800 commits from over 200 different authors. Over 50 of those +authors submitted their first patches. Welcome and thank you to all of our new contributors, and of course the work of all of the seasoned contributors is greatly appreciated. @@ -222,15 +222,37 @@ * Intel Galileo mainboard -Statistics ----------- +Statistics from commit d2d9021543 to f4c97ea131 +----------------------------------------------- -- Total Commits: 1819 -- Average Commits per day: 13.44 -- Total lines added: 150195 -- Average lines added per commit: 82.57 -- Number of patches adding more than 100 lines: 127 -- Average lines added per small commit: 38.38 -- Total lines removed: 33788 +- Total Commits: 1822 +- Average Commits per day: 13.38 +- Total lines added: 150578 +- Average lines added per commit: 82.64 +- Number of patches adding more than 100 lines: 128 +- Average lines added per small commit: 38.44 +- Total lines removed: 33849 - Average lines removed per commit: 18.58 -- Total difference between added and removed: 116407 +- Total difference between added and removed: 116729 +- Total authors: 202 +- New authors: 52 + + +Known Issues +------------ + +A couple of issues were discovered immediately following the release +that will be fixed in a follow-on point release in the upcoming weeks. + +A pair of changes ([CB:67754](https://review.coreboot.org/67754) and +[CB:67662](https://review.coreboot.org/67662)) which merged shortly +before the 4.18 release have created an issue on Intel Apollo Lake +platform boards which prevents SMM/SMI from functioning; this affects +only Apollo Lake (but not Gemini Lake) devices. +See [CB:68599](https://review.coreboot.org/68599) for the fix. + +Another issue applies to all Intel-based boards with onboard I2C TPMs +when verified boot is not enabled. The I2C buses don’t get initialized +until after the TPM, causing timeouts, TPM initialization failures, and +long boot times. See [CB:68550](https://review.coreboot.org/68550) for +the fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/68467 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I77676ddc42488e9635f1e6f995386490dca441c0 Gerrit-Change-Number: 68467 Gerrit-PatchSet: 7 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[master]: Docs/releases: Finalize relnotes for the 4.18 release
by Felix Singer (Code Review) 20 Oct '22

20 Oct '22

Attention is currently required from: Martin L Roth, Martin Roth. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68467 ) Change subject: Docs/releases: Finalize relnotes for the 4.18 release ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68467 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I77676ddc42488e9635f1e6f995386490dca441c0 Gerrit-Change-Number: 68467 Gerrit-PatchSet: 6 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Thu, 20 Oct 2022 20:33:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim/port_descriptors: update DDI for MDN and Chausie
by Nikolai Vyssotski (Code Review) 20 Oct '22

20 Oct '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Jason Nein, Chris Wang, Fred Reitberger. Nikolai Vyssotski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66847 ) Change subject: mb/google/skyrim/port_descriptors: update DDI for MDN and Chausie ...................................................................... Patch Set 10: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/66847 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I02793f032f9855dac202a5aca8666c26426d6cb2 Gerrit-Change-Number: 66847 Gerrit-PatchSet: 10 Gerrit-Owner: Jason Nein <finaljason(a)gmail.com> Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Jason Nein <finaljason(a)gmail.com> Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Thu, 20 Oct 2022 20:25:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: Revert "drivers/intel/dptf: Add multiple fan support under dptf"
by 9elements QA (Code Review) 20 Oct '22

20 Oct '22

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68568 ) Change subject: Revert "drivers/intel/dptf: Add multiple fan support under dptf" ...................................................................... Patch Set 2: Automatic boot test returned (PASS/FAIL/TOTAL): 15 / 1 / 16 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES_ and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/129081 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/129080 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/129079 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/129078 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload TianoCore : https://lava.9esec.io/r/129077 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/129076 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload TianoCore : https://lava.9esec.io/r/129075 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/129074 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload TianoCore : https://lava.9esec.io/r/129073 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload SeaBIOS : https://lava.9esec.io/r/129072 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload TianoCore : https://lava.9esec.io/r/129071 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload SeaBIOS : https://lava.9esec.io/r/129070 FAIL: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/129069 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/129068 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/129067 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/129066 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/68568 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idaeaeaed47be44166a7cba9a0a1fac50d2688e50 Gerrit-Change-Number: 68568 Gerrit-PatchSet: 2 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Baieswara Reddy Sagili <baieswara.reddy.sagili(a)intel.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Thu, 20 Oct 2022 20:14:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022