coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[S] Change in coreboot[master]: util/lint: Fix linting outside of git repos
by Felix Held (Code Review) 21 Oct '22

21 Oct '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68475 ) Change subject: util/lint: Fix linting outside of git repos ...................................................................... util/lint: Fix linting outside of git repos If the coreboot code is not in a git repository, the linters switch from using `git ls-files` to find. This requires some changes to prevent the linters from looking at the wrong files which are automatically excluded by git. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I81d138760c29a7c476280bb9d963f6be99c75d6d Reviewed-on: https://review.coreboot.org/c/coreboot/+/68475 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org> Reviewed-by: Fred Reitberger <reitbergerfred(a)gmail.com> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M util/lint/helper_functions.sh M util/lint/lint-extended-007-checkpatch M util/lint/lint-extended-015-final-newlines M util/lint/lint-stable-003-whitespace M util/lint/lint-stable-009-old-licenses 5 files changed, 33 insertions(+), 7 deletions(-) Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Elyes Haouas: Looks good to me, approved Angel Pons: Looks good to me, approved Fred Reitberger: Looks good to me, approved diff --git a/util/lint/helper_functions.sh b/util/lint/helper_functions.sh index 0c679d9..7abdab8 100644 --- a/util/lint/helper_functions.sh +++ b/util/lint/helper_functions.sh @@ -33,7 +33,8 @@ if [ "${IN_GIT_TREE}" -eq 1 ]; then FIND_FILES="${GIT} ls-files" else - FIND_FILES="find src" + FIND_FILES="find " + FINDOPTS="-type f" fi # Use git grep if the code is in a git repo, otherwise use grep. diff --git a/util/lint/lint-extended-007-checkpatch b/util/lint/lint-extended-007-checkpatch index 8ec1188..24d505b 100755 --- a/util/lint/lint-extended-007-checkpatch +++ b/util/lint/lint-extended-007-checkpatch @@ -7,7 +7,7 @@ PIDS="" DIRS="src/acpi \ src/cpu/armltd src/cpu/qemu-power8 src/cpu/qemu-x86 \ -src/drivers/gic src/drivers/ti \ +src/drivers/ti \ src/ec/purism \ src/include/boot src/include/superio src/include/sys \ src/mainboard/adlink src/mainboard/purism src/mainboard/ti \ diff --git a/util/lint/lint-extended-015-final-newlines b/util/lint/lint-extended-015-final-newlines index 2c79283..b761afb 100755 --- a/util/lint/lint-extended-015-final-newlines +++ b/util/lint/lint-extended-015-final-newlines @@ -14,7 +14,7 @@ PIDS="" INCLUDED_DIRS_AND_FILES='util/* src/* payloads/* configs/* Makefile *.inc' -EXCLUDED_DIRS='src/vendorcode/\|cbfstool/lzma/\|cbfstool/lz4/\|Documentation/\|build/\|3rdparty/\|\.git/\|coreboot-builds/\|util/nvidia/cbootimage/' +EXCLUDED_DIRS='src/vendorcode/\|cbfstool/lzma/\|cbfstool/lz4/\|Documentation/\|build/\|3rdparty/\|\.git/\|coreboot-builds/\|util/nvidia/cbootimage/\|^util/goswid/vendor' EXCLUDED_FILES='\.gif$\|\.jpg$\|\.cksum$\|\.bin$\|\.vbt$\|\.hex$\|\.ico$\|\.o$\|\.bz2$\|\.xz$\|^.tmpconfig\|\.pyc$\|_shipped$\|sha256$\|\.png$\|\.patch$' HAVE_FILE=$(command -v file 1>/dev/null 2>&1; echo $?) diff --git a/util/lint/lint-stable-003-whitespace b/util/lint/lint-stable-003-whitespace index 0611f25..838ea93 100755 --- a/util/lint/lint-stable-003-whitespace +++ b/util/lint/lint-stable-003-whitespace @@ -11,19 +11,19 @@ # shellcheck source=helper_functions.sh . "${LINTDIR}/helper_functions.sh" -EXCLUDELIST='^src/vendorcode/|^util/kconfig/|^util/nvidia/cbootimage$|^util/goswid$|COPYING|LICENSE|README|_shipped$|\.patch$|\.bin$|\.hex$|\.jpg$|\.gif$|\.ttf$|\.woff$|\.png$|\.eot$|\.vbt$|\.ico$|\.md$' +EXCLUDELIST='^src/vendorcode/|^util/kconfig/|^util/nvidia/cbootimage/|^util/goswid/|__pycache__|COPYING|LICENSE|README|_shipped$|\.patch$|\.bin$|\.hex$|\.jpg$|\.gif$|\.ttf$|\.woff$|\.png$|\.eot$|\.vbt$|\.ico$|\.md$' INCLUDELIST="src util payloads Makefile* toolchain.inc tests" # shellcheck disable=SC2086,SC2046 if uname | grep -qi "linux"; then grep -n -H "[[:space:]][[:space:]]*$" \ - $(${FIND_FILES} $INCLUDELIST | \ + $(${FIND_FILES} ${INCLUDELIST} ${FINDOPTS} | \ grep -Ev "($EXCLUDELIST)" ) | \ sed -e "s,^.*$,File & has lines ending with whitespace.," else # The above form is much (100x) faster, but doesn't work # on all systems. A for loop also works but takes 30% longer - ${FIND_FILES} $INCLUDELIST | \ + ${FIND_FILES} ${INCLUDELIST} ${FINDOPTS}| \ grep -Ev "($EXCLUDELIST)" | \ xargs -I % \ grep -l "[[:space:]][[:space:]]*$" % | \ diff --git a/util/lint/lint-stable-009-old-licenses b/util/lint/lint-stable-009-old-licenses index 0b77226..09b53a2 100755 --- a/util/lint/lint-stable-009-old-licenses +++ b/util/lint/lint-stable-009-old-licenses @@ -28,7 +28,11 @@ _shipped$|\ ^util/scripts/no-fsf-addresses.sh|\ ^util/lint/lint-000-license-headers|\ -^util/lint/lint-stable-009-old-licenses\ +^util/lint/lint-stable-009-old-licenses|\ +^util/nvidia/cbootimage|\ +^3rdparty|\ +__pycache__|\ +^payloads/external\ " if [ -z "$HEADER_DIRS" ]; then -- To view, visit https://review.coreboot.org/c/coreboot/+/68475 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I81d138760c29a7c476280bb9d963f6be99c75d6d Gerrit-Change-Number: 68475 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: nb/intel/i945/rcven.c: Use read32p()
by Felix Held (Code Review) 21 Oct '22

21 Oct '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68087 ) Change subject: nb/intel/i945/rcven.c: Use read32p() ...................................................................... nb/intel/i945/rcven.c: Use read32p() Tested on unsupported mainboard (945g-m4). Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: I1935308cc50abd651b52d6290d66180905c6a521 Reviewed-on: https://review.coreboot.org/c/coreboot/+/68087 Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin Roth <martin.roth(a)amd.corp-partner.google.com> --- M src/northbridge/intel/i945/rcven.c 1 file changed, 18 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, but someone else must approve Martin Roth: Looks good to me, approved diff --git a/src/northbridge/intel/i945/rcven.c b/src/northbridge/intel/i945/rcven.c index 37b568a..7d497e6 100644 --- a/src/northbridge/intel/i945/rcven.c +++ b/src/northbridge/intel/i945/rcven.c @@ -29,8 +29,8 @@ } for (i = 0; i < 28; i++) { - read32((void *)addr); - read32((void *)(addr + 0x80)); + read32p(addr); + read32p(addr + 0x80); } reg32 = mchbar_read32(RCVENMT); -- To view, visit https://review.coreboot.org/c/coreboot/+/68087 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1935308cc50abd651b52d6290d66180905c6a521 Gerrit-Change-Number: 68087 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[L] Change in coreboot[master]: mb/google/kahlee: use override devicetrees for variants
by Felix Held (Code Review) 21 Oct '22

21 Oct '22

Attention is currently required from: Jason Nien, Matt DeVillier, Martin Roth. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68634 ) Change subject: mb/google/kahlee: use override devicetrees for variants ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/kahlee/variants/aleena/overridetree.cb: https://review.coreboot.org/c/coreboot/+/68634/comment/083dddda_dcef2b0e PS3, Line 67: chip drivers/i2c/generic : register "hid" = ""ELAN0000"" : register "desc" = ""ELAN Touchpad"" : register "irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_5)" : register "wake" = "7" : register "detect" = "1" : device i2c 15 on end : end > FYI, I tested on LIARA moving the ELAN touchpad to the baseboard and leaving the other (synaptics) i […] thanks for testing; i'll update the patch. wasn't 100% sure, so i went the safe route initially. i'll rework the patch and deduplicate more things -- To view, visit https://review.coreboot.org/c/coreboot/+/68634 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie050c4624327b904e8cb0959b40421339e43f825 Gerrit-Change-Number: 68634 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Fri, 21 Oct 2022 14:12:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/ifdtool: Add Wellsburg support
by Lean Sheng Tan (Code Review) 21 Oct '22

21 Oct '22

Attention is currently required from: Patrick Rudolph, Stefan Reinauer. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68657 ) Change subject: util/ifdtool: Add Wellsburg support ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/68657 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I651730b05deb512478d059174cf8615547d2fde4 Gerrit-Change-Number: 68657 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Fri, 21 Oct 2022 13:54:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/ifdtool: Add Wellsburg support
by Lean Sheng Tan (Code Review) 21 Oct '22

21 Oct '22

Attention is currently required from: Patrick Rudolph, Stefan Reinauer. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68657 ) Change subject: util/ifdtool: Add Wellsburg support ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68657 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I651730b05deb512478d059174cf8615547d2fde4 Gerrit-Change-Number: 68657 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Fri, 21 Oct 2022 13:54:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/ifdtool: Add Wellsburg support
by Angel Pons (Code Review) 21 Oct '22

21 Oct '22

Attention is currently required from: Patrick Rudolph, Stefan Reinauer. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68657 ) Change subject: util/ifdtool: Add Wellsburg support ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/68657/comment/5ed614a0_6453a4b4 PS1, Line 9: is IFDv2 compatible Is it, though? File util/ifdtool/ifdtool.h: https://review.coreboot.org/c/coreboot/+/68657/comment/27a901e0_5d008bd3 PS1, Line 65: PLATFORM_WLS Wellsburg is WBG -- To view, visit https://review.coreboot.org/c/coreboot/+/68657 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I651730b05deb512478d059174cf8615547d2fde4 Gerrit-Change-Number: 68657 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Fri, 21 Oct 2022 13:53:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/ifdtool: Add Wellsburg support
by Patrick Rudolph (Code Review) 21 Oct '22

21 Oct '22

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68657 ) Change subject: util/ifdtool: Add Wellsburg support ...................................................................... util/ifdtool: Add Wellsburg support Wellsburg is IFDv2 compatible and supports up to 6 regions. Use the NR field to differentiate between Wellsburg and Lynxpoint. Also add support using the -p argument to specify Wellsburg platform. Make sure to not use 16 regions as default as this corrupts the image when using the layout modification feature. Tested on Intel Grangeville. Documents used: Intel Document Id: 516552 Intel Document Id: 565117 Change-Id: I651730b05deb512478d059174cf8615547d2fde4 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M util/ifdtool/ifdtool.c M util/ifdtool/ifdtool.h 2 files changed, 44 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/68657/1 diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index e97efcc..880ca17 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -202,6 +202,7 @@ uint32_t msl = (fdb->flmap2 >> 8) & 0xff; uint32_t isl = (fdb->flmap1 >> 24); uint32_t nm = (fdb->flmap1 >> 8) & 0x7; + uint32_t nr = (fdb->flmap0 >> 24) & 7; /* Rest for IFD1 chipset type */ if (iccriba == 0x00) { @@ -220,8 +221,12 @@ return CHIPSET_BAYTRAIL; else if (msl <= 1 && isl <= 18) return CHIPSET_6_SERIES_COUGAR_POINT; - else if (msl <= 1 && isl <= 21) - return CHIPSET_8_SERIES_LYNX_POINT; + else if (msl <= 1 && isl <= 21) { + if (nr > 4) + return CHIPSET_8_SERIES_WELLSBURG; + else + return CHIPSET_8_SERIES_LYNX_POINT; + } printf("Peculiar firmware descriptor, assuming Wildcat Point compatibility.\n"); return CHIPSET_9_SERIES_WILDCAT_POINT; } else if (nm == 6) { @@ -256,6 +261,8 @@ return CHIPSET_C620_SERIES_LEWISBURG; case PLATFORM_DNV: return CHIPSET_DENVERTON; + case PLATFORM_WLS: + return CHIPSET_8_SERIES_WELLSBURG; default: return CHIPSET_PCH_UNKNOWN; } @@ -283,6 +290,7 @@ PLATFORM_SKLKBL, PLATFORM_IFD2, PLATFORM_MTL, + PLATFORM_WLS, }; unsigned int i; @@ -299,7 +307,10 @@ if (is_platform_ifd_2()) { ifd_version = IFD_VERSION_2; chipset = ifd2_platform_to_chipset(platform); - max_regions = MAX_REGIONS; + if (chipset == CHIPSET_8_SERIES_WELLSBURG) + max_regions = MAX_REGIONS_WLS; + else + max_regions = MAX_REGIONS; } else { ifd_version = IFD_VERSION_1; chipset = ifd1_guess_chipset(image, size); @@ -1271,6 +1282,7 @@ } break; case PLATFORM_DNV: + case PLATFORM_WLS: /* CPU/BIOS can read descriptor and BIOS. */ fmba->flmstr1 |= (1 << REGION_DESC) << rd_shift; fmba->flmstr1 |= (1 << REGION_BIOS) << rd_shift; @@ -1709,6 +1721,7 @@ " jsl - Jasper Lake\n" " sklkbl - Sky Lake/Kaby Lake\n" " tgl - Tiger Lake\n" + " wls - Wellsburg\n" " -S | --setpchstrap Write a PCH strap\n" " -V | --newvalue The new value to write into PCH strap specified by -S\n" " -v | --version: print the version\n" @@ -1979,6 +1992,8 @@ platform = PLATFORM_IFD2; } else if (!strcmp(optarg, "mtl")) { platform = PLATFORM_MTL; + } else if (!strcmp(optarg, "wls")) { + platform = PLATFORM_WLS; } else { fprintf(stderr, "Unknown platform: %s\n", optarg); exit(EXIT_FAILURE); diff --git a/util/ifdtool/ifdtool.h b/util/ifdtool/ifdtool.h index 1ee76f1..7c1507c 100644 --- a/util/ifdtool/ifdtool.h +++ b/util/ifdtool/ifdtool.h @@ -62,6 +62,7 @@ PLATFORM_IFD2, PLATFORM_DNV, PLATFORM_MTL, + PLATFORM_WLS, }; #define LAYOUT_LINELEN 80 @@ -122,6 +123,7 @@ // regions #define MAX_REGIONS 16 +#define MAX_REGIONS_WLS 6 #define MAX_REGIONS_OLD 5 enum flash_regions { -- To view, visit https://review.coreboot.org/c/coreboot/+/68657 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I651730b05deb512478d059174cf8615547d2fde4 Gerrit-Change-Number: 68657 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: Update cmocka submodule to upstream master
by Elyes Haouas (Code Review) 21 Oct '22

21 Oct '22

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/68652 ) Change subject: Update cmocka submodule to upstream master ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/68652 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I424db2eff6fcdcadd117296292c6dc1fc947ad4c Gerrit-Change-Number: 68652 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: lib/Kconfig: Disable `DECOMPRESS_OFAST` for x86_64
by Angel Pons (Code Review) 21 Oct '22

21 Oct '22

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/68648 ) Change subject: lib/Kconfig: Disable `DECOMPRESS_OFAST` for x86_64 ...................................................................... Abandoned Prefer CB:44869 -- To view, visit https://review.coreboot.org/c/coreboot/+/68648 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e1475b71754cdda309b6c4ed72086c084dbcb1f Gerrit-Change-Number: 68648 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Bao Zheng <zheng.bao(a)amd.corp-partner.google.com> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: lib/Kconfig: Disable `DECOMPRESS_OFAST` for x86_64
by Angel Pons (Code Review) 21 Oct '22

21 Oct '22

Attention is currently required from: Nico Huber, Martin L Roth, Arthur Heymans, Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68648 ) Change subject: lib/Kconfig: Disable `DECOMPRESS_OFAST` for x86_64 ...................................................................... Patch Set 1: (1 comment) File src/lib/Kconfig: https://review.coreboot.org/c/coreboot/+/68648/comment/185d6931_3ced4322 PS1, Line 121: USE_EXP_X86_64_SUPPORT > > It wouldn't make sense, though: the problem seems to be that `-Ofast` breaks the decompression alg […] Yes, struct incompatibilities is a big problem... In any case, let's go with CB:44869 instead. -- To view, visit https://review.coreboot.org/c/coreboot/+/68648 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e1475b71754cdda309b6c4ed72086c084dbcb1f Gerrit-Change-Number: 68648 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Bao Zheng <zheng.bao(a)amd.corp-partner.google.com> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 21 Oct 2022 12:38:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022