coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[S] Change in coreboot[master]: mb/google/skyrim/var/baseboard: Update gpio setting for touchscreen IRQ
by Chao Gui (Code Review) 21 Oct '22

21 Oct '22

Attention is currently required from: Frank Wu, Jason Nien, Jon Murphy, Martin Roth, Karthik Ramasubramanian. Chao Gui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68638 ) Change subject: mb/google/skyrim/var/baseboard: Update gpio setting for touchscreen IRQ ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/68638 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iccfe5b01f10899c43151762e4730a05990afa602 Gerrit-Change-Number: 68638 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Chao Gui <chaogui(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Fri, 21 Oct 2022 15:21:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/amd: Add an optional unsigned section in PSP verstage
by Raul Rangel (Code Review) 21 Oct '22

21 Oct '22

Attention is currently required from: Jason Glenesk, Matt DeVillier, Fred Reitberger, Karthik Ramasubramanian, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68135 ) Change subject: soc/amd: Add an optional unsigned section in PSP verstage ...................................................................... Patch Set 9: (1 comment) File src/soc/amd/common/block/cpu/noncar/memlayout_psp_verstage.ld: https://review.coreboot.org/c/coreboot/+/68135/comment/017857f8_22d1f400 PS9, Line 25: ALIGN Doesn't this need to move up one line if you want the anchor to be aligned to 64 bytes? -- To view, visit https://review.coreboot.org/c/coreboot/+/68135 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I308223be8fbca1c0bec8c2e1c86ed65d9f91b966 Gerrit-Change-Number: 68135 Gerrit-PatchSet: 9 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 21 Oct 2022 15:20:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/amdfwtool: Add build rules for amdfwread
by Raul Rangel (Code Review) 21 Oct '22

21 Oct '22

Attention is currently required from: Jason Glenesk, Martin L Roth, Marshall Dawson, Matt DeVillier, Jon Murphy, Fred Reitberger, Karthik Ramasubramanian, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66939 ) Change subject: util/amdfwtool: Add build rules for amdfwread ...................................................................... Patch Set 11: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/66939 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3fee4e4c77f62bb2840270b3eaaa58b894780d75 Gerrit-Change-Number: 66939 Gerrit-PatchSet: 11 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 21 Oct 2022 15:15:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: util/amdfwtool/amdfwread: List AMDFW RO binary entries
by Raul Rangel (Code Review) 21 Oct '22

21 Oct '22

Attention is currently required from: Robert Zieba, Jon Murphy, Karthik Ramasubramanian, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66761 ) Change subject: util/amdfwtool/amdfwread: List AMDFW RO binary entries ...................................................................... Patch Set 13: Code-Review+2 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/66761/comment/50f9ae3a_5befb0a5 PS13, Line 20: Dir Ohh, this is pretty File util/amdfwtool/amdfwread.c: https://review.coreboot.org/c/coreboot/+/66761/comment/f3e7da0b_b71c48e4 PS12, Line 330: break > This is break for the case statement so that we dont fall-through to the next case. Yeah.. I forgot how to read C code ;) -- To view, visit https://review.coreboot.org/c/coreboot/+/66761 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia1b8f1a2b9bc7dc6925a305cdff1442aaff182cd Gerrit-Change-Number: 66761 Gerrit-PatchSet: 13 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Robert Zieba <robertzieba(a)google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 21 Oct 2022 15:14:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: nb/intel/i945/rcven.c: Use read32p()
by 9elements QA (Code Review) 21 Oct '22

21 Oct '22

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68087 ) Change subject: nb/intel/i945/rcven.c: Use read32p() ...................................................................... Patch Set 5: Automatic boot test returned (PASS/FAIL/TOTAL): 14 / 2 / 16 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES_ and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/129581 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/129580 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/129579 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/129578 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload TianoCore : https://lava.9esec.io/r/129577 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/129576 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload TianoCore : https://lava.9esec.io/r/129575 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/129574 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload TianoCore : https://lava.9esec.io/r/129573 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload SeaBIOS : https://lava.9esec.io/r/129572 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload TianoCore : https://lava.9esec.io/r/129571 FAIL: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload SeaBIOS : https://lava.9esec.io/r/129570 FAIL: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/129569 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/129568 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/129567 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/129566 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/68087 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1935308cc50abd651b52d6290d66180905c6a521 Gerrit-Change-Number: 68087 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Fri, 21 Oct 2022 15:12:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: util/amdfwtool/amdfwread: Handle recovery A/B layout
by Raul Rangel (Code Review) 21 Oct '22

21 Oct '22

Attention is currently required from: Robert Zieba, Bao Zheng, Jon Murphy, Rob Barnes, Karthik Ramasubramanian, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66554 ) Change subject: util/amdfwtool/amdfwread: Handle recovery A/B layout ...................................................................... Patch Set 15: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/66554 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6576eaebc611ab338885aed2ee087bf85da3ca15 Gerrit-Change-Number: 66554 Gerrit-PatchSet: 15 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Robert Zieba <robertzieba(a)google.com> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 21 Oct 2022 15:10:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: util/amdfwtool/amdfwread: Update relative_offset function
by Raul Rangel (Code Review) 21 Oct '22

21 Oct '22

Attention is currently required from: Robert Zieba, Jon Murphy, Rob Barnes, Karthik Ramasubramanian, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66572 ) Change subject: util/amdfwtool/amdfwread: Update relative_offset function ...................................................................... Patch Set 14: Code-Review+1 (1 comment) File util/amdfwtool/amdfwread.c: https://review.coreboot.org/c/coreboot/+/66572/comment/7a930e92_8084a384 PS13, Line 38: /* Intentional fall-through */ > I have to remove the check for AMD_ADDR_PHYSICAL since that check breaks the amdfwread for Guybrush […] Ah, well glad it caught it. Maybe leave the check so it prints an error with the `exit(1)` commented out and a TODO to fix andfwtool? -- To view, visit https://review.coreboot.org/c/coreboot/+/66572 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I74603dd08eda87393c14b746c4435eaf2bb34126 Gerrit-Change-Number: 66572 Gerrit-PatchSet: 14 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Robert Zieba <robertzieba(a)google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 21 Oct 2022 15:09:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: arch/x86/include: Split msr access into separate file
by Martin Roth (Code Review) 21 Oct '22

21 Oct '22

Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/67917 ) Change subject: arch/x86/include: Split msr access into separate file ...................................................................... arch/x86/include: Split msr access into separate file To allow testing of code that uses msr calls, separate the actual calls into a separate header file, This allows the tests to emulate the msr access without replacing the rest of the msr.h definitions. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I102709fec346f18040baf9f2ce6e6d7eb094682d Reviewed-on: https://review.coreboot.org/c/coreboot/+/67917 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Jakub Czapiga <jacz(a)semihalf.com> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/include/cpu/x86/msr.h A src/include/cpu/x86/msr_access.h 2 files changed, 82 insertions(+), 54 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Jakub Czapiga: Looks good to me, approved diff --git a/src/include/cpu/x86/msr.h b/src/include/cpu/x86/msr.h index ca2a37f..999fdaa 100644 --- a/src/include/cpu/x86/msr.h +++ b/src/include/cpu/x86/msr.h @@ -3,6 +3,8 @@ #ifndef CPU_X86_MSR_H #define CPU_X86_MSR_H +#include <cpu/x86/msr_access.h> + /* Intel SDM: Table 2-1 * IA-32 architectural MSR: Extended Feature Enable Register * @@ -107,66 +109,12 @@ #define IA32_CR_SF_QOS_MASK_2 0x1892 #ifndef __ASSEMBLER__ -#include <types.h> - -typedef struct msr_struct { - unsigned int lo; - unsigned int hi; -} msr_t; typedef struct msrinit_struct { unsigned int index; msr_t msr; } msrinit_t; -#if CONFIG(SOC_SETS_MSRS) -msr_t soc_msr_read(unsigned int index); -void soc_msr_write(unsigned int index, msr_t msr); - -/* Handle MSR references in the other source code */ -static __always_inline msr_t rdmsr(unsigned int index) -{ - return soc_msr_read(index); -} - -static __always_inline void wrmsr(unsigned int index, msr_t msr) -{ - soc_msr_write(index, msr); -} -#else /* CONFIG_SOC_SETS_MSRS */ - -/* The following functions require the __always_inline due to AMD - * function STOP_CAR_AND_CPU that disables cache as - * RAM, the cache as RAM stack can no longer be used. Called - * functions must be inlined to avoid stack usage. Also, the - * compiler must keep local variables register based and not - * allocated them from the stack. With gcc 4.5.0, some functions - * declared as inline are not being inlined. This patch forces - * these functions to always be inlined by adding the qualifier - * __always_inline to their declaration. - */ -static __always_inline msr_t rdmsr(unsigned int index) -{ - msr_t result; - __asm__ __volatile__ ( - "rdmsr" - : "=a" (result.lo), "=d" (result.hi) - : "c" (index) - ); - return result; -} - -static __always_inline void wrmsr(unsigned int index, msr_t msr) -{ - __asm__ __volatile__ ( - "wrmsr" - : /* No outputs */ - : "c" (index), "a" (msr.lo), "d" (msr.hi) - ); -} - -#endif /* CONFIG_SOC_SETS_MSRS */ - /* Get MCA bank count from MSR */ static inline unsigned int mca_get_bank_count(void) { diff --git a/src/include/cpu/x86/msr_access.h b/src/include/cpu/x86/msr_access.h new file mode 100644 index 0000000..a7f72fd --- /dev/null +++ b/src/include/cpu/x86/msr_access.h @@ -0,0 +1,62 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef CPU_X86_MSR_ACCESS_H +#define CPU_X86_MSR_ACCESS_H + +#ifndef __ASSEMBLER__ +#include <types.h> + +typedef struct msr_struct { + unsigned int lo; + unsigned int hi; +} msr_t; + +#if CONFIG(SOC_SETS_MSRS) +msr_t soc_msr_read(unsigned int index); +void soc_msr_write(unsigned int index, msr_t msr); + +/* Handle MSR references in the other source code */ +static __always_inline msr_t rdmsr(unsigned int index) +{ + return soc_msr_read(index); +} + +static __always_inline void wrmsr(unsigned int index, msr_t msr) +{ + soc_msr_write(index, msr); +} +#else /* CONFIG_SOC_SETS_MSRS */ + +/* The following functions require the __always_inline due to AMD + * function STOP_CAR_AND_CPU that disables cache as + * RAM, the cache as RAM stack can no longer be used. Called + * functions must be inlined to avoid stack usage. Also, the + * compiler must keep local variables register based and not + * allocated them from the stack. With gcc 4.5.0, some functions + * declared as inline are not being inlined. This patch forces + * these functions to always be inlined by adding the qualifier + * __always_inline to their declaration. + */ +static __always_inline msr_t rdmsr(unsigned int index) +{ + msr_t result; + __asm__ __volatile__ ( + "rdmsr" + : "=a" (result.lo), "=d" (result.hi) + : "c" (index) + ); + return result; +} + +static __always_inline void wrmsr(unsigned int index, msr_t msr) +{ + __asm__ __volatile__ ( + "wrmsr" + : /* No outputs */ + : "c" (index), "a" (msr.lo), "d" (msr.hi) + ); +} + +#endif /* CONFIG_SOC_SETS_MSRS */ +#endif /* __ASSEMBLER__ */ +#endif /* CPU_X86_MSR_ACCESS_H */ -- To view, visit https://review.coreboot.org/c/coreboot/+/67917 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I102709fec346f18040baf9f2ce6e6d7eb094682d Gerrit-Change-Number: 67917 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: MAINTAINERS: Remove Andrey Petrov from Apollo Lake
by Felix Held (Code Review) 21 Oct '22

21 Oct '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68588 ) Change subject: MAINTAINERS: Remove Andrey Petrov from Apollo Lake ...................................................................... MAINTAINERS: Remove Andrey Petrov from Apollo Lake Andrey doesn't seem to have interacted with APL or coreboot 2+ years, so remove him and mark Apollo Lake as orphaned. Add myself for Odd Fixes. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I6cb2f2da63dda3cb841786d53f89b583a9df9791 Reviewed-on: https://review.coreboot.org/c/coreboot/+/68588 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Andrey Petrov <andrey.petrov(a)gmail.com> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M MAINTAINERS 1 file changed, 21 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Andrey Petrov: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved diff --git a/MAINTAINERS b/MAINTAINERS index a564e14..dc4c3af 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -723,8 +723,8 @@ F: src/soc/intel/alderlake/ INTEL APOLLOLAKE_SOC -M: Andrey Petrov <andrey.petrov(a)gmail.com> -S: Maintained +M: Sean Rhodes <sean(a)starlabs.systems> +S: Odd Fixes F: src/soc/intel/apollolake/ INTEL BRASWELL SOC -- To view, visit https://review.coreboot.org/c/coreboot/+/68588 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6cb2f2da63dda3cb841786d53f89b583a9df9791 Gerrit-Change-Number: 68588 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)intel.corp-partner.google.com> Gerrit-Reviewer: Andrey Petrov <anpetrov(a)fb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: mb/lenovo/t{410,60}/dock.h: Fix header guards
by Felix Held (Code Review) 21 Oct '22

21 Oct '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68020 ) Change subject: mb/lenovo/t{410,60}/dock.h: Fix header guards ...................................................................... mb/lenovo/t{410,60}/dock.h: Fix header guards Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: I7b279cf2c69f62b47ef497edd372034f148fff03 Reviewed-on: https://review.coreboot.org/c/coreboot/+/68020 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/lenovo/t410/dock.h M src/mainboard/lenovo/t60/dock.h 2 files changed, 17 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/src/mainboard/lenovo/t410/dock.h b/src/mainboard/lenovo/t410/dock.h index 34a8fec..1ed58ee 100644 --- a/src/mainboard/lenovo/t410/dock.h +++ b/src/mainboard/lenovo/t410/dock.h @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#ifndef THINKPAD_X201_DOCK_H -#define THINKPAD_X201_DOCK_H +#ifndef THINKPAD_T410_DOCK_H +#define THINKPAD_T410_DOCK_H void init_dock(void); void dock_connect(void); void dock_disconnect(void); diff --git a/src/mainboard/lenovo/t60/dock.h b/src/mainboard/lenovo/t60/dock.h index 0bb50ca..26c9619 100644 --- a/src/mainboard/lenovo/t60/dock.h +++ b/src/mainboard/lenovo/t60/dock.h @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#ifndef THINKPAD_X60_DOCK_H -#define THINKPAD_X60_DOCK_H +#ifndef THINKPAD_T60_DOCK_H +#define THINKPAD_T60_DOCK_H int dock_connect(void); void dock_disconnect(void); -- To view, visit https://review.coreboot.org/c/coreboot/+/68020 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7b279cf2c69f62b47ef497edd372034f148fff03 Gerrit-Change-Number: 68020 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022