coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[L] Change in coreboot[master]: ifdtool: Move regions to seperate file
by Patrick Rudolph (Code Review) 22 Oct '22

22 Oct '22

Attention is currently required from: Stefan Reinauer. Hello Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68695 to look at the new patch set (#2). Change subject: ifdtool: Move regions to seperate file ...................................................................... ifdtool: Move regions to seperate file Change-Id: I6a1ba1799c69881b1f48d903b8f86e7cd93815c2 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M util/ifdtool/Makefile.inc M util/ifdtool/ifdtool.c M util/ifdtool/ifdtool.h A util/ifdtool/regions.c 4 files changed, 169 insertions(+), 137 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/68695/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68695 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6a1ba1799c69881b1f48d903b8f86e7cd93815c2 Gerrit-Change-Number: 68695 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: ifdtool: Introduce region_name_fmap
by Patrick Rudolph (Code Review) 22 Oct '22

22 Oct '22

Attention is currently required from: Stefan Reinauer. Hello Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68694 to look at the new patch set (#2). Change subject: ifdtool: Introduce region_name_fmap ...................................................................... ifdtool: Introduce region_name_fmap Instead of directly accessing the region_name array use a helper function. This allows to move the region name array to a seperate file. Change-Id: Ifc810da1628cebd2728d0185502c462ff9428597 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M util/ifdtool/ifdtool.c 1 file changed, 26 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/68694/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68694 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc810da1628cebd2728d0185502c462ff9428597 Gerrit-Change-Number: 68694 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: ifdtool: Add missing chipset_name
by Patrick Rudolph (Code Review) 22 Oct '22

22 Oct '22

Attention is currently required from: Stefan Reinauer. Hello Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68693 to look at the new patch set (#2). Change subject: ifdtool: Add missing chipset_name ...................................................................... ifdtool: Add missing chipset_name Add denverton soc chipset name. Change-Id: I0fd8494123490d6ccc21af2ed30c30d50ddb4e8e Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M util/ifdtool/ifdtool.c 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/68693/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68693 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0fd8494123490d6ccc21af2ed30c30d50ddb4e8e Gerrit-Change-Number: 68693 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: ifdtool: Drop chipset without IFD
by Patrick Rudolph (Code Review) 22 Oct '22

22 Oct '22

Attention is currently required from: Stefan Reinauer. Hello Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68692 to look at the new patch set (#2). Change subject: ifdtool: Drop chipset without IFD ...................................................................... ifdtool: Drop chipset without IFD Those chipsets do not have an IFD and where not used within the code. Change-Id: I999e5e5d2063b8d33819fb22296ed486e1194cbb Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M util/ifdtool/ifdtool.c M util/ifdtool/ifdtool.h 2 files changed, 12 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/68692/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68692 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I999e5e5d2063b8d33819fb22296ed486e1194cbb Gerrit-Change-Number: 68692 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: ifdtool: Cleanup IFDv1 detection
by Patrick Rudolph (Code Review) 22 Oct '22

22 Oct '22

Attention is currently required from: Stefan Reinauer. Hello build bot (Jenkins), Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68680 to look at the new patch set (#3). Change subject: ifdtool: Cleanup IFDv1 detection ...................................................................... ifdtool: Cleanup IFDv1 detection Change https://review.coreboot.org/c/coreboot/+/54305 "util/ifdtool: Use -p platform name to detect IFDv2 platform and chipset" made the '-p' argument mandatory for IFDv2 platforms. Drop the IFDv2 platform CHIPSET_C620_SERIES_LEWISBURG from IFDv1 detection. Change-Id: If29f8718b7aa696cdc07deef4c98be9a68c66f10 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M util/ifdtool/ifdtool.c 1 file changed, 17 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/68680/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/68680 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If29f8718b7aa696cdc07deef4c98be9a68c66f10 Gerrit-Change-Number: 68680 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: ifdtool: Hardcode supported regions for every chipset
by build bot (Jenkins) (Code Review) 22 Oct '22

22 Oct '22

Attention is currently required from: Stefan Reinauer. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68696 ) Change subject: ifdtool: Hardcode supported regions for every chipset ...................................................................... Patch Set 1: (2 comments) File util/ifdtool/ifdtool.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161046): https://review.coreboot.org/c/coreboot/+/68696/comment/721af135_781f1bba PS1, Line 215: int max_regions_per_chipset(const enum ich_chipset chip); adding a line without newline at end of file File util/ifdtool/regions.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161046): https://review.coreboot.org/c/coreboot/+/68696/comment/b475c202_33ca2b45 PS1, Line 45: [CHIPSET_6_SERIES_COUGAR_POINT] = 0x1f, please, no space before tabs -- To view, visit https://review.coreboot.org/c/coreboot/+/68696 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie9757999cb2ab4b16a5352baacdc11c61164dd46 Gerrit-Change-Number: 68696 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Sat, 22 Oct 2022 13:49:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: ifdtool: Move regions to seperate file
by build bot (Jenkins) (Code Review) 22 Oct '22

22 Oct '22

Attention is currently required from: Stefan Reinauer. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68695 ) Change subject: ifdtool: Move regions to seperate file ...................................................................... Patch Set 1: (8 comments) File util/ifdtool/ifdtool.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161045): https://review.coreboot.org/c/coreboot/+/68695/comment/85b64ae2_5bd78b24 PS1, Line 215: const frba_t *frba); adding a line without newline at end of file File util/ifdtool/regions.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161045): https://review.coreboot.org/c/coreboot/+/68695/comment/8bc10e46_a16dae30 PS1, Line 47: exit (EXIT_FAILURE); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161045): https://review.coreboot.org/c/coreboot/+/68695/comment/5d261625_2dcb5a34 PS1, Line 66: exit (EXIT_FAILURE); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161045): https://review.coreboot.org/c/coreboot/+/68695/comment/c47f0415_a33e4f98 PS1, Line 78: exit (EXIT_FAILURE); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161045): https://review.coreboot.org/c/coreboot/+/68695/comment/3c6be25b_3d160ce8 PS1, Line 88: exit (EXIT_FAILURE); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161045): https://review.coreboot.org/c/coreboot/+/68695/comment/5cb2a337_51683eea PS1, Line 98: exit (EXIT_FAILURE); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161045): https://review.coreboot.org/c/coreboot/+/68695/comment/9fc0a613_d51c9a9f PS1, Line 122: exit (EXIT_FAILURE); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161045): https://review.coreboot.org/c/coreboot/+/68695/comment/d8d2a45f_31243d9a PS1, Line 142: } adding a line without newline at end of file -- To view, visit https://review.coreboot.org/c/coreboot/+/68695 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6a1ba1799c69881b1f48d903b8f86e7cd93815c2 Gerrit-Change-Number: 68695 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Sat, 22 Oct 2022 13:49:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: ifdtool: Introduce region_name_fmap
by build bot (Jenkins) (Code Review) 22 Oct '22

22 Oct '22

Attention is currently required from: Stefan Reinauer. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68694 ) Change subject: ifdtool: Introduce region_name_fmap ...................................................................... Patch Set 1: (2 comments) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161044): https://review.coreboot.org/c/coreboot/+/68694/comment/3bfbb909_7d20326a PS1, Line 8: Possible unwrapped commit description (prefer a maximum 72 chars per line) File util/ifdtool/ifdtool.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161044): https://review.coreboot.org/c/coreboot/+/68694/comment/3b541142_fa91bd88 PS1, Line 365: exit (EXIT_FAILURE); space prohibited between function name and open parenthesis '(' -- To view, visit https://review.coreboot.org/c/coreboot/+/68694 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc810da1628cebd2728d0185502c462ff9428597 Gerrit-Change-Number: 68694 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Sat, 22 Oct 2022 13:48:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: ifdtool: Fix spacing for 10GbE_*
by Patrick Rudolph (Code Review) 22 Oct '22

22 Oct '22

Attention is currently required from: Stefan Reinauer. Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68699 ) Change subject: ifdtool: Fix spacing for 10GbE_* ...................................................................... ifdtool: Fix spacing for 10GbE_* Remove a single whitespace character to align the entry with the other entries printed. Change-Id: Ie803df6ce9a9772116063ad20bad1c677c3b493c Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M util/ifdtool/ifdtool.c 1 file changed, 17 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/68699/1 diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index f543c9d..97bbac2 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -607,11 +607,11 @@ printf(" Flash Descriptor Write Access: %s\n", (flmstr & (1 << wr_shift)) ? "enabled" : "disabled"); if (region_supported(chipset, REGION_10GB_0)) { - printf(" 10GbE_0 Write Access: %s\n", + printf(" 10GbE_0 Write Access: %s\n", (flmstr & (1 << (wr_shift + 11))) ? "enabled" : "disabled"); } if (region_supported(chipset, REGION_10GB_1)) { - printf(" 10GbE_1 Write Access: %s\n", + printf(" 10GbE_1 Write Access: %s\n", (flmstr & (1 << 4)) ? "enabled" : "disabled"); } @@ -632,11 +632,11 @@ printf(" Flash Descriptor Read Access: %s\n", (flmstr & (1 << rd_shift)) ? "enabled" : "disabled"); if (region_supported(chipset, REGION_10GB_0)) { - printf(" 10GbE_0 Read Access: %s\n", + printf(" 10GbE_0 Read Access: %s\n", (flmstr & (1 << (rd_shift + 11))) ? "enabled" : "disabled"); } if (region_supported(chipset, REGION_10GB_1)) { - printf(" 10GbE_1 Read Access: %s\n", + printf(" 10GbE_1 Read Access: %s\n", (flmstr & (1 << 0)) ? "enabled" : "disabled"); } -- To view, visit https://review.coreboot.org/c/coreboot/+/68699 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie803df6ce9a9772116063ad20bad1c677c3b493c Gerrit-Change-Number: 68699 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: ifdtool: Don't print reserved regions
by Patrick Rudolph (Code Review) 22 Oct '22

22 Oct '22

Attention is currently required from: Stefan Reinauer. Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68698 ) Change subject: ifdtool: Don't print reserved regions ...................................................................... ifdtool: Don't print reserved regions Use the introduced array to determine if a region is reserved. Change-Id: Ied1ed8b9b901ba02cbb9e6dbeb8a60e7ed773254 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M util/ifdtool/ifdtool.c M util/ifdtool/ifdtool.h M util/ifdtool/regions.c 3 files changed, 23 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/68698/1 diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index 1d236b3..f543c9d 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -274,7 +274,7 @@ for (i = 0; i < max_regions; i++) { region = get_region(frba, i); /* Skip unused & reserved Flash Region */ - if (region.size < 1 && !strcmp(region_name(i), "Reserved")) + if (region.size < 1 && !region_supported(chipset, i)) continue; printf("FLREG%u: 0x%08x\n", i, frba->flreg[i]); diff --git a/util/ifdtool/ifdtool.h b/util/ifdtool/ifdtool.h index 53f46dc..a4e2cdf 100644 --- a/util/ifdtool/ifdtool.h +++ b/util/ifdtool/ifdtool.h @@ -212,4 +212,5 @@ void dump_region(unsigned int num, const frba_t *frba); void dump_region_layout(char *buf, size_t bufsize, unsigned int num, const frba_t *frba); +bool region_supported(const enum ich_chipset chip, const unsigned int i); int max_regions_per_chipset(const enum ich_chipset chip); \ No newline at end of file diff --git a/util/ifdtool/regions.c b/util/ifdtool/regions.c index 09c9dbe..e97e5f5 100644 --- a/util/ifdtool/regions.c +++ b/util/ifdtool/regions.c @@ -175,6 +175,15 @@ region.base, region.limit, region_name_short(num)); } +bool region_supported(const enum ich_chipset chip, const unsigned int i) +{ + if (chip >= ARRAY_SIZE(region_support_by_chipset)) { + fprintf(stderr, "Unknown chipset: %d\n", chip); + return 0; + } + return !!(region_support_by_chipset[chip] & (1 << i)); +} + int max_regions_per_chipset(const enum ich_chipset chip) { int num = MAX_REGIONS; -- To view, visit https://review.coreboot.org/c/coreboot/+/68698 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ied1ed8b9b901ba02cbb9e6dbeb8a60e7ed773254 Gerrit-Change-Number: 68698 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022