coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[S] Change in coreboot[master]: soc/intel/systemagent.c: Fix memory type reporting
by Paul Menzel (Code Review) 25 Oct '22

25 Oct '22

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68405 ) Change subject: soc/intel/systemagent.c: Fix memory type reporting ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: The [third(?) boot of the Hermes CFL board](https://lava.9esec.io/scheduler/job/130184#L7758) in the 9elements QA also shows this: [0m[DEBUG] apm_control: Finalizing SMM.[0m -- To view, visit https://review.coreboot.org/c/coreboot/+/68405 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3d6f589c60e44a3dce9122d206397cac968647f Gerrit-Change-Number: 68405 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Tue, 25 Oct 2022 07:17:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/brya: Create marasov variant
by Frank Chu (Code Review) 25 Oct '22

25 Oct '22

Attention is currently required from: Nick Vaccaro. Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68575 ) Change subject: mb/google/brya: Create marasov variant ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68575 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib2e30c203ee0dfa6c887a707e9b5074ce89f57ac Gerrit-Change-Number: 68575 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Tue, 25 Oct 2022 07:05:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/brya: Create marasov variant
by Frank Chu (Code Review) 25 Oct '22

25 Oct '22

Attention is currently required from: Nick Vaccaro. Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68575 ) Change subject: mb/google/brya: Create marasov variant ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/68575 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib2e30c203ee0dfa6c887a707e9b5074ce89f57ac Gerrit-Change-Number: 68575 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Tue, 25 Oct 2022 07:01:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: ifdtool: Determine max regions from IFD
by Arthur Heymans (Code Review) 25 Oct '22

25 Oct '22

Attention is currently required from: Patrick Rudolph, Stefan Reinauer. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68780 ) Change subject: ifdtool: Determine max regions from IFD ...................................................................... Patch Set 1: Code-Review+1 (3 comments) Patchset: PS1: Looks good. A few nits. File util/ifdtool/ifdtool.c: https://review.coreboot.org/c/coreboot/+/68780/comment/b391b89b_0a3e235a PS1, Line 304: (max_regions_from_fdbar(fdb) < MAX_REGIONS) ? : max_regions_from_fdbar(fdb) : MAX_REGIONS; MIN(max_regions_from_fdbar(), MAX_REGIONS) ? https://review.coreboot.org/c/coreboot/+/68780/comment/c69851af_9c2f1669 PS1, Line 436: int max_regions_from_fdbar(const fdbar_t *fdb) make it a static function and add a static declaration somewhere higher in the file? -- To view, visit https://review.coreboot.org/c/coreboot/+/68780 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0e3f23ec580b8b8402eb1bf165e3995c8db633f1 Gerrit-Change-Number: 68780 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Tue, 25 Oct 2022 06:50:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: cpu/intel/*: Set SMM SMRR code access check bit
by Arthur Heymans (Code Review) 25 Oct '22

25 Oct '22

Attention is currently required from: Jeff Daly, Mariusz Szafrański, Tim Wawrzynczak, Suresh Bellampalli, Paul Menzel, Vanessa Eusebio, Arthur Heymans. Hello build bot (Jenkins), Jeff Daly, Subrata Banik, Mariusz Szafrański, Suresh Bellampalli, Paul Menzel, Tim Wawrzynczak, Vanessa Eusebio, Lean Sheng Tan, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63788 to look at the new patch set (#5). Change subject: cpu/intel/*: Set SMM SMRR code access check bit ...................................................................... cpu/intel/*: Set SMM SMRR code access check bit This makes sure that only code in TSEG gets executed. See section 34.17.1 "SMM Handler Code Access Control" in the 'Intel 64 and IA-32 Architectures Software Developer’s Manual' Change-Id: I254fb348483d2873917cf8c94c8b60e6f2d2c4e7 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/cpu/intel/haswell/finalize.c M src/include/cpu/intel/smm_reloc.h M src/soc/intel/common/block/smm/smihandler.c M src/soc/intel/denverton_ns/smihandler.c 4 files changed, 60 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/63788/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/63788 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I254fb348483d2873917cf8c94c8b60e6f2d2c4e7 Gerrit-Change-Number: 63788 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: ifdtool: Determine max regions from IFD
by build bot (Jenkins) (Code Review) 25 Oct '22

25 Oct '22

Attention is currently required from: Stefan Reinauer. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68780 ) Change subject: ifdtool: Determine max regions from IFD ...................................................................... Patch Set 1: (1 comment) File util/ifdtool/ifdtool.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161219): https://review.coreboot.org/c/coreboot/+/68780/comment/fe0e4202_2d17a1aa PS1, Line 209: int max_regions_from_fdbar(const fdbar_t *fdb); adding a line without newline at end of file -- To view, visit https://review.coreboot.org/c/coreboot/+/68780 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0e3f23ec580b8b8402eb1bf165e3995c8db633f1 Gerrit-Change-Number: 68780 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Tue, 25 Oct 2022 06:40:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: ifdtool: Move regions to seperate file
by build bot (Jenkins) (Code Review) 25 Oct '22

25 Oct '22

Attention is currently required from: Patrick Rudolph, Stefan Reinauer. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68695 ) Change subject: ifdtool: Move regions to seperate file ...................................................................... Patch Set 5: (1 comment) File util/ifdtool/regions.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161218): https://review.coreboot.org/c/coreboot/+/68695/comment/fef8e808_38d33784 PS5, Line 187: } adding a line without newline at end of file -- To view, visit https://review.coreboot.org/c/coreboot/+/68695 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6a1ba1799c69881b1f48d903b8f86e7cd93815c2 Gerrit-Change-Number: 68695 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Tue, 25 Oct 2022 06:39:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: ifdtool: Don't print reserved regions
by Patrick Rudolph (Code Review) 25 Oct '22

25 Oct '22

Patrick Rudolph has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/68698 ) Change subject: ifdtool: Don't print reserved regions ...................................................................... Abandoned Documentation is not precise enough, always expose all regions... -- To view, visit https://review.coreboot.org/c/coreboot/+/68698 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ied1ed8b9b901ba02cbb9e6dbeb8a60e7ed773254 Gerrit-Change-Number: 68698 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in coreboot[master]: ifdtool: Use chipset to decide if region exists
by Patrick Rudolph (Code Review) 25 Oct '22

25 Oct '22

Patrick Rudolph has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/68697 ) Change subject: ifdtool: Use chipset to decide if region exists ...................................................................... Abandoned Documentation is not precise enough, always expose all regions... -- To view, visit https://review.coreboot.org/c/coreboot/+/68697 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6ac79f66395e378f45eba262df914478ff142b1f Gerrit-Change-Number: 68697 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: abandon

1 0

[M] Change in coreboot[master]: ifdtool: Hardcode supported regions for every chipset
by Patrick Rudolph (Code Review) 25 Oct '22

25 Oct '22

Patrick Rudolph has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/68696 ) Change subject: ifdtool: Hardcode supported regions for every chipset ...................................................................... Abandoned Documentation is not precise enough, always expose all regions... -- To view, visit https://review.coreboot.org/c/coreboot/+/68696 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie9757999cb2ab4b16a5352baacdc11c61164dd46 Gerrit-Change-Number: 68696 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022