Attention is currently required from: Martin L Roth, Stefan Reinauer, Arthur Heymans.
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68815 )
Change subject: payloads/LinuxBoot: Fix Linuxboot kernel fetching for v6.x
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/68815
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic1d407eab8ec4569e02729afb5c71f39ce174401
Gerrit-Change-Number: 68815
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Tue, 25 Oct 2022 11:03:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Patrick Rudolph, Arthur Heymans.
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68814 )
Change subject: mb/prodrive/hermes: Remove FSP workaround
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/68814
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If024a3de808c7d9f62171d75350545bc9fdeb9e0
Gerrit-Change-Number: 68814
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Tue, 25 Oct 2022 10:20:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68814 )
Change subject: mb/prodrive/hermes: Remove FSP workaround
......................................................................
mb/prodrive/hermes: Remove FSP workaround
Older FSP releases had a bug where they dereferenced data in flash,
which required to limit cbfs to certain size. This is not needed
anymore.
TESTED: prodrive/hermes boots fine.
Change-Id: If024a3de808c7d9f62171d75350545bc9fdeb9e0
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/mainboard/prodrive/hermes/Kconfig
1 file changed, 17 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/68814/1
diff --git a/src/mainboard/prodrive/hermes/Kconfig b/src/mainboard/prodrive/hermes/Kconfig
index e4ccd2d..c7aaed3 100644
--- a/src/mainboard/prodrive/hermes/Kconfig
+++ b/src/mainboard/prodrive/hermes/Kconfig
@@ -54,6 +54,6 @@
default n
config CBFS_SIZE
- default 0x900000
+ default 0x1000000
endif # BOARD_PRODRIVE_HERMES_BASEBOARD
--
To view, visit https://review.coreboot.org/c/coreboot/+/68814
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If024a3de808c7d9f62171d75350545bc9fdeb9e0
Gerrit-Change-Number: 68814
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newchange
Attention is currently required from: Elyes Haouas.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68781 )
Change subject: nb/intel/i945: Check if channel 0 and 1 are populated
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Does this fix anything? Should the rcomp be programmed on the actual configuration or based on the capability register?
--
To view, visit https://review.coreboot.org/c/coreboot/+/68781
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia77861e5f44501b5d92707977597e143b439e9d4
Gerrit-Change-Number: 68781
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Tue, 25 Oct 2022 09:15:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Elyes Haouas.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/65247
to look at the new patch set (#6).
Change subject: [test]: Add 945g-m4 mainboard suport
......................................................................
[test]: Add 945g-m4 mainboard suport
Change-Id: I53d47afc971cfb7eda8caf3151fc2450a83943d2
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
A src/mainboard/nec/945g-m4/Kconfig
A src/mainboard/nec/945g-m4/Kconfig.name
A src/mainboard/nec/945g-m4/Makefile.inc
A src/mainboard/nec/945g-m4/acpi/ec.asl
A src/mainboard/nec/945g-m4/acpi/ich7_pci_irqs.asl
A src/mainboard/nec/945g-m4/acpi/mainboard.asl
A src/mainboard/nec/945g-m4/acpi/superio.asl
A src/mainboard/nec/945g-m4/board_info.txt
A src/mainboard/nec/945g-m4/cmos.default
A src/mainboard/nec/945g-m4/cmos.layout
A src/mainboard/nec/945g-m4/cstates.c
A src/mainboard/nec/945g-m4/devicetree.cb
A src/mainboard/nec/945g-m4/dsdt.asl
A src/mainboard/nec/945g-m4/early_init.c
A src/mainboard/nec/945g-m4/gpio.c
A src/mainboard/nec/945g-m4/hda_verb.c
A src/mainboard/nec/Kconfig
A src/mainboard/nec/Kconfig.name
M src/northbridge/intel/i945/raminit.c
19 files changed, 793 insertions(+), 54 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/65247/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/65247
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I53d47afc971cfb7eda8caf3151fc2450a83943d2
Gerrit-Change-Number: 65247
Gerrit-PatchSet: 6
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: newpatchset