Attention is currently required from: Martin L Roth.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68705 )
Change subject: MAINTAINERS: Update instructions
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/68705
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0e06ac5f92109757143897f3d331aeea0cefe4b9
Gerrit-Change-Number: 68705
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Tue, 25 Oct 2022 08:25:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Jan Samek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68405 )
Change subject: soc/intel/systemagent.c: Fix memory type reporting
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> This patch introduces a regression. […]
From my testing on mc_apl2, based upon 193e86b814, APL doesn't seem to be affected by this.
--
To view, visit https://review.coreboot.org/c/coreboot/+/68405
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic3d6f589c60e44a3dce9122d206397cac968647f
Gerrit-Change-Number: 68405
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Jan Samek <jan.samek(a)siemens.com>
Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Comment-Date: Tue, 25 Oct 2022 08:06:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68781 )
Change subject: nb/intel/i945: Check if channel 0 and 1 are populated
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161222):
https://review.coreboot.org/c/coreboot/+/68781/comment/be8b8c2c_d84021fc
PS1, Line 10: to true only if channel 0 and 1 are populated.
Possible unwrapped commit description (prefer a maximum 72 chars per line)
--
To view, visit https://review.coreboot.org/c/coreboot/+/68781
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia77861e5f44501b5d92707977597e143b439e9d4
Gerrit-Change-Number: 68781
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Tue, 25 Oct 2022 08:00:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Nick Vaccaro.
Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68575 )
Change subject: mb/google/brya: Create marasov variant
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/68575
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib2e30c203ee0dfa6c887a707e9b5074ce89f57ac
Gerrit-Change-Number: 68575
Gerrit-PatchSet: 3
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Tue, 25 Oct 2022 07:37:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Nick Vaccaro.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68575 )
Change subject: mb/google/brya: Create marasov variant
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/variants/marasov/memory/mem_parts_used.txt:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161221):
https://review.coreboot.org/c/coreboot/+/68575/comment/9b25df4b_bd44f12a
PS3, Line 9: # See util/spd_tools/README.md for more details and instructions.
'README' may be misspelled - perhaps 'README'?
--
To view, visit https://review.coreboot.org/c/coreboot/+/68575
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib2e30c203ee0dfa6c887a707e9b5074ce89f57ac
Gerrit-Change-Number: 68575
Gerrit-PatchSet: 3
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Tue, 25 Oct 2022 07:36:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Nick Vaccaro.
Hello build bot (Jenkins), Tim Wawrzynczak, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/68575
to look at the new patch set (#3).
Change subject: mb/google/brya: Create marasov variant
......................................................................
mb/google/brya: Create marasov variant
Create the marasov variant of the brya0 reference board by copying
the template files to a new directory named for the variant.
(Auto-Generated by create_coreboot_variant.sh version 4.5.0).
BUG=b:254365935
BRANCH=None
TEST=util/abuild/abuild -p none -t google/brya -x -a
make sure the build includes GOOGLE_MARASOV
Signed-off-by: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Change-Id: Ib2e30c203ee0dfa6c887a707e9b5074ce89f57ac
---
M src/mainboard/google/brya/Kconfig
M src/mainboard/google/brya/Kconfig.name
A src/mainboard/google/brya/variants/marasov/include/variant/ec.h
A src/mainboard/google/brya/variants/marasov/include/variant/gpio.h
A src/mainboard/google/brya/variants/marasov/memory/Makefile.inc
A src/mainboard/google/brya/variants/marasov/memory/dram_id.generated.txt
A src/mainboard/google/brya/variants/marasov/memory/mem_parts_used.txt
A src/mainboard/google/brya/variants/marasov/overridetree.cb
8 files changed, 65 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/68575/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/68575
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib2e30c203ee0dfa6c887a707e9b5074ce89f57ac
Gerrit-Change-Number: 68575
Gerrit-PatchSet: 3
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-MessageType: newpatchset