coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[M] Change in coreboot[master]: [WIP] Documentation/measured_boot.md: fix SRTM/DRTM explanations
by Krystian Hebel (Code Review) 26 Oct '22

26 Oct '22

Attention is currently required from: Daniel P. Smith, Michał Żygowski, Maciej Pijanowski, Sergii Dmytruk. Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68751 ) Change subject: [WIP] Documentation/measured_boot.md: fix SRTM/DRTM explanations ...................................................................... Patch Set 2: (2 comments) File Documentation/security/vboot/measured_boot.md: https://review.coreboot.org/c/coreboot/+/68751/comment/c387d4e6_f1bd0ea3 PS2, Line 48: measure `measures` https://review.coreboot.org/c/coreboot/+/68751/comment/4badacf3_7c18886c PS2, Line 58: cbfs `CBFS` -- To view, visit https://review.coreboot.org/c/coreboot/+/68751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If224dc0cf3c0515dbd18daca544c22275e96b459 Gerrit-Change-Number: 68751 Gerrit-PatchSet: 2 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: Daniel P. Smith Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Daniel P. Smith Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Wed, 26 Oct 2022 12:03:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/alderlake: [TEST] Configure EPP at exit stage BS_PAYLOAD_BOOT
by Sridhar Siricilla (Code Review) 26 Oct '22

26 Oct '22

Sridhar Siricilla has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/68670 ) Change subject: soc/intel/alderlake: [TEST] Configure EPP at exit stage BS_PAYLOAD_BOOT ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/68670 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2db806ed651789d58dcb01688a11a569768c3122 Gerrit-Change-Number: 68670 Gerrit-PatchSet: 1 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: cpu/intel/common: typecast function agument to unint64_t
by build bot (Jenkins) (Code Review) 26 Oct '22

26 Oct '22

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68899 ) Change subject: cpu/intel/common: typecast function agument to unint64_t ...................................................................... Patch Set 1: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161405): https://review.coreboot.org/c/coreboot/+/68899/comment/a01041ca_d370dacc PS1, Line 8: 'fuction' may be misspelled - perhaps 'function'? -- To view, visit https://review.coreboot.org/c/coreboot/+/68899 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I35d382c792b9df260381b7696f3bbff43d6c4dc2 Gerrit-Change-Number: 68899 Gerrit-PatchSet: 1 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 26 Oct 2022 11:42:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya : Update EPP value for Vell board
by Sridhar Siricilla (Code Review) 26 Oct '22

26 Oct '22

Attention is currently required from: Tim Wawrzynczak. Sridhar Siricilla has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68900 ) Change subject: mb/google/brya : Update EPP value for Vell board ...................................................................... mb/google/brya : Update EPP value for Vell board The patch updates the EPP value for Vell for better power improvement. TEST=Verified code build for Vell board Signed-off-by: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Change-Id: I41b15b84025d25cf59dac2d85826a3de9d725bae --- M src/mainboard/google/brya/variants/vell/overridetree.cb 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/68900/1 diff --git a/src/mainboard/google/brya/variants/vell/overridetree.cb b/src/mainboard/google/brya/variants/vell/overridetree.cb index 98983ef..1ad24ef 100644 --- a/src/mainboard/google/brya/variants/vell/overridetree.cb +++ b/src/mainboard/google/brya/variants/vell/overridetree.cb @@ -76,6 +76,10 @@ register "tcss_ports[3]" = "TCSS_PORT_DEFAULT(OC3)" register "sagv" = "SaGv_Enabled" + # Set EPP to 50%: 50 * 256 / 100 = 0x80 + # It overrides the baseboard EPP value (which is 45%) for better power improvement + register "energy_perf_pref_value" = "0x80" + # FIVR RFI Spread Spectrum 6% register "fivr_spread_spectrum" = "FIVR_SS_6" -- To view, visit https://review.coreboot.org/c/coreboot/+/68900 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I41b15b84025d25cf59dac2d85826a3de9d725bae Gerrit-Change-Number: 68900 Gerrit-PatchSet: 1 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: cpu/intel/common: typecast function agument to unint64_t
by Sridhar Siricilla (Code Review) 26 Oct '22

26 Oct '22

Sridhar Siricilla has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68899 ) Change subject: cpu/intel/common: typecast function agument to unint64_t ...................................................................... cpu/intel/common: typecast function agument to unint64_t The patch add typecasting to the msr_unset_and_set() fuction argument to prevent it get converting to incorrect value. During unit testing, the argument is getting to changed to unexpected number which is resulting to an exception. TEST= Verified the code on the Gimble. Noticed coreboot configured EPP value in the IA32_HWP_REQUEST. Signed-off-by: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Change-Id: I35d382c792b9df260381b7696f3bbff43d6c4dc2 --- M src/cpu/intel/common/common_init.c 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/68899/1 diff --git a/src/cpu/intel/common/common_init.c b/src/cpu/intel/common/common_init.c index 4d6df84..d4395b5 100644 --- a/src/cpu/intel/common/common_init.c +++ b/src/cpu/intel/common/common_init.c @@ -223,5 +223,5 @@ void set_energy_perf_pref(u8 pref) { msr_unset_and_set(IA32_HWP_REQUEST, IA32_HWP_REQUEST_EPP_MASK, - pref << IA32_HWP_REQUEST_EPP_SHIFT); + uint64_t(pref << IA32_HWP_REQUEST_EPP_SHIFT)); } -- To view, visit https://review.coreboot.org/c/coreboot/+/68899 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I35d382c792b9df260381b7696f3bbff43d6c4dc2 Gerrit-Change-Number: 68899 Gerrit-PatchSet: 1 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: mb/google/skyrim/var/frostflow: Update devicetree setting
by 9elements QA (Code Review) 26 Oct '22

26 Oct '22

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68482 ) Change subject: mb/google/skyrim/var/frostflow: Update devicetree setting ...................................................................... Patch Set 5: Automatic boot test returned (PASS/FAIL/TOTAL): 13 / 3 / 16 FAIL: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES_ and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/130907 FAIL: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/130906 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/130905 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/130904 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload TianoCore : https://lava.9esec.io/r/130903 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/130902 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload TianoCore : https://lava.9esec.io/r/130901 FAIL: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/130900 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload TianoCore : https://lava.9esec.io/r/130899 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload SeaBIOS : https://lava.9esec.io/r/130898 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload TianoCore : https://lava.9esec.io/r/130897 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload SeaBIOS : https://lava.9esec.io/r/130896 PASS: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/130895 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/130894 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/130893 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/130892 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/68482 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia03962b0e01394ddcd4971cbe0172ef5bd913e15 Gerrit-Change-Number: 68482 Gerrit-PatchSet: 5 Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Chao Gui <chaogui(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Isaac Lee <isaaclee(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-CC: Raul Rangel <rrangel(a)chromium.org> Gerrit-CC: Reka Norman <rekanorman(a)chromium.org> Gerrit-Comment-Date: Wed, 26 Oct 2022 11:31:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: console/console.h: Add 'IWYU pragma: export' comment
by Elyes Haouas (Code Review) 26 Oct '22

26 Oct '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68875 ) Change subject: console/console.h: Add 'IWYU pragma: export' comment ...................................................................... console/console.h: Add 'IWYU pragma: export' comment Say to IWYU (Include What You Use) that <commonlib/loglevel.h> is chain-included via <console/console.h> Change-Id: I72ca6b256d75cccb247f6058bb108bfc456eaf23 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/include/console/console.h 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/68875/1 diff --git a/src/include/console/console.h b/src/include/console/console.h index 49bce61..7061f36 100644 --- a/src/include/console/console.h +++ b/src/include/console/console.h @@ -8,7 +8,7 @@ #include <stdint.h> /* console.h is supposed to provide the log levels defined in here: */ -#include <commonlib/loglevel.h> +#include <commonlib/loglevel.h> // IWYU pragma: export #define RAM_DEBUG (CONFIG(DEBUG_RAM_SETUP) ? BIOS_DEBUG : BIOS_NEVER) #define RAM_SPEW (CONFIG(DEBUG_RAM_SETUP) ? BIOS_SPEW : BIOS_NEVER) -- To view, visit https://review.coreboot.org/c/coreboot/+/68875 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72ca6b256d75cccb247f6058bb108bfc456eaf23 Gerrit-Change-Number: 68875 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/google/brask/variants/moli: keep SAGV disable
by Zhuohao Lee (Code Review) 26 Oct '22

26 Oct '22

Attention is currently required from: YH Lin, Derek Huang, Tim Wawrzynczak, Raihow Shi. Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68898 ) Change subject: mb/google/brask/variants/moli: keep SAGV disable ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68898 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4115b35fed35b74a307b08f7a10ebced2309297f Gerrit-Change-Number: 68898 Gerrit-PatchSet: 3 Gerrit-Owner: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Gerrit-Comment-Date: Wed, 26 Oct 2022 11:20:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: include/string.h: Add 'IWYU pragma: export' comment
by Elyes Haouas (Code Review) 26 Oct '22

26 Oct '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68874 ) Change subject: include/string.h: Add 'IWYU pragma: export' comment ...................................................................... include/string.h: Add 'IWYU pragma: export' comment Say to IWYU (Include What You Use) that <stdarg.h> and <stdio.h> are chain-included via <string.h>. Change-Id: Ic4c666d8703f241967b81e1771386b348b96a6a7 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/include/string.h 1 file changed, 15 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/68874/1 diff --git a/src/include/string.h b/src/include/string.h index f595c7e..65fb526 100644 --- a/src/include/string.h +++ b/src/include/string.h @@ -3,9 +3,9 @@ #ifndef STRING_H #define STRING_H -#include <stdarg.h> +#include <stdarg.h> // IWYU pragma: export #include <stddef.h> -#include <stdio.h> +#include <stdio.h> // IWYU pragma: export void *memcpy(void *dest, const void *src, size_t n); void *memmove(void *dest, const void *src, size_t n); -- To view, visit https://review.coreboot.org/c/coreboot/+/68874 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic4c666d8703f241967b81e1771386b348b96a6a7 Gerrit-Change-Number: 68874 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/google/brask/variants/moli: keep SAGV disable
by Raihow Shi (Code Review) 26 Oct '22

26 Oct '22

Attention is currently required from: YH Lin, Tim Wawrzynczak, Zhuohao Lee. Raihow Shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68898 ) Change subject: mb/google/brask/variants/moli: keep SAGV disable ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/68898 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4115b35fed35b74a307b08f7a10ebced2309297f Gerrit-Change-Number: 68898 Gerrit-PatchSet: 3 Gerrit-Owner: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Comment-Date: Wed, 26 Oct 2022 11:07:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022