Attention is currently required from: Jason Glenesk, Felix Held.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68844 )
Change subject: mb/amd/bilby,mandolin: add missing string.h include
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/68844
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I242a0382e7020681b6c3a25f75a2a91cbccbe815
Gerrit-Change-Number: 68844
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 26 Oct 2022 12:56:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Michał Żygowski, Maciej Pijanowski, Jason Nien, Subrata Banik, Christian Walter, Kapil Porwal, Tim Wawrzynczak, Nick Vaccaro, Martin Roth, Sergii Dmytruk.
Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68746 )
Change subject: [WIP] security/tpm: make log format configurable via Kconfig
......................................................................
Patch Set 3:
(1 comment)
File src/security/tpm/Kconfig:
https://review.coreboot.org/c/coreboot/+/68746/comment/dee8bf22_6dd431dd
PS3, Line 102: config USE_TPM_LOG_CB
Is this required? Why not use `TPM_LOG_CB` directly wherever needed?
--
To view, visit https://review.coreboot.org/c/coreboot/+/68746
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3903aff54e01093bc9ea75862bbf5989cc6e6c55
Gerrit-Change-Number: 68746
Gerrit-PatchSet: 3
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Comment-Date: Wed, 26 Oct 2022 12:55:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Erik van den Bogaert, Michał Żygowski, Maciej Pijanowski, Frans Hendriks, Christian Walter, Sergii Dmytruk.
Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68745 )
Change subject: [WIP] security/tpm: improve tlcl_extend() signature
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/security/tpm/tss/tcg-1.2/tss.c:
https://review.coreboot.org/c/coreboot/+/68745/comment/b0e5af75_61ee5028
PS2, Line 335: enum vb2_hash_algorithm digest_algo)
Maybe this should return error if anything else than SHA1 is requested?
--
To view, visit https://review.coreboot.org/c/coreboot/+/68745
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I944302b502e3424c5041b17c713a867b0fc535c4
Gerrit-Change-Number: 68745
Gerrit-PatchSet: 2
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Comment-Date: Wed, 26 Oct 2022 12:45:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: David Wu, Ricardo Ribalda, Tim Wawrzynczak, Andy Yeh, Jim Lai.
Ricardo Ribalda has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68890 )
Change subject: mb/google/brya/var/kano: Add mipi hi556 camera support
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Dont we have to add the camera at the config.star ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/68890
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I34dbf67634ecd364c40c6e934217af3d8efe1689
Gerrit-Change-Number: 68890
Gerrit-PatchSet: 2
Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Andy Yeh <andy.yeh(a)intel.com>
Gerrit-Reviewer: Jim Lai <jim.lai(a)intel.com>
Gerrit-Reviewer: Ricardo Ribalda <ribalda(a)google.com>
Gerrit-Reviewer: Ricky Liang <jcliang(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Grace Kao <grace.kao(a)intel.com>
Gerrit-CC: Ricardo Ribalda <ribalda(a)chromium.org>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Ricardo Ribalda <ribalda(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Andy Yeh <andy.yeh(a)intel.com>
Gerrit-Attention: Jim Lai <jim.lai(a)intel.com>
Gerrit-Comment-Date: Wed, 26 Oct 2022 12:40:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Arthur Heymans has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/68897 )
Change subject: cpu/x86/smm: Move setting up 64bit mode earlier
......................................................................
cpu/x86/smm: Move setting up 64bit mode earlier
Now there is no need to do it that late in the smm stub. Since we don't
need the stack to save EFER MSR anymore.
This also removes the need exit back to protected mode for the fxrstor
instruction. A further advantage is that all XMM regs (remember that
there are more in long mode) are now properly saved.
Change-Id: Ie247d6fba0dbc953a810038465f1e0d42ca171cf
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/cpu/x86/smm/smm_stub.S
1 file changed, 42 insertions(+), 23 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/68897/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/68897
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie247d6fba0dbc953a810038465f1e0d42ca171cf
Gerrit-Change-Number: 68897
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Patrick Rudolph.
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/68895
to look at the new patch set (#4).
Change subject: cpu/x86/smm: Don't save EFER
......................................................................
cpu/x86/smm: Don't save EFER
THe EFER MSR is in the SMM save state and RSM properly restores it.
Change-Id: Ie0e9584afd1f08f51ca57da5c4350042699f130d
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/cpu/x86/smm/smm_stub.S
M src/cpu/x86/smm/smmhandler.S
2 files changed, 22 insertions(+), 59 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/68895/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/68895
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie0e9584afd1f08f51ca57da5c4350042699f130d
Gerrit-Change-Number: 68895
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Michał Żygowski, Maciej Pijanowski, Christian Walter, Julius Werner, Yu-Ping Wu, Sergii Dmytruk.
Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68750 )
Change subject: [WIP] security/tpm: make use of PCRs configurable via Kconfig
......................................................................
Patch Set 2:
(1 comment)
File src/security/tpm/Kconfig:
https://review.coreboot.org/c/coreboot/+/68750/comment/01c439d1_907e87a8
PS2, Line 176: PCR_CRTM
Rename to `PCR_SRTM`. This is not (only) CRTM.
--
To view, visit https://review.coreboot.org/c/coreboot/+/68750
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3a192d902072f6f8d415c2952a36522b5bf09f9
Gerrit-Change-Number: 68750
Gerrit-PatchSet: 2
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Comment-Date: Wed, 26 Oct 2022 12:26:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Daniel P. Smith, Michał Żygowski, Maciej Pijanowski, Sergii Dmytruk.
Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68752 )
Change subject: [WIP] Documentation/measured_boot.md: document new TPM options
......................................................................
Patch Set 4:
(4 comments)
File Documentation/security/vboot/measured_boot.md:
https://review.coreboot.org/c/coreboot/+/68752/comment/cac9fb34_5b45f46b
PS4, Line 135: In endianness of the firmware. Not meant to be stable.
Since endianness of log itself is fixed, I think it makes sense to fix these fields as well. This would help with cases where FW and OS differ in endianness, like POWER9, to provide tools capable of reading those fields from OS. I don't know if there will ever be the use case for those, but it will be easier to do it now, while nothing depends on it.
https://review.coreboot.org/c/coreboot/+/68752/comment/b2faec95_0e15d5db
PS4, Line 158: In endianness of the firmware. Not meant to be stable.
Same as above.
https://review.coreboot.org/c/coreboot/+/68752/comment/c112e17a_4acd1cc0
PS4, Line 238: GBB HWID by SHA-256
Current version of documentation says it is either SHA-1 or SHA-256, has the implementation changed?
https://review.coreboot.org/c/coreboot/+/68752/comment/a0bf1070_4cd90240
PS4, Line 246: Core
Drop `Core`.
--
To view, visit https://review.coreboot.org/c/coreboot/+/68752
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6dae8e95c59b440c75e13473eefc4c2cf4fd369b
Gerrit-Change-Number: 68752
Gerrit-PatchSet: 4
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-CC: Daniel P. Smith
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Daniel P. Smith
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Comment-Date: Wed, 26 Oct 2022 12:17:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment