Attention is currently required from: Jakub Czapiga.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68540 )
Change subject: Update vboot submodule to upstream main
......................................................................
Patch Set 5: Verified+1
(6 comments)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161409):
https://review.coreboot.org/c/coreboot/+/68540/comment/579f8fb5_5a33f62e
PS5, Line 9: Updating from commit id b827ddb9:
Possible unwrapped commit description (prefer a maximum 72 chars per line)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161409):
https://review.coreboot.org/c/coreboot/+/68540/comment/e5c8d865_af819b1d
PS5, Line 12: to commit id 148e5b83:
Possible unwrapped commit description (prefer a maximum 72 chars per line)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161409):
https://review.coreboot.org/c/coreboot/+/68540/comment/1beaffcc_991212fc
PS5, Line 17: a9c47c41 futility/cmd_show: set uninitialized variable
Possible unwrapped commit description (prefer a maximum 72 chars per line)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161409):
https://review.coreboot.org/c/coreboot/+/68540/comment/87c89261_530540e8
PS5, Line 23: d0f7fdf6 treewide: Fix copyrights and extra new lines at end of file
Possible unwrapped commit description (prefer a maximum 72 chars per line)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161409):
https://review.coreboot.org/c/coreboot/+/68540/comment/b47f0fa2_70799204
PS5, Line 25: 4ca43a34 crossystem: arm: Retry if we fail to read a GPIO
Possible unwrapped commit description (prefer a maximum 72 chars per line)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161409):
https://review.coreboot.org/c/coreboot/+/68540/comment/26f4c4fe_6e1b4558
PS5, Line 42: 62cc7885 subprocess: Log subprocess arguments when running
Possible unwrapped commit description (prefer a maximum 72 chars per line)
--
To view, visit https://review.coreboot.org/c/coreboot/+/68540
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9a16d6e02cee34140ec375ed6166f47560459140
Gerrit-Change-Number: 68540
Gerrit-PatchSet: 5
Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Comment-Date: Wed, 26 Oct 2022 13:41:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held.
Hello build bot (Jenkins), Julius Werner, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/66909
to look at the new patch set (#14).
Change subject: vboot: Add VBOOT_CBFS_INTEGRATION support
......................................................................
vboot: Add VBOOT_CBFS_INTEGRATION support
This patch introduces support signing and verification of firmware
slots using CBFS metadata hash verification method for faster initial
verification. To have complete verification, CBFS_VERIFICATION should
also be enabled, as metadata hash covers only files metadata, not their
contents.
This patch also adapts mainboards and SoCs to new vboot reset
requirements.
TEST=Volteer/Voxel boots with CL:3811754
Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com>
Change-Id: I40ae01c477c4e4f7a1c90e4026a8a868ae64b5ca
---
M src/include/cbfs_glue.h
M src/lib/cbfs.c
M src/mainboard/google/asurada/Makefile.inc
M src/mainboard/google/cherry/Makefile.inc
M src/mainboard/google/corsola/Makefile.inc
M src/mainboard/google/geralt/Makefile.inc
M src/security/vboot/Kconfig
M src/security/vboot/Makefile.inc
M src/security/vboot/common.c
M src/security/vboot/vboot_common.c
M src/security/vboot/vboot_common.h
M src/security/vboot/vboot_loader.c
M src/security/vboot/vboot_logic.c
M src/soc/amd/common/psp_verstage/psp_verstage.c
M src/soc/amd/stoneyridge/Makefile.inc
M src/soc/intel/common/block/cse/cse.c
M src/soc/mediatek/mt8173/Makefile.inc
M src/soc/qualcomm/ipq40xx/Makefile.inc
M src/soc/qualcomm/ipq806x/Makefile.inc
19 files changed, 186 insertions(+), 78 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/66909/14
--
To view, visit https://review.coreboot.org/c/coreboot/+/66909
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40ae01c477c4e4f7a1c90e4026a8a868ae64b5ca
Gerrit-Change-Number: 66909
Gerrit-PatchSet: 14
Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jakub Czapiga.
Hello build bot (Jenkins), Julius Werner, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/68540
to look at the new patch set (#5).
Change subject: Update vboot submodule to upstream main
......................................................................
Update vboot submodule to upstream main
Updating from commit id b827ddb9:
2022-09-01 06:37:33 +0000 - (tests: Ensure auxfw sync runs after EC sync)
to commit id 148e5b83:
2022-10-25 09:36:59 +0000 - (Makefile: Fix and simplify the RUNTEST test wrapper)
This brings in 28 new commits:
148e5b83 Makefile: Fix and simplify the RUNTEST test wrapper
a9c47c41 futility/cmd_show: set uninitialized variable
e18a6cda gscvd: presume GBB flags are zero when hashing the RO space contents
0b0aee9c gscvd: refactor discovering GBB in the image
ff1749cb futility: add option to save ro_gscvd section in a blob
84c65cd3 vboot_reference: Check OS/firmware mismatch and report to UMA
9a1be550 cmd_update: avoid variable name aliasing
d0f7fdf6 treewide: Fix copyrights and extra new lines at end of file
0ca75fd1 tpm_lite: Fix copyrights, line endings, extra new lines at end of file
4ca43a34 crossystem: arm: Retry if we fail to read a GPIO
f1a7efc0 futility: updater: Scan patch files for the signer_config manifest
64803227 futility: updater: Support patching GSCVD
2aa69d0c futility: Remove validate_rec_mrc command
0ca7a9e4 firmware: host: futility: Add CBFS metadata hash support
aaeb307f futility: Use ccd update mode for suzyq ti50
aa44b7cf vboot: gbb_flags_common should treat ccd_ti50 like ccd_cr50
ff8bb2d9 futility: Address double free
6a33a0fc treewide: Fix license headers to conform with linter
b2b4f767 DIR_METADATA: Add V2 Test Plans.
5346938c futility gscvd: add option to print out root key hash
5790c0aa gscvd: add support for reading ranges from the image
499e5743 gbb_flags_common.sh: Restore tmpfile cleanup trap
f3f9d2a6 scripts/OWNERS: Fix engeg email chromium -> google
ce620761 tests: Remove --allow-multiple-definition linker option
956c2efb futility: Skip picking apart an x86 kernel if has the EFI stub
9f2e9804 Avoid build failures on recent distros
62cc7885 subprocess: Log subprocess arguments when running
3bd35108 2api: Add a new entry point for only loading and verifying the kernel
Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com>
Change-Id: I9a16d6e02cee34140ec375ed6166f47560459140
---
M 3rdparty/vboot
1 file changed, 47 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/68540/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/68540
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9a16d6e02cee34140ec375ed6166f47560459140
Gerrit-Change-Number: 68540
Gerrit-PatchSet: 5
Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jason Glenesk.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68848 )
Change subject: mb/amd/mandolin: handle invalid intr_index values in init_tables
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> This looks like it really should be squashed with the previous patch
i intentionally did one patch per logical change here to make this easier to review. for the other mainboards i did then both in one patch to not have an excessive amount of patches
--
To view, visit https://review.coreboot.org/c/coreboot/+/68848
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45ab115f3814b212243c4f6cf706daf77b6ff3b2
Gerrit-Change-Number: 68848
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Comment-Date: Wed, 26 Oct 2022 13:38:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Felix Held.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68849 )
Change subject: mb/amd/bilby,birman,chausie,majolica: rework FCH IRQ mapping generation
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/68849
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia957056b60dafbc52a9809a4563a348ad7443376
Gerrit-Change-Number: 68849
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 26 Oct 2022 13:30:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Felix Held.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68848 )
Change subject: mb/amd/mandolin: handle invalid intr_index values in init_tables
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
This looks like it really should be squashed with the previous patch
--
To view, visit https://review.coreboot.org/c/coreboot/+/68848
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45ab115f3814b212243c4f6cf706daf77b6ff3b2
Gerrit-Change-Number: 68848
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 26 Oct 2022 13:28:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Paz Zcharya, Terry Chen, Tim Wawrzynczak, Nick Vaccaro, Franklin Lin.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68868 )
Change subject: mb/google/brya: Update Crota's ELAN touchscreen delay to 150 ms
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/brya/variants/crota/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/68868/comment/fcc53deb_3ef9626e
PS6, Line 225: 150
do we even need 150ms, on Rex, the reset delay with 20ms is meeting the spec.
--
To view, visit https://review.coreboot.org/c/coreboot/+/68868
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17e1f7d419637f6dff4049484ce1836ad98017ea
Gerrit-Change-Number: 68868
Gerrit-PatchSet: 6
Gerrit-Owner: Paz Zcharya <pazz(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Franklin Lin <franklin_lin(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Terry Chen <terry_chen(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Rajat Jain <rajatja(a)google.com>
Gerrit-Attention: Paz Zcharya <pazz(a)google.com>
Gerrit-Attention: Terry Chen <terry_chen(a)wistron.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Franklin Lin <franklin_lin(a)wistron.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 26 Oct 2022 13:27:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Subrata Banik, Terry Chen, Tim Wawrzynczak, Nick Vaccaro, Franklin Lin.
Paz Zcharya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68868 )
Change subject: mb/google/brya: Update Crota's ELAN touchscreen delay to 150 ms
......................................................................
Patch Set 6:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68868/comment/82579fb0_02289e7a
PS3, Line 7: crota/overridetree.cb: Update ELAN's touchscreen delay to 150 ms (per new uploaded datasheet in AVL)
> "crota/overridetree.cb:" should probably be "mb/google/brya:" […]
Thank you for the constructive feedback. FIXED.
Commit Message:
https://review.coreboot.org/c/coreboot/+/68868/comment/30908550_f16e71b8
PS5, Line 7: mb/google/brya: Update ELAN's touchscreen delay to 150 ms.
> I would still make this clear its crota only […]
FIXED
--
To view, visit https://review.coreboot.org/c/coreboot/+/68868
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17e1f7d419637f6dff4049484ce1836ad98017ea
Gerrit-Change-Number: 68868
Gerrit-PatchSet: 6
Gerrit-Owner: Paz Zcharya <pazz(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Franklin Lin <franklin_lin(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Terry Chen <terry_chen(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Rajat Jain <rajatja(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Terry Chen <terry_chen(a)wistron.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Franklin Lin <franklin_lin(a)wistron.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 26 Oct 2022 13:17:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tarun Tuli <taruntuli(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Jason Nien, Martin Roth, Felix Held.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68846 )
Change subject: mb/amd,google: unify fch_irq_routing struct instance name
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/68846
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I035cffb9c6c8afd6bd115831e8eed4a395e2a7fc
Gerrit-Change-Number: 68846
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 26 Oct 2022 12:59:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jason Nien, Martin Roth, Felix Held.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68845 )
Change subject: mb/google/guybrush,skyrim: add missing string.h include
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/68845
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I286557d6ad83990bc101eaa930bde04345859c0b
Gerrit-Change-Number: 68845
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 26 Oct 2022 12:58:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment