Attention is currently required from: Paul Menzel, Christian Walter, Arthur Heymans, Lean Sheng Tan, Patrick Rudolph, Marvin Drees.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61296 )
Change subject: mb/prodrive/atlas: Configure PCIe device tree settings
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/61296
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id3145156c4ab3ec1c2d3eb6c433108a1b1cab9e8
Gerrit-Change-Number: 61296
Gerrit-PatchSet: 2
Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-Comment-Date: Mon, 31 Jan 2022 17:14:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Christian Walter, Arthur Heymans, Lean Sheng Tan, Patrick Rudolph, Marvin Drees.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61277 )
Change subject: mb/prodrive/atlas: Configure SATA, USB & HSIO device tree settings
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/prodrive/atlas/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/61277/comment/c2d6412e_3af4b68f
PS1, Line 43: PchSerialIoDisabled
Should be enabled
--
To view, visit https://review.coreboot.org/c/coreboot/+/61277
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I88c898d4b0c3bfeefbca71e13dad55e2c5fc846f
Gerrit-Change-Number: 61277
Gerrit-PatchSet: 1
Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-Comment-Date: Mon, 31 Jan 2022 17:14:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Raul Rangel, ritul guru, Marshall Dawson, Paul Menzel, Angel Pons, Felix Held.
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60968 )
Change subject: soc/amd/common/block/psp: Add platform secure boot support
......................................................................
Patch Set 10:
(3 comments)
File src/soc/amd/common/block/psp/Kconfig:
https://review.coreboot.org/c/coreboot/+/60968/comment/fcaf4a3a_bed8a9b2
PS5, Line 33: default n
> doesn't hurt to explicitly set default n.
not needed though..but fine with it.
File src/soc/amd/common/block/psp/Kconfig:
https://review.coreboot.org/c/coreboot/+/60968/comment/8e8c0efd_b70bac50
PS9, Line 34: help
> can you please elaborate on why you are suggesting this dependency?
I see some of the APIs like send_psp_command sourced from SOC_AMD_COMMON_BLOCK_PSP_GEN2/1..
File src/soc/amd/common/block/psp/psb.c:
https://review.coreboot.org/c/coreboot/+/60968/comment/1057abdd_cfa6f6bb
PS9, Line 187:
> Ack
ahh ok..
--
To view, visit https://review.coreboot.org/c/coreboot/+/60968
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I30aac29a22a5800d5995a78c50fdecd660a3d4eb
Gerrit-Change-Number: 60968
Gerrit-PatchSet: 10
Gerrit-Owner: ritul guru <ritul.bits(a)gmail.com>
Gerrit-Reviewer: Aamir Bohra <aamirbohra(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 31 Jan 2022 17:11:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ritul guru <ritul.bits(a)gmail.com>
Comment-In-Reply-To: Aamir Bohra <aamirbohra(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Bora Guvendik, Anil Kumar K, Selma Bensaid, Tim Wawrzynczak, Paul Menzel, Thejaswani Putta.
Hello Bora Guvendik, build bot (Jenkins), Anil Kumar K, Selma Bensaid, Tim Wawrzynczak, Thejaswani Putta,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61354
to look at the new patch set (#6).
Change subject: drivers/wwan/fm: Add Fibocom 5G WWAN ACPI support
......................................................................
drivers/wwan/fm: Add Fibocom 5G WWAN ACPI support
Support PXSX._RST and PXSX.MRST._RST for warm and cold reset.
PXSX._RST is invoked on driver removal.
Test:
Add chip entry to the corresponding root port and check PXSX Device
is generated in ssdt.
Signed-off-by: Cliff Huang <cliff.huang(a)intel.com>
Change-Id: I1e0b9fd405f6cfb1e216ea27558bb9299a09e566
---
A src/drivers/wwan/fm/Kconfig
A src/drivers/wwan/fm/Makefile.inc
A src/drivers/wwan/fm/acpi_fm350gl.c
A src/drivers/wwan/fm/chip.h
4 files changed, 246 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/61354/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/61354
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1e0b9fd405f6cfb1e216ea27558bb9299a09e566
Gerrit-Change-Number: 61354
Gerrit-PatchSet: 6
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Reviewer: Thejaswani Putta <thejaswani.putta(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Thejaswani Putta <thejaswani.putta(a)intel.com>
Gerrit-MessageType: newpatchset
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/61514 )
Change subject: drivers/i2c/designware/dw_i2c: limit scope of dw_i2c_transfer
......................................................................
drivers/i2c/designware/dw_i2c: limit scope of dw_i2c_transfer
Outside of the designware I2C driver the generic platform_i2c_transfer
function should be used instead, so don't make dw_i2c_transfer available
outside of this file.
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: Ib8b6a08b6aa2cd63adc2ef69b828661fa0ed154a
---
M src/drivers/i2c/designware/dw_i2c.c
M src/drivers/i2c/designware/dw_i2c.h
2 files changed, 1 insertion(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/61514/1
diff --git a/src/drivers/i2c/designware/dw_i2c.c b/src/drivers/i2c/designware/dw_i2c.c
index b051359..d6a5e5c 100644
--- a/src/drivers/i2c/designware/dw_i2c.c
+++ b/src/drivers/i2c/designware/dw_i2c.c
@@ -453,7 +453,7 @@
return ret;
}
-enum cb_err dw_i2c_transfer(unsigned int bus, const struct i2c_msg *msg, size_t count)
+static enum cb_err dw_i2c_transfer(unsigned int bus, const struct i2c_msg *msg, size_t count)
{
const struct i2c_msg *orig_msg = msg;
size_t i;
diff --git a/src/drivers/i2c/designware/dw_i2c.h b/src/drivers/i2c/designware/dw_i2c.h
index a600ed6..464facf 100644
--- a/src/drivers/i2c/designware/dw_i2c.h
+++ b/src/drivers/i2c/designware/dw_i2c.h
@@ -107,13 +107,6 @@
struct dw_i2c_speed_config *config);
/*
- * Process given I2C segments in a single transfer
- */
-enum cb_err dw_i2c_transfer(unsigned int bus,
- const struct i2c_msg *segments,
- size_t count);
-
-/*
* Map an i2c host controller device to a logical bus number.
* Return value:
* -1 = failure
--
To view, visit https://review.coreboot.org/c/coreboot/+/61514
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib8b6a08b6aa2cd63adc2ef69b828661fa0ed154a
Gerrit-Change-Number: 61514
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newchange
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/61512 )
Change subject: drivers/i2c/designware/dw_i2c: use cb_err for dw_i2c_gen_speed_config
......................................................................
drivers/i2c/designware/dw_i2c: use cb_err for dw_i2c_gen_speed_config
Using enum cb_err as return type instead of int improves the readability
of the code.
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: I8d96e5f72a8b3552ab39c1d298bafcc224bf9e55
---
M src/drivers/i2c/designware/dw_i2c.c
M src/drivers/i2c/designware/dw_i2c.h
2 files changed, 4 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/61512/1
diff --git a/src/drivers/i2c/designware/dw_i2c.c b/src/drivers/i2c/designware/dw_i2c.c
index e29d54f..1f73d5c 100644
--- a/src/drivers/i2c/designware/dw_i2c.c
+++ b/src/drivers/i2c/designware/dw_i2c.c
@@ -615,7 +615,7 @@
return CB_SUCCESS;
}
-int dw_i2c_gen_speed_config(uintptr_t dw_i2c_addr,
+enum cb_err dw_i2c_gen_speed_config(uintptr_t dw_i2c_addr,
enum i2c_speed speed,
const struct dw_i2c_bus_config *bcfg,
struct dw_i2c_speed_config *config)
@@ -669,7 +669,7 @@
}
/* Generate speed config based on clock */
- if (dw_i2c_gen_speed_config((uintptr_t)regs, speed, bcfg, &config) < 0)
+ if (dw_i2c_gen_speed_config((uintptr_t)regs, speed, bcfg, &config) != CB_SUCCESS)
return CB_ERR;
/* Select this speed in the control register */
@@ -830,7 +830,7 @@
/* Report currently used timing values for the OS driver */
acpigen_write_scope(path);
- if (dw_i2c_gen_speed_config(dw_i2c_addr, speed, bcfg, &sgen) >= 0) {
+ if (dw_i2c_gen_speed_config(dw_i2c_addr, speed, bcfg, &sgen) == CB_SUCCESS) {
dw_i2c_acpi_write_speed_config(&sgen);
}
/* Now check if there are more speed settings available and report them as well. */
diff --git a/src/drivers/i2c/designware/dw_i2c.h b/src/drivers/i2c/designware/dw_i2c.h
index 64e27c0..2d255ee 100644
--- a/src/drivers/i2c/designware/dw_i2c.h
+++ b/src/drivers/i2c/designware/dw_i2c.h
@@ -100,11 +100,8 @@
/*
* Generate speed config based on clock
- * Return value:
- * -1 = failure
- * 0 = success
*/
-int dw_i2c_gen_speed_config(uintptr_t dw_i2c_addr,
+enum cb_err dw_i2c_gen_speed_config(uintptr_t dw_i2c_addr,
enum i2c_speed speed,
const struct dw_i2c_bus_config *bcfg,
struct dw_i2c_speed_config *config);
--
To view, visit https://review.coreboot.org/c/coreboot/+/61512
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d96e5f72a8b3552ab39c1d298bafcc224bf9e55
Gerrit-Change-Number: 61512
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newchange
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/61509 )
Change subject: drivers/i2c/designware/dw_i2c.h: include types.h instead of stdint.h
......................................................................
drivers/i2c/designware/dw_i2c.h: include types.h instead of stdint.h
size_t is defined in stddef.h and not stdint.h, so include types.h to
get both.
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: I3782d3a949b72d1530ebd8078c46bc695f76dc4f
---
M src/drivers/i2c/designware/dw_i2c.h
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/61509/1
diff --git a/src/drivers/i2c/designware/dw_i2c.h b/src/drivers/i2c/designware/dw_i2c.h
index e20a5d1..c010b11 100644
--- a/src/drivers/i2c/designware/dw_i2c.h
+++ b/src/drivers/i2c/designware/dw_i2c.h
@@ -5,7 +5,7 @@
#include <device/device.h>
#include <device/i2c.h>
-#include <stdint.h>
+#include <types.h>
#if CONFIG(DRIVERS_I2C_DESIGNWARE_DEBUG)
#define DW_I2C_DEBUG BIOS_DEBUG
--
To view, visit https://review.coreboot.org/c/coreboot/+/61509
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3782d3a949b72d1530ebd8078c46bc695f76dc4f
Gerrit-Change-Number: 61509
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newchange