Attention is currently required from: HAOUAS Elyes.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61469 )
Change subject: util/lint/checkpatch: Update "check for missing blank lines after declarations"
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/61469
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1b7bc2b4ec832f0abeda215c381856a5ec153883
Gerrit-Change-Number: 61469
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Mon, 31 Jan 2022 17:41:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: HAOUAS Elyes.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61467 )
Change subject: util/lint/checkpatch.pl: Remove unneeded whitespaces and fix some typos
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/61467
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4aa7abce83b41ccd5129717cd3bf85be19ec4807
Gerrit-Change-Number: 61467
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Mon, 31 Jan 2022 17:40:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: HAOUAS Elyes.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61466 )
Change subject: util/lint/checkpatch.pl: Use "perl_version_ok"
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/61466
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c2f5d5c9853dc8ddc8f89a5e2edd6c8613ba790
Gerrit-Change-Number: 61466
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Mon, 31 Jan 2022 17:39:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, HAOUAS Elyes.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60874 )
Change subject: util/lint/checkpatch.pl: Use "tabsize"
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/60874
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifeb9c4406737fa24f9bd803af48d8b8d17654940
Gerrit-Change-Number: 60874
Gerrit-PatchSet: 7
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Mon, 31 Jan 2022 17:37:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Bora Guvendik, Anil Kumar K, Selma Bensaid, Paul Menzel, Tim Wawrzynczak, Thejaswani Putta.
Hello Bora Guvendik, build bot (Jenkins), Anil Kumar K, Selma Bensaid, Tim Wawrzynczak, Thejaswani Putta,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61355
to look at the new patch set (#5).
Change subject: mb/google/brya: Add 5G WWAN ACPI support for Brya and Redrix
......................................................................
mb/google/brya: Add 5G WWAN ACPI support for Brya and Redrix
Add FM350GL 5G WWAN support using drivers/wwan/fm and addtional PM
features from RTD3.
Signed-off-by: Cliff Huang <cliff.huang(a)intel.com>
Change-Id: I6413f106ce6ef6c895d4861f4dbe26ac9a507d25
---
M src/mainboard/google/brya/Kconfig
M src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb
M src/mainboard/google/brya/variants/brya0/overridetree.cb
M src/mainboard/google/brya/variants/brya4es/overridetree.cb
M src/mainboard/google/brya/variants/redrix/overridetree.cb
M src/mainboard/google/brya/variants/redrix4es/overridetree.cb
6 files changed, 47 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/61355/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/61355
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6413f106ce6ef6c895d4861f4dbe26ac9a507d25
Gerrit-Change-Number: 61355
Gerrit-PatchSet: 5
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Reviewer: Thejaswani Putta <thejaswani.putta(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Thejaswani Putta <thejaswani.putta(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Kevin Chiu, Jason Glenesk, Marshall Dawson, Bhanu Prakash Maiya, Tim Wawrzynczak, Paul Menzel, Rob Barnes, Eric Peers, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61125 )
Change subject: mb/google/guybrush/var/nipperkin: Add _HID for privacy screen device
......................................................................
Patch Set 4:
(1 comment)
File src/soc/amd/common/block/graphics/graphics.c:
PS4:
> The change in this file should be split out to a separate patch, as it is not mainboard-specific cod […]
+1.
Nice find Tim
--
To view, visit https://review.coreboot.org/c/coreboot/+/61125
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f45fabac1548cca39379f91cc42fed0cd04f8a3
Gerrit-Change-Number: 61125
Gerrit-PatchSet: 4
Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Reviewer: Eric Peers <epeers(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Rob Barnes <robbarnes(a)google.com>
Gerrit-Attention: Eric Peers <epeers(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 31 Jan 2022 17:30:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, HAOUAS Elyes.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59399 )
Change subject: crossgcc: Upgrade CMake to 3.22.1 version
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
Paul, https://review.coreboot.org/61515 should fix this issue.
--
To view, visit https://review.coreboot.org/c/coreboot/+/59399
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4272f72dd6ed686dbad5615a0ab44c8c632b5930
Gerrit-Change-Number: 59399
Gerrit-PatchSet: 6
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Mon, 31 Jan 2022 17:21:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/61515 )
Change subject: util/crossgcc: Update for normailze_dirs()
......................................................................
util/crossgcc: Update for normailze_dirs()
Currently, the function normalize_dirs() fails if the directories lib32
and lib64 don't exist. That can be fixed by using an rm -rf on it
instead of rmdir.
The cmake build doesn't create those directories, so was showing a
failure message after the build was already completed. That's fixed by
removing normailze_dirs() from the build_CMAKE() function.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: Iea6e3ca57fb91ff1234be875861b27a78972d9ca
---
M util/crossgcc/buildgcc
1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/61515/1
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index b0c7707..f27dd01 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -121,7 +121,7 @@
mkdir -p "$DESTDIR$TARGETDIR/lib"
test -d "$DESTDIR$TARGETDIR/lib32" && mv "$DESTDIR$TARGETDIR"/lib32/* "$DESTDIR$TARGETDIR/lib"
test -d "$DESTDIR$TARGETDIR/lib64" && mv "$DESTDIR$TARGETDIR"/lib64/* "$DESTDIR$TARGETDIR/lib"
- rmdir -p "$DESTDIR$TARGETDIR/lib32" "$DESTDIR$TARGETDIR/lib64"
+ rm -rf "$DESTDIR$TARGETDIR/lib32" "$DESTDIR$TARGETDIR/lib64"
perl -pi -e "s,/lib32,/lib," "$DESTDIR$TARGETDIR"/lib/*.la
perl -pi -e "s,/lib64,/lib," "$DESTDIR$TARGETDIR"/lib/*.la
@@ -834,8 +834,6 @@
# shellcheck disable=SC2086
$MAKE $JOBS || touch .failed
$MAKE install DESTDIR=$DESTDIR || touch .failed
-
- normalize_dirs
}
build_NASM() {
--
To view, visit https://review.coreboot.org/c/coreboot/+/61515
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iea6e3ca57fb91ff1234be875861b27a78972d9ca
Gerrit-Change-Number: 61515
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-MessageType: newchange
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61512 )
Change subject: drivers/i2c/designware/dw_i2c: use cb_err for dw_i2c_gen_speed_config
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/i2c/designware/dw_i2c.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139552):
https://review.coreboot.org/c/coreboot/+/61512/comment/a57f636b_aa9aa934
PS1, Line 833: if (dw_i2c_gen_speed_config(dw_i2c_addr, speed, bcfg, &sgen) == CB_SUCCESS) {
braces {} are not necessary for single statement blocks
--
To view, visit https://review.coreboot.org/c/coreboot/+/61512
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d96e5f72a8b3552ab39c1d298bafcc224bf9e55
Gerrit-Change-Number: 61512
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 31 Jan 2022 17:18:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment