Attention is currently required from: Felix Singer, Tim Wawrzynczak, Nick Vaccaro, Michael Niewöhner, Andrey Petrov, Patrick Rudolph, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60402 )
Change subject: drivers/intel/fsp2_0: Make FSP Notify Phase APIs optional
......................................................................
Patch Set 10:
(1 comment)
Patchset:
PS10:
> I meant "required" as in "FSP will not continue if we don't use it".
Got it :)
>
> Awesome! :-)
--
To view, visit https://review.coreboot.org/c/coreboot/+/60402
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia95e9ec25ae797f2ac8e1c74145cf21e59867d64
Gerrit-Change-Number: 60402
Gerrit-PatchSet: 10
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 04 Jan 2022 19:07:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-MessageType: comment
Attention is currently required from: Julius Werner.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60284 )
Change subject: mb/google/herobrine: Transition BOARD_HEROBRINE to BOARD_HEROBRINE_REV0
......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/google/herobrine/Kconfig:
https://review.coreboot.org/c/coreboot/+/60284/comment/360e195d_203c8b45
PS2, Line 50: default "Herobrine_Rev0" if BOARD_GOOGLE_HEROBRINE_REV0
> nit: I feel like this should still be "Herobrine" because it is used to construct the FWID, which ma […]
Done
File src/mainboard/google/herobrine/mainboard.c:
https://review.coreboot.org/c/coreboot/+/60284/comment/48e272e4_accc792e
PS2, Line 75: /* BOARD_GOOGLE_HEROBRINE */
> nit: This comment is going to be more confusing than helpful once you add more boards.
Ok, removed the comment.
--
To view, visit https://review.coreboot.org/c/coreboot/+/60284
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I67a0b282710031b927ce9022c7c535bd8d4ca1aa
Gerrit-Change-Number: 60284
Gerrit-PatchSet: 3
Gerrit-Owner: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Sudheer Amrabadi <samrabad(a)codeaurora.org>
Gerrit-CC: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Tue, 04 Jan 2022 19:06:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Shelley Chen.
Hello build bot (Jenkins), Julius Werner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60284
to look at the new patch set (#3).
Change subject: mb/google/herobrine: Transition BOARD_HEROBRINE to BOARD_HEROBRINE_REV0
......................................................................
mb/google/herobrine: Transition BOARD_HEROBRINE to BOARD_HEROBRINE_REV0
Deprecating Herobrine Rev0 board. The next board is very different
from the Rev0 board (ie: Most GPIOs have been remapped). Deprecating
and reusing the GOOGLE_BOARD_HEROBRINE Kconfig for next board and
reslotting the old GOOGLE_BOARD_HEROBRINE source under
GOOGLE_BOARD_HEROBRINE_REV0 config. Want to keep the code around in
case somebody needs it but we can remove this code in future after we
recall all the Rev0 devices. Also updating the remapped GPIOs to
match those of the current herobrine board.
BUG=b:211644878
BRANCH=None
TEST=emerge-herobrine coreboot
Change-Id: I67a0b282710031b927ce9022c7c535bd8d4ca1aa
Signed-off-by: Shelley Chen <shchen(a)google.com>
---
M src/mainboard/google/herobrine/Kconfig
M src/mainboard/google/herobrine/Kconfig.name
M src/mainboard/google/herobrine/board.h
M src/mainboard/google/herobrine/mainboard.c
4 files changed, 17 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/60284/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/60284
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I67a0b282710031b927ce9022c7c535bd8d4ca1aa
Gerrit-Change-Number: 60284
Gerrit-PatchSet: 3
Gerrit-Owner: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Sudheer Amrabadi <samrabad(a)codeaurora.org>
Gerrit-CC: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60209 )
Change subject: soc/amd/common/lpc/espi_util: handle espi_get_configuration error
......................................................................
Patch Set 3:
(1 comment)
File src/soc/amd/common/block/lpc/espi_util.c:
https://review.coreboot.org/c/coreboot/+/60209/comment/6f3cb23d_d69d290b
PS2, Line 775: espi_get_configuration
> IMO, we should...
pushed a new version that adds a return value check. would probably be good to test this on guybrush.
i thought about continuing after a failure instead of returning an error, but when the espi_send_command command fails, there's something seriously wrong and retrying likely won't help, so just returning an error is probably the best thing to do there
--
To view, visit https://review.coreboot.org/c/coreboot/+/60209
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iff1a0670e17b9d6c6f4daf2ea56badf6c428b8c9
Gerrit-Change-Number: 60209
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Comment-Date: Tue, 04 Jan 2022 18:22:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held.
Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Marshall Dawson,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60209
to look at the new patch set (#3).
Change subject: soc/amd/common/lpc/espi_util: handle espi_get_configuration error
......................................................................
soc/amd/common/lpc/espi_util: handle espi_get_configuration error
In espi_wait_channel_ready the return value of espi_get_configuration
didn't get checked before. In the case of the espi_send_command call in
espi_get_configuration returning CB_ERR, espi_get_configuration didn't
write to the local config variable, so if this happens in the first pass
of the do-while loop, the following espi_slave_is_channel_ready call
would use the uninitialized local config variable as parameter. Fix this
by checking the return value of espi_get_configuration.
TEST=None
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: Iff1a0670e17b9d6c6f4daf2ea56badf6c428b8c9
---
M src/soc/amd/common/block/lpc/espi_util.c
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/60209/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/60209
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iff1a0670e17b9d6c6f4daf2ea56badf6c428b8c9
Gerrit-Change-Number: 60209
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer, Subrata Banik, Tim Wawrzynczak, Nick Vaccaro, Andrey Petrov, Patrick Rudolph, EricR Lai.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60402 )
Change subject: drivers/intel/fsp2_0: Make FSP Notify Phase APIs optional
......................................................................
Patch Set 10:
(1 comment)
Patchset:
PS10:
> > huh? I always thought the notify phases are required? […]
I meant "required" as in "FSP will not continue if we don't use it".
Awesome! :-)
--
To view, visit https://review.coreboot.org/c/coreboot/+/60402
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia95e9ec25ae797f2ac8e1c74145cf21e59867d64
Gerrit-Change-Number: 60402
Gerrit-PatchSet: 10
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 04 Jan 2022 18:07:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-MessageType: comment
Attention is currently required from: Kevin Chiu, Bhanu Prakash Maiya, Rob Barnes.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60265 )
Change subject: mb/google/guybrush/var/nipperkin: turn on WLAN ASPM L1ss
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/guybrush/variants/nipperkin/variant.c:
https://review.coreboot.org/c/coreboot/+/60265/comment/34da9967_7870b811
PS3, Line 10: true
Isn't this dependent on the board id? Also the latest board still requires false unless the rework was completed.
--
To view, visit https://review.coreboot.org/c/coreboot/+/60265
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie1f295eaa57af7c2942e1807b3a0c4dcd89cd696
Gerrit-Change-Number: 60265
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Attention: Rob Barnes <robbarnes(a)google.com>
Gerrit-Comment-Date: Tue, 04 Jan 2022 17:47:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
vagdevi.p(a)intel.com has removed Paul Menzel from this change. ( https://review.coreboot.org/c/coreboot/+/60749 )
Change subject: Signed-off-by: VAGDEVI P <vagdevi.p(a)intel.com> Change-Id: If2176f3b26587d4ff6b5c7b06c193ddd1c9cbe86 [TEST] /mb/google/brya/variant/gimble Touchscree reset delay to 200ms
......................................................................
Removed cc Paul Menzel.
--
To view, visit https://review.coreboot.org/c/coreboot/+/60749
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f1b4ccf94233193c1f9c2dd82fd27a020a62186
Gerrit-Change-Number: 60749
Gerrit-PatchSet: 1
Gerrit-Owner: vagdevi.p(a)intel.com
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: deleteReviewer