coreboot-gerrit January 2022

coreboot-gerrit@coreboot.org

1 participants
6716 discussions

Change in coreboot[master]: mb/google/brya: Enable CNVi DDR RFIM for base board brya
by Tim Wawrzynczak (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Paul Menzel, Ronak Kanabar. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60740 ) Change subject: mb/google/brya: Enable CNVi DDR RFIM for base board brya ...................................................................... Patch Set 4: Code-Review-1 (1 comment) Patchset: PS4: My understanding is we are letting each OEM decide if they want this feature enabled or not, and typically only those with LP5 / DDR5 -- To view, visit https://review.coreboot.org/c/coreboot/+/60740 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6ad826d0039e400f219c2d407c51762c1751a909 Gerrit-Change-Number: 60740 Gerrit-PatchSet: 4 Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Comment-Date: Tue, 04 Jan 2022 19:37:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/ifdtool: Add support for Denverton platforms
by Name of user not set (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Stefan Reinauer. Hello build bot (Jenkins), Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60737 to look at the new patch set (#3). Change subject: util/ifdtool: Add support for Denverton platforms ...................................................................... util/ifdtool: Add support for Denverton platforms TEST='ifdtool -p dnv -d coreboot.pre' and verify correct output Signed-off-by: Jeff Daly <jeffd(a)silicom-usa.com> Change-Id: Ie85b071201fb3f88e2c780cfb8d6a52629aa0ced --- M util/ifdtool/ifdtool.c M util/ifdtool/ifdtool.h 2 files changed, 34 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/60737/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/60737 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie85b071201fb3f88e2c780cfb8d6a52629aa0ced Gerrit-Change-Number: 60737 Gerrit-PatchSet: 3 Gerrit-Owner: Name of user not set #1004065 Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: src/drivers/wifi/generic/smbios.c: Remove unused <string.h>
by HAOUAS Elyes (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Patrick Rudolph, Felix Held. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60552 ) Change subject: src/drivers/wifi/generic/smbios.c: Remove unused <string.h> ...................................................................... Patch Set 8: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60552/comment/d384a5a0_a5d270fc PS6, Line 10: snprintf > hum, something went to wrong ? Ack Patchset: PS8: Thx File src/drivers/i2c/sx9310/sx9310.c: https://review.coreboot.org/c/coreboot/+/60552/comment/542f0ae0_b894165f PS6, Line 107: snprintf > string.h includes stdio. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/60552 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2a6c5b67af1d2544159e92d4b8c06cc1f5504bd2 Gerrit-Change-Number: 60552 Gerrit-PatchSet: 8 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 04 Jan 2022 19:33:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes <ehaouas(a)noos.fr> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Add console deinit API, use in SMM handler
by Stefan Reinauer (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Nico Huber, Johnny Lin, Paul Menzel, Rocky Phagura, Christian Walter, Angel Pons, Arthur Heymans, Kyösti Mälkki, Peter Tsung Ho Wu, Deomid "rojer" Ryabkov, Ron Minnich. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56386 ) Change subject: Add console deinit API, use in SMM handler ...................................................................... Patch Set 11: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/56386/comment/2961ac09_88398c54 PS11, Line 14: on an OCP Delta Lake server: uart8250_init disables interrupts because it > Patrick - just to provide some more context... […] I agree cleaning up after the uart output is useful for debugging the SMM handlers. our uart init functions have not been written with the OS in mind. The question I have is: Is it worth adding this to the framework as is here, or is it enough to handle this in the two 8250 drivers. Not sure how useful this will ever be with some of the more "serious" UART drivers like speakermodem and ne2000 console ;) File src/drivers/uart/sifive.c: https://review.coreboot.org/c/coreboot/+/56386/comment/bbe3015c_01219138 PS11, Line 58: /* TODO */ If this is for SMM, do we really need an implementation for the sifive UART? File src/drivers/uart/uart8250io.c: https://review.coreboot.org/c/coreboot/+/56386/comment/c1fa3365_0d2477ca PS11, Line 58: static struct uart8250_state s_uart8250_state; Can this be implemented without a static global variable? https://review.coreboot.org/c/coreboot/+/56386/comment/1cb7032a_4ab23212 PS11, Line 62: /* Save previous state for restoring later. */ : s_uart8250_state.IER = inb(base_port + UART8250_IER); : s_uart8250_state.FCR = inb(base_port + UART8250_FCR); : s_uart8250_state.MCR = inb(base_port + UART8250_MCR); : s_uart8250_state.LCR = inb(base_port + UART8250_LCR); : s_uart8250_state.DLL = inb(base_port + UART8250_DLL); : s_uart8250_state.DLM = inb(base_port + UART8250_DLM); : If this is only needed by SMM, could we move this into a separate function that is called before uart8250_init in SMM? No need to redo this for bootblock, romstage and ramstage. File src/drivers/uart/uart8250mem.c: https://review.coreboot.org/c/coreboot/+/56386/comment/8bb2f251_f2c8677c PS11, Line 83: : static struct uart8250_state s_uart8250_state; : : static void uart8250_mem_init(void *base, unsigned int divisor) : { : /* Save previous state for restoring later. */ : s_uart8250_state.IER = uart8250_read(base, UART8250_IER); : s_uart8250_state.FCR = uart8250_read(base, UART8250_FCR); : s_uart8250_state.MCR = uart8250_read(base, UART8250_MCR); : s_uart8250_state.LCR = uart8250_read(base, UART8250_LCR); : s_uart8250_state.DLL = uart8250_read(base, UART8250_DLL); : s_uart8250_state.DLM = uart8250_read(base, UART8250_DLM); : see non-memory-mapped comments. -- To view, visit https://review.coreboot.org/c/coreboot/+/56386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia5e51f385f83cb998c244ca1d1ffc10339d3a714 Gerrit-Change-Number: 56386 Gerrit-PatchSet: 11 Gerrit-Owner: Deomid "rojer" Ryabkov <rojer9(a)fb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Peter Tsung Ho Wu <tsung(a)amazon.com> Gerrit-Reviewer: Rocky Phagura Gerrit-Reviewer: Rocky Phagura <rphagura(a)fb.com> Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rocky Phagura <rphagura(a)fb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Rocky Phagura Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Peter Tsung Ho Wu <tsung(a)amazon.com> Gerrit-Attention: Deomid "rojer" Ryabkov <rojer9(a)fb.com> Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Tue, 04 Jan 2022 19:32:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi <patrick(a)coreboot.org> Comment-In-Reply-To: Johnny Lin <Johnny_Lin(a)wiwynn.com> Comment-In-Reply-To: Rocky Phagura Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/superio/smsc: Remove unused <stdlib.h>
by HAOUAS Elyes (Code Review) 04 Jan '22

04 Jan '22

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60616 ) Change subject: src/superio/smsc: Remove unused <stdlib.h> ...................................................................... Patch Set 3: (1 comment) File src/superio/smsc/sch5545/superio.c: https://review.coreboot.org/c/coreboot/+/60616/comment/a35a835e_ef70ebe1 PS3, Line 9: #include <stdlib.h> > ok, types.h should be added as include then. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/60616 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icb747bcb702a81750a927272432666ffe603ca55 Gerrit-Change-Number: 60616 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 04 Jan 2022 19:32:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Comment-In-Reply-To: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/ifdtool: Add support for Denverton platforms
by Name of user not set (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Name of user not set #1004065, Stefan Reinauer. Hello build bot (Jenkins), Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60737 to look at the new patch set (#2). Change subject: util/ifdtool: Add support for Denverton platforms ...................................................................... util/ifdtool: Add support for Denverton platforms TEST='ifdtool -p dnv -d coreboot.pre' and verify correct output Signed-off-by: Jeff Daly <jeffd(a)silicom-usa.com> Change-Id: Ie85b071201fb3f88e2c780cfb8d6a52629aa0ced --- M util/ifdtool/ifdtool.c M util/ifdtool/ifdtool.h 2 files changed, 30 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/60737/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60737 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie85b071201fb3f88e2c780cfb8d6a52629aa0ced Gerrit-Change-Number: 60737 Gerrit-PatchSet: 2 Gerrit-Owner: Name of user not set #1004065 Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Name of user not set #1004065 Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: libpayload: Remove shell for loops in install Makefile target
by Patrick Georgi (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Felix Singer, Jakub Czapiga. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59980 ) Change subject: libpayload: Remove shell for loops in install Makefile target ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/59980/comment/0023a568_45ac3353 PS1, Line 10: and > are Done https://review.coreboot.org/c/coreboot/+/59980/comment/4bd1e746_3eadbc98 PS1, Line 11: directories > director_y_ Done -- To view, visit https://review.coreboot.org/c/coreboot/+/59980 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9f9dddfe3f3ceceb6a0510d6dd862351e4b10210 Gerrit-Change-Number: 59980 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Comment-Date: Tue, 04 Jan 2022 19:26:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload: Remove shell for loops in install Makefile target
by Patrick Georgi (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Jakub Czapiga. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59980 to look at the new patch set (#3). Change subject: libpayload: Remove shell for loops in install Makefile target ...................................................................... libpayload: Remove shell for loops in install Makefile target They always require special care so that line breaks and variable names are escaped properly. One loop can be removed entirely because install accepts multiple files to install in a target directory, the other loops were filled by find which can just call the commands on its own. Change-Id: I9f9dddfe3f3ceceb6a0510d6dd862351e4b10210 Signed-off-by: Patrick Georgi <patrick(a)coreboot.org> --- M payloads/libpayload/Makefile.inc 1 file changed, 5 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/59980/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/59980 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9f9dddfe3f3ceceb6a0510d6dd862351e4b10210 Gerrit-Change-Number: 59980 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: libpayload: Remove shell for loops in install Makefile target
by Patrick Georgi (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Jakub Czapiga. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59980 ) Change subject: libpayload: Remove shell for loops in install Makefile target ...................................................................... Patch Set 2: (5 comments) File payloads/libpayload/Makefile.inc: https://review.coreboot.org/c/coreboot/+/59980/comment/4a2b8428_1ff4389a PS1, Line 107: \ > I think, you forgot to remove semicolon and backslash Done https://review.coreboot.org/c/coreboot/+/59980/comment/6ee129aa_fb30e12f PS1, Line 107: install -m 644 $(library-targets) $(DESTDIR)/libpayload/lib/; > I think, it would be safer to change it to: […] Done https://review.coreboot.org/c/coreboot/+/59980/comment/a6720053_7d7aa1e2 PS1, Line 114: find include -type f -exec install -m644 {} $(DESTDIR)/libpayload/{} \; > I think there should be '*.h' wildcard filter. Otherwise it might install unnecessary files. Only if we add such files at some point. Either we have these files during the libpayload build and we install them, or we shouldn't have them at all. https://review.coreboot.org/c/coreboot/+/59980/comment/9cd256f2_704a284f PS1, Line 115: cd $(coreboottop)/src/commonlib/bsd && find include -type d -exec install -m755 -d $(DESTDIR)/libpayload/{} \; > Wont it create directories even if no files will be copied to them later? These have to be created by the build system as git doesn't support empty directories. If we create directories during the libpayload build shouldn't we install them? https://review.coreboot.org/c/coreboot/+/59980/comment/318a593a_e8b47507 PS1, Line 116: cd $(coreboottop)/src/commonlib/bsd && find include -type f -exec install -m644 {} $(DESTDIR)/libpayload/{} \; > Same as above Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/59980 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9f9dddfe3f3ceceb6a0510d6dd862351e4b10210 Gerrit-Change-Number: 59980 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Comment-Date: Tue, 04 Jan 2022 19:25:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload: Remove shell for loops in install Makefile target
by Patrick Georgi (Code Review) 04 Jan '22

04 Jan '22

Attention is currently required from: Patrick Georgi. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59980 to look at the new patch set (#2). Change subject: libpayload: Remove shell for loops in install Makefile target ...................................................................... libpayload: Remove shell for loops in install Makefile target They always require special care so that line breaks and variable names and escaped properly. One loop can be removed entirely because install accepts multiple files to install in a target directories, the other loops were filled by find which can just call the commands on its own. Change-Id: I9f9dddfe3f3ceceb6a0510d6dd862351e4b10210 Signed-off-by: Patrick Georgi <patrick(a)coreboot.org> --- M payloads/libpayload/Makefile.inc 1 file changed, 5 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/59980/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59980 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9f9dddfe3f3ceceb6a0510d6dd862351e4b10210 Gerrit-Change-Number: 59980 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2022