Attention is currently required from: Subrata Banik, Reka Norman, Rizwan Qureshi, Tim Wawrzynczak, Krishna P Bhat D, Patrick Rudolph.
Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61106 )
Change subject: soc/intel/alderlake: Add GPP_I GPIO group for Alder Lake N SOC
......................................................................
Patch Set 9: Code-Review+1
(1 comment)
File src/soc/intel/alderlake/include/soc/gpio.h:
https://review.coreboot.org/c/coreboot/+/61106/comment/f29650b0_768ef494
PS9, Line 9: #if CONFIG(SOC_INTEL_ALDERLAKE_PCH_N)
This is already added in CB:61172
--
To view, visit https://review.coreboot.org/c/coreboot/+/61106
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia71a399c03cb7d098a381bd9439d448e8a620761
Gerrit-Change-Number: 61106
Gerrit-PatchSet: 9
Gerrit-Owner: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Usha P <usha.p(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Thu, 27 Jan 2022 01:14:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Reka Norman, Nick Vaccaro.
Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61384 )
Change subject: drivers/wifi/generic: Add support for UntrustedDevice ACPI property
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
> +Kangheui and Reka, nissa will probably need this too
Thanks for looping in!
--
To view, visit https://review.coreboot.org/c/coreboot/+/61384
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1a02ca7c5f717097ec97cf6373b9e0b81a13e05d
Gerrit-Change-Number: 61384
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Thu, 27 Jan 2022 01:10:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Frank Wu, Isaac Lee.
Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60191 )
Change subject: mb/google/zork/var/vilboz: Add new memory K4AAG165WB-BCWE
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/60191
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e409a5a5a3b3d1b0013d2c020eeb4c0aeec51ba
Gerrit-Change-Number: 60191
Gerrit-PatchSet: 3
Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Isaac Lee <isaaclee(a)google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: Isaac Lee <isaaclee(a)google.com>
Gerrit-Comment-Date: Thu, 27 Jan 2022 00:59:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Felix Held has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/61350 )
Change subject: [RFC] commonlib/cb_err.h: add CB_NEED_REBOOT to cb_err enum
......................................................................
Abandoned
Ritul solved the issue in CB:60968 like Angel suggested, so there's no need to add a CB_NEEDS_REBOOT value to the cb_err enum
--
To view, visit https://review.coreboot.org/c/coreboot/+/61350
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I25a828264171e184b07b790cfaa9b3045bbf3d95
Gerrit-Change-Number: 61350
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: abandon
Attention is currently required from: Wonkyu Kim, Subrata Banik, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, Patrick Rudolph, EricR Lai.
John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61283 )
Change subject: soc/intel/common: Add the Primary to Sideband bridge library
......................................................................
Patch Set 5:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61283/comment/5e625681_42a12855
PS3, Line 10: p2sb2
> Since there are concerns to use either the ambiguous p2sb2 or another term for 2nd p2sb, I am droppi […]
Done
Patchset:
PS3:
> > It might be valid to add P2SB_32_BIT_BAR to all platforms and update like "if ((dev == PCH_DEV_P2S […]
Done
File src/soc/intel/common/block/include/intelblocks/p2sb.h:
https://review.coreboot.org/c/coreboot/+/61283/comment/afc8050f_870055ac
PS5, Line 46:
> Remove blank line
Done
File src/soc/intel/common/block/p2sb/p2sb2.c:
https://review.coreboot.org/c/coreboot/+/61283/comment/90218b2b_6fdcfbf1
PS3, Line 36: val = pci_read_config8(PCI_DEV_P2SB2, p2sb2_reg);
> Here is the update by adding the p2sblib. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/61283
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I63f58584e8c3bfe42cdd81912e1e5140337c2d55
Gerrit-Change-Number: 61283
Gerrit-PatchSet: 5
Gerrit-Owner: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Wonkyu Kim
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Wonkyu Kim
Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 26 Jan 2022 23:54:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Wonkyu Kim <wonkyu.kim(a)intel.com>
Comment-In-Reply-To: John Zhao <john.zhao(a)intel.com>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak.
Daisuke Nojiri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61383 )
Change subject: mb/google/brya/var/redrix: Enable MKBP wake
......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/google/brya/variants/redrix/include/variant/ec.h:
https://review.coreboot.org/c/coreboot/+/61383/comment/90feeef7_c4862b7b
PS2, Line 14: EC_HOST_EVENT_USB_MUX
> We should ensure that all brya devices have the same policies on wake (modulo exceptions like PCHG). […]
Done
https://review.coreboot.org/c/coreboot/+/61383/comment/9a7fe8b5_94556a32
PS2, Line 21: EC_HOST_EVENT_MKBP
> nit: this is redundant, it's already contained in `MAINBOARD_EC_S3_WAKE_EVENTS`
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/61383
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie4536b2c0ccc37f92dfa940c5a5712340a32c82c
Gerrit-Change-Number: 61383
Gerrit-PatchSet: 3
Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Wed, 26 Jan 2022 23:30:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Daisuke Nojiri.
Hello build bot (Jenkins), Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61383
to look at the new patch set (#3).
Change subject: mb/google/brya/var/redrix: Enable MKBP wake
......................................................................
mb/google/brya/var/redrix: Enable MKBP wake
To timely update stylus charging status (b:206012072), PCHG device
events have been moved to MKBP. This patch registers the MKPB host
event as a wake-up signal to match the change.
EC filters other EC_MKBP_EVENT_* events (chromium:3413180).
BUG=b:205675485,b:206012072
Cq-Depend: chromium:3413180
Signed-off-by: Daisuke Nojiri <dnojiri(a)chromium.org>
Change-Id: Ie4536b2c0ccc37f92dfa940c5a5712340a32c82c
---
M src/mainboard/google/brya/variants/redrix/include/variant/ec.h
1 file changed, 8 insertions(+), 30 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/61383/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/61383
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie4536b2c0ccc37f92dfa940c5a5712340a32c82c
Gerrit-Change-Number: 61383
Gerrit-PatchSet: 3
Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Daisuke Nojiri <dnojiri(a)chromium.org>
Gerrit-MessageType: newpatchset