coreboot-gerrit January 2022

coreboot-gerrit@coreboot.org

1 participants
6716 discussions

Change in coreboot[master]: soc/amd/cezanne: Add the fw SPL to fw.cfg
by Rob Barnes (Code Review) 28 Jan '22

28 Jan '22

Attention is currently required from: Bao Zheng, Raul Rangel, Marshall Dawson, Zheng Bao, Felix Held. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61425 ) Change subject: soc/amd/cezanne: Add the fw SPL to fw.cfg ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/61425 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0aa456b8b4eec506fbb319293f0903b293325cb0 Gerrit-Change-Number: 61425 Gerrit-PatchSet: 2 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 28 Jan 2022 14:24:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: amdfwtool: Add SPL support
by Rob Barnes (Code Review) 28 Jan '22

28 Jan '22

Attention is currently required from: Bao Zheng, Zheng Bao. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61426 ) Change subject: amdfwtool: Add SPL support ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/61426 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4665f2372ccd599ab835c8784da08cde5558a795 Gerrit-Change-Number: 61426 Gerrit-PatchSet: 3 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Zheng Bao Gerrit-Comment-Date: Fri, 28 Jan 2022 14:24:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/i2c/cs35l53: Add driver for generating device in SSDT
by Vitaly Rodionov (Code Review) 28 Jan '22

28 Jan '22

Vitaly Rodionov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61448 ) Change subject: drivers/i2c/cs35l53: Add driver for generating device in SSDT ...................................................................... Patch Set 2: (4 comments) File src/drivers/i2c/cs35l53/cs35l53.c: https://review.coreboot.org/c/coreboot/+/61448/comment/e6761345_b9cb2d3a PS1, Line 69: if ((config->boost_peak_milliamp > 4500) || > that open brace { should be on the previous line Fixed https://review.coreboot.org/c/coreboot/+/61448/comment/591fad61_b815eeda PS1, Line 82: acpi_dp_add_integer(dsd, "cirrus,gpio1-polarity-invert", config->gpio1_polarity_invert ? 1 : 0); > line over 96 characters Fixed https://review.coreboot.org/c/coreboot/+/61448/comment/60c9f248_dcdd0a76 PS1, Line 83: acpi_dp_add_integer(dsd, "cirrus,gpio1-output-enable", config->gpio1_output_enable ? 1 : 0); > line over 96 characters Fixed https://review.coreboot.org/c/coreboot/+/61448/comment/d09cd448_107be6fa PS1, Line 86: acpi_dp_add_integer(dsd, "cirrus,gpio2-output-enable", config->gpio2_output_enable ? 1 : 0); > line over 96 characters Fixed -- To view, visit https://review.coreboot.org/c/coreboot/+/61448 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2cbb1cef89f8d56ee73fab06c68933a2ab8c3606 Gerrit-Change-Number: 61448 Gerrit-PatchSet: 2 Gerrit-Owner: Vitaly Rodionov <vitaly.rodionov(a)cirrus.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 28 Jan 2022 13:34:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/i2c/cs35l53: Add driver for generating device in SSDT
by Vitaly Rodionov (Code Review) 28 Jan '22

28 Jan '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/61448 to look at the new patch set (#2). Change subject: drivers/i2c/cs35l53: Add driver for generating device in SSDT ...................................................................... drivers/i2c/cs35l53: Add driver for generating device in SSDT This driver uses the ACPI Device Property interface to generate the required parameters into the _DSD table format expected by the kernel. Change-Id: I2cbb1cef89f8d56ee73fab06c68933a2ab8c3606 Signed-off-by: Stefan Binding <sbinding(a)opensource.cirrus.com> Signed-off-by: Vitaly Rodionov <vitaly.rodionov(a)cirrus.corp-partner.google.com> --- A src/drivers/i2c/cs35l53/Kconfig A src/drivers/i2c/cs35l53/Makefile.inc A src/drivers/i2c/cs35l53/chip.h A src/drivers/i2c/cs35l53/cs35l53.c 4 files changed, 265 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/61448/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/61448 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2cbb1cef89f8d56ee73fab06c68933a2ab8c3606 Gerrit-Change-Number: 61448 Gerrit-PatchSet: 2 Gerrit-Owner: Vitaly Rodionov <vitaly.rodionov(a)cirrus.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya/var/taeko: Add new FW_CONFIG option for DB_USB
by Rasheed Hsueh (Code Review) 28 Jan '22

28 Jan '22

Attention is currently required from: YH Lin, Tim Wawrzynczak, Nick Vaccaro. Rasheed Hsueh has uploaded a new patch set (#3) to the change originally created by Joey Peng. ( https://review.coreboot.org/c/coreboot/+/61412 ) Change subject: mb/google/brya/var/taeko: Add new FW_CONFIG option for DB_USB ...................................................................... mb/google/brya/var/taeko: Add new FW_CONFIG option for DB_USB Enable USB Port A on DB for Taeko BUG=b:216533764 TEST=emerge-brya coreboot Signed-off-by: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Change-Id: I1a43c256757f3fc4b53ba1f794587d6a00ba0aa5 --- M src/mainboard/google/brya/variants/taeko/overridetree.cb 1 file changed, 22 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/61412/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/61412 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1a43c256757f3fc4b53ba1f794587d6a00ba0aa5 Gerrit-Change-Number: 61412 Gerrit-PatchSet: 3 Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com> Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com> Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in gerrit-avatars[master]: Add avatar
by Vitaly Rodionov (Code Review) 28 Jan '22

28 Jan '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/gerrit-avatars/+/61449 to look at the new patch set (#4). Change subject: Add avatar ...................................................................... Add avatar Signed-off-by: Vitaly Rodionov <vitaly.rodionov(a)cirrus.corp-partner.google.com> Change-Id: I27108afef70431e0e84d05f997ef3144af5c5930 --- A 1003479.jpg 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/gerrit-avatars refs/changes/49/61449/4 -- To view, visit https://review.coreboot.org/c/gerrit-avatars/+/61449 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: gerrit-avatars Gerrit-Branch: master Gerrit-Change-Id: I27108afef70431e0e84d05f997ef3144af5c5930 Gerrit-Change-Number: 61449 Gerrit-PatchSet: 4 Gerrit-Owner: Vitaly Rodionov <vitaly.rodionov(a)cirrus.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in gerrit-avatars[master]: Signed-off-by: Vitaly Rodionov <vitaly.rodionov@cirrus.corp-partner.g...
by Vitaly Rodionov (Code Review) 28 Jan '22

28 Jan '22

Vitaly Rodionov has uploaded a new patch set (#3). ( https://review.coreboot.org/c/gerrit-avatars/+/61449 ) Change subject: Signed-off-by: Vitaly Rodionov <vitaly.rodionov(a)cirrus.corp-partner.google.com> Change-Id: I27108afef70431e0e84d05f997ef3144af5c5930 ...................................................................... Signed-off-by: Vitaly Rodionov <vitaly.rodionov(a)cirrus.corp-partner.google.com> Change-Id: I27108afef70431e0e84d05f997ef3144af5c5930 --- A 1003479.jpg 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/gerrit-avatars refs/changes/49/61449/3 -- To view, visit https://review.coreboot.org/c/gerrit-avatars/+/61449 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: gerrit-avatars Gerrit-Branch: master Gerrit-Change-Id: I27108afef70431e0e84d05f997ef3144af5c5930 Gerrit-Change-Number: 61449 Gerrit-PatchSet: 3 Gerrit-Owner: Vitaly Rodionov <vitaly.rodionov(a)cirrus.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in gerrit-avatars[master]: Add avatar
by Vitaly Rodionov (Code Review) 28 Jan '22

28 Jan '22

Vitaly Rodionov has uploaded a new patch set (#2). ( https://review.coreboot.org/c/gerrit-avatars/+/61449 ) Change subject: Add avatar ...................................................................... Add avatar Signed-off-by: Vitaly Rodionov <vitaly.rodionov(a)cirrus.corp-partner.google.com> Change-Id: I27108afef70431e0e84d05f997ef3144af5c5930 --- A 1003479.jpg A 1003479.png 2 files changed, 0 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/gerrit-avatars refs/changes/49/61449/2 -- To view, visit https://review.coreboot.org/c/gerrit-avatars/+/61449 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: gerrit-avatars Gerrit-Branch: master Gerrit-Change-Id: I27108afef70431e0e84d05f997ef3144af5c5930 Gerrit-Change-Number: 61449 Gerrit-PatchSet: 2 Gerrit-Owner: Vitaly Rodionov <vitaly.rodionov(a)cirrus.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in gerrit-avatars[master]: Add avatar
by Vitaly Rodionov (Code Review) 28 Jan '22

28 Jan '22

Vitaly Rodionov has uploaded this change for review. ( https://review.coreboot.org/c/gerrit-avatars/+/61449 ) Change subject: Add avatar ...................................................................... Add avatar Signed-off-by: Vitaly Rodionov <vitaly.rodionov(a)cirrus.corp-partner.google.com> Change-Id: I27108afef70431e0e84d05f997ef3144af5c5930 --- A 1003479.png 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/gerrit-avatars refs/changes/49/61449/1 diff --git a/1003479.png b/1003479.png new file mode 100644 index 0000000..3cfdfea --- /dev/null +++ b/1003479.png Binary files differ -- To view, visit https://review.coreboot.org/c/gerrit-avatars/+/61449 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: gerrit-avatars Gerrit-Branch: master Gerrit-Change-Id: I27108afef70431e0e84d05f997ef3144af5c5930 Gerrit-Change-Number: 61449 Gerrit-PatchSet: 1 Gerrit-Owner: Vitaly Rodionov <vitaly.rodionov(a)cirrus.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: drivers/i2c/cs35l53: Add driver for generating device in SSDT
by build bot (Jenkins) (Code Review) 28 Jan '22

28 Jan '22

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61448 ) Change subject: drivers/i2c/cs35l53: Add driver for generating device in SSDT ...................................................................... Patch Set 1: (5 comments) File src/drivers/i2c/cs35l53/cs35l53.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139358): https://review.coreboot.org/c/coreboot/+/61448/comment/419ac2f6_0014aa22 PS1, Line 69: if ((config->boost_peak_milliamp > 4500) || that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139358): https://review.coreboot.org/c/coreboot/+/61448/comment/4fc3e96a_790e561b PS1, Line 82: acpi_dp_add_integer(dsd, "cirrus,gpio1-polarity-invert", config->gpio1_polarity_invert ? 1 : 0); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139358): https://review.coreboot.org/c/coreboot/+/61448/comment/a508b4b3_e08c74dc PS1, Line 83: acpi_dp_add_integer(dsd, "cirrus,gpio1-output-enable", config->gpio1_output_enable ? 1 : 0); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139358): https://review.coreboot.org/c/coreboot/+/61448/comment/d08ae80f_8edeea08 PS1, Line 85: acpi_dp_add_integer(dsd, "cirrus,gpio2-polarity-invert", config->gpio2_polarity_invert ? 1 : 0); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139358): https://review.coreboot.org/c/coreboot/+/61448/comment/44db72c5_acb76c6b PS1, Line 86: acpi_dp_add_integer(dsd, "cirrus,gpio2-output-enable", config->gpio2_output_enable ? 1 : 0); line over 96 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/61448 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2cbb1cef89f8d56ee73fab06c68933a2ab8c3606 Gerrit-Change-Number: 61448 Gerrit-PatchSet: 1 Gerrit-Owner: Vitaly Rodionov <vitaly.rodionov(a)cirrus.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 28 Jan 2022 11:37:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2022