coreboot-gerrit September 2021

coreboot-gerrit@coreboot.org

1 participants
6530 discussions

Change in coreboot[master]: mb/google/kukui: add separated memory mapping table
by Kevin Chiu (Code Review) 07 Sep '21

07 Sep '21

Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/57442 ) Change subject: mb/google/kukui: add separated memory mapping table ...................................................................... mb/google/kukui: add separated memory mapping table set the dedicated memory mappaing table index: 0x40 SAMSUNG 4GB LP4X K4UBE3D4AA-MGCR 0x41 HYNIX 4GB QDP LP4X H9HCNNNCPMALHR-NEE 0x42 MICRON 4GB LP4X MT53E1G32D4NQ-046 WT:E 0x43 MICRON 4GB LP4X MT53E1G32D2NP-046 WT:A 0x48 SAMSUNG 4GB LP4X K4UBE3D4AA-MGCL 0x49 MICRON 8GB LP4X MT53E2G32D4NQ-046 WT:A 0x4A HYNIX 4GB QDP LP4X H9HCNNNCPMMLXR-NEE 0x4B Micron MT29VZZZAD9GQFSM BUG=b:162379736 BRANCH=kukui TEST=emerge-jacuzzi coreboot Signed-off-by: Kevin Chiu <kevin.chiu(a)quantatw.com> Change-Id: I97f296cb8c35fd2f979a05d0b97a0562c1b472f3 --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/sdram_configs.c 2 files changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/57442/1 diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index 4c44c56..a1614ed 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -92,6 +92,7 @@ default 0x10 if BOARD_GOOGLE_BURNET || BOARD_GOOGLE_ESCHE || BOARD_GOOGLE_FENNEL || BOARD_GOOGLE_CERISE || BOARD_GOOGLE_STERN || BOARD_GOOGLE_MAKOMO || BOARD_GOOGLE_MUNNA default 0x20 if BOARD_GOOGLE_KAKADU || BOARD_GOOGLE_KATSU default 0x30 if BOARD_GOOGLE_COZMO || BOARD_GOOGLE_PICO + default 0x40 if BOARD_GOOGLE_KAPPA default 0x0 config BOARD_OVERRIDE_LCM_ID diff --git a/src/mainboard/google/kukui/sdram_configs.c b/src/mainboard/google/kukui/sdram_configs.c index 040810e..50b90c5 100644 --- a/src/mainboard/google/kukui/sdram_configs.c +++ b/src/mainboard/google/kukui/sdram_configs.c @@ -55,6 +55,16 @@ [0x39] = "sdram-lpddr4x-MT53E2G32D4NQ-046-8GB", [0x3a] = "sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB", [0x3b] = "sdram-lpddr4x-H9HCNNNFAMMLXR-NEE-8GB", + + /* Table shared by Kappa, offset = 0x40 */ + [0x40] = "sdram-lpddr4x-K4UBE3D4AA-MGCR-4GB", + [0x41] = "sdram-lpddr4x-H9HCNNNCPMALHR-4GB", + [0x42] = "sdram-lpddr4x-MT53E1G32D4NQ-4GB", + [0x43] = "sdram-lpddr4x-MT53E1G32D2NP-046-4GB", + [0x48] = "sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB", + [0x49] = "sdram-lpddr4x-MT53E2G32D4NQ-046-8GB", + [0x4a] = "sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB", + [0x4b] = "sdram-lpddr4x-MT29VZZZAD9GQFSM-046-4GB", }; static struct sdram_params params; -- To view, visit https://review.coreboot.org/c/coreboot/+/57442 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I97f296cb8c35fd2f979a05d0b97a0562c1b472f3 Gerrit-Change-Number: 57442 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/zork/var/vilboz: update device generic id for 10EC1015 AMP ...
by EricR Lai (Code Review) 07 Sep '21

07 Sep '21

Attention is currently required from: Frank Wu, Martin Roth, Kangheui Won, Isaac Lee. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57286 ) Change subject: mb/google/zork/var/vilboz: update device generic id for 10EC1015 AMP driver ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/57286 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I09c9adc2db08e8e3905d9ba800948252230e4d54 Gerrit-Change-Number: 57286 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Isaac Lee <isaaclee(a)google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com> Gerrit-CC: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Isaac Lee <isaaclee(a)google.com> Gerrit-Comment-Date: Tue, 07 Sep 2021 09:00:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/beetley: Generate SPD ID for supported memory parts
by Zhi7 Li (Code Review) 07 Sep '21

07 Sep '21

Zhi7 Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/57441 ) Change subject: mb/google/dedede/var/beetley: Generate SPD ID for supported memory parts ...................................................................... mb/google/dedede/var/beetley: Generate SPD ID for supported memory parts Add supported memory 'MT53E512M32D1NP-046 WT:B' for beetley BUG=None TEST=Build the beetley board. Signed-off-by: Zhi Li <lizhi7(a)huaqin.corp-partner.google.com> Change-Id: I5f4e3a0070c00859847d16900949aaad9c471c01 --- M src/mainboard/google/dedede/variants/beetley/memory/Makefile.inc M src/mainboard/google/dedede/variants/beetley/memory/dram_id.generated.txt M src/mainboard/google/dedede/variants/beetley/memory/mem_parts_used.txt 3 files changed, 4 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/57441/1 diff --git a/src/mainboard/google/dedede/variants/beetley/memory/Makefile.inc b/src/mainboard/google/dedede/variants/beetley/memory/Makefile.inc index b0ca222..eab93ac 100644 --- a/src/mainboard/google/dedede/variants/beetley/memory/Makefile.inc +++ b/src/mainboard/google/dedede/variants/beetley/memory/Makefile.inc @@ -1,5 +1,5 @@ ## SPDX-License-Identifier: GPL-2.0-or-later ## This is an auto-generated file. Do not edit!! -## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate. -SPD_SOURCES = placeholder.spd.hex +SPD_SOURCES = +SPD_SOURCES += lp4x-spd-1.hex # ID = 0(0b0000) Parts = MT53E512M32D1NP-046 WT:B diff --git a/src/mainboard/google/dedede/variants/beetley/memory/dram_id.generated.txt b/src/mainboard/google/dedede/variants/beetley/memory/dram_id.generated.txt index fa24790..0e6d3e6 100644 --- a/src/mainboard/google/dedede/variants/beetley/memory/dram_id.generated.txt +++ b/src/mainboard/google/dedede/variants/beetley/memory/dram_id.generated.txt @@ -1 +1,2 @@ DRAM Part Name ID to assign +MT53E512M32D1NP-046 WT:B 0 (0000) diff --git a/src/mainboard/google/dedede/variants/beetley/memory/mem_parts_used.txt b/src/mainboard/google/dedede/variants/beetley/memory/mem_parts_used.txt index e4258b5..5d306f1 100644 --- a/src/mainboard/google/dedede/variants/beetley/memory/mem_parts_used.txt +++ b/src/mainboard/google/dedede/variants/beetley/memory/mem_parts_used.txt @@ -1,11 +1 @@ -# This is a CSV file containing a list of memory parts used by this variant. -# One part per line with an optional fixed ID in column 2. -# Only include a fixed ID if it is required for legacy reasons! -# Generated IDs are dependent on the order of parts in this file, -# so new parts must always be added at the end of the file! -# -# Generate an updated Makefile.inc and dram_id.generated.txt by running the -# gen_part_id tool from util/spd_tools/{ddr4,lp4x}. -# See util/spd_tools/{ddr4,lp4x}/README.md for more details and instructions. - -# Part Name +MT53E512M32D1NP-046 WT:B -- To view, visit https://review.coreboot.org/c/coreboot/+/57441 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f4e3a0070c00859847d16900949aaad9c471c01 Gerrit-Change-Number: 57441 Gerrit-PatchSet: 1 Gerrit-Owner: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/dedede: Create beetley variant
by Zhi7 Li (Code Review) 07 Sep '21

07 Sep '21

Attention is currently required from: Paul Menzel, Zhi7 Li, Karthik Ramasubramanian. Hello build bot (Jenkins), Weimin Wu, Shou-Chieh Hsu, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/57358 to look at the new patch set (#2). Change subject: mb/google/dedede: Create beetley variant ...................................................................... mb/google/dedede: Create beetley variant Create the beetley variant of the waddledee reference board by copying the template files to a new directory named for the variant. (Auto-Generated by create_coreboot_variant.sh version 4.5.0). BUG=b:198713668 BRANCH=None TEST=util/abuild/abuild -p none -t google/dedede -x -a make sure the build includes GOOGLE_BEETLEY Signed-off-by: Zhi Li <lizhi7(a)huaqin.corp-partner.google.com> Change-Id: I3d52be55270361406a67f91707b71dff5c725f35 --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/Kconfig.name A src/mainboard/google/dedede/variants/beetley/include/variant/ec.h A src/mainboard/google/dedede/variants/beetley/include/variant/gpio.h A src/mainboard/google/dedede/variants/beetley/memory/Makefile.inc A src/mainboard/google/dedede/variants/beetley/memory/dram_id.generated.txt A src/mainboard/google/dedede/variants/beetley/memory/mem_parts_used.txt A src/mainboard/google/dedede/variants/beetley/overridetree.cb 8 files changed, 82 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/57358/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/57358 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3d52be55270361406a67f91707b71dff5c725f35 Gerrit-Change-Number: 57358 Gerrit-PatchSet: 2 Gerrit-Owner: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Krystal Han <hanlijing(a)huaqin.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: drivers/intel/fsp2_0/Kconfig: select HAVE_DISPLAY_MTRRS
by Angel Pons (Code Review) 07 Sep '21

07 Sep '21

Attention is currently required from: Raul Rangel, Martin Roth, Furquan Shaikh, Marshall Dawson, Angel Pons, Andrey Petrov, Patrick Rudolph, Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51575 ) Change subject: drivers/intel/fsp2_0/Kconfig: select HAVE_DISPLAY_MTRRS ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I remember doing patches for this in the past, which got stalled. Ah, I think CB:44230 was one of them. -- To view, visit https://review.coreboot.org/c/coreboot/+/51575 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2894689ce58e7404d9d5a894f3c288bc4016ea19 Gerrit-Change-Number: 51575 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 07 Sep 2021 08:53:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/fsp2_0/Kconfig: select HAVE_DISPLAY_MTRRS
by Nico Huber (Code Review) 07 Sep '21

07 Sep '21

Attention is currently required from: Raul Rangel, Martin Roth, Furquan Shaikh, Marshall Dawson, Angel Pons, Andrey Petrov, Patrick Rudolph, Felix Held. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51575 ) Change subject: drivers/intel/fsp2_0/Kconfig: select HAVE_DISPLAY_MTRRS ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I remember doing patches for this in the past, which got stalled. There are currently three things done by the two Kconfigs: 1. Show the user option only for platforms where display_mtrrs() gets called. 2. Show the user option only for platforms that are known to be supported by display_mtrrs(). 3. Decide if display_mtrrs() is going to do something. The first can be ignored if we can show that it always gets called. Likewise, 2. is not an issue if we can show that it supports all coreboot-supported x86 CPUs. If we decide that the code should just always be active if supported (e.g. at level DEBUG or SPEW), we can merge the two Kconfigs into one. -- To view, visit https://review.coreboot.org/c/coreboot/+/51575 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2894689ce58e7404d9d5a894f3c288bc4016ea19 Gerrit-Change-Number: 51575 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 07 Sep 2021 08:53:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/x86/mp_init: Fix false error message on parking APs twice
by Angel Pons (Code Review) 07 Sep '21

07 Sep '21

Attention is currently required from: Nico Huber, Johnny Lin, Stefan Reinauer, Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55071 ) Change subject: cpu/x86/mp_init: Fix false error message on parking APs twice ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/55071/comment/d309362e_a4a9546c PS2, Line 9: With Intel TXT APs are parked before LockConfig is called. OK, the ACM requires this: > Other threads of the same physical processor [...] must be in wait-for-SIPI state when BSP launches the ACM. File src/cpu/x86/mp_init.c: https://review.coreboot.org/c/coreboot/+/55071/comment/3b8611c4_741002ed PS2, Line 1056: printk(BIOS_DEBUG, "%s: CPUs already parked\n", __func__); > > We know they had been, but what if they aren't anymore? > > What do you mean? There is no code in coreboot to wake APs twice to get them in a ap_wait_for_instruction() state. Maybe this code will appear in the future, or maybe a blob wakes up the APs again. -- To view, visit https://review.coreboot.org/c/coreboot/+/55071 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I60095cffcb9b31d965b0525ddc3018b592a3e52e Gerrit-Change-Number: 55071 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 07 Sep 2021 08:51:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/fsp2_0/Kconfig: select HAVE_DISPLAY_MTRRS
by Arthur Heymans (Code Review) 07 Sep '21

07 Sep '21

Attention is currently required from: Raul Rangel, Martin Roth, Furquan Shaikh, Marshall Dawson, Andrey Petrov, Patrick Rudolph, Felix Held. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51575 ) Change subject: drivers/intel/fsp2_0/Kconfig: select HAVE_DISPLAY_MTRRS ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I guess you can select this as a default somewhere in cpu/x86. All supported x86 CPUs in coreboot now have MTRRs. -- To view, visit https://review.coreboot.org/c/coreboot/+/51575 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2894689ce58e7404d9d5a894f3c288bc4016ea19 Gerrit-Change-Number: 51575 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 07 Sep 2021 08:42:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/x86/mp_init: Fix false error message on parking APs twice
by Arthur Heymans (Code Review) 07 Sep '21

07 Sep '21

Attention is currently required from: Nico Huber, Johnny Lin, Stefan Reinauer. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55071 ) Change subject: cpu/x86/mp_init: Fix false error message on parking APs twice ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: > Why not fix the spurious call instead? So mp_park_aps() is conditionally called in intel_txt_prepare_txt_env(). Guarding the call in arch_bootstate_coreboot_exit() would be more messy and boil down to the same. File src/cpu/x86/mp_init.c: https://review.coreboot.org/c/coreboot/+/55071/comment/dcb6ab66_e196a58e PS2, Line 1056: printk(BIOS_DEBUG, "%s: CPUs already parked\n", __func__); > We know they had been, but what if they aren't anymore? What do you mean? There is no code in coreboot to wake APs twice to get them in a ap_wait_for_instruction() state. -- To view, visit https://review.coreboot.org/c/coreboot/+/55071 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I60095cffcb9b31d965b0525ddc3018b592a3e52e Gerrit-Change-Number: 55071 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Tue, 07 Sep 2021 08:34:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/trogdor: Mipi panel support for mrbland
by zanxi chen (Code Review) 07 Sep '21

07 Sep '21

Attention is currently required from: Julius Werner, Bob Moragues. Hello build bot (Jenkins), Julius Werner, Bob Moragues, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/57336 to look at the new patch set (#8). Change subject: mb/google/trogdor: Mipi panel support for mrbland ...................................................................... mb/google/trogdor: Mipi panel support for mrbland Add mipi panel support for mrbland - setup gpio and modify LCD sequence. - use the following panel for mrbland: AUO B101UAN08.3 BOE TV101WUM-N53 - use panel_id to distinguish which mipi panel to use. BUG=b:195516474,b:197300875,b:197300876 BRANCH=none TEST=emerge-strongbad coreboot Change-Id: Ib7cd2da429b114bf6bad5af312044a0f01319b46 Signed-off-by: Zanxi Chen <chenzanxi(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/trogdor/Kconfig M src/mainboard/google/trogdor/board.h M src/mainboard/google/trogdor/chromeos.c M src/mainboard/google/trogdor/mainboard.c 4 files changed, 54 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/57336/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/57336 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib7cd2da429b114bf6bad5af312044a0f01319b46 Gerrit-Change-Number: 57336 Gerrit-PatchSet: 8 Gerrit-Owner: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Bob Moragues <moragues(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-CC: Wenli Xu <xuwenli(a)huaqin.corp-partner.google.com> Gerrit-CC: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Bob Moragues <moragues(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2021