coreboot-gerrit August 2021

coreboot-gerrit@coreboot.org

1 participants
4520 discussions

Change in coreboot[master]: mb/amd/bilby: Add support for HDMI display
by Aamir Bohra (Code Review) 02 Aug '21

02 Aug '21

Aamir Bohra has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/56756 ) Change subject: mb/amd/bilby: Add support for HDMI display ...................................................................... mb/amd/bilby: Add support for HDMI display DDI 0/1 ports are shared for DP and HDMI. This implementation adds support for HDMI display when HDMI is set as connector type in ddi descriptors. TEST=verify display over HDMI(0 and 1) in OS. Signed-off-by: Aamir Bohra <aamirbohra(a)gmail.com> Change-Id: I9697211c556f12d1fc0d49418b227fbe6b342673 --- M src/mainboard/amd/bilby/Kconfig M src/mainboard/amd/bilby/mainboard.c A src/mainboard/amd/bilby/mainboard.h M src/mainboard/amd/bilby/port_descriptors.c 4 files changed, 64 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/56756/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56756 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9697211c556f12d1fc0d49418b227fbe6b342673 Gerrit-Change-Number: 56756 Gerrit-PatchSet: 2 Gerrit-Owner: Aamir Bohra <aamirbohra(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/amd/bilby: Add support for HDMI display
by build bot (Jenkins) (Code Review) 02 Aug '21

02 Aug '21

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56756 ) Change subject: mb/amd/bilby: Add support for HDMI display ...................................................................... Patch Set 1: (2 comments) File src/mainboard/amd/bilby/mainboard.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125531): https://review.coreboot.org/c/coreboot/+/56756/comment/bdf58ebf_c023eb37 PS1, Line 3: int get_ddi_port_conn_type (uint8_t port_num); space prohibited between function name and open parenthesis '(' File src/mainboard/amd/bilby/port_descriptors.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125531): https://review.coreboot.org/c/coreboot/+/56756/comment/17445134_70843690 PS1, Line 72: int get_ddi_port_conn_type (uint8_t port_num) space prohibited between function name and open parenthesis '(' -- To view, visit https://review.coreboot.org/c/coreboot/+/56756 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9697211c556f12d1fc0d49418b227fbe6b342673 Gerrit-Change-Number: 56756 Gerrit-PatchSet: 1 Gerrit-Owner: Aamir Bohra <aamirbohra(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 02 Aug 2021 10:38:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/amd/bilby: Add support for HDMI display
by Aamir Bohra (Code Review) 02 Aug '21

02 Aug '21

Aamir Bohra has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56756 ) Change subject: mb/amd/bilby: Add support for HDMI display ...................................................................... mb/amd/bilby: Add support for HDMI display DDI 0/1 ports are shared for DP and HDMI. This implementation adds support for HDMI display when HDMI is set as connector type in ddi descriptors. TEST=verify display over HDMI(0 and 1) in OS. Signed-off-by: Aamir Bohra <aamirbohra(a)gmail.com> Change-Id: I9697211c556f12d1fc0d49418b227fbe6b342673 --- M src/mainboard/amd/bilby/Kconfig M src/mainboard/amd/bilby/mainboard.c A src/mainboard/amd/bilby/mainboard.h M src/mainboard/amd/bilby/port_descriptors.c 4 files changed, 64 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/56756/1 diff --git a/src/mainboard/amd/bilby/Kconfig b/src/mainboard/amd/bilby/Kconfig index 9510238..daa6b6e 100644 --- a/src/mainboard/amd/bilby/Kconfig +++ b/src/mainboard/amd/bilby/Kconfig @@ -106,4 +106,36 @@ int default 0 +choice + prompt "DDI-0 connector type" + default CONNECT_DP_ON_DDI_0 + +config CONNECT_HDMI_ON_DDI_0 + bool "Use HDMI interface" + +config CONNECT_DP_ON_DDI_0 + bool "Use Displayport interface" +endchoice + +config DDI0_CONNECTOR_TYPE + int + default 0 if CONNECT_DP_ON_DDI_0 + default 4 if CONNECT_HDMI_ON_DDI_0 + +choice + prompt "DDI-1 connector type" + default CONNECT_DP_ON_DDI_1 + +config CONNECT_HDMI_ON_DDI_1 + bool "Use HDMI interface" + +config CONNECT_DP_ON_DDI_1 + bool "Use Displayport interface" +endchoice + +config DDI1_CONNECTOR_TYPE + int + default 0 if CONNECT_DP_ON_DDI_1 + default 4 if CONNECT_HDMI_ON_DDI_1 + endif # BOARD_AMD_BILBY diff --git a/src/mainboard/amd/bilby/mainboard.c b/src/mainboard/amd/bilby/mainboard.c index 12f801d..4def65b 100644 --- a/src/mainboard/amd/bilby/mainboard.c +++ b/src/mainboard/amd/bilby/mainboard.c @@ -5,13 +5,18 @@ #include <acpi/acpi.h> #include <amdblocks/amd_pci_util.h> #include <FspsUpd.h> +#include <gpio.h> #include <soc/cpu.h> #include <soc/southbridge.h> #include <soc/pci_devs.h> +#include <soc/platform_descriptors.h> #include <types.h> #include <commonlib/helpers.h> #include <chip.h> #include "gpio.h" +#include "mainboard.h" + +#define MAINBOARD_SHARED_DDI_PORTS 2 /* TODO: recheck IRQ tables */ @@ -79,6 +84,20 @@ picr_data_ptr = fch_pic_routing; } +static void program_display_sel_gpios(void) +{ + int idx, port_type; + gpio_t display_sel[MAINBOARD_SHARED_DDI_PORTS] = {GPIO_29, GPIO_31}; + + for (idx = 0; idx < MAINBOARD_SHARED_DDI_PORTS; idx++) { + port_type = get_ddi_port_conn_type(idx); + if (port_type == HDMI) + /* Set low for HDMI, DP(== HIGH) is default reset config */ + gpio_output(display_sel[idx], 0); + } + +} + static void mainboard_init(void *chip_info) { struct soc_amd_picasso_config *cfg = config_of_soc(); @@ -88,6 +107,8 @@ mainboard_program_gpios(); + program_display_sel_gpios(); + /* Re-muxing LPCCLK0 can hang the system if LPC is in use. */ if (CONFIG(BILBY_LPC)) printk(BIOS_INFO, "eMMC not available due to LPC requirement\n"); diff --git a/src/mainboard/amd/bilby/mainboard.h b/src/mainboard/amd/bilby/mainboard.h new file mode 100644 index 0000000..9e4bb9c --- /dev/null +++ b/src/mainboard/amd/bilby/mainboard.h @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +int get_ddi_port_conn_type (uint8_t port_num); diff --git a/src/mainboard/amd/bilby/port_descriptors.c b/src/mainboard/amd/bilby/port_descriptors.c index 2801c73..912d711 100644 --- a/src/mainboard/amd/bilby/port_descriptors.c +++ b/src/mainboard/amd/bilby/port_descriptors.c @@ -2,6 +2,7 @@ #include <soc/platform_descriptors.h> #include <types.h> +#include "mainboard.h" static const fsp_dxio_descriptor pco_dxio_descriptors[] = { { /* MXM - Entry 0 */ @@ -47,12 +48,12 @@ static const fsp_ddi_descriptor pco_ddi_descriptors[] = { { /* DDI0 - DP */ - .connector_type = DP, + .connector_type = CONFIG_DDI0_CONNECTOR_TYPE, .aux_index = AUX1, .hdp_index = HDP1 }, { /* DDI1 - DP */ - .connector_type = DP, + .connector_type = CONFIG_DDI1_CONNECTOR_TYPE, .aux_index = AUX2, .hdp_index = HDP2 }, @@ -68,6 +69,11 @@ } }; +int get_ddi_port_conn_type (uint8_t port_num) +{ + return pco_ddi_descriptors[port_num].connector_type; +} + void mainboard_get_dxio_ddi_descriptors( const fsp_dxio_descriptor **dxio_descs, size_t *dxio_num, const fsp_ddi_descriptor **ddi_descs, size_t *ddi_num) -- To view, visit https://review.coreboot.org/c/coreboot/+/56756 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9697211c556f12d1fc0d49418b227fbe6b342673 Gerrit-Change-Number: 56756 Gerrit-PatchSet: 1 Gerrit-Owner: Aamir Bohra <aamirbohra(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/amd/bilby: Enable DP2 and DP3 enumeration
by Aamir Bohra (Code Review) 02 Aug '21

02 Aug '21

Aamir Bohra has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/56755 ) Change subject: mb/amd/bilby: Enable DP2 and DP3 enumeration ...................................................................... mb/amd/bilby: Enable DP2 and DP3 enumeration DP2 and DP2 is muxed with USBC port. This implementation configures mux for DP functioanlity. TEST=Verify display over DP2 and DP3. Signed-off-by: Aamir Bohra <aamirbohra(a)gmail.com> Change-Id: If0c8dfbb47175789bb27d4506c1e8b45c425c76a --- M src/mainboard/amd/bilby/devicetree.cb 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/56755/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56755 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If0c8dfbb47175789bb27d4506c1e8b45c425c76a Gerrit-Change-Number: 56755 Gerrit-PatchSet: 2 Gerrit-Owner: Aamir Bohra <aamirbohra(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/amd/bilby: Enable DP2 and DP3 enumeration
by Aamir Bohra (Code Review) 02 Aug '21

02 Aug '21

Aamir Bohra has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56755 ) Change subject: mb/amd/bilby: Enable DP2 and DP3 enumeration ...................................................................... mb/amd/bilby: Enable DP2 and DP3 enumeration DP2 and DP2 is muxed with USBC port. This implementation configures mux for DP functioanlity. TEST=Verify display over DP2 and DP3. Signed-off-by: Aamir Bohra <aamirbohra(a)gmail.com> Change-Id: If0c8dfbb47175789bb27d4506c1e8b45c425c76a Reviewed-on: http://gerrit-git.amd.com/c/embedded/ec/coreboot/+/507246 Tested-by: Abhishek Chaudhary <Abhishek.Chaudhary(a)amd.com> Reviewed-by: Ritul Guru <Ritul.Guru(a)amd.com> --- M src/mainboard/amd/bilby/devicetree.cb 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/56755/1 diff --git a/src/mainboard/amd/bilby/devicetree.cb b/src/mainboard/amd/bilby/devicetree.cb index 862d20f..2d55a44 100644 --- a/src/mainboard/amd/bilby/devicetree.cb +++ b/src/mainboard/amd/bilby/devicetree.cb @@ -92,6 +92,15 @@ .tx_res_tune = 0x01, }" + register "usb_pd_config_override[0]" = "{ + .rfmux_override_en = 1, + .rfmux_config = USB_PD_RFMUX_DP_X4_MODE, + }" + register "usb_pd_config_override[1]" = "{ + .rfmux_override_en = 1, + .rfmux_config = USB_PD_RFMUX_DP_X4_MODE, + }" + # USB OC pin mapping; all ports share one OC pin register "usb_port_overcurrent_pin[0]" = "USB_OC_PIN_0" register "usb_port_overcurrent_pin[1]" = "USB_OC_PIN_0" -- To view, visit https://review.coreboot.org/c/coreboot/+/56755 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If0c8dfbb47175789bb27d4506c1e8b45c425c76a Gerrit-Change-Number: 56755 Gerrit-PatchSet: 1 Gerrit-Owner: Aamir Bohra <aamirbohra(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/brya/variants/taeko: Configure GPIOs according to schematics
by Joey Peng (Code Review) 02 Aug '21

02 Aug '21

Attention is currently required from: Paul Menzel. Hello build bot (Jenkins), Tim Wawrzynczak, YH Lin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56754 to look at the new patch set (#7). Change subject: mb/google/brya/variants/taeko: Configure GPIOs according to schematics ...................................................................... mb/google/brya/variants/taeko: Configure GPIOs according to schematics Update initial gpio configuration for taeko BUG=b:195252436 TEST=FW_NAME=taeko emerge-brya coreboot Change-Id: Ida1edbf874c93f6efac45c276920ead9311ac6f2 Signed-off-by: joey.peng <joey.peng(a)lcfc.corp-partner.google.com> --- A src/mainboard/google/brya/variants/taeko/Makefile.inc A src/mainboard/google/brya/variants/taeko/gpio.c 2 files changed, 206 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/56754/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/56754 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida1edbf874c93f6efac45c276920ead9311ac6f2 Gerrit-Change-Number: 56754 Gerrit-PatchSet: 7 Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya/variants/taeko: Configure GPIOs according to schematics
by Joey Peng (Code Review) 02 Aug '21

02 Aug '21

Attention is currently required from: Paul Menzel. Joey Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56754 ) Change subject: mb/google/brya/variants/taeko: Configure GPIOs according to schematics ...................................................................... Patch Set 6: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/56754/comment/1759413a_4d8d9042 PS5, Line 12: > Please remove the blank line between the tags. Done https://review.coreboot.org/c/coreboot/+/56754/comment/13552b3c_be49043f PS5, Line 15: Change-Id: Ida1edbf874c93f6efac45c276920ead9311ac6f2 > The Signed-off-by line is missing. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/56754 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida1edbf874c93f6efac45c276920ead9311ac6f2 Gerrit-Change-Number: 56754 Gerrit-PatchSet: 6 Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 02 Aug 2021 09:30:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/variants/taeko: Configure GPIOs according to schematics
by Joey Peng (Code Review) 02 Aug '21

02 Aug '21

Attention is currently required from: Joey Peng. Hello build bot (Jenkins), Tim Wawrzynczak, YH Lin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56754 to look at the new patch set (#6). Change subject: mb/google/brya/variants/taeko: Configure GPIOs according to schematics ...................................................................... mb/google/brya/variants/taeko: Configure GPIOs according to schematics Update initial gpio configuration for taeko BUG=b:195252436 TEST=FW_NAME=taeko emerge-brya coreboot Change-Id: Ida1edbf874c93f6efac45c276920ead9311ac6f2 Signed-off-by: joey.peng <joey.peng(a)lcfc.corp-partner.google.com> --- A src/mainboard/google/brya/variants/taeko/Makefile.inc A src/mainboard/google/brya/variants/taeko/gpio.c 2 files changed, 208 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/56754/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/56754 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida1edbf874c93f6efac45c276920ead9311ac6f2 Gerrit-Change-Number: 56754 Gerrit-PatchSet: 6 Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com> Gerrit-Attention: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/kconfig: detect ncurses on FreeBSD
by Paul Menzel (Code Review) 02 Aug '21

02 Aug '21

Attention is currently required from: Martin Roth, Idwer Vollering. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56677 ) Change subject: util/kconfig: detect ncurses on FreeBSD ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > I doubt the linux maintainers care whether you can build linux under FreeBSD. I do think they care. As the goal should be to not deviate too much from upstream, the information if `make menuconfig` at least works in upstream Linux would be good to have. -- To view, visit https://review.coreboot.org/c/coreboot/+/56677 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4344ba2116c0b8618357db4248d993509cbb666e Gerrit-Change-Number: 56677 Gerrit-PatchSet: 4 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Comment-Date: Mon, 02 Aug 2021 09:02:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth <martinroth(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/galtic: Add charger throttling function
by Paul Menzel (Code Review) 02 Aug '21

02 Aug '21

Attention is currently required from: Henry Sun, Frank Chu, Karthik Ramasubramanian. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54673 ) Change subject: mb/google/dedede/var/galtic: Add charger throttling function ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/54673/comment/9c9836ac_5bc31691 PS5, Line 10: > Done Please add that to the commit message. Also, why are the values rounded in the devicetree? -- To view, visit https://review.coreboot.org/c/coreboot/+/54673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e1849551ff051bca591f19f9e40da4c89ab74e7 Gerrit-Change-Number: 54673 Gerrit-PatchSet: 5 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 02 Aug 2021 09:00:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2021