coreboot-gerrit August 2021

coreboot-gerrit@coreboot.org

1 participants
4520 discussions

Change in coreboot[master]: mb/google/dedede/var/magolor: modify SSFC for camera and touchscreen
by Ren Kuo (Code Review) 02 Aug '21

02 Aug '21

Attention is currently required from: Furquan Shaikh, Ren Kuo, Shou-Chieh Hsu. Hello build bot (Jenkins), David Wu, Furquan Shaikh, Tyler Wang, Shou-Chieh Hsu, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56685 to look at the new patch set (#8). Change subject: mb/google/dedede/var/magolor: modify SSFC for camera and touchscreen ...................................................................... mb/google/dedede/var/magolor: modify SSFC for camera and touchscreen The all shipped magolor and maglia has been writed SSFC= 0x840 (5M MIPI camera) in CBI eeprom. But the value:0x840 will confilict with the following definied touchcreen field. It cause some touchsreen no funtion if user make auto-update new firmware. The CL would correct the problem. The origianl field: CAMERA_WFC 38 40 TS_SOURCE 41 44 Correct filed of mipi camera and toch-screen MIPI Cam: CAMERA_WFC 38 40 CAMERA_UFC 41 42 CAMERA_VCM 43 44 Touch-screen: TS_SOURCE 45 48 The SSFC value of Magolor will be ... CAMERA_OVTI5675 5M AF (SSFC = 0x840) CAMERA_OVTI8856 8M AF (SSFC = 0x880) BUG=b:189852808 TEST=Build firmware and verify on camera and touch-sreen devices Change-Id: I13d76ce8b932f483e20ca5388f1c67eb39ba12a1 Signed-off-by: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> --- M src/mainboard/google/dedede/variants/magolor/overridetree.cb 1 file changed, 8 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/56685/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/56685 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I13d76ce8b932f483e20ca5388f1c67eb39ba12a1 Gerrit-Change-Number: 56685 Gerrit-PatchSet: 8 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Henry Sun <henrysun(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/dedede/var/cappy2: Add camera support
by Sunwei Li (Code Review) 02 Aug '21

02 Aug '21

Attention is currently required from: Henry Sun, Bob Moragues, Weimin Wu, Karthik Ramasubramanian. Sunwei Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56647 ) Change subject: mb/google/dedede/var/cappy2: Add camera support ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/56647/comment/2114bb81_22c756fd PS1, Line 11: None > 193397569 Done -- To view, visit https://review.coreboot.org/c/coreboot/+/56647 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3275ab408f6a03735a35eaa8025c36df09c9898c Gerrit-Change-Number: 56647 Gerrit-PatchSet: 5 Gerrit-Owner: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Bob Moragues <moragues(a)google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Bob Moragues <moragues(a)google.com> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 02 Aug 2021 03:20:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Introduce new baseboard brask
by Zhuohao Lee (Code Review) 02 Aug '21

02 Aug '21

Attention is currently required from: Furquan Shaikh, Paul Menzel, Zhuohao Lee. Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56388 ) Change subject: mb/google/brya: Introduce new baseboard brask ...................................................................... Patch Set 6: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/56388/comment/90706d9d_92be5fc1 PS5, Line 7: introduce the brask to the baseboard > What about quick changing the commit title to: […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/56388 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1bb42c7bb2492402de0810bc4ab2e8d8c0e2392b Gerrit-Change-Number: 56388 Gerrit-PatchSet: 6 Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Comment-Date: Mon, 02 Aug 2021 02:14:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Zhuohao Lee <zhuohao(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/variants/gimble: configure correct type-c port
by Scott Chao (Code Review) 02 Aug '21

02 Aug '21

Attention is currently required from: Tim Wawrzynczak, Paul Menzel, Nick Vaccaro. Scott Chao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56545 ) Change subject: mb/google/brya/variants/gimble: configure correct type-c port ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: Hi Tim, can you help to review this CL? Thank you. -- To view, visit https://review.coreboot.org/c/coreboot/+/56545 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaba27aad2adfb0a9e83058ac756ca46a762107bc Gerrit-Change-Number: 56545 Gerrit-PatchSet: 5 Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Mon, 02 Aug 2021 02:07:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/cappy2: Add camera support
by Sunwei Li (Code Review) 02 Aug '21

02 Aug '21

Attention is currently required from: Henry Sun, Bob Moragues, Karthik Ramasubramanian. Sunwei Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56647 ) Change subject: mb/google/dedede/var/cappy2: Add camera support ...................................................................... Patch Set 5: (1 comment) File src/mainboard/google/dedede/variants/cappy2/overridetree.cb: https://review.coreboot.org/c/coreboot/+/56647/comment/c03c67aa_c153551e PS4, Line 38: > # USB Port Configuration […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/56647 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3275ab408f6a03735a35eaa8025c36df09c9898c Gerrit-Change-Number: 56647 Gerrit-PatchSet: 5 Gerrit-Owner: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Bob Moragues <moragues(a)google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Bob Moragues <moragues(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 02 Aug 2021 01:51:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: acpi/acpigen_ps2_keyb: Align comments using tabs
by Lance Zhao (Code Review) 02 Aug '21

02 Aug '21

Attention is currently required from: Paul Menzel, Tim Wawrzynczak. Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56749 ) Change subject: acpi/acpigen_ps2_keyb: Align comments using tabs ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Thanks, that's a good catch :-) -- To view, visit https://review.coreboot.org/c/coreboot/+/56749 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2cca8cdbbd3607acca88da7b273ca6b080db9e7c Gerrit-Change-Number: 56749 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Mon, 02 Aug 2021 01:45:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: acpi/acpigen_ps2_keyb: Align comments using tabs
by Lance Zhao (Code Review) 02 Aug '21

02 Aug '21

Attention is currently required from: Paul Menzel, Tim Wawrzynczak. Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56749 ) Change subject: acpi/acpigen_ps2_keyb: Align comments using tabs ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56749 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2cca8cdbbd3607acca88da7b273ca6b080db9e7c Gerrit-Change-Number: 56749 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Mon, 02 Aug 2021 01:44:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/galtic: Add charger throttling function
by Frank Chu (Code Review) 02 Aug '21

02 Aug '21

Attention is currently required from: Henry Sun, Paul Menzel, Karthik Ramasubramanian. Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54673 ) Change subject: mb/google/dedede/var/galtic: Add charger throttling function ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/54673/comment/bb6f1341_b3f9d90c PS5, Line 10: > > Please document, where you got the values from. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/54673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e1849551ff051bca591f19f9e40da4c89ab74e7 Gerrit-Change-Number: 54673 Gerrit-PatchSet: 5 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 02 Aug 2021 01:37:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/kconfig: detect ncurses on FreeBSD
by Martin Roth (Code Review) 02 Aug '21

02 Aug '21

Attention is currently required from: Idwer Vollering, Paul Menzel. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56677 ) Change subject: util/kconfig: detect ncurses on FreeBSD ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > This patch was part of coreboot's old patch set. […] Btw, in case my above comment comes across as hostile, it's not meant to. I'd just like to understand the concern with the patch. -- To view, visit https://review.coreboot.org/c/coreboot/+/56677 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4344ba2116c0b8618357db4248d993509cbb666e Gerrit-Change-Number: 56677 Gerrit-PatchSet: 4 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 02 Aug 2021 01:19:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth <martinroth(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/kconfig: detect ncurses on FreeBSD
by Martin Roth (Code Review) 02 Aug '21

02 Aug '21

Attention is currently required from: Idwer Vollering, Paul Menzel. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56677 ) Change subject: util/kconfig: detect ncurses on FreeBSD ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > Does Linux’ Kconfig not work on FreeBSD? If it does work, the fix is something else, isn’t it? This patch was part of coreboot's old patch set. I doubt the linux maintainers care whether you can build linux under FreeBSD. I think that if 'make menuconfig' worked, Idwer probably wouldn't have bothered with the patch. If anyone wants to track down a different fix and replace this with it, I'd have no problem with that This is a simple change and worked for FreeBSD before, so again, I see no problem with putting this change in. This is just looking in a different location for the ncurses library. Is there any issue with that? -- To view, visit https://review.coreboot.org/c/coreboot/+/56677 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4344ba2116c0b8618357db4248d993509cbb666e Gerrit-Change-Number: 56677 Gerrit-PatchSet: 4 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 02 Aug 2021 01:11:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth <martinroth(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2021