coreboot-gerrit August 2021

coreboot-gerrit@coreboot.org

1 participants
4520 discussions

Change in coreboot[master]: soc/intel/tigerlake: Clean up FSP chipset lockdown configuration
by Felix Singer (Code Review) 11 Aug '21

11 Aug '21

Attention is currently required from: Patrick Rudolph. Hello build bot (Jenkins), Tim Wawrzynczak, Michael Niewöhner, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52844 to look at the new patch set (#8). Change subject: soc/intel/tigerlake: Clean up FSP chipset lockdown configuration ...................................................................... soc/intel/tigerlake: Clean up FSP chipset lockdown configuration Use a variable to store if the FSP should be responsible for the chipset lockdown and use it for setting related configuration options. Thus, get rid of that if-else-clause. Change-Id: I0580fb3ec9daafac273dcb091f48ce403c22e8f8 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/soc/intel/tigerlake/fsp_params.c 1 file changed, 5 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/52844/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/52844 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0580fb3ec9daafac273dcb091f48ce403c22e8f8 Gerrit-Change-Number: 52844 Gerrit-PatchSet: 8 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/skylake: Clean up FSP chipset lockdown configuration
by Felix Singer (Code Review) 11 Aug '21

11 Aug '21

Attention is currently required from: Patrick Rudolph. Hello build bot (Jenkins), Tim Wawrzynczak, Angel Pons, Michael Niewöhner, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52843 to look at the new patch set (#7). Change subject: soc/intel/skylake: Clean up FSP chipset lockdown configuration ...................................................................... soc/intel/skylake: Clean up FSP chipset lockdown configuration Use a variable to store if the FSP should be responsible for the chipset lockdown and use it for setting related configuration options. Thus, get rid of that if-clause and adjust comments. This changes behavior since now related options are always set, depending on if coreboot or the FSP should be responsible for the chipset lockdown. This ensures a defined state independent from the default configuration of the FSP. Change-Id: I0c43a11a40a474de4af22aa5506b1d387809bda2 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/soc/intel/skylake/chip.c 1 file changed, 13 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/52843/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/52843 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0c43a11a40a474de4af22aa5506b1d387809bda2 Gerrit-Change-Number: 52843 Gerrit-PatchSet: 7 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/cannonlake: Clean up FSP chipset lockdown configuration
by Felix Singer (Code Review) 11 Aug '21

11 Aug '21

Attention is currently required from: Felix Singer, Patrick Rudolph. Hello build bot (Jenkins), Tim Wawrzynczak, Michael Niewöhner, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52842 to look at the new patch set (#6). Change subject: soc/intel/cannonlake: Clean up FSP chipset lockdown configuration ...................................................................... soc/intel/cannonlake: Clean up FSP chipset lockdown configuration Use a variable to store if the FSP should be responsible for the chipset lockdown and use it for setting related configuration options. Thus, get rid of that if-else-clause and adjust comments. Change-Id: I202c212ec8e9ac63f5512c2e74040c23e1562b9a Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/soc/intel/cannonlake/fsp_params.c 1 file changed, 12 insertions(+), 27 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/52842/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/52842 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I202c212ec8e9ac63f5512c2e74040c23e1562b9a Gerrit-Change-Number: 52842 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: drivers/generic/alc1015: Add HID to support alc1019
by EricR Lai (Code Review) 11 Aug '21

11 Aug '21

Attention is currently required from: Paul Menzel. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56877 ) Change subject: drivers/generic/alc1015: Add HID to support alc1019 ...................................................................... Patch Set 5: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/56877/comment/14715b39_56ededaa PS2, Line 13: TEST=: > TEST= Done Patchset: PS1: > Please provide a link (or commit hash) to the Linux kernel driver in the git commit message. https://patchwork.kernel.org/project/alsa-devel/patch/20210317062309.14051-… IDK, how to post this. too long. -- To view, visit https://review.coreboot.org/c/coreboot/+/56877 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3e98297f3a39048b24d61e61ca95c60cd2037eb5 Gerrit-Change-Number: 56877 Gerrit-PatchSet: 5 Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 11 Aug 2021 03:39:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/generic/alc1015: Add HID to support alc1019
by EricR Lai (Code Review) 11 Aug '21

11 Aug '21

Attention is currently required from: EricR Lai. Hello build bot (Jenkins), Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56877 to look at the new patch set (#5). Change subject: drivers/generic/alc1015: Add HID to support alc1019 ...................................................................... drivers/generic/alc1015: Add HID to support alc1019 ALC1019 will use the ACPI compatible and share the same driver with ALC1015. Add HID to support more compatible ICs. BUG=b:195891240 TEST=ALC1019P driver can probe properly. Signed-off-by: Eric Lai <ericr_lai(a)compal.corp-partner.google.com> Change-Id: I3e98297f3a39048b24d61e61ca95c60cd2037eb5 --- M src/drivers/generic/alc1015/alc1015.c M src/drivers/generic/alc1015/chip.h 2 files changed, 6 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/56877/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/56877 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3e98297f3a39048b24d61e61ca95c60cd2037eb5 Gerrit-Change-Number: 56877 Gerrit-PatchSet: 5 Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: drivers/generic/alc1015: Add HID to support alc1019
by EricR Lai (Code Review) 11 Aug '21

11 Aug '21

Attention is currently required from: EricR Lai. Hello build bot (Jenkins), Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56877 to look at the new patch set (#4). Change subject: drivers/generic/alc1015: Add HID to support alc1019 ...................................................................... drivers/generic/alc1015: Add HID to support alc1019 ALC1019 will use the ACPI compatible and share the same driver with ALC1015. Add HID to support more compatible ICs. https://patchwork.kernel.org/project/alsa-devel/patch/20210317062309.14051-… BUG=b:195891240 TEST=ALC1019P driver can probe properly. Signed-off-by: Eric Lai <ericr_lai(a)compal.corp-partner.google.com> Change-Id: I3e98297f3a39048b24d61e61ca95c60cd2037eb5 --- M src/drivers/generic/alc1015/alc1015.c M src/drivers/generic/alc1015/chip.h 2 files changed, 6 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/56877/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/56877 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3e98297f3a39048b24d61e61ca95c60cd2037eb5 Gerrit-Change-Number: 56877 Gerrit-PatchSet: 4 Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: drivers/generic/alc1015: Add HID to support alc1019
by EricR Lai (Code Review) 11 Aug '21

11 Aug '21

Attention is currently required from: EricR Lai. Hello build bot (Jenkins), Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56877 to look at the new patch set (#3). Change subject: drivers/generic/alc1015: Add HID to support alc1019 ...................................................................... drivers/generic/alc1015: Add HID to support alc1019 ALC1019 will use the ACPI compatible and share the same driver with ALC1015. Add HID to support more compatible ICs. BUG=b:195891240 TEST=ALC1019P driver can probe properly. Signed-off-by: Eric Lai <ericr_lai(a)compal.corp-partner.google.com> Change-Id: I3e98297f3a39048b24d61e61ca95c60cd2037eb5 --- M src/drivers/generic/alc1015/alc1015.c M src/drivers/generic/alc1015/chip.h 2 files changed, 6 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/56877/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/56877 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3e98297f3a39048b24d61e61ca95c60cd2037eb5 Gerrit-Change-Number: 56877 Gerrit-PatchSet: 3 Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya: Ensure descriptor is writable before writing
by Furquan Shaikh (Code Review) 11 Aug '21

11 Aug '21

Attention is currently required from: Tim Wawrzynczak, EricR Lai. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56679 ) Change subject: mb/google/brya: Ensure descriptor is writable before writing ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/brya/bootblock.c: https://review.coreboot.org/c/coreboot/+/56679/comment/207595db_8afa3014 PS1, Line 107: configure_descriptor I am thinking rather than always performing this on all brya variants by default, we should allow variant to decide if it wants to do this. This will ensure that the override logic does not slip into shipping devices. What do you think? -- To view, visit https://review.coreboot.org/c/coreboot/+/56679 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I09613d569ffc92fc3b7334bc30628c4f88955250 Gerrit-Change-Number: 56679 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Wed, 11 Aug 2021 03:11:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: include/bcd: move bcd code to commonlib/bsd/include
by Furquan Shaikh (Code Review) 11 Aug '21

11 Aug '21

Attention is currently required from: Hung-Te Lin, Marc Jones, Ricardo Quesada, Jack Rosenthal, Julius Werner. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56904 ) Change subject: include/bcd: move bcd code to commonlib/bsd/include ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Well, you can't just change the license. […] Yes, let's get an approval from the original author. Keeping comment unresolved to ensure this change doesn't go in before that. -- To view, visit https://review.coreboot.org/c/coreboot/+/56904 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If2eba82da35838799bcbcf38303de6bd53f7eb72 Gerrit-Change-Number: 56904 Gerrit-PatchSet: 1 Gerrit-Owner: Ricardo Quesada <ricardoq(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc.jones(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Marc Jones <marc.jones(a)amd.corp-partner.google.com> Gerrit-Attention: Ricardo Quesada <ricardoq(a)google.com> Gerrit-Attention: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Wed, 11 Aug 2021 03:09:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede: allow MKBP devices
by Furquan Shaikh (Code Review) 11 Aug '21

11 Aug '21

Attention is currently required from: Tim Wawrzynczak, Paul Menzel, Angel Pons, Boris Mittelberg. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56840 ) Change subject: mb/google/dedede: allow MKBP devices ...................................................................... Patch Set 5: (1 comment) File src/mainboard/google/dedede/variants/baseboard/include/baseboard/ec.h: https://review.coreboot.org/c/coreboot/+/56840/comment/39e4d98d_e4f5d291 PS5, Line 73: EC_ENABLE_TBMC_DEVICE > Does tablet mode come across as a keyboard scan code (SW_TABLET_MODE I guess) ? EC sets the button/switch related bit in MKBP event information and the kernel driver translates that into appropriate code: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/thi… -- To view, visit https://review.coreboot.org/c/coreboot/+/56840 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9d1f43e4dd56318af4c1d5f5c1c3a2c237a05c5f Gerrit-Change-Number: 56840 Gerrit-PatchSet: 5 Gerrit-Owner: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Aseda Aboagye <aaboagye(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Wed, 11 Aug 2021 03:08:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2021