coreboot-gerrit August 2021

coreboot-gerrit@coreboot.org

1 participants
4520 discussions

Change in coreboot[master]: mb/google/brya/variant/taeko: Update devicetree settings
by Joey Peng (Code Review) 11 Aug '21

11 Aug '21

Attention is currently required from: Tim Wawrzynczak. Hello build bot (Jenkins), Tim Wawrzynczak, Paul Menzel, Nick Vaccaro, YH Lin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56802 to look at the new patch set (#16). Change subject: mb/google/brya/variant/taeko: Update devicetree settings ...................................................................... mb/google/brya/variant/taeko: Update devicetree settings Based on schematic and gpio table of taeko, generate overridetree.cb settings for taeko. BUG=b:195494281 TEST=FW_NAME=taeko emerge-brya coreboot chromeos-bootimage Signed-off-by: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Change-Id: I96aaf48284a226edc39115f870bf0f3dd83ab8b4 --- M src/mainboard/google/brya/variants/taeko/overridetree.cb 1 file changed, 277 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/56802/16 -- To view, visit https://review.coreboot.org/c/coreboot/+/56802 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I96aaf48284a226edc39115f870bf0f3dd83ab8b4 Gerrit-Change-Number: 56802 Gerrit-PatchSet: 16 Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com> Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: elogtool: add "clear" command
by Ricardo Quesada (Code Review) 11 Aug '21

11 Aug '21

1 0

Change in coreboot[master]: mb/google/brya/variant/taeko: Update devicetree settings
by Joey Peng (Code Review) 11 Aug '21

11 Aug '21

Attention is currently required from: Tim Wawrzynczak. Joey Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56802 ) Change subject: mb/google/brya/variant/taeko: Update devicetree settings ...................................................................... Patch Set 15: (3 comments) File src/mainboard/google/brya/variants/taeko/overridetree.cb: https://review.coreboot.org/c/coreboot/+/56802/comment/55c8644d_b09098e1 PS14, Line 119: 0x2c > nit: all the other i2c addresses in this file do not use the `0x` prefix. drop it for consistency. Done https://review.coreboot.org/c/coreboot/+/56802/comment/2e78a858_1b983e20 PS14, Line 193: device ref pmc hidden > Above the `pmc` device, I think you want to add: […] Done https://review.coreboot.org/c/coreboot/+/56802/comment/8f6ba5af_1a2f2791 PS14, Line 204: conn2 > nit: […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/56802 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I96aaf48284a226edc39115f870bf0f3dd83ab8b4 Gerrit-Change-Number: 56802 Gerrit-PatchSet: 15 Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com> Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Wed, 11 Aug 2021 01:02:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: elogtool: add "clear" command
by Ricardo Quesada (Code Review) 11 Aug '21

11 Aug '21

Attention is currently required from: Furquan Shaikh, Jack Rosenthal. Ricardo Quesada has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56883 ) Change subject: elogtool: add "clear" command ...................................................................... Patch Set 3: (12 comments) Patchset: PS3: Thanks. Fixed! Created a new CL for the bcd code. It is the ancestor of this CL. File src/commonlib/bsd/elog.c: https://review.coreboot.org/c/coreboot/+/56883/comment/4730440b_cf355940 PS2, Line 50: mybin2bcd > I think you can just move the function to common bsd code instead of worrying about gpl implications […] Done https://review.coreboot.org/c/coreboot/+/56883/comment/08c44844_6c21f9f3 PS2, Line 57: > indentation nit: since there's stuff on the line above beyond the (, you need to indent to the ( Done https://review.coreboot.org/c/coreboot/+/56883/comment/b8510480_991f8201 PS2, Line 66: sanity > drop "sanity" (inclusive language) Done File src/commonlib/bsd/include/commonlib/bsd/elog.h: https://review.coreboot.org/c/coreboot/+/56883/comment/6d9b2207_d79e6cf4 PS2, Line 317: > same indentation comment as above Done File src/drivers/elog/elog.c: https://review.coreboot.org/c/coreboot/+/56883/comment/67828539_5ef700e9 PS2, Line 793: 0 > spaces inside of braces Done File util/cbfstool/elogtool.c: https://review.coreboot.org/c/coreboot/+/56883/comment/191ffb99_93849da2 PS2, Line 134: + 1 > using <= you can drop the +1 the "+ 1" is for the checksum byte, so in total header + data + 1 is needed. (added "byte" word next to "checksum for clarity) https://review.coreboot.org/c/coreboot/+/56883/comment/61c9e9e4_4ac4a942 PS2, Line 144: (const char *)(event) > is the cast necessary? yes, without it I get: "error: comparison of distinct pointer types lacks a cast" https://review.coreboot.org/c/coreboot/+/56883/comment/2f20e6d4_1108a839 PS2, Line 155: > indentation Done https://review.coreboot.org/c/coreboot/+/56883/comment/1f1f4c01_08cdfd1f PS2, Line 166: NULL > no input file option for clear command? added. input file gets overwritten (following the same pattern as when no file is provided). Although not sure whether you'd like to have an output file. https://review.coreboot.org/c/coreboot/+/56883/comment/a70a2f93_fa5362f6 PS2, Line 176: "RW_ELOG" > since we've used this constant twice now, would be nice to make a #define for it Done https://review.coreboot.org/c/coreboot/+/56883/comment/9806c1b6_60ed484d PS2, Line 177: (void *) > nit: api expects a uint8_t * Done -- To view, visit https://review.coreboot.org/c/coreboot/+/56883 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia28a6eb34c82103ab078a0841b022e2e5e430585 Gerrit-Change-Number: 56883 Gerrit-PatchSet: 3 Gerrit-Owner: Ricardo Quesada <ricardoq(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Ricardo Quesada <ricardoq(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Comment-Date: Wed, 11 Aug 2021 01:02:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: include/bcd: move bcd code to commonlib/bsd/include
by Ricardo Quesada (Code Review) 11 Aug '21

11 Aug '21

Attention is currently required from: Hung-Te Lin, Julius Werner. Ricardo Quesada has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56904 ) Change subject: include/bcd: move bcd code to commonlib/bsd/include ...................................................................... include/bcd: move bcd code to commonlib/bsd/include Move bcd2bin() / bin2bcd() functions to commonlib/bsd/include/ Also, the license is changed from GPL to BSD. This is because it is needed from "utils" (see CL in the chain). For reference bin2bcd() & bcd2bin() are very simple functions. And there are already BSD implementations of them, like this one: https://chromium.googlesource.com/chromiumos/platform/mosys/+/refs/heads/ma… BUG=b:172210863 TEST=make (everything compiled Ok). Change-Id: If2eba82da35838799bcbcf38303de6bd53f7eb72 Signed-off-by: Ricardo Quesada <ricardoq(a)google.com> --- R src/commonlib/bsd/include/commonlib/bsd/bcd.h M src/drivers/ams/as3722rtc.c M src/drivers/elog/elog.c M src/drivers/i2c/pcf8523/pcf8523.c M src/drivers/i2c/rx6110sa/rx6110sa.c M src/drivers/pc80/rtc/mc146818rtc.c M src/drivers/ti/tps65913/tps65913rtc.c M src/include/cper.h M src/soc/mediatek/common/include/soc/rtc_common.h M src/soc/rockchip/common/rk808.c 10 files changed, 15 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/56904/1 diff --git a/src/include/bcd.h b/src/commonlib/bsd/include/commonlib/bsd/bcd.h similarity index 100% rename from src/include/bcd.h rename to src/commonlib/bsd/include/commonlib/bsd/bcd.h diff --git a/src/drivers/ams/as3722rtc.c b/src/drivers/ams/as3722rtc.c index b3a4469..842ed8b 100644 --- a/src/drivers/ams/as3722rtc.c +++ b/src/drivers/ams/as3722rtc.c @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <bcd.h> +#include <commonlib/bsd/bcd.h> #include <device/i2c_simple.h> #include <rtc.h> #include <stdint.h> diff --git a/src/drivers/elog/elog.c b/src/drivers/elog/elog.c index cfeb7ce..48270d2 100644 --- a/src/drivers/elog/elog.c +++ b/src/drivers/elog/elog.c @@ -1,10 +1,10 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <acpi/acpi.h> -#include <bcd.h> #include <boot_device.h> #include <bootstate.h> #include <cbmem.h> +#include <commonlib/bsd/bcd.h> #include <commonlib/bsd/elog.h> #include <commonlib/region.h> #include <console/console.h> diff --git a/src/drivers/i2c/pcf8523/pcf8523.c b/src/drivers/i2c/pcf8523/pcf8523.c index 94a6251..8d368b2 100644 --- a/src/drivers/i2c/pcf8523/pcf8523.c +++ b/src/drivers/i2c/pcf8523/pcf8523.c @@ -1,9 +1,9 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#include <commonlib/bsd/bcd.h> +#include <console/console.h> #include <device/smbus.h> #include <version.h> -#include <console/console.h> -#include <bcd.h> #include "chip.h" /* Set RTC date from coreboot build date. */ diff --git a/src/drivers/i2c/rx6110sa/rx6110sa.c b/src/drivers/i2c/rx6110sa/rx6110sa.c index 3cab8fa..d30963c 100644 --- a/src/drivers/i2c/rx6110sa/rx6110sa.c +++ b/src/drivers/i2c/rx6110sa/rx6110sa.c @@ -2,13 +2,13 @@ #include <acpi/acpi_device.h> #include <acpi/acpigen.h> +#include <commonlib/bsd/bcd.h> +#include <console/console.h> #include <device/device.h> #include <device/i2c.h> #include <device/i2c_bus.h> -#include <version.h> -#include <console/console.h> -#include <bcd.h> #include <timer.h> +#include <version.h> #include "chip.h" #include "rx6110sa.h" diff --git a/src/drivers/pc80/rtc/mc146818rtc.c b/src/drivers/pc80/rtc/mc146818rtc.c index 9153a03..fd659f1 100644 --- a/src/drivers/pc80/rtc/mc146818rtc.c +++ b/src/drivers/pc80/rtc/mc146818rtc.c @@ -2,15 +2,15 @@ #include <acpi/acpi.h> #include <arch/io.h> -#include <bcd.h> -#include <fallback.h> -#include <version.h> +#include <commonlib/bsd/bcd.h> #include <console/console.h> +#include <fallback.h> #include <pc80/mc146818rtc.h> #include <rtc.h> #include <security/vboot/vbnv.h> #include <security/vboot/vbnv_layout.h> #include <types.h> +#include <version.h> static void cmos_reset_date(void) { diff --git a/src/drivers/ti/tps65913/tps65913rtc.c b/src/drivers/ti/tps65913/tps65913rtc.c index 1ee0d81..b2b89ec 100644 --- a/src/drivers/ti/tps65913/tps65913rtc.c +++ b/src/drivers/ti/tps65913/tps65913rtc.c @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <bcd.h> +#include <commonlib/bsd/bcd.h> #include <console/console.h> #include <device/i2c_simple.h> #include <rtc.h> diff --git a/src/include/cper.h b/src/include/cper.h index 020ac41..576e1d8 100644 --- a/src/include/cper.h +++ b/src/include/cper.h @@ -3,10 +3,10 @@ #ifndef _CPER_H_ #define _CPER_H_ +#include <commonlib/bsd/bcd.h> +#include <rtc.h> #include <types.h> #include <uuid.h> -#include <bcd.h> -#include <rtc.h> /* This file contains some definitions and helpers for implementing structures * in the UEFI specification, Appendix "Common Platform Error Record". This diff --git a/src/soc/mediatek/common/include/soc/rtc_common.h b/src/soc/mediatek/common/include/soc/rtc_common.h index 4a86431..d257357c 100644 --- a/src/soc/mediatek/common/include/soc/rtc_common.h +++ b/src/soc/mediatek/common/include/soc/rtc_common.h @@ -3,7 +3,7 @@ #ifndef SOC_MEDIATEK_RTC_COMMON_H #define SOC_MEDIATEK_RTC_COMMON_H -#include <bcd.h> +#include <commonlib/bsd/bcd.h> #include <console/console.h> #include <rtc.h> #include <stdbool.h> diff --git a/src/soc/rockchip/common/rk808.c b/src/soc/rockchip/common/rk808.c index 7021b02..73c2312 100644 --- a/src/soc/rockchip/common/rk808.c +++ b/src/soc/rockchip/common/rk808.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <assert.h> -#include <bcd.h> +#include <commonlib/bsd/bcd.h> #include <console/console.h> #include <delay.h> #include <device/i2c_simple.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/56904 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If2eba82da35838799bcbcf38303de6bd53f7eb72 Gerrit-Change-Number: 56904 Gerrit-PatchSet: 1 Gerrit-Owner: Ricardo Quesada <ricardoq(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: elogtool: add "clear" command
by Ricardo Quesada (Code Review) 11 Aug '21

11 Aug '21

Attention is currently required from: Furquan Shaikh, Ricardo Quesada. Hello build bot (Jenkins), Furquan Shaikh, Jack Rosenthal, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56883 to look at the new patch set (#3). Change subject: elogtool: add "clear" command ...................................................................... elogtool: add "clear" command Adds "clear" command to cbfsutil/elogtool tool. "clear" clears the RW_ELOG using flashrom with ELOG_TYPE_EOL. And inserts a ELOG_TYPE_LOG_CLEAR event. Usage: $ elogtool clear BUG=b:172210863 Change-Id: Ia28a6eb34c82103ab078a0841b022e2e5e430585 Signed-off-by: Ricardo Quesada <ricardoq(a)google.com> --- M src/commonlib/bsd/elog.c M src/commonlib/bsd/include/commonlib/bsd/elog.h M src/drivers/elog/elog.c M util/cbfstool/elogtool.c M util/cbfstool/eventlog.c M util/cbfstool/eventlog.h 6 files changed, 193 insertions(+), 61 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/56883/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/56883 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia28a6eb34c82103ab078a0841b022e2e5e430585 Gerrit-Change-Number: 56883 Gerrit-PatchSet: 3 Gerrit-Owner: Ricardo Quesada <ricardoq(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Ricardo Quesada <ricardoq(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Ricardo Quesada <ricardoq(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya/variant/taeko: Update devicetree settings
by Joey Peng (Code Review) 11 Aug '21

11 Aug '21

Attention is currently required from: Joey Peng. Hello build bot (Jenkins), Tim Wawrzynczak, Paul Menzel, Nick Vaccaro, YH Lin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56802 to look at the new patch set (#15). Change subject: mb/google/brya/variant/taeko: Update devicetree settings ...................................................................... mb/google/brya/variant/taeko: Update devicetree settings Based on schematic and gpio table of taeko, generate overridetree.cb settings for taeko. BUG=b:195494281 TEST=FW_NAME=taeko emerge-brya coreboot chromeos-bootimage Signed-off-by: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Change-Id: I96aaf48284a226edc39115f870bf0f3dd83ab8b4 --- M src/mainboard/google/brya/variants/taeko/overridetree.cb 1 file changed, 273 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/56802/15 -- To view, visit https://review.coreboot.org/c/coreboot/+/56802 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I96aaf48284a226edc39115f870bf0f3dd83ab8b4 Gerrit-Change-Number: 56802 Gerrit-PatchSet: 15 Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com> Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com> Gerrit-Attention: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/dedede: Create driblee variant
by Karthik Ramasubramanian (Code Review) 11 Aug '21

11 Aug '21

Attention is currently required from: Frank Wu, Henry Sun, Paul Menzel, Aseda Aboagye, Shou-Chieh Hsu. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56798 ) Change subject: mb/google/dedede: Create driblee variant ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56798 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ad9a4e0cf7999337b55d62d5cc94e4f6c2e98f3 Gerrit-Change-Number: 56798 Gerrit-PatchSet: 5 Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Comment-Date: Wed, 11 Aug 2021 00:37:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede: Create corori variant
by Karthik Ramasubramanian (Code Review) 11 Aug '21

11 Aug '21

Attention is currently required from: Frank Wu, Ian Feng, Henry Sun, Paul Menzel, Aseda Aboagye. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56796 ) Change subject: mb/google/dedede: Create corori variant ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56796 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8380d5aab61c99d545625789ff1251ec1caa84a2 Gerrit-Change-Number: 56796 Gerrit-PatchSet: 6 Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-CC: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Comment-Date: Wed, 11 Aug 2021 00:36:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/variants/haboki: add discrete TPM in overridetree
by Karthik Ramasubramanian (Code Review) 11 Aug '21

11 Aug '21

Attention is currently required from: Henry Sun, Chen Wisley, Aseda Aboagye. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56829 ) Change subject: mb/google/dedede/variants/haboki: add discrete TPM in overridetree ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56829 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I08f2a562c3f62c60402350151ea260b70890a744 Gerrit-Change-Number: 56829 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Comment-Date: Wed, 11 Aug 2021 00:25:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2021