Attention is currently required from: Jamie Chen, Paul Menzel, Kane Chen, Andrey Petrov, Patrick Rudolph.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56805 )
Change subject: soc/intel/apollolake: change LPDDR4 density define
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/apollolake/meminit.c:
https://review.coreboot.org/c/coreboot/+/56805/comment/e89b2de1_3776415c
PS1, Line 295: int fsp_rank_density;
Nit: Add an empty line between declaration block and function body.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56805
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I36dba2cef130211e7aea9e2a4f82c5db78f82a83
Gerrit-Change-Number: 56805
Gerrit-PatchSet: 1
Gerrit-Owner: Jamie Chen <jamie.chen(a)intel.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com>
Gerrit-Attention: Jamie Chen <jamie.chen(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kane Chen <kane.chen(a)intel.com>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Wed, 11 Aug 2021 00:17:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Jamie Chen, Paul Menzel, Kane Chen, Andrey Petrov, Patrick Rudolph, Karthik Ramasubramanian.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56805 )
Change subject: soc/intel/apollolake: change LPDDR4 density define
......................................................................
Patch Set 1:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56805/comment/07e76548_cdcefda0
PS1, Line 7: define
enum definition?
https://review.coreboot.org/c/coreboot/+/56805/comment/0efdad3a_ad64bc21
PS1, Line 13:
BUG=b:178665760
File src/soc/intel/apollolake/meminit.c:
https://review.coreboot.org/c/coreboot/+/56805/comment/fe536965_7e14a6b5
PS1, Line 24: /* Per rank density in Gb */
: switch (density) {
: case LP4_8Gb_DENSITY:
: sz = 8;
: break;
: case LP4_12Gb_DENSITY:
: sz = 12;
: break;
: case LP4_16Gb_DENSITY:
: sz = 16;
: break;
: default:
: printk(BIOS_ERR, "Invalid DRAM density: %d\n", density);
: sz = 0;
: break;
: }
I think this can be now dropped completely and `sz` can be set directly to density since that is what the density enum is defined as. Also, the caller already has a check to ensure that we never pass in incorrect density here so the default case should never occur.
https://review.coreboot.org/c/coreboot/+/56805/comment/bd436b7b_ee21db26
PS1, Line 292: rank_density
nit: Update this to rank_density_gb to indicate that the rank density is now passed in Gb.
https://review.coreboot.org/c/coreboot/+/56805/comment/b2cf9e1c_779841ab
PS1, Line 307: \n
Gb
--
To view, visit https://review.coreboot.org/c/coreboot/+/56805
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I36dba2cef130211e7aea9e2a4f82c5db78f82a83
Gerrit-Change-Number: 56805
Gerrit-PatchSet: 1
Gerrit-Owner: Jamie Chen <jamie.chen(a)intel.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com>
Gerrit-Attention: Jamie Chen <jamie.chen(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kane Chen <kane.chen(a)intel.com>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Tue, 10 Aug 2021 23:04:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Angel Pons, Boris Mittelberg.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56840 )
Change subject: mb/google/dedede: allow MKBP devices
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/dedede/variants/baseboard/include/baseboard/ec.h:
https://review.coreboot.org/c/coreboot/+/56840/comment/5def5734_db13ba9f
PS5, Line 73: EC_ENABLE_TBMC_DEVICE
Sorry about the late comment. But, is this still required if all the buttons and switches are now routed via MKBP?
--
To view, visit https://review.coreboot.org/c/coreboot/+/56840
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d1f43e4dd56318af4c1d5f5c1c3a2c237a05c5f
Gerrit-Change-Number: 56840
Gerrit-PatchSet: 5
Gerrit-Owner: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Comment-Date: Tue, 10 Aug 2021 22:29:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Boris Mittelberg has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56903 )
Change subject: mb/google/brya: allow MKBP devices
......................................................................
mb/google/brya: allow MKBP devices
Enable MKBP (Matrix Keyboard Protocol) interface for all Brya family
to use for buttons and switches.
BUG=b:170966461
TEST=manual test on Brya P1: Volume Up/Down buttons
Signed-off-by: Boris Mittelberg <bmbm(a)google.com>
Change-Id: Ic9c707f57871f388c363e01c9ab78a3b358ce728
---
M src/mainboard/google/brya/variants/baseboard/brya/include/baseboard/ec.h
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/56903/1
diff --git a/src/mainboard/google/brya/variants/baseboard/brya/include/baseboard/ec.h b/src/mainboard/google/brya/variants/baseboard/brya/include/baseboard/ec.h
index c76274e..4a6a8da 100644
--- a/src/mainboard/google/brya/variants/baseboard/brya/include/baseboard/ec.h
+++ b/src/mainboard/google/brya/variants/baseboard/brya/include/baseboard/ec.h
@@ -60,6 +60,8 @@
#define EC_ENABLE_ALS_DEVICE
/* Enable Keyboard Backlight */
#define EC_ENABLE_KEYBOARD_BACKLIGHT
+/* Enable MKBP for buttons and switches */
+#define EC_ENABLE_MKBP_DEVICE
/* Enable LID switch and provide wake pin for EC */
#define EC_ENABLE_LID_SWITCH
#define EC_ENABLE_WAKE_PIN GPE_EC_WAKE
--
To view, visit https://review.coreboot.org/c/coreboot/+/56903
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic9c707f57871f388c363e01c9ab78a3b358ce728
Gerrit-Change-Number: 56903
Gerrit-PatchSet: 1
Gerrit-Owner: Boris Mittelberg <bmbm(a)google.com>
Gerrit-MessageType: newchange
Attention is currently required from: Paul Menzel, Boris Mittelberg.
Hello build bot (Jenkins), Furquan Shaikh, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56840
to look at the new patch set (#4).
Change subject: mb/google/dedede: allow MKBP devices
......................................................................
mb/google/dedede: allow MKBP devices
Enable MKBP (Matrix Keyboard Protocol) interface for all dedede family
to use for buttons and switches.
BUG=b:170966461
TEST=manual test on Madoo:
Volume Up/Down and Power buttons, Tablet Mode switch
Cq-Depend: chromium:3069163
Signed-off-by: Boris Mittelberg <bmbm(a)google.com>
Change-Id: I9d1f43e4dd56318af4c1d5f5c1c3a2c237a05c5f
---
M src/mainboard/google/dedede/variants/baseboard/include/baseboard/ec.h
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/56840/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/56840
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d1f43e4dd56318af4c1d5f5c1c3a2c237a05c5f
Gerrit-Change-Number: 56840
Gerrit-PatchSet: 4
Gerrit-Owner: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tim Crawford, Jeremy Soller.
Hello build bot (Jenkins), Jeremy Soller,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52349
to look at the new patch set (#9).
Change subject: mb/system76/darp7: Add System76 Darter Pro 7
......................................................................
mb/system76/darp7: Add System76 Darter Pro 7
https://tech-docs.system76.com/models/darp7/README.html
Tested with TianoCore (UefiPayloadPkg).
Working:
- PS/2 keyboard, touchpad
- Both DIMM slots
- M.2 NVMe SSD
- M.2 SATA SSD
- All USB ports
- USB-PD
- Webcam
- Ethernet
- Integrated graphics using Intel GOP driver
- HDMI output
- DP over USB-C output
- Internal microphone
- Internal speakers
- Combined headphone + mic 3.5mm jack
- Booting to Ubuntu Linux 21.04 and Windows 10
Not working:
- S0ix (no PC10 residency)
- Flashing with flashrom (chipset not supported)
Not tested:
- Thunderbolt functionality
Change-Id: I80e5c5375f9d3881fc89a45a91ba68ed2e104a93
Signed-off-by: Jeremy Soller <jeremy(a)system76.com>
Signed-off-by: Tim Crawford <tcrawford(a)system76.com>
---
M Documentation/mainboard/index.md
A Documentation/mainboard/system76/darp7.md
A src/mainboard/system76/darp7/Kconfig
A src/mainboard/system76/darp7/Kconfig.name
A src/mainboard/system76/darp7/Makefile.inc
A src/mainboard/system76/darp7/acpi/mainboard.asl
A src/mainboard/system76/darp7/acpi/sleep.asl
A src/mainboard/system76/darp7/board_info.txt
A src/mainboard/system76/darp7/bootblock.c
A src/mainboard/system76/darp7/cmos.default
A src/mainboard/system76/darp7/cmos.layout
A src/mainboard/system76/darp7/data.vbt
A src/mainboard/system76/darp7/devicetree.cb
A src/mainboard/system76/darp7/dsdt.asl
A src/mainboard/system76/darp7/gpio.h
A src/mainboard/system76/darp7/hda_verb.c
A src/mainboard/system76/darp7/ramstage.c
A src/mainboard/system76/darp7/romstage.c
18 files changed, 927 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/52349/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/52349
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80e5c5375f9d3881fc89a45a91ba68ed2e104a93
Gerrit-Change-Number: 52349
Gerrit-PatchSet: 9
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Shelley Chen, Douglas Anderson.
Hello Shelley Chen, Douglas Anderson,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/56901
to review the following change.
Change subject: trogdor: Fix "TPM interrupt" lb_gpio to be ACTIVE_HIGH
......................................................................
trogdor: Fix "TPM interrupt" lb_gpio to be ACTIVE_HIGH
"Latched" GPIOs like this one are a virtual representation of the
pending interrupt flag for the edge-triggered pin and not a direct
representation of line state, so they should always be marked
ACTIVE_HIGH or depthcharge will incorrectly negate them. This has always
been wrong and meant that depthcharge doesn't correctly wait for Cr50
flow control responses on these platforms. Thankfully it doesn't seem
like we've seen any practical issues from this, but it's still very
wrong.
BRANCH=trogdor
BUG=none
TEST=Booted CoachZ (no visible difference)
Signed-off-by: Julius Werner <jwerner(a)chromium.org>
Change-Id: Ie1586b0e10b64df0712e28552411c4d540a7e457
---
M src/mainboard/google/trogdor/chromeos.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/56901/1
diff --git a/src/mainboard/google/trogdor/chromeos.c b/src/mainboard/google/trogdor/chromeos.c
index 2136da3..c218388 100644
--- a/src/mainboard/google/trogdor/chromeos.c
+++ b/src/mainboard/google/trogdor/chromeos.c
@@ -31,7 +31,7 @@
"EC in RW"},
{GPIO_AP_EC_INT.addr, ACTIVE_LOW, gpio_get(GPIO_AP_EC_INT),
"EC interrupt"},
- {GPIO_H1_AP_INT.addr, ACTIVE_LOW, gpio_get(GPIO_H1_AP_INT),
+ {GPIO_H1_AP_INT.addr, ACTIVE_HIGH, gpio_get(GPIO_H1_AP_INT),
"TPM interrupt"},
{GPIO_SD_CD_L.addr, ACTIVE_LOW, gpio_get(GPIO_SD_CD_L),
"SD card detect"},
--
To view, visit https://review.coreboot.org/c/coreboot/+/56901
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie1586b0e10b64df0712e28552411c4d540a7e457
Gerrit-Change-Number: 56901
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Douglas Anderson <dianders(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Douglas Anderson <dianders(a)chromium.org>
Gerrit-MessageType: newchange