Attention is currently required from: Furquan Shaikh, Jack Rosenthal.
Ricardo Quesada has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56883 )
Change subject: elogtool: add "clear" command
......................................................................
Patch Set 4:
(4 comments)
Patchset:
PS4:
Thanks. fixed!
File src/drivers/elog/elog.c:
https://review.coreboot.org/c/coreboot/+/56883/comment/1b730845_8c5129e2
PS3, Line 825:
> indent to (
Done
File util/cbfstool/elogtool.c:
https://review.coreboot.org/c/coreboot/+/56883/comment/6015d14b_91cb77d3
PS2, Line 166: NULL
> hmm ... good point ... separate inputs and outputs may be a useful feature, especially for testing.. […]
sg
File util/cbfstool/elogtool.c:
https://review.coreboot.org/c/coreboot/+/56883/comment/240b386b_081d9961
PS3, Line 200: {
: buffer_delete(&buf);
: return ret;
: }
> you can drop the repeated code by using a goto […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56883
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia28a6eb34c82103ab078a0841b022e2e5e430585
Gerrit-Change-Number: 56883
Gerrit-PatchSet: 4
Gerrit-Owner: Ricardo Quesada <ricardoq(a)google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org>
Gerrit-Reviewer: Ricardo Quesada <ricardoq(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Jack Rosenthal <jrosenth(a)chromium.org>
Gerrit-Comment-Date: Wed, 11 Aug 2021 16:51:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ricardo Quesada <ricardoq(a)google.com>
Comment-In-Reply-To: Jack Rosenthal <jrosenth(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Marc Jones, Furquan Shaikh, Jack Rosenthal, Julius Werner.
Ricardo Quesada has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56904 )
Change subject: include/bcd: move bcd code to commonlib/bsd/include
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
Thanks. fixed.
Note: added in the commit description a link to the FreeBSD code where they use bin2bcd/bcd2bin.
File src/commonlib/bsd/include/commonlib/bsd/bcd.h:
https://review.coreboot.org/c/coreboot/+/56904/comment/bb259298_fdbc28b4
PS1, Line 1: GPL-2.0-only
> Needs changed to BSD
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56904
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If2eba82da35838799bcbcf38303de6bd53f7eb72
Gerrit-Change-Number: 56904
Gerrit-PatchSet: 2
Gerrit-Owner: Ricardo Quesada <ricardoq(a)google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Marc Jones <marc.jones(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Marc Jones <marc.jones(a)amd.corp-partner.google.com>
Gerrit-Attention: Jack Rosenthal <jrosenth(a)chromium.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Wed, 11 Aug 2021 16:50:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jack Rosenthal <jrosenth(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Marc Jones, Furquan Shaikh, Ricardo Quesada, Julius Werner.
Hello Hung-Te Lin, Marc Jones, build bot (Jenkins), Furquan Shaikh, Marc Jones, Jack Rosenthal, Julius Werner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56904
to look at the new patch set (#2).
Change subject: include/bcd: move bcd code to commonlib/bsd/include
......................................................................
include/bcd: move bcd code to commonlib/bsd/include
Move bcd2bin() / bin2bcd() functions to commonlib/bsd/include/
Also, the license is changed from GPL to BSD.
This is because it is needed from "utils" (see CL in the chain).
For reference bin2bcd() &
bcd2bin() are very simple functions. And there are already BSD
implementations of them, like these ones, to name a few:
https://chromium.googlesource.com/chromiumos/platform/mosys/+/refs/heads/ma…http://web.mit.edu/freebsd/head/sys/contrib/octeon-sdk/cvmx-cn3010-evb-hs5.c
BUG=b:172210863
TEST=make (everything compiled Ok).
Change-Id: If2eba82da35838799bcbcf38303de6bd53f7eb72
Signed-off-by: Ricardo Quesada <ricardoq(a)google.com>
---
R src/commonlib/bsd/include/commonlib/bsd/bcd.h
M src/drivers/ams/as3722rtc.c
M src/drivers/elog/elog.c
M src/drivers/i2c/pcf8523/pcf8523.c
M src/drivers/i2c/rx6110sa/rx6110sa.c
M src/drivers/pc80/rtc/mc146818rtc.c
M src/drivers/ti/tps65913/tps65913rtc.c
M src/include/cper.h
M src/soc/mediatek/common/include/soc/rtc_common.h
M src/soc/rockchip/common/rk808.c
10 files changed, 16 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/56904/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56904
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If2eba82da35838799bcbcf38303de6bd53f7eb72
Gerrit-Change-Number: 56904
Gerrit-PatchSet: 2
Gerrit-Owner: Ricardo Quesada <ricardoq(a)google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Marc Jones <marc.jones(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Marc Jones <marc.jones(a)amd.corp-partner.google.com>
Gerrit-Attention: Ricardo Quesada <ricardoq(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Menzel, Kane Chen, Andrey Petrov, Patrick Rudolph, Karthik Ramasubramanian.
Hello build bot (Jenkins), Jamie Chen, Furquan Shaikh, Kane Chen, Andrey Petrov, Patrick Rudolph, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/55153
to look at the new patch set (#8).
Change subject: soc/intel/apollolake: add 4Gb and 6Gb dram density
......................................................................
soc/intel/apollolake: add 4Gb and 6Gb dram density
This patch adds 4gb and 6gb dram density support to APL and GLK.
BUG=b:178665760
BRANCH=NONE
TEST=build fw and flash to the dut, the dut can boot up successfully.
Change-Id: Ic0d5d14f26a30da7a9caf4ef43d7fac88a4d2bf1
Signed-off-by: Jamie Chen <jamie.chen(a)intel.com>
---
M src/soc/intel/apollolake/include/soc/meminit.h
M src/soc/intel/apollolake/meminit.c
2 files changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/55153/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/55153
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0d5d14f26a30da7a9caf4ef43d7fac88a4d2bf1
Gerrit-Change-Number: 55153
Gerrit-PatchSet: 8
Gerrit-Owner: Jamie Chen <jamie.chen(a)intel.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Jamie Chen <jamie.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kane Chen <kane.chen(a)intel.com>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: newpatchset