coreboot-gerrit August 2021

coreboot-gerrit@coreboot.org

1 participants
4520 discussions

Change in coreboot[master]: elogtool: add "clear" command
by Jack Rosenthal (Code Review) 12 Aug '21

12 Aug '21

Attention is currently required from: Furquan Shaikh, Ricardo Quesada. Jack Rosenthal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56883 ) Change subject: elogtool: add "clear" command ...................................................................... Patch Set 3: (3 comments) File src/drivers/elog/elog.c: https://review.coreboot.org/c/coreboot/+/56883/comment/f1bf7dce_12d5df4f PS3, Line 825: indent to ( File util/cbfstool/elogtool.c: https://review.coreboot.org/c/coreboot/+/56883/comment/c2c2ff5e_2d933de5 PS2, Line 166: NULL > added. […] hmm ... good point ... separate inputs and outputs may be a useful feature, especially for testing... but possibly in the future? I think we can add it down the road File util/cbfstool/elogtool.c: https://review.coreboot.org/c/coreboot/+/56883/comment/1d01029f_465b0fe3 PS3, Line 200: { : buffer_delete(&buf); : return ret; : } you can drop the repeated code by using a goto { ... if (ret != 0) goto exit; ... exit: buffer_delete(&buf); return ret; } -- To view, visit https://review.coreboot.org/c/coreboot/+/56883 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia28a6eb34c82103ab078a0841b022e2e5e430585 Gerrit-Change-Number: 56883 Gerrit-PatchSet: 3 Gerrit-Owner: Ricardo Quesada <ricardoq(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Ricardo Quesada <ricardoq(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Ricardo Quesada <ricardoq(a)google.com> Gerrit-Comment-Date: Wed, 11 Aug 2021 15:53:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ricardo Quesada <ricardoq(a)google.com> Comment-In-Reply-To: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: include/bcd: move bcd code to commonlib/bsd/include
by Jack Rosenthal (Code Review) 12 Aug '21

12 Aug '21

Attention is currently required from: Hung-Te Lin, Marc Jones, Furquan Shaikh, Ricardo Quesada, Julius Werner. Jack Rosenthal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56904 ) Change subject: include/bcd: move bcd code to commonlib/bsd/include ...................................................................... Patch Set 1: (1 comment) File src/commonlib/bsd/include/commonlib/bsd/bcd.h: https://review.coreboot.org/c/coreboot/+/56904/comment/68aa671b_65da3106 PS1, Line 1: GPL-2.0-only Needs changed to BSD -- To view, visit https://review.coreboot.org/c/coreboot/+/56904 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If2eba82da35838799bcbcf38303de6bd53f7eb72 Gerrit-Change-Number: 56904 Gerrit-PatchSet: 1 Gerrit-Owner: Ricardo Quesada <ricardoq(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc.jones(a)amd.corp-partner.google.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Marc Jones <marc.jones(a)amd.corp-partner.google.com> Gerrit-Attention: Ricardo Quesada <ricardoq(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Wed, 11 Aug 2021 15:45:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: include/bcd: move bcd code to commonlib/bsd/include
by Jack Rosenthal (Code Review) 12 Aug '21

12 Aug '21

Attention is currently required from: Hung-Te Lin, Furquan Shaikh, Marc Jones, Ricardo Quesada, Julius Werner. Jack Rosenthal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56904 ) Change subject: include/bcd: move bcd code to commonlib/bsd/include ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Yes, let's get an approval from the original author. […] I think it's OK since as Ricardo mentions, this code existed in mosys under a BSD license before coreboot (going back to 2012).... at least the bin2bcd part. I'm no lawyer tho, so may be best to wait. -- To view, visit https://review.coreboot.org/c/coreboot/+/56904 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If2eba82da35838799bcbcf38303de6bd53f7eb72 Gerrit-Change-Number: 56904 Gerrit-PatchSet: 1 Gerrit-Owner: Ricardo Quesada <ricardoq(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc.jones(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Marc Jones <marc.jones(a)amd.corp-partner.google.com> Gerrit-Attention: Ricardo Quesada <ricardoq(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Wed, 11 Aug 2021 15:40:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org> Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Processor hang while hot plug unplug of TBT Device
by Sugnan Prabhu S (Code Review) 12 Aug '21

12 Aug '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Patrick Rudolph. Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56503 to look at the new patch set (#6). Change subject: soc/intel/alderlake: Processor hang while hot plug unplug of TBT Device ...................................................................... soc/intel/alderlake: Processor hang while hot plug unplug of TBT Device BIOS should execute TBT PCIe RP RTD3 flow based on the value TBT_DMA_CFG_VS_CAP_9[30]. It should skip TBT PCIe RP RTD3 flow, if BIT30 in TBT FW version is not set. BUG=b:194880254 Change-Id: Ie3577df519f64c6f7270dc5537278af76536774e Signed-off-by: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> --- M src/soc/intel/alderlake/acpi/tcss.asl M src/soc/intel/alderlake/acpi/tcss_dma.asl 2 files changed, 10 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/56503/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/56503 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie3577df519f64c6f7270dc5537278af76536774e Gerrit-Change-Number: 56503 Gerrit-PatchSet: 6 Gerrit-Owner: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/system76/darp7: Add System76 Darter Pro 7
by Tim Crawford (Code Review) 12 Aug '21

12 Aug '21

Attention is currently required from: Jeremy Soller. Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52349 ) Change subject: mb/system76/darp7: Add System76 Darter Pro 7 ...................................................................... Patch Set 9: (1 comment) File src/mainboard/system76/darp7/devicetree.cb: https://review.coreboot.org/c/coreboot/+/52349/comment/1e4e2cc5_fc4fa9c4 PS9, Line 146: device ref tbt_dma0 on # J_TYPEC2 I assume I have something misconfigured, since in dmesg I see these: pci 0000:00:07.0: DPC: RP PIO log size 0 is invalid thunderbolt: probe of 0000:00:0d.2 failed with error -110 Although, I have no TBT devices to test with. -- To view, visit https://review.coreboot.org/c/coreboot/+/52349 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I80e5c5375f9d3881fc89a45a91ba68ed2e104a93 Gerrit-Change-Number: 52349 Gerrit-PatchSet: 9 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Comment-Date: Wed, 11 Aug 2021 15:12:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common: Add TGL-H PCI IDs
by Tim Crawford (Code Review) 11 Aug '21

11 Aug '21

Attention is currently required from: Jeremy Soller. Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56900 ) Change subject: soc/intel/common: Add TGL-H PCI IDs ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/56900 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I751d0d59aff9e93e2aa92546db78775bd1e6ef22 Gerrit-Change-Number: 56900 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Comment-Date: Wed, 11 Aug 2021 14:53:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/variant/lantis: Include SPD for MT53E512M32D1NP-046 ...
by Chen Wisley (Code Review) 11 Aug '21

11 Aug '21

Attention is currently required from: Chen Wisley, Wisley Chen. Hello build bot (Jenkins), Wisley Chen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56909 to look at the new patch set (#3). Change subject: mb/google/dedede/variant/lantis: Include SPD for MT53E512M32D1NP-046 WT:B ...................................................................... mb/google/dedede/variant/lantis: Include SPD for MT53E512M32D1NP-046 WT:B Add SPD support to lantis for MT53E512M32D1NP-046 WT:B BUG=None BRANCH=firmware-dedede-13606.B TEST=FW_NAME=lantis emerge-dedede coreboot chromeos-bootimage Change-Id: I22c50a55dd3b8bbda64ba1b607c8b22cc6592f98 Signed-off-by: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> --- M src/mainboard/google/dedede/variants/lantis/memory/Makefile.inc M src/mainboard/google/dedede/variants/lantis/memory/dram_id.generated.txt M src/mainboard/google/dedede/variants/lantis/memory/mem_parts_used.txt 3 files changed, 3 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/56909/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/56909 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22c50a55dd3b8bbda64ba1b607c8b22cc6592f98 Gerrit-Change-Number: 56909 Gerrit-PatchSet: 3 Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: HACK sc7280: QSIP SPI NOR addressing mode for SKU1 and SKU2 HACK
by build bot (Jenkins) (Code Review) 11 Aug '21

11 Aug '21

Attention is currently required from: Shelley Chen, Ravi kumar, mturney mturney. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50586 ) Change subject: HACK sc7280: QSIP SPI NOR addressing mode for SKU1 and SKU2 HACK ...................................................................... Patch Set 64: (2 comments) File src/drivers/spi/spi_flash.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126066): https://review.coreboot.org/c/coreboot/+/50586/comment/980b844b_2c6bc8cb PS64, Line 541: while (1) suspect code indent for conditional statements (24, 24) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126066): https://review.coreboot.org/c/coreboot/+/50586/comment/d7accad6_55760d3e PS64, Line 562: while (1) suspect code indent for conditional statements (24, 24) -- To view, visit https://review.coreboot.org/c/coreboot/+/50586 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ied5b647d0fcc8e3effff3bb7c8680ed5a0c1f3d4 Gerrit-Change-Number: 50586 Gerrit-PatchSet: 64 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: Sajida Bhanu <sbhanu(a)codeaurora.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org> Gerrit-Comment-Date: Wed, 11 Aug 2021 14:29:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: sc7280: Add PCIe RC driver in Coreboot
by build bot (Jenkins) (Code Review) 11 Aug '21

11 Aug '21

Attention is currently required from: Shelley Chen, Ravi kumar, Furquan Shaikh, Julius Werner, mturney mturney. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53902 ) Change subject: sc7280: Add PCIe RC driver in Coreboot ...................................................................... Patch Set 31: (1 comment) File src/soc/qualcomm/sc7280/include/soc/pcie.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126058): https://review.coreboot.org/c/coreboot/+/53902/comment/a30f9c76_41d23f71 PS31, Line 168: #define PCIE_DEV_FUNC (dev, func) {(PCI_SLOT(devfn)) | (PCI_FUNC(devfn))} Macros with complex values should be enclosed in parentheses -- To view, visit https://review.coreboot.org/c/coreboot/+/53902 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iccf60aa56541f5230fa9c3f821d7709615c36631 Gerrit-Change-Number: 53902 Gerrit-PatchSet: 31 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Prasad Malisetty <pmaliset(a)qualcomm.corp-partner.google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org> Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org> Gerrit-Comment-Date: Wed, 11 Aug 2021 14:27:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/adlrvp: Update DIMM type as memory down for DDR5 MR SKU
by Meera Ravindranath (Code Review) 11 Aug '21

11 Aug '21

Attention is currently required from: Furquan Shaikh, Maulik V Vaghela, Paul Menzel. Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56881 ) Change subject: mb/intel/adlrvp: Update DIMM type as memory down for DDR5 MR SKU ...................................................................... Patch Set 6: (2 comments) File src/mainboard/intel/adlrvp/romstage_fsp_params.c: https://review.coreboot.org/c/coreboot/+/56881/comment/b0c44201_58c0d89e PS4, Line 58: case ADL_P_DDR5_2: > shouldn't this go to https://review.coreboot. […] Done File src/mainboard/intel/adlrvp/spd/Makefile.inc: https://review.coreboot.org/c/coreboot/+/56881/comment/c1ff64cd_6268acb0 PS2, Line 9: SPD_SOURCES += adlrvp_ddr5_mr # 0b006 > Please properly align the comments. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/56881 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0b7a96b5534d8b80776aa7578ce7c13181af7882 Gerrit-Change-Number: 56881 Gerrit-PatchSet: 6 Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 11 Aug 2021 14:17:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2021