Attention is currently required from: Ricardo Quesada.
Hello build bot (Jenkins), Furquan Shaikh, Jack Rosenthal,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56883
to look at the new patch set (#5).
Change subject: elogtool: add "clear" command
......................................................................
elogtool: add "clear" command
Adds "clear" command to cbfsutil/elogtool tool.
"clear" clears the RW_ELOG using flashrom with ELOG_TYPE_EOL.
And inserts a ELOG_TYPE_LOG_CLEAR event.
Additionally, it does a minor cleanup to command "list", like:
* use buffer_end()
* add "list" to the cmds struct
* and make elog_read() very similar to elog_write()
Usage:
$ elogtool clear
BUG=b:172210863
Change-Id: Ia28a6eb34c82103ab078a0841b022e2e5e430585
Signed-off-by: Ricardo Quesada <ricardoq(a)google.com>
---
M util/cbfstool/elogtool.c
M util/cbfstool/eventlog.c
M util/cbfstool/eventlog.h
3 files changed, 160 insertions(+), 36 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/56883/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/56883
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia28a6eb34c82103ab078a0841b022e2e5e430585
Gerrit-Change-Number: 56883
Gerrit-PatchSet: 5
Gerrit-Owner: Ricardo Quesada <ricardoq(a)google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org>
Gerrit-Reviewer: Ricardo Quesada <ricardoq(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Ricardo Quesada <ricardoq(a)google.com>
Gerrit-MessageType: newpatchset
Julius Werner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/56901 )
Change subject: trogdor: Fix "TPM interrupt" lb_gpio to be ACTIVE_HIGH
......................................................................
trogdor: Fix "TPM interrupt" lb_gpio to be ACTIVE_HIGH
"Latched" GPIOs like this one are a virtual representation of the
pending interrupt flag for the edge-triggered pin and not a direct
representation of line state, so they should always be marked
ACTIVE_HIGH or depthcharge will incorrectly negate them. This has always
been wrong and meant that depthcharge doesn't correctly wait for Cr50
flow control responses on these platforms. Thankfully it doesn't seem
like we've seen any practical issues from this, but it's still very
wrong.
BRANCH=trogdor
BUG=none
TEST=Booted CoachZ (no visible difference)
Signed-off-by: Julius Werner <jwerner(a)chromium.org>
Change-Id: Ie1586b0e10b64df0712e28552411c4d540a7e457
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56901
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org>
Reviewed-by: Douglas Anderson <dianders(a)chromium.org>
---
M src/mainboard/google/trogdor/chromeos.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
build bot (Jenkins): Verified
Paul Menzel: Looks good to me, but someone else must approve
Douglas Anderson: Looks good to me, approved
diff --git a/src/mainboard/google/trogdor/chromeos.c b/src/mainboard/google/trogdor/chromeos.c
index 2136da3..c218388 100644
--- a/src/mainboard/google/trogdor/chromeos.c
+++ b/src/mainboard/google/trogdor/chromeos.c
@@ -31,7 +31,7 @@
"EC in RW"},
{GPIO_AP_EC_INT.addr, ACTIVE_LOW, gpio_get(GPIO_AP_EC_INT),
"EC interrupt"},
- {GPIO_H1_AP_INT.addr, ACTIVE_LOW, gpio_get(GPIO_H1_AP_INT),
+ {GPIO_H1_AP_INT.addr, ACTIVE_HIGH, gpio_get(GPIO_H1_AP_INT),
"TPM interrupt"},
{GPIO_SD_CD_L.addr, ACTIVE_LOW, gpio_get(GPIO_SD_CD_L),
"SD card detect"},
--
To view, visit https://review.coreboot.org/c/coreboot/+/56901
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie1586b0e10b64df0712e28552411c4d540a7e457
Gerrit-Change-Number: 56901
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Douglas Anderson <dianders(a)chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Shelley Chen, Yu-Ping Wu.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56965 )
Change subject: device: Move MIPI panel library from mainboard/google/kukui into common
......................................................................
Patch Set 2:
(3 comments)
File src/include/device/mipi_panel.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126264):
https://review.coreboot.org/c/coreboot/+/56965/comment/0b52b2bf_63a3a14c
PS2, Line 39: #define PANEL_DCS(...) \
Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126264):
https://review.coreboot.org/c/coreboot/+/56965/comment/22f005e6_d8d4cb87
PS2, Line 44: #define PANEL_GENERIC(...) \
Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126264):
https://review.coreboot.org/c/coreboot/+/56965/comment/5e5c6356_32dd1f18
PS2, Line 49: #define PANEL_DELAY(delay) \
Macros with complex values should be enclosed in parentheses
--
To view, visit https://review.coreboot.org/c/coreboot/+/56965
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I877f2b0c7ab984412b288e2ed27f37cd93c70863
Gerrit-Change-Number: 56965
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Mon, 16 Aug 2021 22:52:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Vinod Polimera, Shelley Chen, Hung-Te Lin, Yu-Ping Wu.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56966 )
Change subject: qualcomm/sc7180: Switch to common MIPI panel library
......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/trogdor/mainboard.c:
https://review.coreboot.org/c/coreboot/+/56966/comment/193fb0c2_8efb2f59
PS1, Line 110: get_panel_config
> Remove it from trogdor/panel_driver.c (and soc/display/panel. […]
Right thanks, meant to delete both of those.
File src/soc/qualcomm/sc7180/display/dsi.c:
https://review.coreboot.org/c/coreboot/+/56966/comment/1a8b0642_5453fbac
PS1, Line 247: ret
> I guess it's fine to convert int return value to cb_err_t?
No, this was an oversight, thanks.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56966
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78f6efbaa9da88a3574d5c6a51061e308412340e
Gerrit-Change-Number: 56966
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Vinod Polimera <vpolimer(a)qualcomm.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Vinod Polimera <vpolimer(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Mon, 16 Aug 2021 22:52:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Shelley Chen, Yu-Ping Wu.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56965 )
Change subject: device: Move MIPI panel library from mainboard/google/kukui into common
......................................................................
Patch Set 1:
(6 comments)
Commit Message:
PS1:
> rk3399 also has lots of duplicate code. […]
I don't really feel like spending the time right now tbh, it's an old chipset and it's very unlikely anyone will ever use it again. Let's establish this going forward for now, and if anyone cares backporting it to the older stuff they're welcome to do so.
https://review.coreboot.org/c/coreboot/+/56965/comment/493318d3_87bb3096
PS1, Line 15: at
> a?
Done
File src/device/mipi/Kconfig:
https://review.coreboot.org/c/coreboot/+/56965/comment/5d6115f9_01041837
PS1, Line 38:
> Extra blank line.
Done
File src/include/device/mipi_panel.h:
https://review.coreboot.org/c/coreboot/+/56965/comment/17c15a2f_af33ff7d
PS1, Line 11: PANEL_END_CMD
> I'd prefer consistent prefixes: PANEL_CMD_*.
Done
https://review.coreboot.org/c/coreboot/+/56965/comment/7771a9a7_8f1f954e
PS1, Line 24: that
> remove
Done
File src/soc/mediatek/common/dsi.c:
https://review.coreboot.org/c/coreboot/+/56965/comment/b6848f24_40baf7ff
PS1, Line 359: TODO
> It's considered an error according in rk_mipi_dsi_write().
Let me switch it to CB_ERR.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56965
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I877f2b0c7ab984412b288e2ed27f37cd93c70863
Gerrit-Change-Number: 56965
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Mon, 16 Aug 2021 22:52:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Vinod Polimera, Shelley Chen, Hung-Te Lin, Julius Werner.
Hello Vinod Polimera, Hung-Te Lin, Shelley Chen, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56966
to look at the new patch set (#2).
Change subject: qualcomm/sc7180: Switch to common MIPI panel library
......................................................................
qualcomm/sc7180: Switch to common MIPI panel library
This patch changes the sc7180 boards to use the new common MIPI panel
framework, which allows more flexible initialization command packing and
sharing panel definitions between boards. (I'm taking the lane count
control back out again for now, since it seems we only ever want 4 for
now anyway, and if we ever have a need for a different lane count it's
not clear whether that should be a property of the board or the panel or
both. Better to leave that decision until we have a real use case.)
Signed-off-by: Julius Werner <jwerner(a)chromium.org>
Change-Id: I78f6efbaa9da88a3574d5c6a51061e308412340e
---
M src/device/mipi/Kconfig
M src/device/mipi/Makefile.inc
A src/device/mipi/panel-VIS_RM69299.c
M src/mainboard/google/trogdor/Kconfig
M src/mainboard/google/trogdor/Makefile.inc
M src/mainboard/google/trogdor/mainboard.c
D src/mainboard/google/trogdor/panel_driver.c
M src/soc/qualcomm/sc7180/display/dsi.c
M src/soc/qualcomm/sc7180/include/soc/display/mipi_dsi.h
D src/soc/qualcomm/sc7180/include/soc/display/panel.h
10 files changed, 141 insertions(+), 152 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/56966/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56966
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78f6efbaa9da88a3574d5c6a51061e308412340e
Gerrit-Change-Number: 56966
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Vinod Polimera <vpolimer(a)qualcomm.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Vinod Polimera <vpolimer(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Shelley Chen, Julius Werner.
Hello Hung-Te Lin, Shelley Chen, build bot (Jenkins), Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56965
to look at the new patch set (#2).
Change subject: device: Move MIPI panel library from mainboard/google/kukui into common
......................................................................
device: Move MIPI panel library from mainboard/google/kukui into common
All boards that are trying to use MIPI panels eventually run into the
problem that they need to store physical parameters and a list of DCS
initialization commands for each panel, and these commands can be very
different (e.g. a large amount of very short commands, a few very large
commands, etc.). Finding a data format to fit all these different cases
efficiently into the same structures keeps being a challenge, and the
Kukui mainboard already once put a lot of effort into designing a
clean, flexible and efficient solution for this. This patch moves that
framework into a common src/device/mipi/ library where it can be used by
other boards as well. (Also, this will hopefully allow us to save some
duplicated work when using the same panel on different boards at some
point.)
Signed-off-by: Julius Werner <jwerner(a)chromium.org>
Change-Id: I877f2b0c7ab984412b288e2ed27f37cd93c70863
---
M src/device/Kconfig
M src/device/Makefile.inc
A src/device/mipi/Kconfig
A src/device/mipi/Makefile.inc
A src/device/mipi/panel-AUO_B101UAN08_3.c
R src/device/mipi/panel-AUO_KD101N80_45NA.c
R src/device/mipi/panel-AUO_NT51021D8P.c
A src/device/mipi/panel-BOE_TV080WUM_NG0.c
A src/device/mipi/panel-BOE_TV101WUM_N53.c
A src/device/mipi/panel-BOE_TV101WUM_NG0.c
A src/device/mipi/panel-BOE_TV101WUM_NL6.c
A src/device/mipi/panel-BOE_TV105WUM_NW0.c
A src/device/mipi/panel-CMN_P097PFG_SSD2858.c
A src/device/mipi/panel-INX_OTA7290D10P.c
A src/device/mipi/panel-STA_2081101QFH032011_53G.c
A src/device/mipi/panel.c
A src/include/device/mipi_panel.h
M src/mainboard/google/kukui/Kconfig
M src/mainboard/google/kukui/panel.h
D src/mainboard/google/kukui/panel_params/Makefile.inc
D src/mainboard/google/kukui/panel_params/panel-AUO_B101UAN08_3.c
D src/mainboard/google/kukui/panel_params/panel-BOE_TV080WUM_NG0.c
D src/mainboard/google/kukui/panel_params/panel-BOE_TV101WUM_N53.c
D src/mainboard/google/kukui/panel_params/panel-BOE_TV101WUM_NG0.c
D src/mainboard/google/kukui/panel_params/panel-BOE_TV101WUM_NL6.c
D src/mainboard/google/kukui/panel_params/panel-BOE_TV105WUM_NW0.c
D src/mainboard/google/kukui/panel_params/panel-CMN_P097PFG_SSD2858.c
D src/mainboard/google/kukui/panel_params/panel-INX_OTA7290D10P.c
D src/mainboard/google/kukui/panel_params/panel-STA_2081101QFH032011_53G.c
M src/soc/mediatek/common/dsi.c
M src/soc/mediatek/common/include/soc/dsi_common.h
31 files changed, 2,405 insertions(+), 2,306 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/56965/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56965
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I877f2b0c7ab984412b288e2ed27f37cd93c70863
Gerrit-Change-Number: 56965
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jeremy Soller.
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52349 )
Change subject: mb/system76/darp7: Add System76 Darter Pro 7
......................................................................
Patch Set 11:
(1 comment)
File src/mainboard/system76/darp7/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/52349/comment/b26855b4_e2b5f40f
PS9, Line 146: device ref tbt_dma0 on # J_TYPEC2
> I assume I have something misconfigured, since in dmesg I see these: […]
pci 07.0 error happens on proprietary firmware, so not too concerned about it.
0d.2 probe error is something introduced in Linux 5.13. On 5.11 there is no error and TBT is detected in GNOME.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52349
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80e5c5375f9d3881fc89a45a91ba68ed2e104a93
Gerrit-Change-Number: 52349
Gerrit-PatchSet: 11
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Comment-Date: Mon, 16 Aug 2021 22:42:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Crawford <tcrawford(a)system76.com>
Gerrit-MessageType: comment
Attention is currently required from: Tim Crawford, Jeremy Soller.
Hello build bot (Jenkins), Jeremy Soller,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52349
to look at the new patch set (#11).
Change subject: mb/system76/darp7: Add System76 Darter Pro 7
......................................................................
mb/system76/darp7: Add System76 Darter Pro 7
https://tech-docs.system76.com/models/darp7/README.html
Tested with TianoCore (UefiPayloadPkg).
Working:
- PS/2 keyboard, touchpad
- Both DIMM slots
- M.2 NVMe SSD
- M.2 SATA SSD
- All USB ports
- USB-PD
- Webcam
- Ethernet
- WiFi/Bluetooth
- Integrated graphics using Intel GOP driver
- HDMI output
- DP over USB-C output
- Internal microphone
- Internal speakers
- Combined headphone + mic 3.5mm jack
- Booting to Ubuntu Linux 21.04 and Windows 10
Not working:
- S0ix (no PC10 residency)
- Flashing with flashrom (chipset not supported)
Not tested:
- Thunderbolt functionality
Change-Id: I80e5c5375f9d3881fc89a45a91ba68ed2e104a93
Signed-off-by: Jeremy Soller <jeremy(a)system76.com>
Signed-off-by: Tim Crawford <tcrawford(a)system76.com>
---
M Documentation/mainboard/index.md
A Documentation/mainboard/system76/darp7.md
A src/mainboard/system76/darp7/Kconfig
A src/mainboard/system76/darp7/Kconfig.name
A src/mainboard/system76/darp7/Makefile.inc
A src/mainboard/system76/darp7/acpi/mainboard.asl
A src/mainboard/system76/darp7/acpi/sleep.asl
A src/mainboard/system76/darp7/board_info.txt
A src/mainboard/system76/darp7/bootblock.c
A src/mainboard/system76/darp7/cmos.default
A src/mainboard/system76/darp7/cmos.layout
A src/mainboard/system76/darp7/data.vbt
A src/mainboard/system76/darp7/devicetree.cb
A src/mainboard/system76/darp7/dsdt.asl
A src/mainboard/system76/darp7/gpio.h
A src/mainboard/system76/darp7/hda_verb.c
A src/mainboard/system76/darp7/ramstage.c
A src/mainboard/system76/darp7/romstage.c
18 files changed, 921 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/52349/11
--
To view, visit https://review.coreboot.org/c/coreboot/+/52349
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80e5c5375f9d3881fc89a45a91ba68ed2e104a93
Gerrit-Change-Number: 52349
Gerrit-PatchSet: 11
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Shelley Chen, Julius Werner.
Douglas Anderson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56901 )
Change subject: trogdor: Fix "TPM interrupt" lb_gpio to be ACTIVE_HIGH
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
> "latched" means the line is edge triggered and the hardware will set an interrupt flag as soon as it […]
OK, makes sense! ...so something (presumably in coreboot) is in charge of setting whether this cares about rising edges, falling edges, or both and that's abstracted out from here.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56901
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie1586b0e10b64df0712e28552411c4d540a7e457
Gerrit-Change-Number: 56901
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Douglas Anderson <dianders(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Mon, 16 Aug 2021 22:31:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Douglas Anderson <dianders(a)chromium.org>
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment