Nick Vaccaro has submitted this change. ( https://review.coreboot.org/c/coreboot/+/56909 )
Change subject: mb/google/dedede/variant/lantis: Include SPD for MT53E512M32D1NP-046 WT:B
......................................................................
mb/google/dedede/variant/lantis: Include SPD for MT53E512M32D1NP-046 WT:B
Add SPD support to lantis for MT53E512M32D1NP-046 WT:B
BUG=None
BRANCH=firmware-dedede-13606.B
TEST=FW_NAME=lantis emerge-dedede coreboot chromeos-bootimage
Change-Id: I22c50a55dd3b8bbda64ba1b607c8b22cc6592f98
Signed-off-by: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56909
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Karthik Ramasubramanian <kramasub(a)google.com>
---
M src/mainboard/google/dedede/variants/lantis/memory/Makefile.inc
M src/mainboard/google/dedede/variants/lantis/memory/dram_id.generated.txt
M src/mainboard/google/dedede/variants/lantis/memory/mem_parts_used.txt
3 files changed, 3 insertions(+), 12 deletions(-)
Approvals:
build bot (Jenkins): Verified
Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/dedede/variants/lantis/memory/Makefile.inc b/src/mainboard/google/dedede/variants/lantis/memory/Makefile.inc
index f6282bf..a934428 100644
--- a/src/mainboard/google/dedede/variants/lantis/memory/Makefile.inc
+++ b/src/mainboard/google/dedede/variants/lantis/memory/Makefile.inc
@@ -2,4 +2,4 @@
## This is an auto-generated file. Do not edit!!
SPD_SOURCES =
-SPD_SOURCES += lp4x-spd-1.hex # ID = 0(0b0000) Parts = MT53E512M32D2NP-046 WT:E, H9HCNNNBKMMLXR-NEE, K4U6E3S4AA-MGCR
+SPD_SOURCES += lp4x-spd-1.hex # ID = 0(0b0000) Parts = MT53E512M32D2NP-046 WT:E, H9HCNNNBKMMLXR-NEE, K4U6E3S4AA-MGCR, MT53E512M32D1NP-046 WT:B
diff --git a/src/mainboard/google/dedede/variants/lantis/memory/dram_id.generated.txt b/src/mainboard/google/dedede/variants/lantis/memory/dram_id.generated.txt
index 856d016..e8ec694 100644
--- a/src/mainboard/google/dedede/variants/lantis/memory/dram_id.generated.txt
+++ b/src/mainboard/google/dedede/variants/lantis/memory/dram_id.generated.txt
@@ -2,3 +2,4 @@
MT53E512M32D2NP-046 WT:E 0 (0000)
H9HCNNNBKMMLXR-NEE 0 (0000)
K4U6E3S4AA-MGCR 0 (0000)
+MT53E512M32D1NP-046 WT:B 0 (0000)
diff --git a/src/mainboard/google/dedede/variants/lantis/memory/mem_parts_used.txt b/src/mainboard/google/dedede/variants/lantis/memory/mem_parts_used.txt
index 1bcd3da..09ed381 100644
--- a/src/mainboard/google/dedede/variants/lantis/memory/mem_parts_used.txt
+++ b/src/mainboard/google/dedede/variants/lantis/memory/mem_parts_used.txt
@@ -1,14 +1,4 @@
-# This is a CSV file containing a list of memory parts used by this variant.
-# One part per line with an optional fixed ID in column 2.
-# Only include a fixed ID if it is required for legacy reasons!
-# Generated IDs are dependent on the order of parts in this file,
-# so new parts must always be added at the end of the file!
-#
-# Generate an updated Makefile.inc and dram_id.generated.txt by running the
-# gen_part_id tool from util/spd_tools/{ddr4,lp4x}.
-# See util/spd_tools/{ddr4,lp4x}/README.md for more details and instructions.
-
-# Part Name
MT53E512M32D2NP-046 WT:E
H9HCNNNBKMMLXR-NEE
K4U6E3S4AA-MGCR
+MT53E512M32D1NP-046 WT:B
--
To view, visit https://review.coreboot.org/c/coreboot/+/56909
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I22c50a55dd3b8bbda64ba1b607c8b22cc6592f98
Gerrit-Change-Number: 56909
Gerrit-PatchSet: 4
Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Timofey Komarov, Nico Huber, Patrick Rudolph, Maxim Polyakov, Paul Menzel, Thomas Heijligen, Edward O'Callaghan, Michael Niewöhner, Marcello Sylvester Bauer.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50194 )
Change subject: util/liveiso: Add NixOS configs for bootable live systems
......................................................................
Patch Set 29:
(1 comment)
Patchset:
PS4:
> I worked out a solution which allows you using a storage device as boot device but also as persisten […]
Moved to CB:56983 since it seems some more rework, but it shouldn't block this patch.
--
To view, visit https://review.coreboot.org/c/coreboot/+/50194
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaf49d198e99781434bd89d2a8a125a4988b77e1c
Gerrit-Change-Number: 50194
Gerrit-PatchSet: 29
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Marcello Sylvester Bauer <sylv(a)sylv.io>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Timofey Komarov <happycorsair(a)yandex.ru>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Timofey Komarov <happycorsair(a)yandex.ru>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Attention: Marcello Sylvester Bauer <sylv(a)sylv.io>
Gerrit-Comment-Date: Tue, 17 Aug 2021 03:14:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Shelley Chen, Julius Werner.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56965 )
Change subject: device: Move MIPI panel library from mainboard/google/kukui into common
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56965
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I877f2b0c7ab984412b288e2ed27f37cd93c70863
Gerrit-Change-Number: 56965
Gerrit-PatchSet: 4
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Tue, 17 Aug 2021 03:05:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Ian Feng has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56988 )
Change subject: mb/google/dedede/var/corori: Generate RAM ID and SPD file
......................................................................
mb/google/dedede/var/corori: Generate RAM ID and SPD file
Add the support RAM parts for Corori.
Here is the ram part number list:
1. Hynix H9HCNNNBKMMLXR-NEE
2. Samsung K4U6E3S4AA-MGCR
BUG=b:196744958
BRANCH=keeby
TEST=emerge-keeby coreboot
Signed-off-by: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Change-Id: Ia11b5db145deeea838a8f5949accdb11e13342f2
---
M src/mainboard/google/dedede/variants/corori/memory/Makefile.inc
M src/mainboard/google/dedede/variants/corori/memory/dram_id.generated.txt
M src/mainboard/google/dedede/variants/corori/memory/mem_parts_used.txt
3 files changed, 6 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/56988/1
diff --git a/src/mainboard/google/dedede/variants/corori/memory/Makefile.inc b/src/mainboard/google/dedede/variants/corori/memory/Makefile.inc
index b0ca222..315f10f 100644
--- a/src/mainboard/google/dedede/variants/corori/memory/Makefile.inc
+++ b/src/mainboard/google/dedede/variants/corori/memory/Makefile.inc
@@ -1,5 +1,5 @@
## SPDX-License-Identifier: GPL-2.0-or-later
## This is an auto-generated file. Do not edit!!
-## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate.
-SPD_SOURCES = placeholder.spd.hex
+SPD_SOURCES =
+SPD_SOURCES += lp4x-spd-1.hex # ID = 0(0b0000) Parts = H9HCNNNBKMMLXR-NEE, K4U6E3S4AA-MGCR
diff --git a/src/mainboard/google/dedede/variants/corori/memory/dram_id.generated.txt b/src/mainboard/google/dedede/variants/corori/memory/dram_id.generated.txt
index fa24790..d0b9209 100644
--- a/src/mainboard/google/dedede/variants/corori/memory/dram_id.generated.txt
+++ b/src/mainboard/google/dedede/variants/corori/memory/dram_id.generated.txt
@@ -1 +1,3 @@
DRAM Part Name ID to assign
+H9HCNNNBKMMLXR-NEE 0 (0000)
+K4U6E3S4AA-MGCR 0 (0000)
diff --git a/src/mainboard/google/dedede/variants/corori/memory/mem_parts_used.txt b/src/mainboard/google/dedede/variants/corori/memory/mem_parts_used.txt
index e4258b5..ae86d68 100644
--- a/src/mainboard/google/dedede/variants/corori/memory/mem_parts_used.txt
+++ b/src/mainboard/google/dedede/variants/corori/memory/mem_parts_used.txt
@@ -1,11 +1,2 @@
-# This is a CSV file containing a list of memory parts used by this variant.
-# One part per line with an optional fixed ID in column 2.
-# Only include a fixed ID if it is required for legacy reasons!
-# Generated IDs are dependent on the order of parts in this file,
-# so new parts must always be added at the end of the file!
-#
-# Generate an updated Makefile.inc and dram_id.generated.txt by running the
-# gen_part_id tool from util/spd_tools/{ddr4,lp4x}.
-# See util/spd_tools/{ddr4,lp4x}/README.md for more details and instructions.
-
-# Part Name
+H9HCNNNBKMMLXR-NEE
+K4U6E3S4AA-MGCR
--
To view, visit https://review.coreboot.org/c/coreboot/+/56988
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia11b5db145deeea838a8f5949accdb11e13342f2
Gerrit-Change-Number: 56988
Gerrit-PatchSet: 1
Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-MessageType: newchange
Attention is currently required from: Shelley Chen, Julius Werner.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56965 )
Change subject: device: Move MIPI panel library from mainboard/google/kukui into common
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/56965
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I877f2b0c7ab984412b288e2ed27f37cd93c70863
Gerrit-Change-Number: 56965
Gerrit-PatchSet: 4
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Tue, 17 Aug 2021 02:01:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Shelley Chen.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56965 )
Change subject: device: Move MIPI panel library from mainboard/google/kukui into common
......................................................................
Patch Set 4:
(3 comments)
File src/include/device/mipi_panel.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126274):
https://review.coreboot.org/c/coreboot/+/56965/comment/61fbe7ba_56a59405
PS4, Line 39: #define PANEL_DCS(...) \
Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126274):
https://review.coreboot.org/c/coreboot/+/56965/comment/a02b0976_7f7a5678
PS4, Line 44: #define PANEL_GENERIC(...) \
Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126274):
https://review.coreboot.org/c/coreboot/+/56965/comment/ab726074_9b8cbb08
PS4, Line 49: #define PANEL_DELAY(delay) \
Macros with complex values should be enclosed in parentheses
--
To view, visit https://review.coreboot.org/c/coreboot/+/56965
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I877f2b0c7ab984412b288e2ed27f37cd93c70863
Gerrit-Change-Number: 56965
Gerrit-PatchSet: 4
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Comment-Date: Tue, 17 Aug 2021 01:34:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Shelley Chen, Julius Werner.
Hello Hung-Te Lin, Shelley Chen, build bot (Jenkins), Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56965
to look at the new patch set (#4).
Change subject: device: Move MIPI panel library from mainboard/google/kukui into common
......................................................................
device: Move MIPI panel library from mainboard/google/kukui into common
All boards that are trying to use MIPI panels eventually run into the
problem that they need to store physical parameters and a list of DCS
initialization commands for each panel, and these commands can be very
different (e.g. a large amount of very short commands, a few very large
commands, etc.). Finding a data format to fit all these different cases
efficiently into the same structures keeps being a challenge, and the
Kukui mainboard already once put a lot of effort into designing a
clean, flexible and efficient solution for this. This patch moves that
framework into a common src/device/mipi/ library where it can be used by
other boards as well. (Also, this will hopefully allow us to save some
duplicated work when using the same panel on different boards at some
point.)
Signed-off-by: Julius Werner <jwerner(a)chromium.org>
Change-Id: I877f2b0c7ab984412b288e2ed27f37cd93c70863
---
M src/device/Kconfig
M src/device/Makefile.inc
A src/device/mipi/Kconfig
A src/device/mipi/Makefile.inc
A src/device/mipi/panel-AUO_B101UAN08_3.c
R src/device/mipi/panel-AUO_KD101N80_45NA.c
R src/device/mipi/panel-AUO_NT51021D8P.c
A src/device/mipi/panel-BOE_TV080WUM_NG0.c
A src/device/mipi/panel-BOE_TV101WUM_N53.c
A src/device/mipi/panel-BOE_TV101WUM_NG0.c
A src/device/mipi/panel-BOE_TV101WUM_NL6.c
A src/device/mipi/panel-BOE_TV105WUM_NW0.c
A src/device/mipi/panel-CMN_P097PFG_SSD2858.c
A src/device/mipi/panel-INX_OTA7290D10P.c
A src/device/mipi/panel-STA_2081101QFH032011_53G.c
A src/device/mipi/panel.c
A src/include/device/mipi_panel.h
M src/mainboard/google/kukui/Kconfig
M src/mainboard/google/kukui/panel.h
M src/mainboard/google/kukui/panel_anx7625.c
D src/mainboard/google/kukui/panel_params/Makefile.inc
D src/mainboard/google/kukui/panel_params/panel-AUO_B101UAN08_3.c
D src/mainboard/google/kukui/panel_params/panel-BOE_TV080WUM_NG0.c
D src/mainboard/google/kukui/panel_params/panel-BOE_TV101WUM_N53.c
D src/mainboard/google/kukui/panel_params/panel-BOE_TV101WUM_NG0.c
D src/mainboard/google/kukui/panel_params/panel-BOE_TV101WUM_NL6.c
D src/mainboard/google/kukui/panel_params/panel-BOE_TV105WUM_NW0.c
D src/mainboard/google/kukui/panel_params/panel-CMN_P097PFG_SSD2858.c
D src/mainboard/google/kukui/panel_params/panel-INX_OTA7290D10P.c
D src/mainboard/google/kukui/panel_params/panel-STA_2081101QFH032011_53G.c
M src/mainboard/google/kukui/panel_ps8640.c
M src/soc/mediatek/common/dsi.c
M src/soc/mediatek/common/include/soc/dsi_common.h
33 files changed, 2,407 insertions(+), 2,308 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/56965/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/56965
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I877f2b0c7ab984412b288e2ed27f37cd93c70863
Gerrit-Change-Number: 56965
Gerrit-PatchSet: 4
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Shelley Chen.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56965 )
Change subject: device: Move MIPI panel library from mainboard/google/kukui into common
......................................................................
Patch Set 3:
(3 comments)
File src/include/device/mipi_panel.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126272):
https://review.coreboot.org/c/coreboot/+/56965/comment/c8c7744a_6bcb2d35
PS3, Line 39: #define PANEL_DCS(...) \
Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126272):
https://review.coreboot.org/c/coreboot/+/56965/comment/6ca84cad_5558357e
PS3, Line 44: #define PANEL_GENERIC(...) \
Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126272):
https://review.coreboot.org/c/coreboot/+/56965/comment/082da0ad_536c3200
PS3, Line 49: #define PANEL_DELAY(delay) \
Macros with complex values should be enclosed in parentheses
--
To view, visit https://review.coreboot.org/c/coreboot/+/56965
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I877f2b0c7ab984412b288e2ed27f37cd93c70863
Gerrit-Change-Number: 56965
Gerrit-PatchSet: 3
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Comment-Date: Tue, 17 Aug 2021 01:08:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment