Attention is currently required from: Shelley Chen, Julius Werner.
Hello Hung-Te Lin, Shelley Chen, build bot (Jenkins), Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56965
to look at the new patch set (#3).
Change subject: device: Move MIPI panel library from mainboard/google/kukui into common
......................................................................
device: Move MIPI panel library from mainboard/google/kukui into common
All boards that are trying to use MIPI panels eventually run into the
problem that they need to store physical parameters and a list of DCS
initialization commands for each panel, and these commands can be very
different (e.g. a large amount of very short commands, a few very large
commands, etc.). Finding a data format to fit all these different cases
efficiently into the same structures keeps being a challenge, and the
Kukui mainboard already once put a lot of effort into designing a
clean, flexible and efficient solution for this. This patch moves that
framework into a common src/device/mipi/ library where it can be used by
other boards as well. (Also, this will hopefully allow us to save some
duplicated work when using the same panel on different boards at some
point.)
Signed-off-by: Julius Werner <jwerner(a)chromium.org>
Change-Id: I877f2b0c7ab984412b288e2ed27f37cd93c70863
---
M src/device/Kconfig
M src/device/Makefile.inc
A src/device/mipi/Kconfig
A src/device/mipi/Makefile.inc
A src/device/mipi/panel-AUO_B101UAN08_3.c
R src/device/mipi/panel-AUO_KD101N80_45NA.c
R src/device/mipi/panel-AUO_NT51021D8P.c
A src/device/mipi/panel-BOE_TV080WUM_NG0.c
A src/device/mipi/panel-BOE_TV101WUM_N53.c
A src/device/mipi/panel-BOE_TV101WUM_NG0.c
A src/device/mipi/panel-BOE_TV101WUM_NL6.c
A src/device/mipi/panel-BOE_TV105WUM_NW0.c
A src/device/mipi/panel-CMN_P097PFG_SSD2858.c
A src/device/mipi/panel-INX_OTA7290D10P.c
A src/device/mipi/panel-STA_2081101QFH032011_53G.c
A src/device/mipi/panel.c
A src/include/device/mipi_panel.h
M src/mainboard/google/kukui/Kconfig
M src/mainboard/google/kukui/panel.h
M src/mainboard/google/kukui/panel_anx7625.c
D src/mainboard/google/kukui/panel_params/Makefile.inc
D src/mainboard/google/kukui/panel_params/panel-AUO_B101UAN08_3.c
D src/mainboard/google/kukui/panel_params/panel-BOE_TV080WUM_NG0.c
D src/mainboard/google/kukui/panel_params/panel-BOE_TV101WUM_N53.c
D src/mainboard/google/kukui/panel_params/panel-BOE_TV101WUM_NG0.c
D src/mainboard/google/kukui/panel_params/panel-BOE_TV101WUM_NL6.c
D src/mainboard/google/kukui/panel_params/panel-BOE_TV105WUM_NW0.c
D src/mainboard/google/kukui/panel_params/panel-CMN_P097PFG_SSD2858.c
D src/mainboard/google/kukui/panel_params/panel-INX_OTA7290D10P.c
D src/mainboard/google/kukui/panel_params/panel-STA_2081101QFH032011_53G.c
M src/soc/mediatek/common/dsi.c
M src/soc/mediatek/common/include/soc/dsi_common.h
32 files changed, 2,406 insertions(+), 2,307 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/56965/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/56965
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I877f2b0c7ab984412b288e2ed27f37cd93c70863
Gerrit-Change-Number: 56965
Gerrit-PatchSet: 3
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Malik Hsu, Paul Menzel.
Malik Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56981 )
Change subject: mb/google/brya/variants/primus: Fix GL9755S power sequence
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56981/comment/91b44ec5_fb7ebd84
PS1, Line 7: mb/google/brya/variants/primus: Fix GL9755S SD card reader power
: sequence
> comment header must be 72 chars wide maximum, suggestion: […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56981
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I33c17e88cabdc9b13634fc8f341aa6a09b7bfde5
Gerrit-Change-Number: 56981
Gerrit-PatchSet: 3
Gerrit-Owner: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-Attention: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Tue, 17 Aug 2021 00:58:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Shelley Chen, Julius Werner.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56965 )
Change subject: device: Move MIPI panel library from mainboard/google/kukui into common
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
src/mainboard/google/kukui/panel_anx7625.c:17:12: error: 'INIT_END_CMD' undeclared here
--
To view, visit https://review.coreboot.org/c/coreboot/+/56965
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I877f2b0c7ab984412b288e2ed27f37cd93c70863
Gerrit-Change-Number: 56965
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Tue, 17 Aug 2021 00:55:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Shelley Chen, Julius Werner.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56965 )
Change subject: device: Move MIPI panel library from mainboard/google/kukui into common
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/56965
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I877f2b0c7ab984412b288e2ed27f37cd93c70863
Gerrit-Change-Number: 56965
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Tue, 17 Aug 2021 00:53:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Ricardo Quesada.
Hello build bot (Jenkins), Furquan Shaikh, Jack Rosenthal,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56883
to look at the new patch set (#6).
Change subject: elogtool: add "clear" command
......................................................................
elogtool: add "clear" command
Adds "clear" command to cbfsutil/elogtool tool.
"clear" clears the RW_ELOG using flashrom with ELOG_TYPE_EOL.
And inserts a ELOG_TYPE_LOG_CLEAR event.
Additionally, it does a minor cleanup to command "list", like:
* use buffer_end()
* add "list" to the cmds struct
* and make elog_read() very similar to elog_write()
Usage:
$ elogtool clear
BUG=b:172210863
Change-Id: Ia28a6eb34c82103ab078a0841b022e2e5e430585
Signed-off-by: Ricardo Quesada <ricardoq(a)google.com>
---
M util/cbfstool/elogtool.c
M util/cbfstool/eventlog.c
M util/cbfstool/eventlog.h
3 files changed, 161 insertions(+), 36 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/56883/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/56883
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia28a6eb34c82103ab078a0841b022e2e5e430585
Gerrit-Change-Number: 56883
Gerrit-PatchSet: 6
Gerrit-Owner: Ricardo Quesada <ricardoq(a)google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org>
Gerrit-Reviewer: Ricardo Quesada <ricardoq(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Ricardo Quesada <ricardoq(a)google.com>
Gerrit-MessageType: newpatchset