coreboot-gerrit July 2021

coreboot-gerrit@coreboot.org

1 participants
5824 discussions

Change in coreboot[master]: drivers/intel/usb4/retimer: Update code to assign correct port number
by Maulik V Vaghela (Code Review) 01 Jul '21

01 Jul '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak. Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55945 ) Change subject: drivers/intel/usb4/retimer: Update code to assign correct port number ...................................................................... Patch Set 1: (1 comment) File src/drivers/intel/usb4/retimer/chip.h: https://review.coreboot.org/c/coreboot/+/55945/comment/eaad25ac_d7ae56a9 PS1, Line 20: uint8_t controller; > It looks like this is only used to calculate the USB port number. […] Ohk..this is good. Thank you Tim..wasn't aware we can do that. :) -- To view, visit https://review.coreboot.org/c/coreboot/+/55945 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib11637ae39046e0afdacd33bc34e8a59e6f2bfb1 Gerrit-Change-Number: 55945 Gerrit-PatchSet: 1 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Abhijeet Rao <abhijeet.rao(a)intel.corp-partner.google.com> Gerrit-CC: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-CC: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Thu, 01 Jul 2021 06:14:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/jsl: Control Fivr bypass mode by DisableExternalVnnVcc1p05B...
by Simon Yang (Code Review) 01 Jul '21

01 Jul '21

Attention is currently required from: Paul Menzel. Simon Yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55744 ) Change subject: soc/intel/jsl: Control Fivr bypass mode by DisableExternalVnnVcc1p05BypassMode config ...................................................................... Patch Set 9: (6 comments) This change is ready for review. Commit Message: https://review.coreboot.org/c/coreboot/+/55744/comment/d3b204c1_c7b5f29f PS7, Line 8: > Please elaborate, what the problem is. Done Patchset: PS9: Hi Paul, Sorry for the mistakes, I just push wrong changes to review. Thanks to your kindly reminding. I just made a new change to correct them, if you have time please correct me if anything still not perfect one. BTW, I am also changing the config name after discussed internally. Simon File src/soc/intel/jasperlake/chip.h: https://review.coreboot.org/c/coreboot/+/55744/comment/2f56b517_c15d99be PS7, Line 23: #define MAX_HD_AUDIO_SSP_LINKS 6 > Please revert this (unrelated) hunk. Done https://review.coreboot.org/c/coreboot/+/55744/comment/ff62e38e_1ff573ab PS7, Line 408: do > does Done File src/soc/intel/jasperlake/fsp_params.c: https://review.coreboot.org/c/coreboot/+/55744/comment/c6e6e6f7_a0358df2 PS7, Line 69: params->CpuMpPpi = (uintptr_t)mp_fill_ppi_services_data(); > Unrelated. Done https://review.coreboot.org/c/coreboot/+/55744/comment/d55899c8_8118f315 PS7, Line 186: config->PchPmSlpAMinAssert, config->PchPmPwrCycDur); > Unrelated. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/55744 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10bc203d3fed32ab65f325978426b7d0fca6f392 Gerrit-Change-Number: 55744 Gerrit-PatchSet: 9 Gerrit-Owner: Simon Yang <simon1.yang(a)intel.com> Gerrit-Reviewer: Jamie Chen <jamie.chen(a)intel.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Thu, 01 Jul 2021 06:09:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: selfboot: Add support for selfload in romstage
by Paul Menzel (Code Review) 01 Jul '21

01 Jul '21

Attention is currently required from: Shelley Chen, Ravi kumar, mturney mturney. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55865 ) Change subject: selfboot: Add support for selfload in romstage ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/55865/comment/5a2a4047_6f14224d PS4, Line 11: > This is the error. I don't think that this needs to be in the commit message: […] From the paste `undefined reference to `bootmem_region_targets_type'` could be added to the commit message. -- To view, visit https://review.coreboot.org/c/coreboot/+/55865 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8dfa2f2079a9a2859114c53c22bf7ef466ac2ad9 Gerrit-Change-Number: 55865 Gerrit-PatchSet: 5 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org> Gerrit-Comment-Date: Thu, 01 Jul 2021 05:44:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Shelley Chen <shchen(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/block/cse: Add ME EOP timestamps
by Subrata Banik (Code Review) 01 Jul '21

01 Jul '21

Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55774 ) Change subject: soc/intel/common/block/cse: Add ME EOP timestamps ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/55774 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0376610c5cbae7df1bf1a927b3bc99b1022de4cb Gerrit-Change-Number: 55774 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 01 Jul 2021 05:38:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Add HANG_DETECT host event to EC S0ix wake mask
by Paul Menzel (Code Review) 01 Jul '21

01 Jul '21

Attention is currently required from: Tim Wawrzynczak, Boris Mittelberg. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55988 ) Change subject: mb/google/brya: Add HANG_DETECT host event to EC S0ix wake mask ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/55988/comment/f6bb14de_7815fbda PS1, Line 10: BIOS BIOS means coreboot? -- To view, visit https://review.coreboot.org/c/coreboot/+/55988 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2c699114abcd9a045a41858c731e4b6fe99d3000 Gerrit-Change-Number: 55988 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Thu, 01 Jul 2021 05:37:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/block/cse: Add ME EOP timestamps
by Paul Menzel (Code Review) 01 Jul '21

01 Jul '21

Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55774 ) Change subject: soc/intel/common/block/cse: Add ME EOP timestamps ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/55774 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0376610c5cbae7df1bf1a927b3bc99b1022de4cb Gerrit-Change-Number: 55774 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 01 Jul 2021 05:36:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/hatch/scout: update gpios and device tree
by Jeff Chase (Code Review) 01 Jul '21

01 Jul '21

Jeff Chase has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55922 ) Change subject: mb/google/hatch/scout: update gpios and device tree ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Could you please assist by submitting this change for us? -- To view, visit https://review.coreboot.org/c/coreboot/+/55922 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3cb9cf515ab7a4a0ebbee249644dd3f133d8735 Gerrit-Change-Number: 55922 Gerrit-PatchSet: 1 Gerrit-Owner: Jeff Chase <jnchase(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Joe Tessler <jrt(a)google.com> Gerrit-Comment-Date: Thu, 01 Jul 2021 04:59:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/cret: Disable SDCard controller
by Karthik Ramasubramanian (Code Review) 01 Jul '21

01 Jul '21

Attention is currently required from: Dtrain Hsu, Henry Sun, Ben Kao. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55935 ) Change subject: mb/google/dedede/var/cret: Disable SDCard controller ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: > Thank you for review. […] Thanks for confirming that the GPIOs are configured as NC. -- To view, visit https://review.coreboot.org/c/coreboot/+/55935 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I889f0545883aa75813dd91dc3e6a4dcfc246687f Gerrit-Change-Number: 55935 Gerrit-PatchSet: 1 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Ben Kao <ben.kao(a)intel.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Ben Kao <ben.kao(a)intel.com> Gerrit-Comment-Date: Thu, 01 Jul 2021 03:54:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/cret: Disable SDCard controller
by Dtrain Hsu (Code Review) 01 Jul '21

01 Jul '21

Attention is currently required from: Henry Sun, Ben Kao, Karthik Ramasubramanian. Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55935 ) Change subject: mb/google/dedede/var/cret: Disable SDCard controller ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Should we also configure the SD Card GPIOs as PAD_NC for Cret? Thank you for review. CB:51629 set GPP_H1, GPP_G0 ~ GPP_G7 to PAD_NC already, -- To view, visit https://review.coreboot.org/c/coreboot/+/55935 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I889f0545883aa75813dd91dc3e6a4dcfc246687f Gerrit-Change-Number: 55935 Gerrit-PatchSet: 1 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Ben Kao <ben.kao(a)intel.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Ben Kao <ben.kao(a)intel.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 01 Jul 2021 03:48:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Create redrix variant
by Wisley Chen (Code Review) 01 Jul '21

01 Jul '21

Attention is currently required from: Chen Wisley, Tim Wawrzynczak. Wisley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55883 ) Change subject: mb/google/brya: Create redrix variant ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Hi Tim/Nick, Please help to review again. Thanks -- To view, visit https://review.coreboot.org/c/coreboot/+/55883 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4cfa0bd84e1ba9f8140f95d18a6da960da8124ad Gerrit-Change-Number: 55883 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Thu, 01 Jul 2021 01:00:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2021