Attention is currently required from: Shelley Chen, Ravi kumar, mturney mturney.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55865 )
Change subject: selfboot: Add support for selfload in romstage
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55865/comment/5a2a4047_6f14224d
PS4, Line 11:
> This is the error. I don't think that this needs to be in the commit message: […]
From the paste `undefined reference to `bootmem_region_targets_type'` could be added to the commit message.
--
To view, visit https://review.coreboot.org/c/coreboot/+/55865
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8dfa2f2079a9a2859114c53c22bf7ef466ac2ad9
Gerrit-Change-Number: 55865
Gerrit-PatchSet: 5
Gerrit-Owner: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Comment-Date: Thu, 01 Jul 2021 05:44:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen <shchen(a)google.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55774 )
Change subject: soc/intel/common/block/cse: Add ME EOP timestamps
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/55774
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0376610c5cbae7df1bf1a927b3bc99b1022de4cb
Gerrit-Change-Number: 55774
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Thu, 01 Jul 2021 05:38:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Boris Mittelberg.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55988 )
Change subject: mb/google/brya: Add HANG_DETECT host event to EC S0ix wake mask
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55988/comment/f6bb14de_7815fbda
PS1, Line 10: BIOS
BIOS means coreboot?
--
To view, visit https://review.coreboot.org/c/coreboot/+/55988
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2c699114abcd9a045a41858c731e4b6fe99d3000
Gerrit-Change-Number: 55988
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Comment-Date: Thu, 01 Jul 2021 05:37:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55774 )
Change subject: soc/intel/common/block/cse: Add ME EOP timestamps
......................................................................
Patch Set 6: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/55774
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0376610c5cbae7df1bf1a927b3bc99b1022de4cb
Gerrit-Change-Number: 55774
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Thu, 01 Jul 2021 05:36:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Jeff Chase has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55922 )
Change subject: mb/google/hatch/scout: update gpios and device tree
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Could you please assist by submitting this change for us?
--
To view, visit https://review.coreboot.org/c/coreboot/+/55922
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic3cb9cf515ab7a4a0ebbee249644dd3f133d8735
Gerrit-Change-Number: 55922
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Chase <jnchase(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Joe Tessler <jrt(a)google.com>
Gerrit-Comment-Date: Thu, 01 Jul 2021 04:59:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Dtrain Hsu, Henry Sun, Ben Kao.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55935 )
Change subject: mb/google/dedede/var/cret: Disable SDCard controller
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
> Thank you for review. […]
Thanks for confirming that the GPIOs are configured as NC.
--
To view, visit https://review.coreboot.org/c/coreboot/+/55935
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I889f0545883aa75813dd91dc3e6a4dcfc246687f
Gerrit-Change-Number: 55935
Gerrit-PatchSet: 1
Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Ben Kao <ben.kao(a)intel.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Ben Kao <ben.kao(a)intel.com>
Gerrit-Comment-Date: Thu, 01 Jul 2021 03:54:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Henry Sun, Ben Kao, Karthik Ramasubramanian.
Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55935 )
Change subject: mb/google/dedede/var/cret: Disable SDCard controller
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Should we also configure the SD Card GPIOs as PAD_NC for Cret?
Thank you for review.
CB:51629 set GPP_H1, GPP_G0 ~ GPP_G7 to PAD_NC already,
--
To view, visit https://review.coreboot.org/c/coreboot/+/55935
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I889f0545883aa75813dd91dc3e6a4dcfc246687f
Gerrit-Change-Number: 55935
Gerrit-PatchSet: 1
Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Ben Kao <ben.kao(a)intel.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Ben Kao <ben.kao(a)intel.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Thu, 01 Jul 2021 03:48:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Chen Wisley.
Wisley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55885 )
Change subject: mb/google/brya/var/redrix: Generate SPD ID for supported parts
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
Hi Tim/Nick,
Please help to review again.
Thanks
--
To view, visit https://review.coreboot.org/c/coreboot/+/55885
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62ee401e43bef22b4b09f41ea59bbdbc479f293c
Gerrit-Change-Number: 55885
Gerrit-PatchSet: 5
Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Chen Wisley <wisley.chen(a)quantatw.com>
Gerrit-Comment-Date: Thu, 01 Jul 2021 01:00:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Wisley Chen.
Hello build bot (Jenkins), Tim Wawrzynczak, Nick Vaccaro, Wisley Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/55885
to look at the new patch set (#5).
Change subject: mb/google/brya/var/redrix: Generate SPD ID for supported parts
......................................................................
mb/google/brya/var/redrix: Generate SPD ID for supported parts
Add supported memory parts in mem_parts_used.txt, and generate
SPD id for these parts.
MT53E1G32D2NP-046 WT:A
H9HCNNNBKMMLXR-NEE
K4U6E3S4AA-MGCR
MT53E512M32D2NP-046 WT:E
H9HCNNNCPMMLXR-NEE
K4UBE3D4AA-MGCR
H9HCNNNFAMMLXR-NEE
MT53E2G32D4NQ-046 WT:A
BUG=b:190818098, b:190874372
TEST=build
Change-Id: I62ee401e43bef22b4b09f41ea59bbdbc479f293c
Signed-off-by: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/brya/variants/redrix/memory/Makefile.inc
M src/mainboard/google/brya/variants/redrix/memory/dram_id.generated.txt
M src/mainboard/google/brya/variants/redrix/memory/mem_parts_used.txt
3 files changed, 22 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/55885/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/55885
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62ee401e43bef22b4b09f41ea59bbdbc479f293c
Gerrit-Change-Number: 55885
Gerrit-PatchSet: 5
Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset