Attention is currently required from: Stefan Reinauer, David Hendricks, Angel Pons, Public Gerrit, Werner Zeh.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51208 )
Change subject: Add public gerrit account
......................................................................
Patch Set 4:
(1 comment)
File Documentation/getting_started/gerrit_guidelines.md:
https://review.coreboot.org/c/coreboot/+/51208/comment/08e88b74_786d1f79
PS4, Line 323: edit anonymous
> This account is unlikely to be used inappropriately. […]
I think it might be better to create a web interface than to just publish a username/password. We could control what the account can do significantly better than through this method. We wouldn't have to worry about commenting or one user of public_gerrit deleting another public_gerrit user's commits, as could happen now.
David, would it make you more comfortable if we restricted the account with a check in the builders? It would be pretty easy to add a check to make sure that this account only edits .md files, or it would get a -1 on verification.
I'd also rephrase this to highlight ease of use instead of anonymity - "If you want to contribute documentation without needing to create a gerrit account..."
--
To view, visit https://review.coreboot.org/c/coreboot/+/51208
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibf6d7c47bba10d89956cbb683b8da2e8e04e269d
Gerrit-Change-Number: 51208
Gerrit-PatchSet: 4
Gerrit-Owner: Public Gerrit <public-gerrit(a)guerrillamail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <reinauer(a)chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Stefan Reinauer <reinauer(a)chromium.org>
Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Public Gerrit <public-gerrit(a)guerrillamail.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Comment-Date: Fri, 02 Jul 2021 16:33:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com>
Comment-In-Reply-To: Public Gerrit <public-gerrit(a)guerrillamail.com>
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56045 )
Change subject: device/resource_allocator_v4: Only highlight log message with ===
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56045
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40c3876e1f895b7f9771479234c9529cca2b97ba
Gerrit-Change-Number: 56045
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Fri, 02 Jul 2021 16:32:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Arthur Heymans, Patrick Rudolph.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56017 )
Change subject: [WIP]Documentation: Improve x86_64
......................................................................
Patch Set 2:
(1 comment)
File Documentation/arch/x86/x86_64.md:
https://review.coreboot.org/c/coreboot/+/56017/comment/581baf8d_0a648ab1
PS2, Line 92: Fix running MRC.bin (Sandy Bridge / Haswell boards)
> The mrc.bin call back into coreboot for console. You'd need a wrapper for that too.
yes, but I'm not sure if it's worth the effort.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56017
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia5ba51be629a8c878aad64d3297176457cf8e855
Gerrit-Change-Number: 56017
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Fri, 02 Jul 2021 16:17:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Karthik Ramasubramanian.
Hello build bot (Jenkins), Tim Wawrzynczak, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/55846
to look at the new patch set (#3).
Change subject: Documentation/drivers/dptf: Add oem variables support
......................................................................
Documentation/drivers/dptf: Add oem variables support
Add oem variables information with usage example.
BRANCH=None
BUG=b:187253038
TEST=Built and tested on dedede board
Change-Id: I45db17f6ee3328da28f985c6854d65a430c9c61b
Signed-off-by: Sumeet Pawnikar <sumeet.r.pawnikar(a)intel.com>
---
M Documentation/drivers/dptf.md
1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/55846/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/55846
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45db17f6ee3328da28f985c6854d65a430c9c61b
Gerrit-Change-Number: 55846
Gerrit-PatchSet: 3
Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tim Wawrzynczak, Karthik Ramasubramanian.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55846 )
Change subject: Documentation/drivers/dptf: Add oem variables support
......................................................................
Patch Set 2:
(1 comment)
File Documentation/drivers/dptf.md:
https://review.coreboot.org/c/coreboot/+/55846/comment/36b60170_2fee8e96
PS2, Line 321:
> Can you give an example of how and why OEM variables are used?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/55846
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45db17f6ee3328da28f985c6854d65a430c9c61b
Gerrit-Change-Number: 55846
Gerrit-PatchSet: 2
Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Fri, 02 Jul 2021 16:01:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment