coreboot-gerrit July 2021

coreboot-gerrit@coreboot.org

1 participants
5824 discussions

Change in coreboot[master]: mb/google/dedede: Fix the pointer/address used in memcpy
by Karthik Ramasubramanian (Code Review) 02 Jul '21

02 Jul '21

Attention is currently required from: Martin Roth, Evan Green, Paul Menzel. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56046 ) Change subject: mb/google/dedede: Fix the pointer/address used in memcpy ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/56046/comment/11be5849_c6876072 PS2, Line 12: memcpy. This issue is caught during coverity scan CID: 1458054, 1458053. > Please use the tag Found-by. Done https://review.coreboot.org/c/coreboot/+/56046/comment/dfd82bed_e98d44e1 PS2, Line 17: function. > Were there any functional issues? Not that I am aware of since the original CL (CB:54671) landed very recently - just couple of days back. There was a refactoring in that CL where the bug got introduced. -- To view, visit https://review.coreboot.org/c/coreboot/+/56046 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79d6d9af03acd59ab5e1cd7df97bf451011dfeaa Gerrit-Change-Number: 56046 Gerrit-PatchSet: 3 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Evan Green <evgreen(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Henry Sun <henrysun(a)google.com> Gerrit-CC: Kevin Chiu <kevin.chiu(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Evan Green <evgreen(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Fri, 02 Jul 2021 21:30:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede: Fix the pointer/address used in memcpy
by Karthik Ramasubramanian (Code Review) 02 Jul '21

02 Jul '21

Attention is currently required from: Martin Roth, Evan Green, Karthik Ramasubramanian. Hello build bot (Jenkins), Furquan Shaikh, Martin Roth, Evan Green, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56046 to look at the new patch set (#3). Change subject: mb/google/dedede: Fix the pointer/address used in memcpy ...................................................................... mb/google/dedede: Fix the pointer/address used in memcpy The caller is already passing the address to the required LTE reset and enable GPIO. During memcpy, the address to that pointer is used which will lead to copying undefined data. Fix the pointer/address used in memcpy. BUG=None BRANCH=dedede TEST=Build Kracko, Drawcia and Metaknight mainboards which use this function. Change-Id: I79d6d9af03acd59ab5e1cd7df97bf451011dfeaa Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com> Found-by: Coverity CID 1458053, 1458054. --- M src/mainboard/google/dedede/variants/baseboard/ramstage.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/56046/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/56046 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79d6d9af03acd59ab5e1cd7df97bf451011dfeaa Gerrit-Change-Number: 56046 Gerrit-PatchSet: 3 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Evan Green <evgreen(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Henry Sun <henrysun(a)google.com> Gerrit-CC: Kevin Chiu <kevin.chiu(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Evan Green <evgreen(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/dedede: Fix the pointer/address used in memcpy
by Paul Menzel (Code Review) 02 Jul '21

02 Jul '21

Attention is currently required from: Martin Roth, Evan Green, Karthik Ramasubramanian. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56046 ) Change subject: mb/google/dedede: Fix the pointer/address used in memcpy ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/56046/comment/b926f5d0_bb892f9a PS2, Line 12: memcpy. This issue is caught during coverity scan CID: 1458054, 1458053. Please use the tag Found-by. https://review.coreboot.org/c/coreboot/+/56046/comment/d3c5b357_1f1c2881 PS2, Line 17: function. Were there any functional issues? -- To view, visit https://review.coreboot.org/c/coreboot/+/56046 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79d6d9af03acd59ab5e1cd7df97bf451011dfeaa Gerrit-Change-Number: 56046 Gerrit-PatchSet: 2 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Evan Green <evgreen(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Henry Sun <henrysun(a)google.com> Gerrit-CC: Kevin Chiu <kevin.chiu(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Evan Green <evgreen(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Fri, 02 Jul 2021 21:20:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede: Fix the pointer/address used in memcpy
by Furquan Shaikh (Code Review) 02 Jul '21

02 Jul '21

Attention is currently required from: Martin Roth, Evan Green, Karthik Ramasubramanian. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56046 ) Change subject: mb/google/dedede: Fix the pointer/address used in memcpy ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56046 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79d6d9af03acd59ab5e1cd7df97bf451011dfeaa Gerrit-Change-Number: 56046 Gerrit-PatchSet: 2 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Evan Green <evgreen(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Henry Sun <henrysun(a)google.com> Gerrit-CC: Kevin Chiu <kevin.chiu(a)quanta.corp-partner.google.com> Gerrit-CC: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Evan Green <evgreen(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Fri, 02 Jul 2021 20:56:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede: Fix the pointer/address used in memcpy
by Karthik Ramasubramanian (Code Review) 02 Jul '21

02 Jul '21

Karthik Ramasubramanian has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/56046 ) Change subject: mb/google/dedede: Fix the pointer/address used in memcpy ...................................................................... mb/google/dedede: Fix the pointer/address used in memcpy The caller is already passing the address to the required LTE reset and enable GPIO. During memcpy, the address to that pointer is used which will lead to copying undefined data. Fix the pointer/address used in memcpy. This issue is caught during coverity scan CID: 1458054, 1458053. BUG=None BRANCH=dedede TEST=Build Kracko, Drawcia and Metaknight mainboards which use this function. Change-Id: I79d6d9af03acd59ab5e1cd7df97bf451011dfeaa Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com> --- M src/mainboard/google/dedede/variants/baseboard/ramstage.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/56046/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56046 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79d6d9af03acd59ab5e1cd7df97bf451011dfeaa Gerrit-Change-Number: 56046 Gerrit-PatchSet: 2 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/dedede: Fix the pointer/address used in memcpy
by Karthik Ramasubramanian (Code Review) 02 Jul '21

02 Jul '21

Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56046 ) Change subject: mb/google/dedede: Fix the pointer/address used in memcpy ...................................................................... mb/google/dedede: Fix the pointer/address used in memcpy The caller is already passing the address to the required LTE reset and enable GPIO. During memcpy, the address to that pointer is used which will lead to copying undefined data. Fix the pointer/address used in memcpy. BUG=None TEST=Build Kracko, Drawcia and Metaknight mainboards which use this function. Change-Id: I79d6d9af03acd59ab5e1cd7df97bf451011dfeaa Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com> --- M src/mainboard/google/dedede/variants/baseboard/ramstage.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/56046/1 diff --git a/src/mainboard/google/dedede/variants/baseboard/ramstage.c b/src/mainboard/google/dedede/variants/baseboard/ramstage.c index 136fe13..aedaa3f 100644 --- a/src/mainboard/google/dedede/variants/baseboard/ramstage.c +++ b/src/mainboard/google/dedede/variants/baseboard/ramstage.c @@ -35,10 +35,10 @@ config->type = UPC_TYPE_INTERNAL; if (port->path.usb.port_type == LTE_USB_PORT_TYPE) { config->has_power_resource = 1; - memcpy(&config->reset_gpio, &lte_reset_gpio, + memcpy(&config->reset_gpio, lte_reset_gpio, sizeof(config->reset_gpio)); config->reset_off_delay_ms = 20; - memcpy(&config->enable_gpio, &lte_enable_gpio, + memcpy(&config->enable_gpio, lte_enable_gpio, sizeof(config->enable_gpio)); config->enable_delay_ms = 20; } -- To view, visit https://review.coreboot.org/c/coreboot/+/56046 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79d6d9af03acd59ab5e1cd7df97bf451011dfeaa Gerrit-Change-Number: 56046 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: timestamp,vc/google/chromeos/cr50: Add timestamp for enable update
by Karthik Ramasubramanian (Code Review) 02 Jul '21

02 Jul '21

Attention is currently required from: Raul Rangel, Furquan Shaikh, Marshall Dawson, Tim Wawrzynczak, Felix Held. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55402 ) Change subject: timestamp,vc/google/chromeos/cr50: Add timestamp for enable update ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/55402 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I522d0638a4a6ae9624965e49b47bca8743c3206c Gerrit-Change-Number: 55402 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 02 Jul 2021 19:50:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP]Documentation: Improve x86_64
by Paul Menzel (Code Review) 02 Jul '21

02 Jul '21

Attention is currently required from: Patrick Rudolph, Arthur Heymans. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56017 ) Change subject: [WIP]Documentation: Improve x86_64 ...................................................................... Patch Set 2: (6 comments) File Documentation/arch/x86/x86_64.md: https://review.coreboot.org/c/coreboot/+/56017/comment/0dd8a093_067401ec PS2, Line 3: contains documentation about documents https://review.coreboot.org/c/coreboot/+/56017/comment/019411f9_8ca79179 PS2, Line 10: *hack* Maybe put it in quotes: “hacks”. https://review.coreboot.org/c/coreboot/+/56017/comment/5798cddf_e8ba1beb PS2, Line 27: instructions, which are not only slower, but also increase code size. As you have a blank line above, I’d separate the items by a blank line. https://review.coreboot.org/c/coreboot/+/56017/comment/844a55bc_02963cf0 PS2, Line 28: pagetables Above you spell it as two words. https://review.coreboot.org/c/coreboot/+/56017/comment/c0e94e0e_e3246bef PS2, Line 36: constrains constraints https://review.coreboot.org/c/coreboot/+/56017/comment/d05fcedd_dd2c79f1 PS2, Line 37: constrains constraints -- To view, visit https://review.coreboot.org/c/coreboot/+/56017 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia5ba51be629a8c878aad64d3297176457cf8e855 Gerrit-Change-Number: 56017 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 02 Jul 2021 19:50:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/usb4/retimer: remove redundant member PLD
by Paul Menzel (Code Review) 02 Jul '21

02 Jul '21

Attention is currently required from: Furquan Shaikh, Maulik V Vaghela, Tim Wawrzynczak, John Zhao. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56025 ) Change subject: drivers/intel/usb4/retimer: remove redundant member PLD ...................................................................... Patch Set 5: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/56025/comment/759275f6_85f37429 PS5, Line 9: We we https://review.coreboot.org/c/coreboot/+/56025/comment/df9932a2_262daddd PS5, Line 10: removing remove https://review.coreboot.org/c/coreboot/+/56025/comment/a7ae578c_7ade56c3 PS5, Line 10: and devicetree need not fill PLD structure now … so the devicetree does not need to fill the PLD structure anymore. https://review.coreboot.org/c/coreboot/+/56025/comment/f44f5f33_b03c3aba PS5, Line 11: redundant obsolete -- To view, visit https://review.coreboot.org/c/coreboot/+/56025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a561677ab65ddb870d1b00b35ee9d7a22ef9c70 Gerrit-Change-Number: 56025 Gerrit-PatchSet: 5 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: John Zhao <john.zhao(a)intel.com> Gerrit-Comment-Date: Fri, 02 Jul 2021 19:45:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Add GFx Device ID 0x46a6
by Paul Menzel (Code Review) 02 Jul '21

02 Jul '21

Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Patrick Rudolph. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56026 ) Change subject: soc/intel/alderlake: Add GFx Device ID 0x46a6 ...................................................................... Patch Set 1: (1 comment) File src/include/device/pci_ids.h: https://review.coreboot.org/c/coreboot/+/56026/comment/95ff6179_dd71bc71 PS1, Line 3821: #define PCI_DEVICE_ID_INTEL_ADL_P_GT2_6 0x46a6 Please sort by the id. -- To view, visit https://review.coreboot.org/c/coreboot/+/56026 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8ca875c7faf2997d207aff9e292f94a3b6311e94 Gerrit-Change-Number: 56026 Gerrit-PatchSet: 1 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 02 Jul 2021 19:44:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2021