coreboot-gerrit July 2021

coreboot-gerrit@coreboot.org

1 participants
5824 discussions

Change in coreboot[master]: supermicro/x11-lga1151-series: Remove SkipExtGfxScan = 1
by Jan Tatje (Code Review) 05 Jul '21

05 Jul '21

Attention is currently required from: Michael Niewöhner. Jan Tatje has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56071 ) Change subject: supermicro/x11-lga1151-series: Remove SkipExtGfxScan = 1 ...................................................................... Patch Set 3: (2 comments) Patchset: PS2: > hmm, interesting. could you share your . […] I just set MAINBOARD_DO_NATIVE_VGA_INIT and VGA_TEXT_FRAMEBUFFER, it's using drivers/aspeed/ast2050. File src/mainboard/supermicro/x11-lga1151-series/devicetree.cb: https://review.coreboot.org/c/coreboot/+/56071/comment/faf7e9ea_488ed665 PS2, Line 4: register "SkipExtGfxScan" = "0" > rather drop the whole line, since 0 is the default anyways Done -- To view, visit https://review.coreboot.org/c/coreboot/+/56071 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I41249112c65927b61ca5f791f8eb8c3f3d204fce Gerrit-Change-Number: 56071 Gerrit-PatchSet: 3 Gerrit-Owner: Jan Tatje <jan(a)jnt.io> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Mon, 05 Jul 2021 12:46:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Add two sensors for DPTF functionality
by Sumeet R Pawnikar (Code Review) 05 Jul '21

05 Jul '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Aaron Durbin, Karthik Ramasubramanian. Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Aaron Durbin, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/54724 to look at the new patch set (#2). Change subject: mb/google/brya: Add two sensors for DPTF functionality ...................................................................... mb/google/brya: Add two sensors for DPTF functionality Add two thermal sensors for fan and wwan for DPTF based thermal control. BRANCH=None BUG=b:181271666 TEST=None Change-Id: Idc9bd6040c9bb316ec7e314f5e9c937c75cfc95a Signed-off-by: Sumeet Pawnikar <sumeet.r.pawnikar(a)intel.com> --- M src/mainboard/google/brya/variants/brya0/overridetree.cb 1 file changed, 16 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/54724/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/54724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc9bd6040c9bb316ec7e314f5e9c937c75cfc95a Gerrit-Change-Number: 54724 Gerrit-PatchSet: 2 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: [TESTME] mb/prodrive/hermes: Update HDA codec subvendor ID
by Angel Pons (Code Review) 05 Jul '21

05 Jul '21

Attention is currently required from: wouter.eckhardt(a)prodrive-technologies.com, Justin van Son, Patrick Rudolph, Christian Walter. Hello wouter.eckhardt(a)prodrive-technologies.com, build bot (Jenkins), Justin van Son, Patrick Rudolph, Christian Walter, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56086 to look at the new patch set (#2). Change subject: [TESTME] mb/prodrive/hermes: Update HDA codec subvendor ID ...................................................................... [TESTME] mb/prodrive/hermes: Update HDA codec subvendor ID Change-Id: I72be8bde59d9eb0c1eff8c65dc734c6805732e09 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/prodrive/hermes/variants/baseboard/hda_verb.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/56086/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56086 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72be8bde59d9eb0c1eff8c65dc734c6805732e09 Gerrit-Change-Number: 56086 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Justin van Son <justin.van.son(a)prodrive-technologies.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: wouter.eckhardt(a)prodrive-technologies.com Gerrit-Attention: wouter.eckhardt(a)prodrive-technologies.com Gerrit-Attention: Justin van Son <justin.van.son(a)prodrive-technologies.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/siemens/mc_ehl: Switch to 16 MB ROM and provide a flashmap
by Werner Zeh (Code Review) 05 Jul '21

05 Jul '21

Attention is currently required from: Arthur Heymans. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56035 ) Change subject: mb/siemens/mc_ehl: Switch to 16 MB ROM and provide a flashmap ...................................................................... Patch Set 3: (2 comments) File src/mainboard/siemens/mc_ehl/mc_ehl.fmd: https://review.coreboot.org/c/coreboot/+/56035/comment/5692c5cf_68b149a5 PS2, Line 9: 0xbefe00 > Cool, this is new to me. Nice feature, will change. Done File src/mainboard/siemens/mc_ehl/variants/mc_ehl1/Kconfig: https://review.coreboot.org/c/coreboot/+/56035/comment/0c315df3_37176cb1 PS2, Line 3: config BOARD_SPECIFIC_OPTIONS : def_bool y > Will be used in the next commits. But yes, I can remove for this commit and add in later. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/56035 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I694729ad98f91e27308220903c49e7cb7fc436b4 Gerrit-Change-Number: 56035 Gerrit-PatchSet: 3 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 05 Jul 2021 12:34:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/siemens/mc_ehl: Switch to 16 MB ROM and provide a flashmap
by Werner Zeh (Code Review) 05 Jul '21

05 Jul '21

Attention is currently required from: Arthur Heymans. Hello build bot (Jenkins), Mario Scheithauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56035 to look at the new patch set (#3). Change subject: mb/siemens/mc_ehl: Switch to 16 MB ROM and provide a flashmap ...................................................................... mb/siemens/mc_ehl: Switch to 16 MB ROM and provide a flashmap There is a 16 MB flash chip on mc_ehl. Set the ROM size accordingly and provide a flashmap for partitioning. Select the used flashmap on variant level to allow different layouts for different variants. Change-Id: I694729ad98f91e27308220903c49e7cb7fc436b4 Signed-off-by: Werner Zeh <werner.zeh(a)siemens.com> --- M src/mainboard/siemens/mc_ehl/Kconfig A src/mainboard/siemens/mc_ehl/mc_ehl.fmd A src/mainboard/siemens/mc_ehl/variants/mc_ehl1/Kconfig 3 files changed, 19 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/56035/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/56035 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I694729ad98f91e27308220903c49e7cb7fc436b4 Gerrit-Change-Number: 56035 Gerrit-PatchSet: 3 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/siemens/mc_ehl: Move SPD data to variant directory
by Werner Zeh (Code Review) 05 Jul '21

05 Jul '21

Attention is currently required from: Mario Scheithauer. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56036 ) Change subject: mb/siemens/mc_ehl: Move SPD data to variant directory ...................................................................... Patch Set 2: (2 comments) File src/mainboard/siemens/mc_ehl/variants/mc_ehl1/Makefile.inc: https://review.coreboot.org/c/coreboot/+/56036/comment/caa0c982_4fdfb78b PS2, Line 7: # 0b000 > Maybe just put the memory type here as a comment. This comment does not reflect the memory type but the ID of the SPD file, namely 0. https://review.coreboot.org/c/coreboot/+/56036/comment/9f81e4a9_f84bdb05 PS2, Line 8: LIB_SPD_DEPS := $(foreach f, $(SPD_SOURCES), \ : src/mainboard/$(MAINBOARDDIR)/variants/$(VARIANT_DIR)/spd/$(f).spd.hex) > Do we really need this? There should be only one matching SPD file. I did this in order to be flexible with the spd file naming in the future. If we should change the DRAM chip and need new SPD data I would like to change the file name and have it included from scratch. Does that sound reasonable or should we add it back in once we have the case? -- To view, visit https://review.coreboot.org/c/coreboot/+/56036 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I38aa5e7514437bfcc61c38d64f0ba6f19350810d Gerrit-Change-Number: 56036 Gerrit-PatchSet: 2 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Comment-Date: Mon, 05 Jul 2021 12:33:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer/var/voema: Remove stop delay time for ELAN TS
by David Wu (Code Review) 05 Jul '21

05 Jul '21

David Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56087 ) Change subject: mb/google/volteer/var/voema: Remove stop delay time for ELAN TS ...................................................................... mb/google/volteer/var/voema: Remove stop delay time for ELAN TS Remove register "generic.stop_delay_ms" and build local AP, it can still meet elan touchscreen spec (T3 > 150ms). BUG=b:185308246 TEST=Measure the T3 delay time is greater than 150ms on voema Signed-off-by: David Wu <david_wu(a)quanta.corp-partner.google.com> Change-Id: Id326fd4d9d71eef171580b1c6001505e698b40a3 --- M src/mainboard/google/volteer/variants/voema/overridetree.cb 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/56087/1 diff --git a/src/mainboard/google/volteer/variants/voema/overridetree.cb b/src/mainboard/google/volteer/variants/voema/overridetree.cb index fcec5eb..745ed51 100644 --- a/src/mainboard/google/volteer/variants/voema/overridetree.cb +++ b/src/mainboard/google/volteer/variants/voema/overridetree.cb @@ -71,7 +71,6 @@ register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_F16)" register "generic.enable_delay_ms" = "10" register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E3)" - register "generic.stop_delay_ms" = "150" register "generic.has_power_resource" = "1" register "generic.disable_gpio_export_in_crs" = "1" register "hid_desc_reg_offset" = "0x01" -- To view, visit https://review.coreboot.org/c/coreboot/+/56087 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id326fd4d9d71eef171580b1c6001505e698b40a3 Gerrit-Change-Number: 56087 Gerrit-PatchSet: 1 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/brya: Add UsbTcPortEn in devicetree
by EricR Lai (Code Review) 05 Jul '21

05 Jul '21

Attention is currently required from: Tim Wawrzynczak, Subrata Banik, Patrick Rudolph. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56074 ) Change subject: mb/google/brya: Add UsbTcPortEn in devicetree ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/alderlake/chip.h: https://review.coreboot.org/c/coreboot/+/56074/comment/84f5e366_135b7a38 PS1, Line 115: /* > suggested to add a macro here, similar to https://review.coreboot. […] Do you mean we can add define in TCSS then use UsbTcPortEn="PORT_0|PORT_1|PORT_2"? -- To view, visit https://review.coreboot.org/c/coreboot/+/56074 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe9d3a6d1d73cb37daae4a1ae49ee26abc43635b Gerrit-Change-Number: 56074 Gerrit-PatchSet: 1 Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 05 Jul 2021 12:24:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/siemens/mc_ehl: Switch to 16 MB ROM and provide a flashmap
by Werner Zeh (Code Review) 05 Jul '21

05 Jul '21

Attention is currently required from: Arthur Heymans. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56035 ) Change subject: mb/siemens/mc_ehl: Switch to 16 MB ROM and provide a flashmap ...................................................................... Patch Set 2: (2 comments) File src/mainboard/siemens/mc_ehl/mc_ehl.fmd: https://review.coreboot.org/c/coreboot/+/56035/comment/c0a3da3e_075c6a82 PS2, Line 9: 0xbefe00 > You can also leave this empty and fmaptool will fill the size to fill the parent region. Cool, this is new to me. Nice feature, will change. File src/mainboard/siemens/mc_ehl/variants/mc_ehl1/Kconfig: https://review.coreboot.org/c/coreboot/+/56035/comment/3ac6a936_ecf2b2a5 PS2, Line 3: config BOARD_SPECIFIC_OPTIONS : def_bool y > remove as it's not selecting anything? Will be used in the next commits. But yes, I can remove for this commit and add in later. -- To view, visit https://review.coreboot.org/c/coreboot/+/56035 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I694729ad98f91e27308220903c49e7cb7fc436b4 Gerrit-Change-Number: 56035 Gerrit-PatchSet: 2 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 05 Jul 2021 12:23:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [TESTME] mb/prodrive/hermes: Update HDA codec subvendor ID
by Angel Pons (Code Review) 05 Jul '21

05 Jul '21

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56086 ) Change subject: [TESTME] mb/prodrive/hermes: Update HDA codec subvendor ID ...................................................................... [TESTME] mb/prodrive/hermes: Update HDA codec subvendor ID Change-Id: I72be8bde59d9eb0c1eff8c65dc734c6805732e09 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/prodrive/hermes/variants/baseboard/hda_verb.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/56086/1 diff --git a/src/mainboard/prodrive/hermes/variants/baseboard/hda_verb.c b/src/mainboard/prodrive/hermes/variants/baseboard/hda_verb.c index 0e5d359..7aac105 100644 --- a/src/mainboard/prodrive/hermes/variants/baseboard/hda_verb.c +++ b/src/mainboard/prodrive/hermes/variants/baseboard/hda_verb.c @@ -7,7 +7,7 @@ 0x10ec0888, /* Codec Vendor / Device ID: Realtek ALC888 */ 0x10ec0888, /* Subsystem ID */ 15, /* Number of 4 dword sets */ - AZALIA_SUBVENDOR(0, 0x10ec0888), + AZALIA_SUBVENDOR(0, 0x1d330067), /* Pin widgets */ AZALIA_PIN_CFG(0, 0x11, 0x411111f0), /* SPDIF-OUT2 - disabled */ -- To view, visit https://review.coreboot.org/c/coreboot/+/56086 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72be8bde59d9eb0c1eff8c65dc734c6805732e09 Gerrit-Change-Number: 56086 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2021