coreboot-gerrit July 2021

coreboot-gerrit@coreboot.org

1 participants
5824 discussions

Change in coreboot[master]: util/ifdtool: Add sklkbl to IFDv2 platforms
by Angel Pons (Code Review) 06 Jul '21

06 Jul '21

Attention is currently required from: Jan Tatje, Stefan Reinauer. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56070 ) Change subject: util/ifdtool: Add sklkbl to IFDv2 platforms ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: > I'll check this against the SPI programming guide. IFD v2 is the right choice. -- To view, visit https://review.coreboot.org/c/coreboot/+/56070 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f92b090e929336b5c18b442d1504ee1000f5594 Gerrit-Change-Number: 56070 Gerrit-PatchSet: 1 Gerrit-Owner: Jan Tatje <jan(a)jnt.io> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jan Tatje <jan(a)jnt.io> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Tue, 06 Jul 2021 11:24:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/ifdtool: Add sklkbl to IFDv2 platforms
by Paul Menzel (Code Review) 06 Jul '21

06 Jul '21

Attention is currently required from: Jan Tatje, Stefan Reinauer. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56070 ) Change subject: util/ifdtool: Add sklkbl to IFDv2 platforms ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/56070/comment/c4a50467_5b4a1426 PS1, Line 12: Please add a Fixes: tag: > Fixes: 8c082e5fef ("util/ifdtool: Use -p platform name to detect IFDv2 platform and chipset") -- To view, visit https://review.coreboot.org/c/coreboot/+/56070 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f92b090e929336b5c18b442d1504ee1000f5594 Gerrit-Change-Number: 56070 Gerrit-PatchSet: 1 Gerrit-Owner: Jan Tatje <jan(a)jnt.io> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jan Tatje <jan(a)jnt.io> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Tue, 06 Jul 2021 11:21:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: grunt/treeya: add Realtek ALC5682 codec support
by Kevin Chang (Code Review) 06 Jul '21

06 Jul '21

Attention is currently required from: Kevin Chang. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56100 to look at the new patch set (#2). Change subject: grunt/treeya: add Realtek ALC5682 codec support ...................................................................... grunt/treeya: add Realtek ALC5682 codec support ALC5682 i2c address: 0x1A BUG=b:185972050 BRANCH=master TEST=emerge-grunt coreboot Signed-off-by: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Change-Id: I49c673fd944b2c2a79c4283eee941a16596ba7fa --- M src/mainboard/google/kahlee/variants/treeya/Makefile.inc A src/mainboard/google/kahlee/variants/treeya/audio.c M src/mainboard/google/kahlee/variants/treeya/devicetree.cb A src/mainboard/google/kahlee/variants/treeya/include/variant/sku.h 4 files changed, 85 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/56100/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56100 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I49c673fd944b2c2a79c4283eee941a16596ba7fa Gerrit-Change-Number: 56100 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/ifdtool: Add sklkbl to IFDv2 platforms
by Angel Pons (Code Review) 06 Jul '21

06 Jul '21

Attention is currently required from: Jan Tatje, Stefan Reinauer. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56070 ) Change subject: util/ifdtool: Add sklkbl to IFDv2 platforms ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I'll check this against the SPI programming guide. -- To view, visit https://review.coreboot.org/c/coreboot/+/56070 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f92b090e929336b5c18b442d1504ee1000f5594 Gerrit-Change-Number: 56070 Gerrit-PatchSet: 1 Gerrit-Owner: Jan Tatje <jan(a)jnt.io> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jan Tatje <jan(a)jnt.io> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Tue, 06 Jul 2021 11:12:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/siemens/mc_ehl: Switch to 16 MB ROM and provide a flashmap
by Mario Scheithauer (Code Review) 06 Jul '21

06 Jul '21

Attention is currently required from: Arthur Heymans, Werner Zeh. Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56035 ) Change subject: mb/siemens/mc_ehl: Switch to 16 MB ROM and provide a flashmap ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56035 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I694729ad98f91e27308220903c49e7cb7fc436b4 Gerrit-Change-Number: 56035 Gerrit-PatchSet: 3 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Tue, 06 Jul 2021 11:07:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/ifdtool: Use -p platform name to detect IFDv2 platform and chipset
by Jan Tatje (Code Review) 06 Jul '21

06 Jul '21

Attention is currently required from: Subrata Banik. Jan Tatje has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54305 ) Change subject: util/ifdtool: Use -p platform name to detect IFDv2 platform and chipset ...................................................................... Patch Set 10: (1 comment) Patchset: PS10: > Earlier if your platform was entering into earlier if loop and touching bit 7:0 then it was doing wrong programming. I either don't understand that sentence correctly or it is the opposite, the else clause is what touches bit 7:0. If ifd_version is set to IFD_VERSION_2 like it was before this change, then it will not touch bits 7:0 and set read and write permissions to true. In the else-clause of the condition, which it uses now, both 7:0 reserved bits are changed and (I think this is what breaks boot) read permission bits 15:8 are set to 0. > I would say, it was wrong that SKL was considered as IFDv2. Even if IFDv2 is supposed to mean that 7:0 of the flash master are used for Extended Region Access Permissions somewhere else, in ifdtool it just decides whether FLMSTR uses 31:16 or 31:8 for permissions. IMHO adding SKLKBL to the ifd_2_platforms list is the easiest solution to fix this issue. This is the change I applied to make it work for me: https://review.coreboot.org/c/coreboot/+/56070 -- To view, visit https://review.coreboot.org/c/coreboot/+/54305 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25f69ce775454409974056d8326c02e29038ec8a Gerrit-Change-Number: 54305 Gerrit-PatchSet: 10 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <lean.sheng.tan(a)intel.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Jan Tatje <jan(a)jnt.io> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subi.banik(a)gmail.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Comment-Date: Tue, 06 Jul 2021 10:55:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jan Tatje <jan(a)jnt.io> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/gma: Support IGD Opregion 2.1
by Angel Pons (Code Review) 06 Jul '21

06 Jul '21

1 0

Change in coreboot[master]: drivers/intel/gma: Support IGD Opregion 2.1
by Angel Pons (Code Review) 06 Jul '21

06 Jul '21

Attention is currently required from: Krishna Prabhakaran, Selma Bensaid, Meera Ravindranath, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52758 ) Change subject: drivers/intel/gma: Support IGD Opregion 2.1 ...................................................................... Patch Set 10: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/52758/comment/21cd0172_78a93893 PS10, Line 12: incase in case File src/drivers/intel/gma/Kconfig: https://review.coreboot.org/c/coreboot/+/52758/comment/45c1167e_db1730ba PS10, Line 57: register (0xe0) rather than the SWSCI register (0xe8). Place new Kconfig options here. https://review.coreboot.org/c/coreboot/+/52758/comment/7a189c9a_2c82f426 PS10, Line 149: config INTEL_IGD_OPREGION_VERSION This shouldn't be guarded by `if GFX_GMA`. I'd add the Kconfig options on line 57 (see comment there) https://review.coreboot.org/c/coreboot/+/52758/comment/bd09c08d_c09e941a PS10, Line 151: default 0x200 Does the OpRegion version need to be specified in hex? I feel having specific Kconfig options for the versions would be cleaner: config INTEL_GMA_OPREGION_2_0 bool default n if INTEL_GMA_OPREGION_2_1 default y config INTEL_GMA_OPREGION_2_1 bool default n Then, make a helper function to return the version number: static u32 opregion_version(void) { if (CONFIG(INTEL_GMA_OPREGION_2_0)) return 0x200; if (CONFIG(INTEL_GMA_OPREGION_2_1)) return 0x201; return dead_code_t(u32); } By writing the function this way, GCC can automatically inline it, as it either returns an integer constant or `dead_code_t` forces a build failure. #include <assert.h> to use the `dead_code_t` macro. File src/drivers/intel/gma/opregion.c: https://review.coreboot.org/c/coreboot/+/52758/comment/982207dc_f904afa4 PS10, Line 362: CONFIG_INTEL_IGD_OPREGION_VERSION This now has a different value. Looks like it's not intentional? Before: 2 << 24 == 0x02000000 After: 0x200 -- To view, visit https://review.coreboot.org/c/coreboot/+/52758 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I95a9f3df185002a4e38faa910f867ace0b97ac2b Gerrit-Change-Number: 52758 Gerrit-PatchSet: 10 Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Krishna Prabhakaran <krishna.prabhakaran(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Krishna Prabhakaran <krishna.prabhakaran(a)intel.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 06 Jul 2021 10:39:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: vc/mediatek/mt8195: Enable VREF calibration at DDR3200 for S0 stability
by Rex-BC Chen (Code Review) 06 Jul '21

06 Jul '21

Attention is currently required from: Hung-Te Lin, Ryan Chuang, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56105 ) Change subject: vc/mediatek/mt8195: Enable VREF calibration at DDR3200 for S0 stability ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/56105/comment/cf597f13_10e46755 PS2, Line 7: vc/mediatek/mt8195: Enable VREF calibration at DDR3200 for enter/exit S0 stability > Line too long Done -- To view, visit https://review.coreboot.org/c/coreboot/+/56105 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9df776b393f6b6166d1d6f02d5e96bd7ebc4a707 Gerrit-Change-Number: 56105 Gerrit-PatchSet: 3 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Ryan Chuang <ryan.chuang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Ryan Chuang <ryan.chuang(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 06 Jul 2021 10:21:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: vc/mediatek/mt8195: Improve settings of duty calibration
by Rex-BC Chen (Code Review) 06 Jul '21

06 Jul '21

Attention is currently required from: Hung-Te Lin, Ryan Chuang, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56104 ) Change subject: vc/mediatek/mt8195: Improve settings of duty calibration ...................................................................... Patch Set 3: (1 comment) File src/vendorcode/mediatek/mt8195/dramc/dramc_pi_calibration_api.c: https://review.coreboot.org/c/coreboot/+/56104/comment/39533865_5af73e07 PS2, Line 14816: DramcClockDutySetClkDelayCell(p, p->pSavetimeData->s1ClockDuty_clk_delay_cell[p->channel]); : DQSDutyScan_SetDqsDelayCell(p, p->pSavetimeData->s1DQSDuty_clk_delay_cell[p->channel]); : #if __LP5_COMBO__ : WCKDutyScan_SetWCKDelayCell(p, p->pSavetimeData->s1WCKDuty_clk_delay_cell[p->channel]); : #endif : #if APPLY_DQDQM_DUTY_CALIBRATION : DQDQMDutyScan_SetDQDQMDelayCell(p, p->channel, p->pSavetimeData->s1DQMDuty_clk_delay_cell[p->channel], DutyScan_Calibration_K_DQM); : DQDQMDutyScan_SetDQDQMDelayCell(p, p->channel, p->pSavetimeData->s1DQDuty_clk_delay_cell[p->channel], DutyScan_Calibration_K_DQ); : #endif > No, everything inside the for loop. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/56104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic4aeaec947356001d073df72977899ca06b18bda Gerrit-Change-Number: 56104 Gerrit-PatchSet: 3 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Ryan Chuang <ryan.chuang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Ryan Chuang <ryan.chuang(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 06 Jul 2021 10:21:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2021