coreboot-gerrit July 2021

coreboot-gerrit@coreboot.org

1 participants
5824 discussions

Change in coreboot[master]: soc/intel/alderlake: Add missing devices to pci_devs.h
by Patrick Rudolph (Code Review) 12 Jul '21

12 Jul '21

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56172 ) Change subject: soc/intel/alderlake: Add missing devices to pci_devs.h ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: The QA test failure seems to be a false positive. The error message last seen when booting Linux seems to be a KVM bug. -- To view, visit https://review.coreboot.org/c/coreboot/+/56172 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2b9f8cceb4bd0c77fc43ef2e48190dd736a84ad8 Gerrit-Change-Number: 56172 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 12 Jul 2021 09:28:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/skylake: Drop dead `ScanExtGfxForLegacyOpRom`
by Angel Pons (Code Review) 12 Jul '21

12 Jul '21

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56207 ) Change subject: soc/intel/skylake: Drop dead `ScanExtGfxForLegacyOpRom` ...................................................................... soc/intel/skylake: Drop dead `ScanExtGfxForLegacyOpRom` This devicetree option is never set and never used. Drop it. Change-Id: I9cd4733746849728b2b9f85793eace9191a97f49 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/soc/intel/skylake/chip.h 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/56207/1 diff --git a/src/soc/intel/skylake/chip.h b/src/soc/intel/skylake/chip.h index d30547e..d463c3b 100644 --- a/src/soc/intel/skylake/chip.h +++ b/src/soc/intel/skylake/chip.h @@ -283,7 +283,6 @@ Display_Switchable, } PrimaryDisplay; u8 SkipExtGfxScan; - u8 ScanExtGfxForLegacyOpRom; /* GPIO IRQ Route The valid values is 14 or 15*/ u8 GpioIrqSelect; -- To view, visit https://review.coreboot.org/c/coreboot/+/56207 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9cd4733746849728b2b9f85793eace9191a97f49 Gerrit-Change-Number: 56207 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/siemens/chili: Drop ineffective `SaGv` setting
by Felix Singer (Code Review) 12 Jul '21

12 Jul '21

Attention is currently required from: Nico Huber, Angel Pons. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56205 ) Change subject: mb/siemens/chili: Drop ineffective `SaGv` setting ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56205 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5be518cce08206ad149efd1665e44a7111b24202 Gerrit-Change-Number: 56205 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 12 Jul 2021 09:11:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/skylake: Rename `Rmt` devicetree setting
by Angel Pons (Code Review) 12 Jul '21

12 Jul '21

Attention is currently required from: Felix Singer, Michael Niewöhner. Hello Felix Singer, Michael Niewöhner, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/56206 to review the following change. Change subject: soc/intel/skylake: Rename `Rmt` devicetree setting ...................................................................... soc/intel/skylake: Rename `Rmt` devicetree setting Rename `Rmt` to `RMT` for consistency with the UPD name. Change-Id: I905b9b65fa6c5711c6e726cc09d3cad5ba3640a1 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/soc/intel/skylake/chip.h M src/soc/intel/skylake/romstage/fsp_params.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/56206/1 diff --git a/src/soc/intel/skylake/chip.h b/src/soc/intel/skylake/chip.h index d30547e..59f75bf 100644 --- a/src/soc/intel/skylake/chip.h +++ b/src/soc/intel/skylake/chip.h @@ -94,7 +94,7 @@ } SaGv; /* Enable/disable Rank Margin Tool */ - u8 Rmt; + u8 RMT; /* Disable Command TriState */ u8 CmdTriStateDis; diff --git a/src/soc/intel/skylake/romstage/fsp_params.c b/src/soc/intel/skylake/romstage/fsp_params.c index f05532c..21526e4 100644 --- a/src/soc/intel/skylake/romstage/fsp_params.c +++ b/src/soc/intel/skylake/romstage/fsp_params.c @@ -83,7 +83,7 @@ m_cfg->ProbelessTrace = 0; m_cfg->SaGv = config->SaGv; m_cfg->UserBd = BOARD_TYPE_ULT_ULX; - m_cfg->RMT = config->Rmt; + m_cfg->RMT = config->RMT; m_cfg->CmdTriStateDis = config->CmdTriStateDis; m_cfg->DdrFreqLimit = 0; m_cfg->VmxEnable = CONFIG(ENABLE_VMX); -- To view, visit https://review.coreboot.org/c/coreboot/+/56206 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I905b9b65fa6c5711c6e726cc09d3cad5ba3640a1 Gerrit-Change-Number: 56206 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/siemens/chili: Use CHIPSET_LOCKDOWN_COREBOOT
by Angel Pons (Code Review) 12 Jul '21

12 Jul '21

Attention is currently required from: Felix Singer. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56198 ) Change subject: mb/siemens/chili: Use CHIPSET_LOCKDOWN_COREBOOT ...................................................................... Patch Set 3: (1 comment) File src/mainboard/siemens/chili/variants/base/devicetree.cb: https://review.coreboot.org/c/coreboot/+/56198/comment/495ffcfb_acbd8199 PS3, Line 5: register "SaGv" = "SaGv_Enabled" Hmmm, but this board doesn't use ULT/ULX CPUs? CB:56205 -- To view, visit https://review.coreboot.org/c/coreboot/+/56198 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee4f6986e5edfe1bf6c84fe132bcb47b15bb81f5 Gerrit-Change-Number: 56198 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Mon, 12 Jul 2021 09:04:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/siemens/chili: Drop ineffective `SaGv` setting
by Angel Pons (Code Review) 12 Jul '21

12 Jul '21

Attention is currently required from: Felix Singer, Nico Huber. Hello Felix Singer, Nico Huber, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/56205 to review the following change. Change subject: mb/siemens/chili: Drop ineffective `SaGv` setting ...................................................................... mb/siemens/chili: Drop ineffective `SaGv` setting SaGv is only available on ULT/ULX processors, which use PCH-LP. Given that the Siemens Chili board selects `SOC_INTEL_CANNONLAKE_PCH_H`, it does not use ULT/ULX processors, and thus does not support SaGv. Drop the `SaGv` setting from the devicetrees, as it has no effect. Change-Id: I5be518cce08206ad149efd1665e44a7111b24202 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/siemens/chili/variants/base/devicetree.cb M src/mainboard/siemens/chili/variants/chili/devicetree.cb 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/56205/1 diff --git a/src/mainboard/siemens/chili/variants/base/devicetree.cb b/src/mainboard/siemens/chili/variants/base/devicetree.cb index ccbe804..81dae2e 100644 --- a/src/mainboard/siemens/chili/variants/base/devicetree.cb +++ b/src/mainboard/siemens/chili/variants/base/devicetree.cb @@ -2,7 +2,6 @@ chip soc/intel/cannonlake # FSP configuration - register "SaGv" = "SaGv_Enabled" register "RMT" = "0" register "PchHdaDspEnable" = "0" diff --git a/src/mainboard/siemens/chili/variants/chili/devicetree.cb b/src/mainboard/siemens/chili/variants/chili/devicetree.cb index 4416dbf..b4d9970 100644 --- a/src/mainboard/siemens/chili/variants/chili/devicetree.cb +++ b/src/mainboard/siemens/chili/variants/chili/devicetree.cb @@ -2,7 +2,6 @@ chip soc/intel/cannonlake # FSP configuration - register "SaGv" = "SaGv_Enabled" register "RMT" = "0" register "PchHdaDspEnable" = "0" -- To view, visit https://review.coreboot.org/c/coreboot/+/56205 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5be518cce08206ad149efd1665e44a7111b24202 Gerrit-Change-Number: 56205 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: drivers/intel/gma: Restructure Opregion version info code
by Subrata Banik (Code Review) 12 Jul '21

12 Jul '21

Attention is currently required from: Furquan Shaikh, Maulik V Vaghela, Tim Wawrzynczak, Angel Pons, Meera Ravindranath, Patrick Rudolph. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56168 ) Change subject: drivers/intel/gma: Restructure Opregion version info code ...................................................................... Patch Set 6: (1 comment) File src/drivers/intel/gma/opregion.c: https://review.coreboot.org/c/coreboot/+/56168/comment/9f718ecd_a768112f PS6, Line 261: 2 > > knowing that, Rev and Rsvd always having 0, can't we use below logic? Thoughts ? > > > > union opregion_version { > > u32 data; > > struct fields{ > > u8 rsvd; > > u8 revision; > > u8 minor; > > u8 major; > > }; > > }; > > > > +---------------+---------------+------+------+------------------+ > > | 31:24 | 23:16 | 15:8 | 7:0 | Opregion version | > > +---------------+---------------+------+------+------------------+ > > | Major Version | Minor version | Rev | Rsvd | | > > | 1 | 0 | 0 | 0 | 1.0.0 | > > | 1 | 5 | 0 | 0 | 1.5.0 | > > | 2 | 3 | 0 | 0 | 2.3.0 | > > | A | F | 0 | 0 | 10.15 | > > +---------------+---------------+------+------+------------------+ > > > > > > config OPREGION_2_0_VERSION > > int > > default 2000 > > > > config OPREGION_2_1_VERSION > > int > > default 2100 > > > > config OPREGION_3_0_VERSION > > int > > default 3000 > > These base-10 integers don't result in the desired values. If anything, they should be written in hex as follows: > > config OPREGION_2_0_VERSION > hex > default 0x02000000 > > config OPREGION_2_1_VERSION > int > default 0x02010000 > > config OPREGION_3_0_VERSION > int > default 0x03000000 yes, not decimal for sure, its hex, my bad > > IMHO, having boolean Kconfig options and encoding the version number in C code is easier to understand and maintain. Agreed, i was thinking more from how to ask developers to change the code less and things are automatically taken care, when they just select the INTEL_GMA_OPREGION_2_0 for example -- To view, visit https://review.coreboot.org/c/coreboot/+/56168 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I93a9f2df186002a4e38caa910f867bce0b97ac2b Gerrit-Change-Number: 56168 Gerrit-PatchSet: 6 Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 12 Jul 2021 08:56:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/siemens/chili: Use CHIPSET_LOCKDOWN_COREBOOT
by Angel Pons (Code Review) 12 Jul '21

12 Jul '21

Attention is currently required from: Felix Singer. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56198 ) Change subject: mb/siemens/chili: Use CHIPSET_LOCKDOWN_COREBOOT ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56198 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee4f6986e5edfe1bf6c84fe132bcb47b15bb81f5 Gerrit-Change-Number: 56198 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Mon, 12 Jul 2021 08:51:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/gma: Restructure Opregion version info code
by Angel Pons (Code Review) 12 Jul '21

12 Jul '21

Attention is currently required from: Furquan Shaikh, Maulik V Vaghela, Tim Wawrzynczak, Subrata Banik, Meera Ravindranath, Angel Pons, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56168 ) Change subject: drivers/intel/gma: Restructure Opregion version info code ...................................................................... Patch Set 6: (1 comment) File src/drivers/intel/gma/opregion.c: https://review.coreboot.org/c/coreboot/+/56168/comment/be8bb134_30db9457 PS6, Line 261: 2 > knowing that, Rev and Rsvd always having 0, can't we use below logic? Thoughts ? > > union opregion_version { > u32 data; > struct fields{ > u8 rsvd; > u8 revision; > u8 minor; > u8 major; > }; > }; > > +---------------+---------------+------+------+------------------+ > | 31:24 | 23:16 | 15:8 | 7:0 | Opregion version | > +---------------+---------------+------+------+------------------+ > | Major Version | Minor version | Rev | Rsvd | | > | 1 | 0 | 0 | 0 | 1.0.0 | > | 1 | 5 | 0 | 0 | 1.5.0 | > | 2 | 3 | 0 | 0 | 2.3.0 | > | A | F | 0 | 0 | 10.15 | > +---------------+---------------+------+------+------------------+ > > > config OPREGION_2_0_VERSION > int > default 2000 > > config OPREGION_2_1_VERSION > int > default 2100 > > config OPREGION_3_0_VERSION > int > default 3000 These base-10 integers don't result in the desired values. If anything, they should be written in hex as follows: config OPREGION_2_0_VERSION hex default 0x02000000 config OPREGION_2_1_VERSION int default 0x02010000 config OPREGION_3_0_VERSION int default 0x03000000 IMHO, having boolean Kconfig options and encoding the version number in C code is easier to understand and maintain. -- To view, visit https://review.coreboot.org/c/coreboot/+/56168 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I93a9f2df186002a4e38caa910f867bce0b97ac2b Gerrit-Change-Number: 56168 Gerrit-PatchSet: 6 Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 12 Jul 2021 08:50:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common: Use SPR for backing up data way and eviction mask
by Angel Pons (Code Review) 12 Jul '21

12 Jul '21

Attention is currently required from: Furquan Shaikh, Subrata Banik, Nick Vaccaro, Patrick Rudolph, Karthik Ramasubramanian. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56161 ) Change subject: soc/intel/common: Use SPR for backing up data way and eviction mask ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/56161 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I12e0cb7bb050e4f7b17ecf30108db335d1d82ab7 Gerrit-Change-Number: 56161 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 12 Jul 2021 08:44:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2021