coreboot-gerrit July 2021

coreboot-gerrit@coreboot.org

1 participants
5824 discussions

Change in coreboot[master]: mb/google/brya: Program Unused Cnvi BT related GPIOs to NC
by Tim Wawrzynczak (Code Review) 12 Jul '21

12 Jul '21

Attention is currently required from: Furquan Shaikh, Maulik V Vaghela, Sugnan Prabhu S. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55317 ) Change subject: mb/google/brya: Program Unused Cnvi BT related GPIOs to NC ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: Does having these programmed in CNVi mode cause any issues? -- To view, visit https://review.coreboot.org/c/coreboot/+/55317 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I33a37ceb8a91603d2a193de5bdd1b6885eb3c319 Gerrit-Change-Number: 55317 Gerrit-PatchSet: 6 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Comment-Date: Mon, 12 Jul 2021 15:16:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer: Deduplicate lockdown config
by Tim Wawrzynczak (Code Review) 12 Jul '21

12 Jul '21

Attention is currently required from: Felix Singer, Michael Niewöhner. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56199 ) Change subject: mb/google/volteer: Deduplicate lockdown config ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56199 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I597e4487e7a0e1848d2a2f2c8f8ebd552994aac2 Gerrit-Change-Number: 56199 Gerrit-PatchSet: 7 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Mon, 12 Jul 2021 15:15:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer/baseboard: Configure chipset_lockdown seperately
by Tim Wawrzynczak (Code Review) 12 Jul '21

12 Jul '21

Attention is currently required from: Felix Singer, Angel Pons. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56209 ) Change subject: mb/google/volteer/baseboard: Configure chipset_lockdown seperately ...................................................................... Patch Set 2: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/56209/comment/3e788617_e4c73ade PS2, Line 12: seperetaly separately https://review.coreboot.org/c/coreboot/+/56209/comment/e6c459ac_17f54524 PS2, Line 10: since their configuration of : `common_soc_config` overwrites the configuration of the baseboard's : devicetree. This is an issue with sconfig (it can't tell apart these two cases, even though it's setting the exact same field in the generated C code, although properly fixing it would be very tricky Patchset: PS2: I think it would be OK to drop this change, and just keep the next one; they will still all have CHIPSET_LOCKDOWN_COREBOOT selected (this one should be set at the baseboard level, not variants). -- To view, visit https://review.coreboot.org/c/coreboot/+/56209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I595c042cf62680d61f60965710d382bfdcd81671 Gerrit-Change-Number: 56209 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 12 Jul 2021 15:15:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: intel/kblrvp: Move lockdown config to baseboard devicetree
by Subrata Banik (Code Review) 12 Jul '21

12 Jul '21

Attention is currently required from: Felix Singer. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56212 ) Change subject: intel/kblrvp: Move lockdown config to baseboard devicetree ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56212 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I78e847c321c61c3a974b26f30bc2823ff84df651 Gerrit-Change-Number: 56212 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Mon, 12 Jul 2021 15:13:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads: FILO: Hook up autoboot options
by Paul Menzel (Code Review) 12 Jul '21

12 Jul '21

Attention is currently required from: Martin Roth, Stefan Reinauer. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56213 ) Change subject: payloads: FILO: Hook up autoboot options ...................................................................... Patch Set 1: (1 comment) File payloads/external/FILO/Makefile: https://review.coreboot.org/c/coreboot/+/56213/comment/8184c4bf_a4dcc4cb PS1, Line 36: ifeq ($(CONFIG_FILO_USE_AUTOBOOT),y) For some reason, even if selected, the if is not chosen. -- To view, visit https://review.coreboot.org/c/coreboot/+/56213 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id167e9a144bf466da87469108002672b299b702a Gerrit-Change-Number: 56213 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Mon, 12 Jul 2021 15:12:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Update the FIVR configurations
by Tim Wawrzynczak (Code Review) 12 Jul '21

12 Jul '21

Attention is currently required from: Malik Hsu, Mark Hsieh, Anfernee Chen, Casper Chang. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56165 ) Change subject: mb/google/brya: Update the FIVR configurations ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: Thanks Casper! Could we also remove it from the overridetree.cb files? -- To view, visit https://review.coreboot.org/c/coreboot/+/56165 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5c6b97e0b003560e1e22c96c5c3a1328fe876f47 Gerrit-Change-Number: 56165 Gerrit-PatchSet: 3 Gerrit-Owner: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Attention: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-Attention: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Attention: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-Attention: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-Comment-Date: Mon, 12 Jul 2021 15:11:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads: FILO: Hook up autoboot options
by Paul Menzel (Code Review) 12 Jul '21

12 Jul '21

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56213 ) Change subject: payloads: FILO: Hook up autoboot options ...................................................................... payloads: FILO: Hook up autoboot options FILO allows to configure a line to autoboot. Hook this up into coreboot’s build system. Change-Id: Id167e9a144bf466da87469108002672b299b702a Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de> --- M payloads/external/FILO/Kconfig M payloads/external/FILO/Makefile M payloads/external/Makefile.inc 3 files changed, 26 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/56213/1 diff --git a/payloads/external/FILO/Kconfig b/payloads/external/FILO/Kconfig index 1cf171d..3d2b10c 100644 --- a/payloads/external/FILO/Kconfig +++ b/payloads/external/FILO/Kconfig @@ -16,6 +16,23 @@ endchoice +config FILO_USE_AUTOBOOT + prompt "Use FILO's autoboot" + default n + bool + help + Select this option to make FILO autobot a command line after timeout. + +config FILO_AUTOBOOT_FILE + string "Configure FILO's autoboot kernel filename and parameters" + depends on FILO_USE_AUTOBOOT + default "hda1:/vmlinuz root=/dev/hda1 console=tty0 console=ttyS0,115200" + help + #AUTOBOOT_FILE = "mem@0xfff80000" + #AUTOBOOT_FILE = "hde1@0" + #AUTOBOOT_FILE = "uda1:/vmlinuz.elf" + #AUTOBOOT_FILE = "flashb@0x00400000,0x154a00 console=tty0 console=ttyS0,115200" + config PAYLOAD_FILE default "payloads/external/FILO/filo/build/filo.elf" diff --git a/payloads/external/FILO/Makefile b/payloads/external/FILO/Makefile index 9089557..9a34de8 100644 --- a/payloads/external/FILO/Makefile +++ b/payloads/external/FILO/Makefile @@ -33,6 +33,12 @@ #echo "CONFIG_VGAHOOKS=y" >> filo/.config # This shows how to force a previously set .config option *off* #echo "# CONFIG_SMBIOS is not set" >> filo/.config +ifeq ($(CONFIG_FILO_USE_AUTOBOOT),y) + echo "# CONFIG_USE_GRUB is not set" >> filo/.config + echo "CONFIG_USE_AUTOBOOT=y" >> filo/.config + echo "CONFIG_AUTOBOOT_FILE=$(CONFIG_FILO_AUTOBOOT_FILE)" >> filo/.config +endif + $(MAKE) -C filo oldconfig LIBCONFIG_PATH=../../../libpayload filo: config diff --git a/payloads/external/Makefile.inc b/payloads/external/Makefile.inc index 3d46553..03da40b 100644 --- a/payloads/external/Makefile.inc +++ b/payloads/external/Makefile.inc @@ -167,7 +167,9 @@ CC="$(CC_x86_32)" LD="$(LD_x86_32)" OBJDUMP="$(OBJDUMP_x86_32)" \ OBJCOPY="$(OBJCOPY_x86_32)" STRIP="$(STRIP_x86_32)" \ CONFIG_FILO_MASTER=$(CONFIG_FILO_MASTER) \ - CONFIG_FILO_STABLE=$(CONFIG_FILO_STABLE) + CONFIG_FILO_STABLE=$(CONFIG_FILO_STABLE) \ + CONFIG_USE_AUTOBOOT=$(CONFIG_FILO_USE_AUTOBOOT) \ + CONFIG_AUTOBOOT_FILE=$(CONFIG_FILO_AUTOBOOT_FILE) payloads/external/FILO/filo/build/filo.elf: filo payloads/external/FILO/filo/.config: filo -- To view, visit https://review.coreboot.org/c/coreboot/+/56213 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id167e9a144bf466da87469108002672b299b702a Gerrit-Change-Number: 56213 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: security/intel/txt: use mca_get_bank_count()
by Marshall Dawson (Code Review) 12 Jul '21

12 Jul '21

Attention is currently required from: Patrick Rudolph, Philipp Deppenwiese, Felix Held. Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56187 ) Change subject: security/intel/txt: use mca_get_bank_count() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56187 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I28244c975ee34d36d0b44df092d4a62a01c3c79c Gerrit-Change-Number: 56187 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Philipp Deppenwiese <philipp.deppenwiese(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Philipp Deppenwiese <philipp.deppenwiese(a)9elements.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 12 Jul 2021 15:06:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: security/intel/txt: add missing cpu/x86/msr.h include
by Marshall Dawson (Code Review) 12 Jul '21

12 Jul '21

Attention is currently required from: Patrick Rudolph, Felix Held. Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56186 ) Change subject: security/intel/txt: add missing cpu/x86/msr.h include ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56186 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a3299381ff54b7665620861dec60642f27bac8d Gerrit-Change-Number: 56186 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 12 Jul 2021 15:04:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/*/mca: use mca_get_bank_count()
by Marshall Dawson (Code Review) 12 Jul '21

12 Jul '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Felix Held. Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56185 ) Change subject: soc/amd/*/mca: use mca_get_bank_count() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56185 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I126767cf9ad468cab6d6537dd73e9b2dc377b5c4 Gerrit-Change-Number: 56185 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 12 Jul 2021 15:03:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2021