coreboot-gerrit July 2021

coreboot-gerrit@coreboot.org

1 participants
5824 discussions

Change in coreboot[master]: drivers/pc80/rtc: Make use of alt-century byte configurable
by Angel Pons (Code Review) 13 Jul '21

13 Jul '21

Attention is currently required from: Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56214 ) Change subject: drivers/pc80/rtc: Make use of alt-century byte configurable ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File src/drivers/pc80/rtc/mc146818rtc.c: https://review.coreboot.org/c/coreboot/+/56214/comment/d4f1ddb7_86aa966c PS1, Line 235: 69 > Reworked. The calculation was wrong anyway (copied from Linux where 1900 AD is the […] Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/56214 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifba3d77120c2474393ac5e64faac1baeeb58c893 Gerrit-Change-Number: 56214 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Tue, 13 Jul 2021 10:12:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lib/Makefile.inc: Remove effect-free line
by Angel Pons (Code Review) 13 Jul '21

13 Jul '21

Attention is currently required from: Paul Menzel, Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56216 ) Change subject: lib/Makefile.inc: Remove effect-free line ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/56216/comment/20629e36_f13f6f34 PS1, Line 8: > Excuse my ignorance, but why is rtc. […] Sorry, I don't follow. This patch merely removes a line that has no effect in the build process. -- To view, visit https://review.coreboot.org/c/coreboot/+/56216 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ife2ee152ab32ef23df5986c47bec490db592ab60 Gerrit-Change-Number: 56216 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 13 Jul 2021 10:12:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads/external/tianocore: Add build argument for 4G Decode
by Sean Rhodes (Code Review) 13 Jul '21

13 Jul '21

Attention is currently required from: Paul Menzel. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56223 ) Change subject: payloads/external/tianocore: Add build argument for 4G Decode ...................................................................... Patch Set 5: (3 comments) This change is ready for review. Commit Message: https://review.coreboot.org/c/coreboot/+/56223/comment/95eb4615_0c51d9aa PS5, Line 9: Add Kconfig option TIANOCORE_DISABLE_ABOVE_4G to pass build option to edk2 to disable > Please wrapt the line after 75 characters. Ack https://review.coreboot.org/c/coreboot/+/56223/comment/63dd2eb6_805d5577 PS5, Line 11: > Useful for what? Making Qubes boot File payloads/external/Makefile.inc: https://review.coreboot.org/c/coreboot/+/56223/comment/ebb608d5_5ab3dfab PS5, Line 150: TIANOCORE_ABOVE_4G_DECODE > Is `CONFIG_` missing? Woops -- To view, visit https://review.coreboot.org/c/coreboot/+/56223 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia3b1d15196c0ec611431af29031682fea626d19d Gerrit-Change-Number: 56223 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 13 Jul 2021 10:09:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[4.12_branch]: crossgcc/buildgcc: Fix compilation of IASL on GCC10
by Paul Menzel (Code Review) 13 Jul '21

13 Jul '21

Attention is currently required from: Patrick Rudolph. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55568 ) Change subject: crossgcc/buildgcc: Fix compilation of IASL on GCC10 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Is that also fixed in newer IASL releases? -- To view, visit https://review.coreboot.org/c/coreboot/+/55568 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: 4.12_branch Gerrit-Change-Id: I51a93c5519d376bddb6e137a9a48d1a1ab3cadbb Gerrit-Change-Number: 55568 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Comment-Date: Tue, 13 Jul 2021 10:08:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[4.12_branch]: crossgcc/buildgcc: Fix compilation of IASL on GCC10
by Paul Menzel (Code Review) 13 Jul '21

13 Jul '21

Attention is currently required from: Patrick Rudolph. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55568 ) Change subject: crossgcc/buildgcc: Fix compilation of IASL on GCC10 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Is that also fixed in newer IASL releases? -- To view, visit https://review.coreboot.org/c/coreboot/+/55568 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: 4.12_branch Gerrit-Change-Id: I51a93c5519d376bddb6e137a9a48d1a1ab3cadbb Gerrit-Change-Number: 55568 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Comment-Date: Tue, 13 Jul 2021 10:08:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Update the FIVR configurations
by Paul Menzel (Code Review) 13 Jul '21

13 Jul '21

Attention is currently required from: Malik Hsu, Mark Hsieh, Anfernee Chen, Casper Chang. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56165 ) Change subject: mb/google/brya: Update the FIVR configurations ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/56165/comment/1781013a_27dc17af PS4, Line 9: sets the disable disables -- To view, visit https://review.coreboot.org/c/coreboot/+/56165 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5c6b97e0b003560e1e22c96c5c3a1328fe876f47 Gerrit-Change-Number: 56165 Gerrit-PatchSet: 4 Gerrit-Owner: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Attention: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-Attention: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Attention: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-Attention: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-Comment-Date: Tue, 13 Jul 2021 10:06:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: vc/mediatek/mt8195: Remove redundant code
by Paul Menzel (Code Review) 13 Jul '21

13 Jul '21

Attention is currently required from: Rex-BC Chen. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56203 ) Change subject: vc/mediatek/mt8195: Remove redundant code ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/56203/comment/b97cc1c9_c992ed22 PS4, Line 8: Please elaborate next time. -- To view, visit https://review.coreboot.org/c/coreboot/+/56203 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10b2d3c6cb3480f9e3e3232b5ce87ecf7074bbbf Gerrit-Change-Number: 56203 Gerrit-PatchSet: 4 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Ryan Chuang <ryan.chuang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Tue, 13 Jul 2021 10:04:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8195: Get DRAM size from DRAM calibration result
by Paul Menzel (Code Review) 13 Jul '21

13 Jul '21

Attention is currently required from: Hung-Te Lin, Rex-BC Chen. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56204 ) Change subject: soc/mediatek/mt8195: Get DRAM size from DRAM calibration result ...................................................................... Patch Set 3: (1 comment) File src/soc/mediatek/mt8195/emi.c: https://review.coreboot.org/c/coreboot/+/56204/comment/e9966a80_17f7ddc1 PS3, Line 9: int unsigned int or size_t -- To view, visit https://review.coreboot.org/c/coreboot/+/56204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic34f29d1692b94284b2cf6c5d91d323df736c76f Gerrit-Change-Number: 56204 Gerrit-PatchSet: 3 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Ryan Chuang <ryan.chuang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Tue, 13 Jul 2021 10:03:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/pc80/rtc: Make use of alt-century byte configurable
by Nico Huber (Code Review) 13 Jul '21

13 Jul '21

Attention is currently required from: Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56214 ) Change subject: drivers/pc80/rtc: Make use of alt-century byte configurable ...................................................................... Patch Set 2: (1 comment) File src/drivers/pc80/rtc/mc146818rtc.c: https://review.coreboot.org/c/coreboot/+/56214/comment/665233d1_da38478c PS1, Line 235: 69 > Hrmm, copied from Linux ;) Reworked. The calculation was wrong anyway (copied from Linux where 1900 AD is the base, but coreboot's `year` is 0 AD based). -- To view, visit https://review.coreboot.org/c/coreboot/+/56214 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifba3d77120c2474393ac5e64faac1baeeb58c893 Gerrit-Change-Number: 56214 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 13 Jul 2021 10:03:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lib/Makefile.inc: Remove effect-free line
by Paul Menzel (Code Review) 13 Jul '21

13 Jul '21

Attention is currently required from: Angel Pons, Arthur Heymans. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56216 ) Change subject: lib/Makefile.inc: Remove effect-free line ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/56216/comment/57c96255_8b4d7a7e PS1, Line 8: Excuse my ignorance, but why is rtc.c not need to be added? -- To view, visit https://review.coreboot.org/c/coreboot/+/56216 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ife2ee152ab32ef23df5986c47bec490db592ab60 Gerrit-Change-Number: 56216 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 13 Jul 2021 10:01:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2021