Attention is currently required from: Martin Roth, Paul Menzel, Stefan Reinauer.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56213 )
Change subject: payloads: FILO: Hook up autoboot options
......................................................................
Patch Set 2:
(1 comment)
File payloads/external/FILO/Makefile:
https://review.coreboot.org/c/coreboot/+/56213/comment/439a62d3_6e40e458
PS2, Line 39: echo "CONFIG_AUTOBOOT_FILE=$(CONFIG_FILO_AUTOBOOT_FILE)" >> filo/.config
> That seems to work now, but it overridden later on: […]
I don't understand. Isn't this intended? It looks to me like it's working?
--
To view, visit https://review.coreboot.org/c/coreboot/+/56213
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id167e9a144bf466da87469108002672b299b702a
Gerrit-Change-Number: 56213
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Tue, 13 Jul 2021 12:19:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Rex-BC Chen, Paul Menzel.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56204 )
Change subject: soc/mediatek/mt8195: Get DRAM size from DRAM calibration result
......................................................................
Patch Set 3:
(1 comment)
File src/soc/mediatek/mt8195/emi.c:
https://review.coreboot.org/c/coreboot/+/56204/comment/fafb4ee3_066b7b06
PS3, Line 9: int
> I think get_rank_nr_by_emi is return int: […]
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/56204
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic34f29d1692b94284b2cf6c5d91d323df736c76f
Gerrit-Change-Number: 56204
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Ryan Chuang <ryan.chuang(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Tue, 13 Jul 2021 12:07:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56223 )
Change subject: payloads/external/tianocore: Add build argument for 4G Decode
......................................................................
Patch Set 7:
(2 comments)
This change is ready for review.
Patchset:
PS7:
> Nice to see that you are making progress.
Me too!
File payloads/external/tianocore/Kconfig:
https://review.coreboot.org/c/coreboot/+/56223/comment/fe6ff6ff_97b12b9d
PS7, Line 99: for Qubes (Xen).
> I do not understand what decoding means wrt. dispatching drivers. Can you […]
"Above 4G Decoding" follows the term used by other firmware platforms; might make it easier for others to find it.
Change make the DXE keep everything under 4GB, doesn't change anything else. End result is that EFI_LOADED_IMAGE is mapped under 4GB.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56223
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia3b1d15196c0ec611431af29031682fea626d19d
Gerrit-Change-Number: 56223
Gerrit-PatchSet: 7
Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Andy Pont <andy.pont(a)sdcsystems.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Comment-Date: Tue, 13 Jul 2021 11:31:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: comment
Attention is currently required from: Julius Werner.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56210 )
Change subject: console: Handle verstage as "first non-bootblock stage"
......................................................................
Patch Set 1:
(1 comment)
File src/console/init.c:
https://review.coreboot.org/c/coreboot/+/56210/comment/fd5d3ea5_be0612d7
PS1, Line 15: #endif
> I believe the NO_BOOTBLOCK_CONSOLE part here already made no sense to begin with, and this would be […]
The idea was to give systems that don't use get_option() before the
first console output a chance to print something in case something
behind get_option() is broken. That was based on your complexity
arguments and it was the historic behavior before CB:45765, although,
not explicitly.
I know it's not perfect, if a particular system runs into the error
earlier, this FIRST_CONSOLE logic won't help. But other systems
get a chance. ENV_INITIAL_STAGE doesn't help either wrt. "the first
output on the console". I don't mind if we just remove this logic,
no strong feelings.
(sorry for missing SEPARATE_VERSTAGE, I should have been aware)
--
To view, visit https://review.coreboot.org/c/coreboot/+/56210
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I494a33483e306a049aa0c8137a118644fc28177e
Gerrit-Change-Number: 56210
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Tue, 13 Jul 2021 10:43:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Sugnan Prabhu S, Subrata Banik, Sathya Prakash M R.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56208 )
Change subject: mb/intel/adlrvp: Fix Tmode setting for ADL P RVP
......................................................................
Patch Set 1:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56208/comment/14c801d4_a2d98829
PS1, Line 7: mb/intel/adlrvp: Fix Tmode setting for ADL P RVP
Please be more specific and rephrase to something like:
> Use HDA TMODE 8T to match spec
https://review.coreboot.org/c/coreboot/+/56208/comment/380c2e9e_f47b530f
PS1, Line 8:
Please describe the problem first:
> HDMI/DP playback currently does not work. …
https://review.coreboot.org/c/coreboot/+/56208/comment/b34e1f3e_55004a27
PS1, Line 13: carry
carried
https://review.coreboot.org/c/coreboot/+/56208/comment/55b60179_b20a6e4b
PS1, Line 13: Earlier setting was with older FSP which was carry forwarded.
What FSP version did you test with?
https://review.coreboot.org/c/coreboot/+/56208/comment/be8d07e4_b976c798
PS1, Line 16: HDMI /DP
HDMI/DP
https://review.coreboot.org/c/coreboot/+/56208/comment/dc690aad_af303988
PS1, Line 17:
Please add a fixes tag:
> Fixes: …
--
To view, visit https://review.coreboot.org/c/coreboot/+/56208
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia39a33f5da2fea0dc2eaf4eae45999a711c61c33
Gerrit-Change-Number: 56208
Gerrit-PatchSet: 1
Gerrit-Owner: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com>
Gerrit-Comment-Date: Tue, 13 Jul 2021 10:23:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Dtrain Hsu, Henry Sun, Shou-Chieh Hsu, Karthik Ramasubramanian.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56248 )
Change subject: mb/google/dedede/var/cret: Enable/disable Touchscreen based on FW_CONFIG
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56248/comment/706efe22_f11c38df
PS3, Line 10: The Touchscreen settings are included GPIO settings and I2C bus settings.
Can you please rephrase this, as I do not fully understand the sentence?
File src/mainboard/google/dedede/variants/cret/gpio.c:
https://review.coreboot.org/c/coreboot/+/56248/comment/4e43e54f_9c365d08
PS3, Line 103: // Audio codec
Please use C89 comment style for consistency.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56248
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ice517c034e2dab93bb27e75dccf06d9a0936526b
Gerrit-Change-Number: 56248
Gerrit-PatchSet: 3
Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Tue, 13 Jul 2021 10:19:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Ravindra, Karthik Ramasubramanian.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56251 )
Change subject: drivers/wifi/generic: DSM setting enablement for Intel WLAN card
......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56251/comment/39b3ca91_b83a9810
PS1, Line 2: Author: Ravindra <ravindra(a)intel.com>
Same comments as in I18d3f3b1dd91a0487e0ee3321b9bff24513913e3.
https://review.coreboot.org/c/coreboot/+/56251/comment/b879c0c5_f5be5dd7
PS1, Line 10: Ukraine AX / Russia AX), Intel WLAN card has to set DSM setting
Same comments as in I18d3f3b1dd91a0487e0ee3321b9bff24513913e3.
https://review.coreboot.org/c/coreboot/+/56251/comment/6a5435ca_0d538cc8
PS1, Line 12:
Please elaborate, where this is specified, and how the ACPI stuff is supposed to work.
File src/drivers/wifi/generic/acpi.c:
https://review.coreboot.org/c/coreboot/+/56251/comment/0da16729_8256dfd0
PS1, Line 91: *
Please remove this line.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56251
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62f4be846ffb83ea6eaed5a83440bc035b401425
Gerrit-Change-Number: 56251
Gerrit-PatchSet: 1
Gerrit-Owner: Ravindra <ravindra(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Ravindra <ravindra(a)intel.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Tue, 13 Jul 2021 10:17:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Paul Menzel.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56204 )
Change subject: soc/mediatek/mt8195: Get DRAM size from DRAM calibration result
......................................................................
Patch Set 3:
(1 comment)
File src/soc/mediatek/mt8195/emi.c:
https://review.coreboot.org/c/coreboot/+/56204/comment/6e92a463_55c0e7b9
PS3, Line 9: int
> unsigned int or size_t
I think get_rank_nr_by_emi is return int:
src/vendorcode/mediatek/mt8195/dramc/emi.c:702:int get_rank_nr_by_emi(void)
--
To view, visit https://review.coreboot.org/c/coreboot/+/56204
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic34f29d1692b94284b2cf6c5d91d323df736c76f
Gerrit-Change-Number: 56204
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Ryan Chuang <ryan.chuang(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Tue, 13 Jul 2021 10:15:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Henry Sun, Rizwan Qureshi, Ravindra, Karthik Ramasubramanian.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56250 )
Change subject: mb/google/cret: DSM setting enablement for Intel WLAN card
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56250/comment/90f89efe_140b6119
PS1, Line 2: Ravindra
If you have a surname, please add that.
https://review.coreboot.org/c/coreboot/+/56250/comment/9feef13b_d80d4d46
PS1, Line 7: mb/google/cret: DSM setting enablement for Intel WLAN card
Please use statements [1]:
> Add DSM settings for Indonesia, Ukraine, Russia
[1]: https://chris.beams.io/posts/git-commit/https://review.coreboot.org/c/coreboot/+/56250/comment/6e155804_2afca5a9
PS1, Line 9: feature(Indonesia AX /
Please add a space before the (.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56250
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I18d3f3b1dd91a0487e0ee3321b9bff24513913e3
Gerrit-Change-Number: 56250
Gerrit-PatchSet: 1
Gerrit-Owner: Ravindra <ravindra(a)intel.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Attention: Ravindra <ravindra(a)intel.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Tue, 13 Jul 2021 10:13:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment