coreboot-gerrit July 2021

coreboot-gerrit@coreboot.org

1 participants
5824 discussions

Change in coreboot[master]: Revert "amdfwtool: Use relative address for EFS gen2"
by Bao Zheng (Code Review) 15 Jul '21

15 Jul '21

Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56131 ) Change subject: Revert "amdfwtool: Use relative address for EFS gen2" ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > i wonder what exactly caused the regression (verstage or a/b image integration maybe?!), but i'm ok […] I think the loader of the psp_verstage can not find the target when the address in PSP header changes. -- To view, visit https://review.coreboot.org/c/coreboot/+/56131 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie50cba4aaf31425ef8fee848c098a826f55c98da Gerrit-Change-Number: 56131 Gerrit-PatchSet: 3 Gerrit-Owner: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Thu, 15 Jul 2021 08:36:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/gimble: Include SPD for MT53E1G32D2NP-046 WT:A and...
by Angel Pons (Code Review) 15 Jul '21

15 Jul '21

Attention is currently required from: Furquan Shaikh, Caveh Jalali, Tim Wawrzynczak, Nick Vaccaro, Mark Hsieh. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56329 ) Change subject: mb/google/brya/var/gimble: Include SPD for MT53E1G32D2NP-046 WT:A and K4U6E3S4AA-MGCR ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/56329 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4bfc18fd42c6ff2675e6f836c2ecc9617fac3aff Gerrit-Change-Number: 56329 Gerrit-PatchSet: 1 Gerrit-Owner: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Comment-Date: Thu, 15 Jul 2021 08:34:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/zork/var/vilboz: Add new memory MT40A1G16RC-062E:B
by Kangheui Won (Code Review) 15 Jul '21

15 Jul '21

Attention is currently required from: Frank Wu, Martin Roth, Isaac Lee, Paul Menzel. Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56328 ) Change subject: mb/google/zork/var/vilboz: Add new memory MT40A1G16RC-062E:B ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56328 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I07c69f628da7871b990c91af4a8244430b4d96a0 Gerrit-Change-Number: 56328 Gerrit-PatchSet: 3 Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Isaac Lee <isaaclee(a)google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com> Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Isaac Lee <isaaclee(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Thu, 15 Jul 2021 08:32:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/zork/var/vilboz: Add new memory MT40A1G16RC-062E:B
by Frank Wu (Code Review) 15 Jul '21

15 Jul '21

Attention is currently required from: Martin Roth, Kangheui Won, Isaac Lee, Paul Menzel. Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56328 ) Change subject: mb/google/zork/var/vilboz: Add new memory MT40A1G16RC-062E:B ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > Not sure if char limit also applies to this long command. Other than that, lgtm. Clean and update commit message. Thank you for reviewing. -- To view, visit https://review.coreboot.org/c/coreboot/+/56328 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I07c69f628da7871b990c91af4a8244430b4d96a0 Gerrit-Change-Number: 56328 Gerrit-PatchSet: 3 Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Isaac Lee <isaaclee(a)google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com> Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Isaac Lee <isaaclee(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Thu, 15 Jul 2021 08:31:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kangheui Won <khwon(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: UPSTREAM: mb/google/volteer/variants/collis: Fix pen ejection event
by Frank Chu (Code Review) 15 Jul '21

15 Jul '21

Attention is currently required from: Tim Wawrzynczak. Hello Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56331 to look at the new patch set (#2). Change subject: UPSTREAM: mb/google/volteer/variants/collis: Fix pen ejection event ...................................................................... UPSTREAM: mb/google/volteer/variants/collis: Fix pen ejection event Modify PENH device GPIO GPP_E17 for pen ejection event. BUG=b:192511670,b:193093749 BRANCH=firmware-volteer-13672.B TEST=test pen insert and remove by evtest ,SW_PEN_INSERT value 1 when insert pen to pen slot. SW_PEN_INSERT value 0 when remove pen from pen slot. Signed-off-by: FrankChu <frank_chu(a)pegatron.corp-partner.google.com> Change-Id: Ida5e5b35464471a7896cef392e178a3d2c0ea1aa --- M src/mainboard/google/volteer/variants/collis/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/56331/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56331 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida5e5b35464471a7896cef392e178a3d2c0ea1aa Gerrit-Change-Number: 56331 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: UPSTREAM: mb/google/volteer/variants/collis: Fix pen ejection event
by Frank Chu (Code Review) 15 Jul '21

15 Jul '21

Frank Chu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56331 ) Change subject: UPSTREAM: mb/google/volteer/variants/collis: Fix pen ejection event ...................................................................... UPSTREAM: mb/google/volteer/variants/collis: Fix pen ejection event Modify PENH device GPIO GPP_E17 for pen ejection event. BUG=b:192511670;b:193093749 BRANCH=firmware-volteer-13672.B TEST=test pen insert and remove by evtest ,SW_PEN_INSERT value 1 when insert pen to pen slot. SW_PEN_INSERT value 0 when remove pen from pen slot. Signed-off-by: FrankChu <frank_chu(a)pegatron.corp-partner.google.com> Change-Id: Ida5e5b35464471a7896cef392e178a3d2c0ea1aa --- M src/mainboard/google/volteer/variants/collis/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/56331/1 diff --git a/src/mainboard/google/volteer/variants/collis/overridetree.cb b/src/mainboard/google/volteer/variants/collis/overridetree.cb index 00ec738..8efebf6 100644 --- a/src/mainboard/google/volteer/variants/collis/overridetree.cb +++ b/src/mainboard/google/volteer/variants/collis/overridetree.cb @@ -144,7 +144,7 @@ chip drivers/generic/gpio_keys register "name" = ""PENH"" # GPP_E17 is the IRQ source, and GPP_E1 is the wake source - register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(GPP_E17)" + register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_HIGH(GPP_E17)" register "key.wake_gpe" = "GPE0_DW2_01" register "key.wakeup_route" = "WAKEUP_ROUTE_SCI" register "key.wakeup_event_action" = "EV_ACT_DEASSERTED" -- To view, visit https://review.coreboot.org/c/coreboot/+/56331 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida5e5b35464471a7896cef392e178a3d2c0ea1aa Gerrit-Change-Number: 56331 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: [TEST] FSPS IRMS UPD enable
by Ronak Kanabar (Code Review) 15 Jul '21

15 Jul '21

Attention is currently required from: V Sowmya, Balaji Manigandan. Ronak Kanabar has removed Sowmya V from this change. ( https://review.coreboot.org/c/coreboot/+/56330 ) Change subject: [TEST] FSPS IRMS UPD enable ...................................................................... Removed reviewer Sowmya V. -- To view, visit https://review.coreboot.org/c/coreboot/+/56330 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ice5c775ef9560503109957a1ed994af1d287aafc Gerrit-Change-Number: 56330 Gerrit-PatchSet: 1 Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: [TEST] FSPS IRMS UPD enable
by Ronak Kanabar (Code Review) 15 Jul '21

15 Jul '21

Ronak Kanabar has removed Tim Wawrzynczak from this change. ( https://review.coreboot.org/c/coreboot/+/56330 ) Change subject: [TEST] FSPS IRMS UPD enable ...................................................................... Removed reviewer Tim Wawrzynczak. -- To view, visit https://review.coreboot.org/c/coreboot/+/56330 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ice5c775ef9560503109957a1ed994af1d287aafc Gerrit-Change-Number: 56330 Gerrit-PatchSet: 1 Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: [TEST] FSPS IRMS UPD enable
by Ronak Kanabar (Code Review) 15 Jul '21

15 Jul '21

Attention is currently required from: Tim Wawrzynczak. Ronak Kanabar has removed Patrick Rudolph from this change. ( https://review.coreboot.org/c/coreboot/+/56330 ) Change subject: [TEST] FSPS IRMS UPD enable ...................................................................... Removed reviewer Patrick Rudolph. -- To view, visit https://review.coreboot.org/c/coreboot/+/56330 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ice5c775ef9560503109957a1ed994af1d287aafc Gerrit-Change-Number: 56330 Gerrit-PatchSet: 1 Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: [TEST] FSPS IRMS UPD enable
by Ronak Kanabar (Code Review) 15 Jul '21

15 Jul '21

Ronak Kanabar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56330 ) Change subject: [TEST] FSPS IRMS UPD enable ...................................................................... [TEST] FSPS IRMS UPD enable Change-Id: Ice5c775ef9560503109957a1ed994af1d287aafc Signed-off-by: Ronak Kanabar <ronak.kanabar(a)intel.com> --- M src/soc/intel/alderlake/fsp_params.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/56330/1 diff --git a/src/soc/intel/alderlake/fsp_params.c b/src/soc/intel/alderlake/fsp_params.c index f483bed..a64ccdb 100644 --- a/src/soc/intel/alderlake/fsp_params.c +++ b/src/soc/intel/alderlake/fsp_params.c @@ -611,8 +611,10 @@ s_cfg->VccInAuxImonIccImax = get_vccin_aux_imon_iccmax(); /* VrConfig Settings for IA and GT domains */ - for (i = 0; i < ARRAY_SIZE(config->domain_vr_config); i++) + for (i = 0; i < ARRAY_SIZE(config->domain_vr_config); i++){ fill_vr_domain_config(s_cfg, i, &config->domain_vr_config[i]); + s_cfg->Irms[i] = 0x01; + } } -- To view, visit https://review.coreboot.org/c/coreboot/+/56330 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ice5c775ef9560503109957a1ed994af1d287aafc Gerrit-Change-Number: 56330 Gerrit-PatchSet: 1 Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2021