coreboot-gerrit July 2021

coreboot-gerrit@coreboot.org

1 participants
5824 discussions

Change in coreboot[master]: cpu/intel: Add dedicated file to grow Intel CPUIDs
by Subrata Banik (Code Review) 15 Jul '21

15 Jul '21

Attention is currently required from: Anjaneya "Reddy" Chagam, Furquan Shaikh, Mariusz Szafrański, Jonathan Zhang, Johnny Lin, Tim Wawrzynczak, Suresh Bellampalli, Vanessa Eusebio, Angel Pons, Michal Motyl, Morgan Jang, Patrick Rudolph. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56333 ) Change subject: cpu/intel: Add dedicated file to grow Intel CPUIDs ...................................................................... Patch Set 1: (1 comment) File src/cpu/intel/haswell/haswell.h: PS1: > Any reason to touch Haswell? These CPUIDs aren't used in common code... nothing specific for common code, attempted to move all IA CPUIDs in a common location outside the scope of common code. Like how we have added PCI_IDs into pci-ids.h into common location. -- To view, visit https://review.coreboot.org/c/coreboot/+/56333 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id88e038c5d8b1ae077c822554582410de6f4a7ca Gerrit-Change-Number: 56333 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 15 Jul 2021 09:49:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/magolor: Add custom Wifi SAR for magister
by David Wu (Code Review) 15 Jul '21

15 Jul '21

David Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56334 ) Change subject: mb/google/dedede/var/magolor: Add custom Wifi SAR for magister ...................................................................... mb/google/dedede/var/magolor: Add custom Wifi SAR for magister Add wifi sar for magister. Due to fw-config cannot distinguish between magolor and magister. Using sku_id to decide to load magister custom wifi sar. BUG=none TEST=build and test on magolor/magister Signed-off-by: David Wu <david_wu(a)quanta.corp-partner.google.com> Change-Id: I4510cc2ad42a11ec802ecd439b353f8e87d63868 --- M src/mainboard/google/dedede/variants/magolor/variant.c 1 file changed, 35 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/56334/1 diff --git a/src/mainboard/google/dedede/variants/magolor/variant.c b/src/mainboard/google/dedede/variants/magolor/variant.c index bb9cf08..44162c1 100644 --- a/src/mainboard/google/dedede/variants/magolor/variant.c +++ b/src/mainboard/google/dedede/variants/magolor/variant.c @@ -1,13 +1,47 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <drivers/intel/gma/opregion.h> +#include <ec/google/chromeec/ec.h> #include <fw_config.h> #include <sar.h> +enum { + Magolor_SKU1 = 0x70000, + Magolor_SKU2 = 0x70001, + Magolor_SKU3 = 0x70002, + Magolor_SKU4 = 0x70003, + Magolor_SKU5 = 0x70004, + Magolor_SKU6 = 0x70005, + Maglia_SKU1 = 0x80000, + Maglia_SKU2 = 0x80001, + Maglia_SKU3 = 0x80002, + Magister_SKU1 = 0xC0000, + Magister_SKU2 = 0xC0001, + Magister_SKU3 = 0xC0002, + Magister_SKU4 = 0xC0003, +}; + const char *get_wifi_sar_cbfs_filename(void) { - if (fw_config_probe(FW_CONFIG(TABLETMODE, TABLETMODE_ENABLED))) + uint32_t sku_id = google_chromeec_get_board_sku(); + + switch (sku_id) { + case Magolor_SKU1: + case Magolor_SKU2: + case Magolor_SKU3: + case Magolor_SKU4: + case Magolor_SKU5: + case Magolor_SKU6: + case Maglia_SKU1: + case Maglia_SKU2: + case Maglia_SKU3: return "wifi_sar-magolor.hex"; + case Magister_SKU1: + case Magister_SKU2: + case Magister_SKU3: + case Magister_SKU4: + return "wifi_sar-magister.hex"; + } return WIFI_SAR_CBFS_DEFAULT_FILENAME; } -- To view, visit https://review.coreboot.org/c/coreboot/+/56334 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4510cc2ad42a11ec802ecd439b353f8e87d63868 Gerrit-Change-Number: 56334 Gerrit-PatchSet: 1 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/intel/xeon_sp/cpx: Align Cooper Lake CPUID as per EDS
by Angel Pons (Code Review) 15 Jul '21

15 Jul '21

Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Subrata Banik, Arthur Heymans, Morgan Jang, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56332 ) Change subject: soc/intel/xeon_sp/cpx: Align Cooper Lake CPUID as per EDS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56332 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I240a06e3b3d7e3dc080f9a9ed1539fadc982495d Gerrit-Change-Number: 56332 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 15 Jul 2021 09:46:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/intel: Add dedicated file to grow Intel CPUIDs
by Angel Pons (Code Review) 15 Jul '21

15 Jul '21

Attention is currently required from: Anjaneya "Reddy" Chagam, Furquan Shaikh, Mariusz Szafrański, Jonathan Zhang, Johnny Lin, Tim Wawrzynczak, Suresh Bellampalli, Vanessa Eusebio, Subrata Banik, Michal Motyl, Morgan Jang, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56333 ) Change subject: cpu/intel: Add dedicated file to grow Intel CPUIDs ...................................................................... Patch Set 1: (1 comment) File src/cpu/intel/haswell/haswell.h: PS1: Any reason to touch Haswell? These CPUIDs aren't used in common code... -- To view, visit https://review.coreboot.org/c/coreboot/+/56333 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id88e038c5d8b1ae077c822554582410de6f4a7ca Gerrit-Change-Number: 56333 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 15 Jul 2021 09:45:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: AGESA binaryPI: Use common acpi_fill_madt()
by Kyösti Mälkki (Code Review) 15 Jul '21

15 Jul '21

Attention is currently required from: Michał Żygowski, Alexander Couzens, Patrick Rudolph, Piotr Król. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55569 ) Change subject: AGESA binaryPI: Use common acpi_fill_madt() ...................................................................... Patch Set 2: (1 comment) File src/northbridge/amd/pi/00730F01/acpi_tables.c: https://review.coreboot.org/c/coreboot/+/55569/comment/a5d8c934_a29e752b PS2, Line 11: /* Write SB800 IOAPIC, only one */ > nit: probably should be FCH IOAPIC. […] This commit just moves the file to better location and no more. Immediate follow-ups suggest to change the code below to remove MAX_CPUS reference, fix the comment there? -- To view, visit https://review.coreboot.org/c/coreboot/+/55569 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I01ee0ba99eca6ad4c01848ab133166f8c922684d Gerrit-Change-Number: 55569 Gerrit-PatchSet: 2 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Thu, 15 Jul 2021 09:43:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer/variants/collis: Fix pen ejection event
by Frank Chu (Code Review) 15 Jul '21

15 Jul '21

Attention is currently required from: Frank Chu, Isaac Lee, Paul Menzel, Tim Wawrzynczak, Zhuohao Lee. Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56331 ) Change subject: mb/google/volteer/variants/collis: Fix pen ejection event ...................................................................... Patch Set 4: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/56331/comment/ade75a7d_9e6e7c08 PS2, Line 7: UPSTREAM: > Please remove. Done https://review.coreboot.org/c/coreboot/+/56331/comment/70939cea_1772840e PS2, Line 13: evtest ,SW_PEN_INSERT > Please put the space after the comma. Done https://review.coreboot.org/c/coreboot/+/56331/comment/f83460b2_3ac0ff01 PS2, Line 13: evtest ,SW_PEN_INSERT > Please put the space after the comma. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/56331 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida5e5b35464471a7896cef392e178a3d2c0ea1aa Gerrit-Change-Number: 56331 Gerrit-PatchSet: 4 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Isaac Lee <isaaclee(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Attention: Isaac Lee <isaaclee(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Comment-Date: Thu, 15 Jul 2021 09:42:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer/variants/collis: Fix pen ejection event
by Frank Chu (Code Review) 15 Jul '21

15 Jul '21

Attention is currently required from: Isaac Lee, Paul Menzel, Tim Wawrzynczak, Zhuohao Lee. Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56331 ) Change subject: mb/google/volteer/variants/collis: Fix pen ejection event ...................................................................... Patch Set 4: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/56331/comment/1c091e54_0963179b PS2, Line 2: FrankChu > Frank Chu Yes, this is my account https://review.coreboot.org/c/coreboot/+/56331/comment/28495f12_f04bca18 PS2, Line 15: FrankChu > Frank Chu Yes, this is my account -- To view, visit https://review.coreboot.org/c/coreboot/+/56331 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida5e5b35464471a7896cef392e178a3d2c0ea1aa Gerrit-Change-Number: 56331 Gerrit-PatchSet: 4 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Isaac Lee <isaaclee(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Isaac Lee <isaaclee(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Comment-Date: Thu, 15 Jul 2021 09:41:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer/variants/collis: Fix pen ejection event
by Frank Chu (Code Review) 15 Jul '21

15 Jul '21

Attention is currently required from: Isaac Lee, Tim Wawrzynczak, Zhuohao Lee. Hello build bot (Jenkins), Isaac Lee, Tim Wawrzynczak, Zhuohao Lee, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56331 to look at the new patch set (#4). Change subject: mb/google/volteer/variants/collis: Fix pen ejection event ...................................................................... mb/google/volteer/variants/collis: Fix pen ejection event Modify PENH device GPIO GPP_E17 for pen ejection event. BUG=b:192511670,b:193093749 BRANCH=firmware-volteer-13672.B TEST=test pen insert and remove by evtest , SW_PEN_INSERT value 1 when insert pen to pen slot. SW_PEN_INSERT value 0 when remove pen from pen slot. Signed-off-by: FrankChu <frank_chu(a)pegatron.corp-partner.google.com> Change-Id: Ida5e5b35464471a7896cef392e178a3d2c0ea1aa --- M src/mainboard/google/volteer/variants/collis/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/56331/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/56331 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida5e5b35464471a7896cef392e178a3d2c0ea1aa Gerrit-Change-Number: 56331 Gerrit-PatchSet: 4 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Isaac Lee <isaaclee(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Isaac Lee <isaaclee(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: cannonlake mainboards: Set PMC as hidden in devicetree
by Angel Pons (Code Review) 15 Jul '21

15 Jul '21

Attention is currently required from: Matt DeVillier, Jeremy Soller, Tim Wawrzynczak, Karthik Ramasubramanian. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56008 ) Change subject: cannonlake mainboards: Set PMC as hidden in devicetree ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/56008 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib4a20ce9075ce7653388a5d3e281fe774bf89355 Gerrit-Change-Number: 56008 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 15 Jul 2021 09:35:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer/variants/collis: Fix pen ejection event
by Frank Chu (Code Review) 15 Jul '21

15 Jul '21

Attention is currently required from: Frank Chu, Isaac Lee, Tim Wawrzynczak, Zhuohao Lee. Hello build bot (Jenkins), Isaac Lee, Tim Wawrzynczak, Zhuohao Lee, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56331 to look at the new patch set (#3). Change subject: mb/google/volteer/variants/collis: Fix pen ejection event ...................................................................... mb/google/volteer/variants/collis: Fix pen ejection event Modify PENH device GPIO GPP_E17 for pen ejection event. BUG=b:192511670,b:193093749 BRANCH=firmware-volteer-13672.B TEST=test pen insert and remove by evtest ,SW_PEN_INSERT value 1 when insert pen to pen slot. SW_PEN_INSERT value 0 when remove pen from pen slot. Signed-off-by: FrankChu <frank_chu(a)pegatron.corp-partner.google.com> Change-Id: Ida5e5b35464471a7896cef392e178a3d2c0ea1aa --- M src/mainboard/google/volteer/variants/collis/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/56331/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/56331 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida5e5b35464471a7896cef392e178a3d2c0ea1aa Gerrit-Change-Number: 56331 Gerrit-PatchSet: 3 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Isaac Lee <isaaclee(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Attention: Isaac Lee <isaaclee(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2021