Attention is currently required from: Arthur Heymans.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56339
to look at the new patch set (#4).
Change subject: asrock/e3c246d4i: Add board
......................................................................
asrock/e3c246d4i: Add board
This board has upstream Openbmc support so it's quite nice to develop
on.
What is tested:
- ast2500 BMC: video, serial
- 10G NIC
- USB boot: from virtual CD from BMC and real disk
- EDK2 with UefiPayloadPkg
- 8G DIMM in slot0
What does not work:
- SeaBIOS: seems to hang in the menu. Possibly related to running
options of the 10G NICs
TODO: A lot of things are pretty bare in this port like USB and PCIe
setup, but I don't own schematics so it's hard to improve on that.
No idea what the nuvoton superio is hooked up to either.
Change-Id: I66e168c8af5de9862b0724fa397ecd709843af1a
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
A src/mainboard/asrock/e3c246d4i/Kconfig
A src/mainboard/asrock/e3c246d4i/Kconfig.name
A src/mainboard/asrock/e3c246d4i/Makefile.inc
A src/mainboard/asrock/e3c246d4i/board_info.txt
A src/mainboard/asrock/e3c246d4i/bootblock.c
A src/mainboard/asrock/e3c246d4i/devicetree.cb
A src/mainboard/asrock/e3c246d4i/dsdt.asl
A src/mainboard/asrock/e3c246d4i/gpio.c
A src/mainboard/asrock/e3c246d4i/include/mainboard/gpio.h
A src/mainboard/asrock/e3c246d4i/ramstage.c
A src/mainboard/asrock/e3c246d4i/romstage.c
11 files changed, 1,556 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/56339/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/56339
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I66e168c8af5de9862b0724fa397ecd709843af1a
Gerrit-Change-Number: 56339
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56339 )
Change subject: asrock/e3c246d4i: Add board
......................................................................
Patch Set 3:
(4 comments)
File src/mainboard/asrock/e3c246d4i/romstage.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124311):
https://review.coreboot.org/c/coreboot/+/56339/comment/78c18c7f_f0fa4ae5
PS3, Line 10: {
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124311):
https://review.coreboot.org/c/coreboot/+/56339/comment/190c1afe_459cea66
PS3, Line 15: {
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124311):
https://review.coreboot.org/c/coreboot/+/56339/comment/15dc637f_069abba4
PS3, Line 20: {
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124311):
https://review.coreboot.org/c/coreboot/+/56339/comment/0762e15c_44b69947
PS3, Line 25: {
that open brace { should be on the previous line
--
To view, visit https://review.coreboot.org/c/coreboot/+/56339
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I66e168c8af5de9862b0724fa397ecd709843af1a
Gerrit-Change-Number: 56339
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Thu, 15 Jul 2021 13:18:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56339
to look at the new patch set (#3).
Change subject: asrock/e3c246d4i: Add board
......................................................................
asrock/e3c246d4i: Add board
This board has upstream Openbmc support so it's quite nice to develop
on.
What is tested:
- ast2500 BMC: video, serial
- 10G NIC
- USB boot: from virtual CD from BMC and real disk
- EDK2 with UefiPayloadPkg
- 8G DIMM in slot0
What does not work:
- SeaBIOS: seems to hang in the menu. Possibly related to running
options of the 10G NICs
TODO: A lot of things are pretty bare in this port like USB and PCIe
setup, but I don't own schematics so it's hard to improve on that.
No idea what the nuvoton superio is hooked up to either.
Change-Id: I66e168c8af5de9862b0724fa397ecd709843af1a
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
A src/mainboard/asrock/e3c246d4i/Kconfig
A src/mainboard/asrock/e3c246d4i/Kconfig.name
A src/mainboard/asrock/e3c246d4i/Makefile.inc
A src/mainboard/asrock/e3c246d4i/board_info.txt
A src/mainboard/asrock/e3c246d4i/bootblock.c
A src/mainboard/asrock/e3c246d4i/devicetree.cb
A src/mainboard/asrock/e3c246d4i/dsdt.asl
A src/mainboard/asrock/e3c246d4i/gpio.c
A src/mainboard/asrock/e3c246d4i/include/mainboard/gpio.h
A src/mainboard/asrock/e3c246d4i/ramstage.c
A src/mainboard/asrock/e3c246d4i/romstage.c
11 files changed, 1,560 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/56339/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/56339
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I66e168c8af5de9862b0724fa397ecd709843af1a
Gerrit-Change-Number: 56339
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56339 )
Change subject: asrock/e3c246d4i: Add board
......................................................................
Patch Set 2:
(6 comments)
File src/mainboard/asrock/e3c246d4i/romstage.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124310):
https://review.coreboot.org/c/coreboot/+/56339/comment/19af758f_5731a562
PS2, Line 8: the hardware starting from closest to the cpu. */
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124310):
https://review.coreboot.org/c/coreboot/+/56339/comment/3c9b8d00_9175953f
PS2, Line 8: the hardware starting from closest to the cpu. */
please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124310):
https://review.coreboot.org/c/coreboot/+/56339/comment/b4501043_d69cb43a
PS2, Line 10: {
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124310):
https://review.coreboot.org/c/coreboot/+/56339/comment/5c7ee6eb_061a2fc4
PS2, Line 15: {
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124310):
https://review.coreboot.org/c/coreboot/+/56339/comment/d178741b_b44acf45
PS2, Line 20: {
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124310):
https://review.coreboot.org/c/coreboot/+/56339/comment/d122fe1e_a83818ce
PS2, Line 25: {
that open brace { should be on the previous line
--
To view, visit https://review.coreboot.org/c/coreboot/+/56339
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I66e168c8af5de9862b0724fa397ecd709843af1a
Gerrit-Change-Number: 56339
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Thu, 15 Jul 2021 13:09:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Arthur Heymans has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/56339 )
Change subject: asrock/e3c246d4i: Add board
......................................................................
asrock/e3c246d4i: Add board
This board has upstream Openbmc support so it's quite nice to develop
on.
What is tested:
- ast2500 BMC: video, serial
- 10G NIC
- USB boot: from virtual CD from BMC and real disk
- EDK2 with UefiPayloadPkg
- 8G DIMM in slot0
What does not work:
- SeaBIOS: seems to hang in the menu. Possibly related to running
options of the 10G NICs
TODO: A lot of things are pretty bare in this port like USB and PCIe
setup, but I don't own schematics so it's hard to improve on that.
No idea what the nuvoton superio is hooked up to either.
Change-Id: I66e168c8af5de9862b0724fa397ecd709843af1a
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
A src/mainboard/asrock/e3c246d4i/Kconfig
A src/mainboard/asrock/e3c246d4i/Kconfig.name
A src/mainboard/asrock/e3c246d4i/Makefile.inc
A src/mainboard/asrock/e3c246d4i/board_info.txt
A src/mainboard/asrock/e3c246d4i/bootblock.c
A src/mainboard/asrock/e3c246d4i/devicetree.cb
A src/mainboard/asrock/e3c246d4i/dsdt.asl
A src/mainboard/asrock/e3c246d4i/gpio.c
A src/mainboard/asrock/e3c246d4i/include/mainboard/gpio.h
A src/mainboard/asrock/e3c246d4i/ramstage.c
A src/mainboard/asrock/e3c246d4i/romstage.c
11 files changed, 1,560 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/56339/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56339
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I66e168c8af5de9862b0724fa397ecd709843af1a
Gerrit-Change-Number: 56339
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jamie Chen, Patrick Rudolph.
Hello build bot (Jenkins), Jamie Chen, Kane Chen, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56336
to look at the new patch set (#2).
Change subject: soc/intel/jasperlake: add pcie modphy settings
......................................................................
soc/intel/jasperlake: add pcie modphy settings
This patch adds device tree settings to control pcie modphy tuning
FSP UPDs. With this patch, the pcie modphy can be tuned per board.
BUG=b:192716633
BRANCH=NONE
TEST=build dedede variant coreboot with fw_debug enable and check if
these settings have been changed successfully on fsp debug log.
Change-Id: I80a91d45f9dd8ef218846e1284fdad309313e831
Signed-off-by: Jamie Chen <jamie.chen(a)intel.com>
---
M src/soc/intel/jasperlake/chip.h
M src/soc/intel/jasperlake/romstage/fsp_params.c
2 files changed, 40 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/56336/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56336
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80a91d45f9dd8ef218846e1284fdad309313e831
Gerrit-Change-Number: 56336
Gerrit-PatchSet: 2
Gerrit-Owner: Jamie Chen <jamie.chen(a)intel.com>
Gerrit-Reviewer: Jamie Chen <jamie.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jamie Chen <jamie.chen(a)intel.corp-partner.google.com>
Gerrit-Attention: Jamie Chen <jamie.chen(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Subrata Banik, Arthur Heymans, Morgan Jang, Patrick Rudolph.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56332 )
Change subject: soc/intel/xeon_sp/cpx: Align Cooper Lake CPUID as per EDS
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56332
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I240a06e3b3d7e3dc080f9a9ed1539fadc982495d
Gerrit-Change-Number: 56332
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Thu, 15 Jul 2021 12:02:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment