Sunwei Li has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/56646 )
Change subject: mb/google/dedede/var/cappy2: Add usb port configruation
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/56646
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3bd8f963fe1a637b25608e98d28004ff24003c7
Gerrit-Change-Number: 56646
Gerrit-PatchSet: 2
Gerrit-Owner: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com>
Gerrit-CC: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: abandon
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Karthik Ramasubramanian, Felix Held.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56684 )
Change subject: soc/amd/cezanne/early_fch: Perform early SPI initialization
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56684/comment/d248306a_e0c65fa4
PS1, Line 13: TEST=Build and boot to OS in Guybrush.
Does this add time to the boot?
--
To view, visit https://review.coreboot.org/c/coreboot/+/56684
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibfbe6e16bd6b0dd46c13cecf2a35f0c0b4576b88
Gerrit-Change-Number: 56684
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 29 Jul 2021 07:27:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Karthik Ramasubramanian, Felix Held.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56683 )
Change subject: soc/amd/common/block/spi: Enable host burst to 4 DWORD when using DMA
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56683/comment/549e5f2a_1c8a770b
PS1, Line 9: Early SPI initialization disables 4 DWORD burst.
Why does it need to be disabled at all?
File src/soc/amd/common/block/spi/fch_spi.c:
https://review.coreboot.org/c/coreboot/+/56683/comment/4e3b3bb5_967759dd
PS1, Line 64: if (!CONFIG(SOC_AMD_COMMON_BLOCK_LPC_SPI_DMA))
A debug message might be nice, that it’s skipped.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56683
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I363acdcdb4178a10e4f7eb2bbcbd6d0ca7924f2d
Gerrit-Change-Number: 56683
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 29 Jul 2021 07:26:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Ricardo Quesada, Tim Wawrzynczak, Patrick Rudolph.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56403 )
Change subject: Move post_codes.h to commonlib/console/
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/56403
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie48c4b1d01474237d007c47832613cf1d4a86ae1
Gerrit-Change-Number: 56403
Gerrit-PatchSet: 3
Gerrit-Owner: Ricardo Quesada <ricardoq(a)google.com>
Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Ricardo Quesada <ricardoq(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Thu, 29 Jul 2021 07:17:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: David Wu, Furquan Shaikh, Tyler Wang, Karthik Ramasubramanian.
Hello build bot (Jenkins), David Wu, Furquan Shaikh, Tyler Wang, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56685
to look at the new patch set (#6).
Change subject: mb/google/dedede/var/magolor: Modify SSFC for camera and touchscreen
......................................................................
mb/google/dedede/var/magolor: Modify SSFC for camera and touchscreen
The all shipped magolor and maglia has been set as SSFC= 0x840 (5M MIPI camera)in CBI eeprom.
But the value:0x840 will confilict with the following definied touchcreen field.
It cause some touchsreen no funtion if user make auto-update new firmware.
The CL is a workaround to fix the problem,and it will impact magister and magma project's SSFC value for touchscreen.
The origianl field:
field CAMERA_WFC 38 40
field TS_SOURCE 41 44
Modify filed and mipi camera value to consistent with released CBI bin:
CAMERA_OVTI5675 33 (SSFC = 0x840)
CAMERA_OVTI8856 34 (SSFC = 0x880)
Modified field:
field CAMERA_WFC 38 43
field TS_SOURCE 44 47
BUG=b:194639170
TEST=Build firmware and verify on camera and touch-sreen devices
Change-Id: I13d76ce8b932f483e20ca5388f1c67eb39ba12a1
Signed-off-by: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/dedede/variants/magolor/overridetree.cb
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/56685/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/56685
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13d76ce8b932f483e20ca5388f1c67eb39ba12a1
Gerrit-Change-Number: 56685
Gerrit-PatchSet: 6
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: David Wu, Furquan Shaikh, Tyler Wang, Karthik Ramasubramanian.
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56685 )
Change subject: mb/google/dedede/var/magolor: Modify SSFC for camera and touchscreen
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/56685
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13d76ce8b932f483e20ca5388f1c67eb39ba12a1
Gerrit-Change-Number: 56685
Gerrit-PatchSet: 5
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Thu, 29 Jul 2021 06:53:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: David Wu, Furquan Shaikh, Ren Kuo, Tyler Wang, Karthik Ramasubramanian.
Hello build bot (Jenkins), David Wu, Furquan Shaikh, Tyler Wang, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56685
to look at the new patch set (#5).
Change subject: mb/google/dedede/var/magolor: Modify SSFC for camera and touchscreen
......................................................................
mb/google/dedede/var/magolor: Modify SSFC for camera and touchscreen
The all shipped magolor and maglia has been set as SSFC= 0x840 (5M MIPI camera)in CBI eeprom. But the value:0x840 will confilict with the following definied touchcreen field.
It cause some touchsreen no funtion if user make auto-update new firmware.
The CL is a workaround to fix the problem,and it will impact magister and magma project's SSFC value for touchscreen.
The origianl field:
field CAMERA_WFC 38 40
field TS_SOURCE 41 44
Modify filed and mipi camera value to consistent with released CBI bin:
CAMERA_OVTI5675 33 (SSFC = 0x840)
CAMERA_OVTI8856 34 (SSFC = 0x880)
Modified field:
field CAMERA_WFC 38 43
field TS_SOURCE 44 47
BUG=b:194639170
TEST=Build firmware and verify on camera and touch-sreen devices
Change-Id: I13d76ce8b932f483e20ca5388f1c67eb39ba12a1
Signed-off-by: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/dedede/variants/magolor/overridetree.cb
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/56685/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/56685
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13d76ce8b932f483e20ca5388f1c67eb39ba12a1
Gerrit-Change-Number: 56685
Gerrit-PatchSet: 5
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: David Wu, Furquan Shaikh, Ren Kuo, Tyler Wang, Karthik Ramasubramanian.
Hello build bot (Jenkins), David Wu, Furquan Shaikh, Tyler Wang, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56685
to look at the new patch set (#4).
Change subject: mb/google/dedede/var/magolor: Modify SSFC for camera and touchscreen
......................................................................
mb/google/dedede/var/magolor: Modify SSFC for camera and touchscreen
The all shipped magolor and maglia has been set as SSFC= 0x840 (5M MIPI camera)in CBI eeprom. But the value:0x840 will confilict with the following definied touchcreen field.
It cause some touchsreen no funtion if user make auto-update new firmware.
The CL is a workaround to fix the problem,and it will impact magister and magma project's SSFC value for touchscreen.
The origianl field:
field CAMERA_WFC 38 40
field TS_SOURCE 41 44
Modify filed and mipi camera value to consistent with released CBI bin:
CAMERA_OVTI5675 33 (SSFC = 0x840)
CAMERA_OVTI8856 34 (SSFC = 0x880)
Modified field:
field CAMERA_WFC 38 43
field TS_SOURCE 44 47
BUG=b:189852808
TEST=Build firmware and verify on camera and touch-sreen devices
Change-Id: I13d76ce8b932f483e20ca5388f1c67eb39ba12a1
Signed-off-by: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/dedede/variants/magolor/overridetree.cb
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/56685/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/56685
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13d76ce8b932f483e20ca5388f1c67eb39ba12a1
Gerrit-Change-Number: 56685
Gerrit-PatchSet: 4
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: newpatchset