Attention is currently required from: Sunwei Li, Karthik Ramasubramanian.
Hello build bot (Jenkins), Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56658
to look at the new patch set (#2).
Change subject: mb/google/dedede/var/cappy2: Add Tpm2.0 device support
......................................................................
mb/google/dedede/var/cappy2: Add Tpm2.0 device support
Using Tpm2.0 device instead of the Cr50 in cappy2
BUG=b:191743435
BRANCH=dedede
TEST=tpm2.0 device function is ok
Signed-off-by: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Change-Id: I216ceb6386ad57c9f1982187a4525d89869fa9c4
---
M src/mainboard/google/dedede/variants/cappy2/overridetree.cb
1 file changed, 5 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/56658/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56658
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I216ceb6386ad57c9f1982187a4525d89869fa9c4
Gerrit-Change-Number: 56658
Gerrit-PatchSet: 2
Gerrit-Owner: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com>
Gerrit-CC: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Sunwei Li, Karthik Ramasubramanian.
Hello build bot (Jenkins), Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56647
to look at the new patch set (#2).
Change subject: mb/google/dedede/var/cappy2: Add camera support
......................................................................
mb/google/dedede/var/cappy2: Add camera support
Add camera support in devicetree and associated GPIO configuration.
BUG=b:193397569
BRANCH=dedede
TEST=Camera function is OK
Signed-off-by: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Change-Id: I3275ab408f6a03735a35eaa8025c36df09c9898c
---
A src/mainboard/google/dedede/variants/cappy2/Makefile.inc
A src/mainboard/google/dedede/variants/cappy2/gpio.c
M src/mainboard/google/dedede/variants/cappy2/overridetree.cb
3 files changed, 34 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/56647/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56647
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3275ab408f6a03735a35eaa8025c36df09c9898c
Gerrit-Change-Number: 56647
Gerrit-PatchSet: 2
Gerrit-Owner: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com>
Gerrit-CC: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Henry Sun, Paul Menzel, Werner Zeh.
Hello build bot (Jenkins), Henry Sun, Werner Zeh, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56513
to look at the new patch set (#9).
Change subject: mb/google/dedede/var/cappy2: Add I2C devices
......................................................................
mb/google/dedede/var/cappy2: Add I2C devices
Add tp and audio devices support in devicetree.
BUG=b:193099842
BRANCH=dedede
TEST=i2c devices function is OK
Signed-off-by: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Change-Id: I995e93b5a4c4294d6f6b97c48d14fabf48004d92
---
M src/mainboard/google/dedede/variants/cappy2/overridetree.cb
1 file changed, 56 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/56513/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/56513
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I995e93b5a4c4294d6f6b97c48d14fabf48004d92
Gerrit-Change-Number: 56513
Gerrit-PatchSet: 9
Gerrit-Owner: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com>
Gerrit-CC: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Ravi kumar, Shelley Chen, Paul Menzel, Julius Werner, Mars Chen, mturney mturney.
Vinod Polimera has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52662 )
Change subject: sc7180: Add display support for mipi panels
......................................................................
Patch Set 26:
(12 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52662/comment/527529b9_68b4b728
PS23, Line 8:
> Please add a commit message body explaining the implementation, documenting the datasheet names and […]
updated explanation for mipi panel path. Boot time differs from each panel as they have their own on/init commands. For eDP boards(existing ones), this code will not be run as this is specific to mipi panel boards. I cannot share panel datasheet as it is provided by panel third party vendor.
File src/mainboard/google/trogdor/mainboard.c:
https://review.coreboot.org/c/coreboot/+/52662/comment/c3c5671f_ef730ac0
PS23, Line 76: void
> Good point, we shouldn't call fb_new_framebuffer_info_from_edid() unless initialization was successf […]
Done
File src/mainboard/google/trogdor/panel_driver.c:
https://review.coreboot.org/c/coreboot/+/52662/comment/0331ed60_c26d1159
PS23, Line 33: visionox_init_cmds
> Please add the datasheet name and revision as a comment.
I have just added this panel as an example and we have internal bubs platform to validate this feature using this panel. I cannot share this panel datasheet as mentioned earlier. This panel is already in kernel which can be used as a reference.
https://review.coreboot.org/c/coreboot/+/52662/comment/9146d469_b521ff21
PS23, Line 48: .pixel_clock = 158695,
> One indentation level too deep?
Done
File src/soc/qualcomm/sc7180/display/dsi.c:
https://review.coreboot.org/c/coreboot/+/52662/comment/812fc2c7_9495d69a
PS23, Line 33: PAYLOAD_BYTE_BOUND
> Should the name be prefixed with DSI too?
Done
https://review.coreboot.org/c/coreboot/+/52662/comment/b15eedbe_94c27115
PS23, Line 198: "Panel CMD: count :%d command mode dma test failed\n", count);
> Please fix the indentation level.
Done
https://review.coreboot.org/c/coreboot/+/52662/comment/7d2f1055_4abdd9fc
PS23, Line 222:
> Please remove the blank line.
Done
https://review.coreboot.org/c/coreboot/+/52662/comment/a91b885b_581d0d12
PS23, Line 230: /* select CMD_DMA_PATTERN_SEL to 3 */
> What does 3 mean? Please add that in the comment.
Done
https://review.coreboot.org/c/coreboot/+/52662/comment/143df374_8c070ac4
PS23, Line 231: BIT(16) | BIT(17)
> Can defines be added for this?
Done
https://review.coreboot.org/c/coreboot/+/52662/comment/bccdb88b_11e8b133
PS23, Line 281: if (!pinfo && !pinfo->init_cmd)
> Maybe this should be an assert() instead.
Done
https://review.coreboot.org/c/coreboot/+/52662/comment/21b97074_c4540dac
PS23, Line 289: mdelay(20);
> Where is this 20 ms decumented?
we can remove this 20ms as we are already added 200ms for panel to be up
File src/soc/qualcomm/sc7180/include/soc/display/panel.h:
https://review.coreboot.org/c/coreboot/+/52662/comment/e673ae2b_5e5fc480
PS23, Line 11: int
> size_t or unsigned int?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/52662
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id698265a4e2399ad1c26e026e9a5f8ecd305467f
Gerrit-Change-Number: 52662
Gerrit-PatchSet: 26
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Mars Chen <chenxiangrui(a)huaqin.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Vinod Polimera <vpolimer(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Mars Chen <chenxiangrui(a)huaqin.corp-partner.google.com>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Comment-Date: Thu, 29 Jul 2021 04:48:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Paul Menzel, Zhuohao Lee.
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56388 )
Change subject: mb/google/brya: introduce the brask to the baseboard
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56388/comment/1446e3ad_2c6e8a8d
PS5, Line 7: introduce the brask to the baseboard
> Brask is a new baseboard under mb/google/brya. […]
Yeah, Brask is a new baseboard. Could we mark this as resolved?
--
To view, visit https://review.coreboot.org/c/coreboot/+/56388
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1bb42c7bb2492402de0810bc4ab2e8d8c0e2392b
Gerrit-Change-Number: 56388
Gerrit-PatchSet: 5
Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Comment-Date: Thu, 29 Jul 2021 04:11:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment