Attention is currently required from: David Wu, Furquan Shaikh, Ren Kuo, Tyler Wang, Karthik Ramasubramanian.
Hello build bot (Jenkins), David Wu, Furquan Shaikh, Tyler Wang, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56685
to look at the new patch set (#3).
Change subject: mb/google/dedede/var/magolor: modify SSFC for camera and touchscreen
......................................................................
mb/google/dedede/var/magolor: modify SSFC for camera and touchscreen
The all shipped magolor and maglia has been set as SSFC= 0x840 (5M MIPI camera)in CBI eeprom. But the value:0x840 will confilict with the following definied touchcreen field.
It cause some touchsreen no funtion if user make auto-update new firmware.
The CL is a workaround to fix the problem,and it will impact magister and magma project's SSFC value for touchscreen.
The origianl field:
field CAMERA_WFC 38 40
field TS_SOURCE 41 44
Modify filed and mipi camera value to consistent with released CBI bin:
CAMERA_OVTI5675 33 (SSFC = 0x840)
CAMERA_OVTI8856 34 (SSFC = 0x880)
Modified field:
field CAMERA_WFC 38 43
field TS_SOURCE 44 47
BUG=b:189852808
TEST=Build firmware and verify on camera and touch-sreen devices
Change-Id: I13d76ce8b932f483e20ca5388f1c67eb39ba12a1
Signed-off-by: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/dedede/variants/magolor/overridetree.cb
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/56685/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/56685
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13d76ce8b932f483e20ca5388f1c67eb39ba12a1
Gerrit-Change-Number: 56685
Gerrit-PatchSet: 3
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: David Wu, Furquan Shaikh, Tyler Wang, Karthik Ramasubramanian.
Hello David Wu, Furquan Shaikh, Tyler Wang, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56685
to look at the new patch set (#2).
Change subject: mb/google/dedede/var/magolor: modify SSFC for camera and touchscreen
......................................................................
mb/google/dedede/var/magolor: modify SSFC for camera and touchscreen
The all shipped magolor and maglia has been set as SSFC= 0x840 (5M MIPI camera)in CBI eeprom. But the value:0x840 will confilict with the following definied touchcreen field.
It cause some touchsreen no funtion if user make auto-update new firmware.
The CL is a workaround to fix the problem,and it will impact magister and magma project's
SSFC value for touchscreen.
The origianl field:
field CAMERA_WFC 38 40
field TS_SOURCE 41 44
Modify filed and mipi camera value to consistent with released CBI bin:
CAMERA_OVTI5675 33 (SSFC = 0x840)
CAMERA_OVTI8856 34 (SSFC = 0x880)
Modified field:
field CAMERA_WFC 38 43
field TS_SOURCE 44 47
BUG=b:189852808
TEST=Build firmware and verify on camera and touch-sreen devices
Change-Id: I13d76ce8b932f483e20ca5388f1c67eb39ba12a1
Signed-off-by: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/dedede/variants/magolor/overridetree.cb
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/56685/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56685
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13d76ce8b932f483e20ca5388f1c67eb39ba12a1
Gerrit-Change-Number: 56685
Gerrit-PatchSet: 2
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-CC: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: newpatchset
Ren Kuo has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56685 )
Change subject: mb/google/dedede/var/magolor: modify SSFC for camera and touchscreen
......................................................................
mb/google/dedede/var/magolor: modify SSFC for camera and touchscreen
The all shipped magolor and maglia has been set as SSFC= 0x840 (5M MIPI camera)
in CBI eeprom. But the value:0x840 will confilict with the following definied touchcreen field.
It cause some touchsreen no funtion if user make auto-update new firmware.
The CL is a workaround to fix the problem,and it will impact magister and magma project's
SSFC value for touchscreen.
The origianl field:
field CAMERA_WFC 38 40
field TS_SOURCE 41 44
Modify filed and mipi camera value to consistent with released CBI bin:
CAMERA_OVTI5675 33 (SSFC = 0x840)
CAMERA_OVTI8856 34 (SSFC = 0x880)
Modified field:
field CAMERA_WFC 38 43
field TS_SOURCE 44 47
BUG=b:189852808
TEST=Build firmware and verify on camera and touch-sreen devices
Change-Id: I13d76ce8b932f483e20ca5388f1c67eb39ba12a1
Signed-off-by: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/dedede/variants/magolor/overridetree.cb
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/56685/1
diff --git a/src/mainboard/google/dedede/variants/magolor/overridetree.cb b/src/mainboard/google/dedede/variants/magolor/overridetree.cb
index ef0dd2c..8c21662 100644
--- a/src/mainboard/google/dedede/variants/magolor/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/magolor/overridetree.cb
@@ -1,10 +1,10 @@
fw_config
- field CAMERA_WFC 38 40
+ field CAMERA_WFC 38 43
option CAMERA_NONE 0
- option CAMERA_OVTI5675 1
- option CAMERA_OVTI8856 2
+ option CAMERA_OVTI5675 33
+ option CAMERA_OVTI8856 34
end
- field TS_SOURCE 41 44
+ field TS_SOURCE 44 47
option TS_UNPROVISIONED 0
option TS_ELAN_6915 1
option TS_ELAN_6918 2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56685
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13d76ce8b932f483e20ca5388f1c67eb39ba12a1
Gerrit-Change-Number: 56685
Gerrit-PatchSet: 1
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newchange
Attention is currently required from: Furquan Shaikh, Paul Menzel, Angel Pons, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56650 )
Change subject: soc/intel/common: Don't suppress SPD Module Type value
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/common/smbios.c:
https://review.coreboot.org/c/coreboot/+/56650/comment/a7150cf0_e868c520
PS3, Line 18: /* Translate to DDR2 module type field that SMBIOS code expects. */
> I see conflicting types for DDR2 v/s DDR3 in the SPD spec.
Sorry, i meant to say, excluding DDR2, other DDRx are looks similar so possible to combine those, i will take a look
--
To view, visit https://review.coreboot.org/c/coreboot/+/56650
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia3f38c24efa6a8685639bb607926e2fd9c702ff6
Gerrit-Change-Number: 56650
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Thu, 29 Jul 2021 06:29:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-MessageType: comment
Attention is currently required from: Raul Rangel, Martin Roth, Paul Menzel, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56645 )
Change subject: mb/google/guybrush: Switch from 33MHz to 66MHz SPI Speed
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56645/comment/210ac65d_b43971f4
PS1, Line 7: Switch
> Maybe: Switch from 33 MHz to
Done
https://review.coreboot.org/c/coreboot/+/56645/comment/babcca28_561989d5
PS1, Line 13: TEST=Build and boot to OS in Guybrush
> Please document boot time measurements.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56645
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc5c0580ed0d19f1fffce59df3888dd7963255a1
Gerrit-Change-Number: 56645
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 29 Jul 2021 06:13:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Raul Rangel, Martin Roth, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56645 )
Change subject: mb/google/guybrush: Switch from 33MHz to 66MHz SPI Speed
......................................................................
Patch Set 2:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56645
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc5c0580ed0d19f1fffce59df3888dd7963255a1
Gerrit-Change-Number: 56645
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 29 Jul 2021 06:12:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56683 )
Change subject: soc/amd/common/block/spi: Enable host burst to 4 DWORD when using DMA
......................................................................
soc/amd/common/block/spi: Enable host burst to 4 DWORD when using DMA
Early SPI initialization disables 4 DWORD burst. This causes SPI DMA
operations to stall. Leave it enabled when SPI DMA is used. This is
required to initialize SPI bus at non-default speeds.
BUG=b:194919326
TEST=Build and boot to OS in Guybrush.
Change-Id: I363acdcdb4178a10e4f7eb2bbcbd6d0ca7924f2d
Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com>
---
M src/soc/amd/common/block/spi/fch_spi.c
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/56683/1
diff --git a/src/soc/amd/common/block/spi/fch_spi.c b/src/soc/amd/common/block/spi/fch_spi.c
index 0351847..60bc0cc 100644
--- a/src/soc/amd/common/block/spi/fch_spi.c
+++ b/src/soc/amd/common/block/spi/fch_spi.c
@@ -61,6 +61,7 @@
{
lpc_enable_spi_rom(SPI_ROM_ENABLE);
lpc_enable_spi_prefetch();
- fch_spi_disable_4dw_burst();
+ if (!CONFIG(SOC_AMD_COMMON_BLOCK_LPC_SPI_DMA))
+ fch_spi_disable_4dw_burst();
fch_spi_config_modes();
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/56683
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I363acdcdb4178a10e4f7eb2bbcbd6d0ca7924f2d
Gerrit-Change-Number: 56683
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: newchange