coreboot-gerrit June 2021

coreboot-gerrit@coreboot.org

1 participants
7127 discussions

Change in coreboot[master]: soc/mediatek/mt8195: Enable mt8195 auxadc
by Rex-BC Chen (Code Review) 03 Jun '21

03 Jun '21

Hello Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55155 to look at the new patch set (#3). Change subject: soc/mediatek/mt8195: Enable mt8195 auxadc ...................................................................... soc/mediatek/mt8195: Enable mt8195 auxadc Enable auxadc on MediaTek mt8195 platform. Signed-off-by: Zhiqiang Ma <zhiqiang.ma(a)mediatek.com> Change-Id: Ie79420e20c9ed6155791b490e1b5e4b44a579a49 --- M src/soc/mediatek/mt8195/Makefile.inc M src/soc/mediatek/mt8195/include/soc/addressmap.h A src/soc/mediatek/mt8195/include/soc/auxadc.h A src/soc/mediatek/mt8195/include/soc/efuse.h 4 files changed, 44 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/55155/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/55155 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie79420e20c9ed6155791b490e1b5e4b44a579a49 Gerrit-Change-Number: 55155 Gerrit-PatchSet: 3 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/cherry: Initialize SPM
by Rex-BC Chen (Code Review) 03 Jun '21

03 Jun '21

Attention is currently required from: Hung-Te Lin, Rex-BC Chen, DAWEI CHIEN. Hello Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu, DAWEI CHIEN, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55154 to look at the new patch set (#4). Change subject: mb/google/cherry: Initialize SPM ...................................................................... mb/google/cherry: Initialize SPM This patch adds support for SPM. This adds 43ms to the boot time. TEST=program counter of SPM is correct value after booting up. Signed-off-by: Dawei Chien <dawei.chien(a)mediatek.com> Signed-off-by: Edward-JW Yang <edward-jw.yang(a)mediatek.corp-partner.google.com> Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Change-Id: I5f17f6d51fc9ad2d23c71c3c5cd29fdc777dc071 --- M src/mainboard/google/cherry/mainboard.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/55154/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/55154 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f17f6d51fc9ad2d23c71c3c5cd29fdc777dc071 Gerrit-Change-Number: 55154 Gerrit-PatchSet: 4 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: DAWEI CHIEN <dawei.chien(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: DAWEI CHIEN <dawei.chien(a)mediatek.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/mediatek/mt8195: add SPM loader
by Rex-BC Chen (Code Review) 03 Jun '21

03 Jun '21

Attention is currently required from: Rex-BC Chen. Hello Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu, DAWEI CHIEN, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55140 to look at the new patch set (#7). Change subject: soc/mediatek/mt8195: add SPM loader ...................................................................... soc/mediatek/mt8195: add SPM loader This patch adds support for loading SPM firmware from CBFS to SPM SRAM. SPM needs its own firmware to enable SPM suspend/resume function which turns off several resources such as DRAM/mainpll/26M clk when linux system suspend. TEST=program counter of SPM is correct value after booting up. Change-Id: Ia0f9b9f86e44b293c1cc47213946304c64aea75e Signed-off-by: Dawei Chien <dawei.chien(a)mediatek.com> Signed-off-by: Edward-JW Yang <edward-jw.yang(a)mediatek.corp-partner.google.com> --- M src/soc/mediatek/mt8195/Kconfig M src/soc/mediatek/mt8195/Makefile.inc M src/soc/mediatek/mt8195/include/soc/spm.h A src/soc/mediatek/mt8195/spm.c 4 files changed, 1,155 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/55140/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/55140 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia0f9b9f86e44b293c1cc47213946304c64aea75e Gerrit-Change-Number: 55140 Gerrit-PatchSet: 7 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: DAWEI CHIEN <dawei.chien(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/cbfstool/linux_trampoline.h: Fix typo in comment
by Michael Niewöhner (Code Review) 03 Jun '21

03 Jun '21

Attention is currently required from: Paul Menzel, Angel Pons, Julius Werner, Arthur Heymans, Felix Held. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55161 ) Change subject: util/cbfstool/linux_trampoline.h: Fix typo in comment ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/55161 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I38987119ddabb08c457c9a7c8aecb8025fe2d9d3 Gerrit-Change-Number: 55161 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 03 Jun 2021 09:52:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/cbfstool/linux_trampoline.h: Fix typo in comment
by Kyösti Mälkki (Code Review) 03 Jun '21

03 Jun '21

Attention is currently required from: Paul Menzel, Angel Pons, Julius Werner, Arthur Heymans, Felix Held. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55161 ) Change subject: util/cbfstool/linux_trampoline.h: Fix typo in comment ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/55161 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I38987119ddabb08c457c9a7c8aecb8025fe2d9d3 Gerrit-Change-Number: 55161 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 03 Jun 2021 09:51:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/cbfstool/linux_trampoline.h: Fix typo in comment
by Angel Pons (Code Review) 03 Jun '21

03 Jun '21

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/55161 ) Change subject: util/cbfstool/linux_trampoline.h: Fix typo in comment ...................................................................... util/cbfstool/linux_trampoline.h: Fix typo in comment inlucde ---> include Change-Id: I38987119ddabb08c457c9a7c8aecb8025fe2d9d3 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M util/cbfstool/linux_trampoline.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/55161/1 diff --git a/util/cbfstool/linux_trampoline.h b/util/cbfstool/linux_trampoline.h index 9851b52..839d7ca 100644 --- a/util/cbfstool/linux_trampoline.h +++ b/util/cbfstool/linux_trampoline.h @@ -3,7 +3,7 @@ /* * This file contains #define constants used by both the Linux * trampoline C-code and assembly language code. As such it can only - * contain preprocessor macros. Do not inlucde C language + * contain preprocessor macros. Do not include C language * declarations in this file. */ -- To view, visit https://review.coreboot.org/c/coreboot/+/55161 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I38987119ddabb08c457c9a7c8aecb8025fe2d9d3 Gerrit-Change-Number: 55161 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: cbfstool/linux_trampoline.S: Fix up the e820 table
by Angel Pons (Code Review) 03 Jun '21

03 Jun '21

Attention is currently required from: Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55074 ) Change subject: cbfstool/linux_trampoline.S: Fix up the e820 table ...................................................................... Patch Set 4: (1 comment) File util/cbfstool/linux_trampoline.c: https://review.coreboot.org/c/coreboot/+/55074/comment/a4882095_45d32ff5 PS4, Line 1: /* This file is automatically generated. Do not manually change */ > Huh? Oh, it wasn't manually edited. Autogenerating this file after deleting it results in the exact same thing. -- To view, visit https://review.coreboot.org/c/coreboot/+/55074 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie0e41c66e002919e41590327afe0f543e0037369 Gerrit-Change-Number: 55074 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Rocky Phagura Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 03 Jun 2021 09:44:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Update ACPI device ID of IOM
by Maulik V Vaghela (Code Review) 03 Jun '21

03 Jun '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Patrick Rudolph, Azhar Shaikh. Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54859 ) Change subject: soc/intel/alderlake: Update ACPI device ID of IOM ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Hi Tim, Can you please review and help in merging? -- To view, visit https://review.coreboot.org/c/coreboot/+/54859 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifdfcd0c1534e8204719e59e718688cd42e846e84 Gerrit-Change-Number: 54859 Gerrit-PatchSet: 1 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Azhar Shaikh <azhar.shaikh(a)intel.com> Gerrit-CC: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Azhar Shaikh <azhar.shaikh(a)intel.com> Gerrit-Comment-Date: Thu, 03 Jun 2021 09:43:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Update ACPI device ID of IOM
by Maulik V Vaghela (Code Review) 03 Jun '21

03 Jun '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Patrick Rudolph, Azhar Shaikh. Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54859 ) Change subject: soc/intel/alderlake: Update ACPI device ID of IOM ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/alderlake/acpi/tcss.asl: https://review.coreboot.org/c/coreboot/+/54859/comment/f17548e8_55d04fd5 PS1, Line 320: INTC1079 > The kernel patch has landed here: https://chromium-review.googlesource. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/54859 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifdfcd0c1534e8204719e59e718688cd42e846e84 Gerrit-Change-Number: 54859 Gerrit-PatchSet: 1 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Azhar Shaikh <azhar.shaikh(a)intel.com> Gerrit-CC: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Azhar Shaikh <azhar.shaikh(a)intel.com> Gerrit-Comment-Date: Thu, 03 Jun 2021 09:42:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Azhar Shaikh <azhar.shaikh(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/blipper: Update DPTF parameters
by Tao Xia (Code Review) 03 Jun '21

03 Jun '21

Attention is currently required from: Henry Sun, Sumeet R Pawnikar, Karthik Ramasubramanian. Tao Xia has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54715 ) Change subject: mb/google/dedede/var/blipper: Update DPTF parameters ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/dedede/variants/blipper/overridetree.cb: https://review.coreboot.org/c/coreboot/+/54715/comment/83e64dfc_253fb31a PS1, Line 52: register "policies.passive[0]" = "DPTF_PASSIVE(CPU, TEMP_SENSOR_1, 50, 60000)" > Do you have all the temperature sensors listed in the baseboard devicetree. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/54715 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I379c0ea79a7c27bdd81ed41a54135f7284fb6412 Gerrit-Change-Number: 54715 Gerrit-PatchSet: 2 Gerrit-Owner: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ginger Zhang <zhangqingchun(a)huaqin.corp-partner.google.com> Gerrit-CC: Krystal Han <hanlijing(a)huaqin.corp-partner.google.com> Gerrit-CC: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-CC: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 03 Jun 2021 09:39:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2021