Attention is currently required from: Maulik V Vaghela, Sridhar Siricilla, Subrata Banik, Balaji Manigandan, Deepti Deshatty, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55230 )
Change subject: soc/intel/alderlake: Correct TCSS XHCI Port status offset
......................................................................
Patch Set 2:
(2 comments)
File src/soc/intel/alderlake/xhci.c:
https://review.coreboot.org/c/coreboot/+/55230/comment/3de69ad7_3f82d954
PS1, Line 18: 0x490
> @Tim, I'm working with our internal teams for doc update. sorry for the confusion.
Oh oops I had PCH on the brain, you're right, thanks.
https://review.coreboot.org/c/coreboot/+/55230/comment/c4548ba9_43682e14
PS1, Line 19: 10
> This needs correction as well since ADL-P CPU doesn't support USB2 ports. […]
You're right, should be 0
--
To view, visit https://review.coreboot.org/c/coreboot/+/55230
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I20c77d78f52277a9a979e11303cdb6cdabae7c59
Gerrit-Change-Number: 55230
Gerrit-PatchSet: 2
Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Deepti Deshatty <deepti.deshatty(a)intel.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Attention: Deepti Deshatty <deepti.deshatty(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Fri, 04 Jun 2021 18:44:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Comment-In-Reply-To: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-MessageType: comment
Attention is currently required from: Star Labs, Tim Wawrzynczak, Angel Pons.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54971 )
Change subject: Revert "src/mainboard: Add Star Labs labtop series"
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/54971
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I119b7a81b849bbe3424d73d5fdf9b55481444686
Gerrit-Change-Number: 54971
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Star Labs <admin(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Star Labs <admin(a)starlabs.systems>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Fri, 04 Jun 2021 18:41:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Star Labs, Tim Wawrzynczak, Angel Pons.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54971 )
Change subject: Revert "src/mainboard: Add Star Labs labtop series"
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/54971/comment/859fd235_36cc96c7
PS2, Line 11: could use more work
> How about: "Was submitted too early and out-of-order. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/54971
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I119b7a81b849bbe3424d73d5fdf9b55481444686
Gerrit-Change-Number: 54971
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Star Labs <admin(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Attention: Star Labs <admin(a)starlabs.systems>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Fri, 04 Jun 2021 18:40:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Star Labs, Tim Wawrzynczak.
Hello build bot (Jenkins), Star Labs, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/54971
to look at the new patch set (#3).
Change subject: Revert "src/mainboard: Add Star Labs labtop series"
......................................................................
Revert "src/mainboard: Add Star Labs labtop series"
This reverts commit 2e665eb8daa2963c52092e694a5316dc544a23f5.
Reason for revert: Was submitted too early and out-of-order.
Change-Id: I119b7a81b849bbe3424d73d5fdf9b55481444686
Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
---
M Documentation/distributions.md
M Documentation/mainboard/index.md
D Documentation/mainboard/starlabs/labtop.md
M MAINTAINERS
D src/mainboard/starlabs/Kconfig
D src/mainboard/starlabs/Kconfig.name
D src/mainboard/starlabs/labtop/Kconfig
D src/mainboard/starlabs/labtop/Kconfig.name
D src/mainboard/starlabs/labtop/Makefile.inc
D src/mainboard/starlabs/labtop/acpi/ec.asl
D src/mainboard/starlabs/labtop/acpi/mainboard.asl
D src/mainboard/starlabs/labtop/acpi/sleep.asl
D src/mainboard/starlabs/labtop/acpi/superio.asl
D src/mainboard/starlabs/labtop/board_info.txt
D src/mainboard/starlabs/labtop/bootblock.c
D src/mainboard/starlabs/labtop/cmos.default
D src/mainboard/starlabs/labtop/cmos.layout
D src/mainboard/starlabs/labtop/dsdt.asl
D src/mainboard/starlabs/labtop/hda_verb.c
D src/mainboard/starlabs/labtop/mainboard.c
D src/mainboard/starlabs/labtop/ramstage.c
D src/mainboard/starlabs/labtop/spd/Makefile.inc
D src/mainboard/starlabs/labtop/spd/empty_ddr4.spd.hex
D src/mainboard/starlabs/labtop/spd/micron-MT40A1G16KD-062E-E.spd.hex
D src/mainboard/starlabs/labtop/spd/samsung-K4A8G165WB-BCRC.spd.hex
D src/mainboard/starlabs/labtop/spd/spd.h
D src/mainboard/starlabs/labtop/spd/spd_util.c
D src/mainboard/starlabs/labtop/variants/baseboard/include/baseboard/memory.h
D src/mainboard/starlabs/labtop/variants/baseboard/include/baseboard/romstage.h
D src/mainboard/starlabs/labtop/variants/baseboard/include/baseboard/variants.h
D src/mainboard/starlabs/labtop/variants/cml/Makefile.inc
D src/mainboard/starlabs/labtop/variants/cml/board.fmd
D src/mainboard/starlabs/labtop/variants/cml/data.vbt
D src/mainboard/starlabs/labtop/variants/cml/devicetree.cb
D src/mainboard/starlabs/labtop/variants/cml/gma-mainboard.ads
D src/mainboard/starlabs/labtop/variants/cml/include/variant/gpio.h
D src/mainboard/starlabs/labtop/variants/cml/include/variant/hda_verb.h
D src/mainboard/starlabs/labtop/variants/cml/romstage.c
D src/mainboard/starlabs/labtop/variants/kbl/Makefile.inc
D src/mainboard/starlabs/labtop/variants/kbl/board.fmd
D src/mainboard/starlabs/labtop/variants/kbl/data.vbt
D src/mainboard/starlabs/labtop/variants/kbl/devicetree.cb
D src/mainboard/starlabs/labtop/variants/kbl/gma-mainboard.ads
D src/mainboard/starlabs/labtop/variants/kbl/include/variant/gpio.h
D src/mainboard/starlabs/labtop/variants/kbl/include/variant/hda_verb.h
D src/mainboard/starlabs/labtop/variants/kbl/romstage.c
46 files changed, 0 insertions(+), 2,163 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/54971/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/54971
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I119b7a81b849bbe3424d73d5fdf9b55481444686
Gerrit-Change-Number: 54971
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Star Labs <admin(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Attention: Star Labs <admin(a)starlabs.systems>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Star Labs, Tim Wawrzynczak.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54971 )
Change subject: Revert "src/mainboard: Add Star Labs labtop series"
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/54971/comment/6b8eff47_6b736e5f
PS2, Line 11: could use more work
How about: "Was submitted too early and out-of-order."
--
To view, visit https://review.coreboot.org/c/coreboot/+/54971
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I119b7a81b849bbe3424d73d5fdf9b55481444686
Gerrit-Change-Number: 54971
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Star Labs <admin(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Attention: Star Labs <admin(a)starlabs.systems>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Fri, 04 Jun 2021 18:39:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Star Labs, Tim Wawrzynczak.
Hello build bot (Jenkins), Star Labs,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/54971
to look at the new patch set (#2).
Change subject: Revert "src/mainboard: Add Star Labs labtop series"
......................................................................
Revert "src/mainboard: Add Star Labs labtop series"
This reverts commit 2e665eb8daa2963c52092e694a5316dc544a23f5.
Reason for revert: could use more work
Change-Id: I119b7a81b849bbe3424d73d5fdf9b55481444686
Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
---
M Documentation/distributions.md
M Documentation/mainboard/index.md
D Documentation/mainboard/starlabs/labtop.md
M MAINTAINERS
D src/mainboard/starlabs/Kconfig
D src/mainboard/starlabs/Kconfig.name
D src/mainboard/starlabs/labtop/Kconfig
D src/mainboard/starlabs/labtop/Kconfig.name
D src/mainboard/starlabs/labtop/Makefile.inc
D src/mainboard/starlabs/labtop/acpi/ec.asl
D src/mainboard/starlabs/labtop/acpi/mainboard.asl
D src/mainboard/starlabs/labtop/acpi/sleep.asl
D src/mainboard/starlabs/labtop/acpi/superio.asl
D src/mainboard/starlabs/labtop/board_info.txt
D src/mainboard/starlabs/labtop/bootblock.c
D src/mainboard/starlabs/labtop/cmos.default
D src/mainboard/starlabs/labtop/cmos.layout
D src/mainboard/starlabs/labtop/dsdt.asl
D src/mainboard/starlabs/labtop/hda_verb.c
D src/mainboard/starlabs/labtop/mainboard.c
D src/mainboard/starlabs/labtop/ramstage.c
D src/mainboard/starlabs/labtop/spd/Makefile.inc
D src/mainboard/starlabs/labtop/spd/empty_ddr4.spd.hex
D src/mainboard/starlabs/labtop/spd/micron-MT40A1G16KD-062E-E.spd.hex
D src/mainboard/starlabs/labtop/spd/samsung-K4A8G165WB-BCRC.spd.hex
D src/mainboard/starlabs/labtop/spd/spd.h
D src/mainboard/starlabs/labtop/spd/spd_util.c
D src/mainboard/starlabs/labtop/variants/baseboard/include/baseboard/memory.h
D src/mainboard/starlabs/labtop/variants/baseboard/include/baseboard/romstage.h
D src/mainboard/starlabs/labtop/variants/baseboard/include/baseboard/variants.h
D src/mainboard/starlabs/labtop/variants/cml/Makefile.inc
D src/mainboard/starlabs/labtop/variants/cml/board.fmd
D src/mainboard/starlabs/labtop/variants/cml/data.vbt
D src/mainboard/starlabs/labtop/variants/cml/devicetree.cb
D src/mainboard/starlabs/labtop/variants/cml/gma-mainboard.ads
D src/mainboard/starlabs/labtop/variants/cml/include/variant/gpio.h
D src/mainboard/starlabs/labtop/variants/cml/include/variant/hda_verb.h
D src/mainboard/starlabs/labtop/variants/cml/romstage.c
D src/mainboard/starlabs/labtop/variants/kbl/Makefile.inc
D src/mainboard/starlabs/labtop/variants/kbl/board.fmd
D src/mainboard/starlabs/labtop/variants/kbl/data.vbt
D src/mainboard/starlabs/labtop/variants/kbl/devicetree.cb
D src/mainboard/starlabs/labtop/variants/kbl/gma-mainboard.ads
D src/mainboard/starlabs/labtop/variants/kbl/include/variant/gpio.h
D src/mainboard/starlabs/labtop/variants/kbl/include/variant/hda_verb.h
D src/mainboard/starlabs/labtop/variants/kbl/romstage.c
46 files changed, 0 insertions(+), 2,163 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/54971/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/54971
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I119b7a81b849bbe3424d73d5fdf9b55481444686
Gerrit-Change-Number: 54971
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Star Labs <admin(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Attention: Star Labs <admin(a)starlabs.systems>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Star Labs.
Tim Wawrzynczak has created a revert of this change. ( https://review.coreboot.org/c/coreboot/+/55128 )
Change subject: src/mainboard: Add Star Labs labtop series
......................................................................
--
To view, visit https://review.coreboot.org/c/coreboot/+/55128
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iffa6061b0e600880b0c93746f35b1731e4841e31
Gerrit-Change-Number: 55128
Gerrit-PatchSet: 15
Gerrit-Owner: Star Labs <admin(a)starlabs.systems>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Attention: Star Labs <admin(a)starlabs.systems>
Gerrit-MessageType: revert