coreboot-gerrit May 2021

coreboot-gerrit@coreboot.org

1 participants
6048 discussions

Change in coreboot[master]: util/crossgcc: Update binutils to 2.36.1
by Patrick Georgi (Code Review) 11 May '21

11 May '21

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/54049 ) Change subject: util/crossgcc: Update binutils to 2.36.1 ...................................................................... util/crossgcc: Update binutils to 2.36.1 Change-Id: Ia68d4d9f836ad23fb8f6a7203a78b4ea40c7c43b Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M util/crossgcc/buildgcc R util/crossgcc/patches/binutils-2.36.1_as-ipxe.patch R util/crossgcc/patches/binutils-2.36.1_mips-gold.patch R util/crossgcc/patches/binutils-2.36.1_no-bfd-doc.patch R util/crossgcc/patches/binutils-2.36.1_no-makeinfo.patch D util/crossgcc/sum/binutils-2.35.1.tar.xz.cksum A util/crossgcc/sum/binutils-2.36.1.tar.xz.cksum 7 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/54049/1 diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index abe602c..d588450 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -37,7 +37,7 @@ MPC_VERSION=1.2.1 GCC_VERSION=8.3.0 GCC_AUTOCONF_VERSION=2.69 -BINUTILS_VERSION=2.35.1 +BINUTILS_VERSION=2.36.1 GDB_VERSION=9.2 IASL_VERSION=20200925 PYTHON_VERSION=3.8.5 diff --git a/util/crossgcc/patches/binutils-2.35.1_as-ipxe.patch b/util/crossgcc/patches/binutils-2.36.1_as-ipxe.patch similarity index 100% rename from util/crossgcc/patches/binutils-2.35.1_as-ipxe.patch rename to util/crossgcc/patches/binutils-2.36.1_as-ipxe.patch diff --git a/util/crossgcc/patches/binutils-2.35.1_mips-gold.patch b/util/crossgcc/patches/binutils-2.36.1_mips-gold.patch similarity index 100% rename from util/crossgcc/patches/binutils-2.35.1_mips-gold.patch rename to util/crossgcc/patches/binutils-2.36.1_mips-gold.patch diff --git a/util/crossgcc/patches/binutils-2.35.1_no-bfd-doc.patch b/util/crossgcc/patches/binutils-2.36.1_no-bfd-doc.patch similarity index 100% rename from util/crossgcc/patches/binutils-2.35.1_no-bfd-doc.patch rename to util/crossgcc/patches/binutils-2.36.1_no-bfd-doc.patch diff --git a/util/crossgcc/patches/binutils-2.35.1_no-makeinfo.patch b/util/crossgcc/patches/binutils-2.36.1_no-makeinfo.patch similarity index 100% rename from util/crossgcc/patches/binutils-2.35.1_no-makeinfo.patch rename to util/crossgcc/patches/binutils-2.36.1_no-makeinfo.patch diff --git a/util/crossgcc/sum/binutils-2.35.1.tar.xz.cksum b/util/crossgcc/sum/binutils-2.35.1.tar.xz.cksum deleted file mode 100644 index b1abda8..0000000 --- a/util/crossgcc/sum/binutils-2.35.1.tar.xz.cksum +++ /dev/null @@ -1 +0,0 @@ -45f7a96a2580a422f44b78317f0abf13935fecb6 tarballs/binutils-2.35.1.tar.xz diff --git a/util/crossgcc/sum/binutils-2.36.1.tar.xz.cksum b/util/crossgcc/sum/binutils-2.36.1.tar.xz.cksum new file mode 100644 index 0000000..46571b7 --- /dev/null +++ b/util/crossgcc/sum/binutils-2.36.1.tar.xz.cksum @@ -0,0 +1 @@ +021c97cc0e751e989afb8db025fbd2ae48391831 tarballs/binutils-2.36.1.tar.xz -- To view, visit https://review.coreboot.org/c/coreboot/+/54049 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia68d4d9f836ad23fb8f6a7203a78b4ea40c7c43b Gerrit-Change-Number: 54049 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: util/crossgcc: Update mpc to 1.2.1
by Patrick Georgi (Code Review) 11 May '21

11 May '21

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/54048 ) Change subject: util/crossgcc: Update mpc to 1.2.1 ...................................................................... util/crossgcc: Update mpc to 1.2.1 Change-Id: Ic1422464d0a95c9cba1c417aaa05e4f1fe799d26 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M util/crossgcc/buildgcc D util/crossgcc/sum/mpc-1.2.0.tar.gz.cksum A util/crossgcc/sum/mpc-1.2.1.tar.gz.cksum 3 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/54048/1 diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index d8f25db..abe602c 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -34,7 +34,7 @@ # GCC toolchain version numbers GMP_VERSION=6.2.1 MPFR_VERSION=4.1.0 -MPC_VERSION=1.2.0 +MPC_VERSION=1.2.1 GCC_VERSION=8.3.0 GCC_AUTOCONF_VERSION=2.69 BINUTILS_VERSION=2.35.1 diff --git a/util/crossgcc/sum/mpc-1.2.0.tar.gz.cksum b/util/crossgcc/sum/mpc-1.2.0.tar.gz.cksum deleted file mode 100644 index ed98cc0..0000000 --- a/util/crossgcc/sum/mpc-1.2.0.tar.gz.cksum +++ /dev/null @@ -1 +0,0 @@ -0abdc94acab0c9bfdaa391347cdfd7bbdb1cf017 tarballs/mpc-1.2.0.tar.gz diff --git a/util/crossgcc/sum/mpc-1.2.1.tar.gz.cksum b/util/crossgcc/sum/mpc-1.2.1.tar.gz.cksum new file mode 100644 index 0000000..84254eb --- /dev/null +++ b/util/crossgcc/sum/mpc-1.2.1.tar.gz.cksum @@ -0,0 +1 @@ +2a4919abf445c6eda4e120cd669b8733ce337227 tarballs/mpc-1.2.1.tar.gz -- To view, visit https://review.coreboot.org/c/coreboot/+/54048 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic1422464d0a95c9cba1c417aaa05e4f1fe799d26 Gerrit-Change-Number: 54048 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: util/crossgcc: Update gmp to 6.2.1
by Patrick Georgi (Code Review) 11 May '21

11 May '21

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/54047 ) Change subject: util/crossgcc: Update gmp to 6.2.1 ...................................................................... util/crossgcc: Update gmp to 6.2.1 Change-Id: I871942f66e8fc496ebe523fdab539ea20950a202 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M util/crossgcc/buildgcc R util/crossgcc/patches/gmp-6.2.1_generic-build.patch D util/crossgcc/sum/gmp-6.2.0.tar.xz.cksum A util/crossgcc/sum/gmp-6.2.1.tar.xz.cksum 4 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/54047/1 diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index c947dd4..d8f25db 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -32,7 +32,7 @@ THREADS=1 # GCC toolchain version numbers -GMP_VERSION=6.2.0 +GMP_VERSION=6.2.1 MPFR_VERSION=4.1.0 MPC_VERSION=1.2.0 GCC_VERSION=8.3.0 diff --git a/util/crossgcc/patches/gmp-6.2.0_generic-build.patch b/util/crossgcc/patches/gmp-6.2.1_generic-build.patch similarity index 100% rename from util/crossgcc/patches/gmp-6.2.0_generic-build.patch rename to util/crossgcc/patches/gmp-6.2.1_generic-build.patch diff --git a/util/crossgcc/sum/gmp-6.2.0.tar.xz.cksum b/util/crossgcc/sum/gmp-6.2.0.tar.xz.cksum deleted file mode 100644 index b00b669..0000000 --- a/util/crossgcc/sum/gmp-6.2.0.tar.xz.cksum +++ /dev/null @@ -1 +0,0 @@ -052a5411dc74054240eec58132d2cf41211d0ff6 tarballs/gmp-6.2.0.tar.xz diff --git a/util/crossgcc/sum/gmp-6.2.1.tar.xz.cksum b/util/crossgcc/sum/gmp-6.2.1.tar.xz.cksum new file mode 100644 index 0000000..3ea4232 --- /dev/null +++ b/util/crossgcc/sum/gmp-6.2.1.tar.xz.cksum @@ -0,0 +1 @@ +0578d48607ec0e272177d175fd1807c30b00fdf2 tarballs/gmp-6.2.1.tar.xz -- To view, visit https://review.coreboot.org/c/coreboot/+/54047 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I871942f66e8fc496ebe523fdab539ea20950a202 Gerrit-Change-Number: 54047 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: security/intel/cbnt: Allow to use an externally provided cbnt-prov bin
by Arthur Heymans (Code Review) 11 May '21

11 May '21

Arthur Heymans has submitted this change. ( https://review.coreboot.org/c/coreboot/+/51982 ) Change subject: security/intel/cbnt: Allow to use an externally provided cbnt-prov bin ...................................................................... security/intel/cbnt: Allow to use an externally provided cbnt-prov bin Building the cbnt-prov tool requires godeps which does not work if offline. Therefore, add an option to provide this binary via Kconfig. It's the responsibility of the user to use a compatible binary then. Change-Id: I06ff4ee01bf58cae45648ddb8a30a30b9a7e027a Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/51982 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/security/intel/cbnt/Kconfig M src/security/intel/cbnt/Makefile.inc 2 files changed, 19 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/src/security/intel/cbnt/Kconfig b/src/security/intel/cbnt/Kconfig index a602cca..9d48490 100644 --- a/src/security/intel/cbnt/Kconfig +++ b/src/security/intel/cbnt/Kconfig @@ -87,6 +87,20 @@ Or extract it from a working configuration: $ bg-prov read-config +config INTEL_CBNT_PROV_EXTERNAL_BIN + bool "Use an external cbnt-prov binary" + default n + depends on INTEL_CBNT_GENERATE_BPM || INTEL_CBNT_GENERATE_KM + help + Building cbnt-prov requires godeps which makes it impossible to build + it in an offline environment. A solution is to use an external binary. + +config INTEL_CBNT_PROV_EXTERNAL_BIN_PATH + string "cbnt-prov path" + depends on INTEL_CBNT_PROV_EXTERNAL_BIN + help + Path to the cbnt-prov binary. + config INTEL_CBNT_NEED_KM_PUB_KEY bool diff --git a/src/security/intel/cbnt/Makefile.inc b/src/security/intel/cbnt/Makefile.inc index b0ff9be..9b00d7d 100644 --- a/src/security/intel/cbnt/Makefile.inc +++ b/src/security/intel/cbnt/Makefile.inc @@ -29,12 +29,17 @@ CBNT_PROV:=$(obj)/cbnt-prov CBNT_CFG:=$(obj)/cbnt.json +ifneq ($(CONFIG_INTEL_CBNT_PROV_EXTERNAL_BIN),y) $(CBNT_PROV): printf " CBNT_PROV building tool\n" cd 3rdparty/intel-sec-tools; \ GO111MODULE=on go mod download; \ GO111MODULE=on go mod verify; \ GO111MODULE=on go build -o $(top)/$@ cmd/cbnt-prov/*.go +else +$(CBNT_PROV): $(call strip_quotes, $(CONFIG_INTEL_CBNT_PROV_EXTERNAL_BIN_PATH)) + cp $< $@ +endif $(CBNT_CFG): $(call strip_quotes, $(CONFIG_INTEL_CBNT_CBNT_PROV_CFG_FILE)) cp $(CONFIG_INTEL_CBNT_CBNT_PROV_CFG_FILE) $@ -- To view, visit https://review.coreboot.org/c/coreboot/+/51982 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I06ff4ee01bf58cae45648ddb8a30a30b9a7e027a Gerrit-Change-Number: 51982 Gerrit-PatchSet: 9 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: security/intel/cbnt/Makefile.inc: Use variables for hash alg
by Arthur Heymans (Code Review) 11 May '21

11 May '21

Arthur Heymans has submitted this change. ( https://review.coreboot.org/c/coreboot/+/51975 ) Change subject: security/intel/cbnt/Makefile.inc: Use variables for hash alg ...................................................................... security/intel/cbnt/Makefile.inc: Use variables for hash alg Change-Id: I4113b1496e99c10017fc1d85a4acbbc16d32ea41 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/51975 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/security/intel/cbnt/Makefile.inc 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/src/security/intel/cbnt/Makefile.inc b/src/security/intel/cbnt/Makefile.inc index c20a3dd..b0ff9be 100644 --- a/src/security/intel/cbnt/Makefile.inc +++ b/src/security/intel/cbnt/Makefile.inc @@ -2,6 +2,12 @@ ramstage-y += cmos.c +# As specified in Intel Trusted Execution Technology and Boot Guard Server BIOS +# Specification, document number # 558294 +PK_HASH_ALG_SHA1:=4 +PK_HASH_ALG_SHA256:=11 +PK_HASH_ALG_SHA384:=12 + # The private key also contains the public key, so use that if a private key is provided. ifeq ($(CONFIG_INTEL_CBNT_NEED_KM_PRIV_KEY),y) $(obj)/km_pub.pem: $(call strip_quotes, $(CONFIG_INTEL_CBNT_KM_PRIV_KEY_FILE)) @@ -41,7 +47,6 @@ else $(obj)/bpm_unsigned.bin: $(obj)/coreboot.rom $(CBNT_PROV) printf " CBNT_PROV creating unsigned BPM\n" - # SHA256, SHA1, SHA384 for digest $(CBNT_PROV) bpm-gen $@ $< --revision=$(CONFIG_INTEL_CBNT_BPM_REVISION) \ --svn=$(CONFIG_INTEL_CBNT_BPM_SVN) \ --acmsvn=$(CONFIG_INTEL_CBNT_ACM_SVN) \ @@ -49,7 +54,7 @@ --pbet=$(CONFIG_INTEL_CBNT_PBET) \ --ibbflags=$(CONFIG_INTEL_CBNT_IBB_FLAGS) \ --entrypoint=$(shell printf "%d" 0xfffffff0) \ - --ibbhash=11,4,12 \ + --ibbhash=$(PK_HASH_ALG_SHA256),$(PK_HASH_ALG_SHA1),$(PK_HASH_ALG_SHA384) \ --coreboot \ --sinitmin=$(CONFIG_INTEL_CBNT_SINIT_SVN) \ --txtflags=0 \ @@ -103,7 +108,6 @@ printf " CBNT_PROV creating unsigned KM using config file\n" $(CBNT_PROV) km-gen $@ $< --config=$(CBNT_CFG) else -PK_HASH_ALG_SHA256:=11 # Hardcode as no other options are available for CBnT $(obj)/km_unsigned.bin: $(obj)/km_pub.pem $(obj)/bpm_pub.pem $(CBNT_PROV) printf " CBNT_PROV creating unsigned KM\n" $(CBNT_PROV) km-gen $@ $< --revision=$(CONFIG_INTEL_CBNT_KM_REVISION) \ -- To view, visit https://review.coreboot.org/c/coreboot/+/51975 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4113b1496e99c10017fc1d85a4acbbc16d32ea41 Gerrit-Change-Number: 51975 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: security/intel/cbnt: Allow to use an externally provided cbnt-prov bin
by Angel Pons (Code Review) 11 May '21

11 May '21

Attention is currently required from: Martin Roth, Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51982 ) Change subject: security/intel/cbnt: Allow to use an externally provided cbnt-prov bin ...................................................................... Patch Set 8: Code-Review+2 (1 comment) File src/security/intel/cbnt/Makefile.inc: https://review.coreboot.org/c/coreboot/+/51982/comment/868c0ebc_d98390db PS8, Line 41: $@ > > Should this be `$(top)/$@` ? […] Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/51982 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I06ff4ee01bf58cae45648ddb8a30a30b9a7e027a Gerrit-Change-Number: 51982 Gerrit-PatchSet: 8 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 11 May 2021 08:29:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: security/intel/cbnt: Allow to use an externally provided cbnt-prov bin
by Arthur Heymans (Code Review) 11 May '21

11 May '21

Attention is currently required from: Martin Roth, Angel Pons. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51982 ) Change subject: security/intel/cbnt: Allow to use an externally provided cbnt-prov bin ...................................................................... Patch Set 8: (1 comment) File src/security/intel/cbnt/Makefile.inc: https://review.coreboot.org/c/coreboot/+/51982/comment/fa1fe5b5_4c4ced08 PS8, Line 41: $@ > Should this be `$(top)/$@` ? This is only needed in the previous lines because a 'cd' is issued. -- To view, visit https://review.coreboot.org/c/coreboot/+/51982 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I06ff4ee01bf58cae45648ddb8a30a30b9a7e027a Gerrit-Change-Number: 51982 Gerrit-PatchSet: 8 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 11 May 2021 08:29:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: security/intel/cbnt/Makefile.inc: Use variables for hash alg
by Angel Pons (Code Review) 11 May '21

11 May '21

Attention is currently required from: Martin Roth, Christian Walter, Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51975 ) Change subject: security/intel/cbnt/Makefile.inc: Use variables for hash alg ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/51975 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4113b1496e99c10017fc1d85a4acbbc16d32ea41 Gerrit-Change-Number: 51975 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 11 May 2021 08:23:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: security/intel/cbnt: Allow to use an externally provided cbnt-prov bin
by Angel Pons (Code Review) 11 May '21

11 May '21

Attention is currently required from: Martin Roth, Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51982 ) Change subject: security/intel/cbnt: Allow to use an externally provided cbnt-prov bin ...................................................................... Patch Set 8: Code-Review+1 (1 comment) File src/security/intel/cbnt/Makefile.inc: https://review.coreboot.org/c/coreboot/+/51982/comment/19e09ba1_442352b6 PS8, Line 41: $@ Should this be `$(top)/$@` ? -- To view, visit https://review.coreboot.org/c/coreboot/+/51982 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I06ff4ee01bf58cae45648ddb8a30a30b9a7e027a Gerrit-Change-Number: 51982 Gerrit-PatchSet: 8 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 11 May 2021 08:22:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/octopus/var/fleex: Add cs42l42 HSBIAS setting
by Vitaly Rodionov (Code Review) 11 May '21

11 May '21

Attention is currently required from: Ian Feng. Vitaly Rodionov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53901 ) Change subject: mb/google/octopus/var/fleex: Add cs42l42 HSBIAS setting ...................................................................... Patch Set 3: Code-Review+1 This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/53901 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I12c0e0a0f7490d35d36fe8ccbc940f29e1bb7976 Gerrit-Change-Number: 53901 Gerrit-PatchSet: 3 Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marco Chen <marcochen(a)google.com> Gerrit-Reviewer: Vitaly Rodionov <vitaly.rodionov(a)cirrus.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com> Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Tue, 11 May 2021 08:17:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2021