Attention is currently required from: Paul Menzel.
Hello Felix Singer, build bot (Jenkins), Matt DeVillier,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/54272
to look at the new patch set (#2).
Change subject: Documentation/distributions: Order vendor list lexicographically
......................................................................
Documentation/distributions: Order vendor list lexicographically
Change-Id: Id1f27d68124de745ff0eaad669ee86ce0b57ec09
Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de>
---
M Documentation/distributions.md
1 file changed, 7 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/54272/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/54272
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id1f27d68124de745ff0eaad669ee86ce0b57ec09
Gerrit-Change-Number: 54272
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Menzel.
Hello Felix Singer, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/54271
to look at the new patch set (#2).
Change subject: Documentation/distributions: Separate all vendors by exactly one blank line
......................................................................
Documentation/distributions: Separate all vendors by exactly one blank line
Change-Id: Ib1718dfa174e2a4e9c2c4b5564e196e8483a8f3c
Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de>
---
M Documentation/distributions.md
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/54271/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/54271
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib1718dfa174e2a4e9c2c4b5564e196e8483a8f3c
Gerrit-Change-Number: 54271
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Rex-BC Chen.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54269 )
Change subject: mb/google/cherry: Add fast calibration support
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/54269/comment/196982db_9f53c29d
PS4, Line 7: Add fast calibration support
> this patch is only for dram-k.
mtk_dram_init internally calls dram_run_fast_calibration or dram_run_full_calibration so this is for dram calibration, but not only fast-k.
File src/mainboard/google/cherry/sdram_configs.c:
https://review.coreboot.org/c/coreboot/+/54269/comment/ca53aea4_23e42380
PS4, Line 8: Currently ddr_geometry and ddr_type are not used in Cherry.
> ddr_geometry and ddr_type are only used on 8192 and not used on 8195.
oh that's interesting. so you mean the 8195 dram init code will detect memory module and do everything without external info?
it can identify size, channels, banks, byte mode, ... etc everything?
--
To view, visit https://review.coreboot.org/c/coreboot/+/54269
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib7677baef126ee60bf35da3a4eaf720eaa118a27
Gerrit-Change-Number: 54269
Gerrit-PatchSet: 5
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 14 May 2021 06:11:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org>
Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-MessageType: comment
John Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/54292 )
Change subject: mb/intel/shadowmountain: Update mainboard properties
......................................................................
mb/intel/shadowmountain: Update mainboard properties
This changes updates mainboard properties by adding DFP number and
power_gpio for each DFP.
BUG=b:186521258
TEST=None
Signed-off-by: John Zhao <john.zhao(a)intel.com>
Change-Id: I29480bf77f7df9890bef64a5f9f02074a34dc131
---
M src/mainboard/intel/shadowmountain/variants/baseboard/devicetree.cb
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/54292/1
diff --git a/src/mainboard/intel/shadowmountain/variants/baseboard/devicetree.cb b/src/mainboard/intel/shadowmountain/variants/baseboard/devicetree.cb
index 02b4586..d76db95 100644
--- a/src/mainboard/intel/shadowmountain/variants/baseboard/devicetree.cb
+++ b/src/mainboard/intel/shadowmountain/variants/baseboard/devicetree.cb
@@ -189,6 +189,14 @@
device pci 0a.0 off end # Crash-log SRAM
device pci 0d.0 on end # USB xHCI
device pci 0d.1 off end # USB xDCI (OTG)
+ device pci 0d.2 on
+ chip drivers/intel/usb4/retimer
+ register "dfp" = "{
+ [0] = {.power_gpio = ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_H19),},
+ [1] = {.power_gpio = ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_H19),}}"
+ device generic 0 on end
+ end
+ end
device pci 0d.3 on end # TBT DMA1
device pci 0e.0 off end # VMD
device pci 10.0 off end
--
To view, visit https://review.coreboot.org/c/coreboot/+/54292
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29480bf77f7df9890bef64a5f9f02074a34dc131
Gerrit-Change-Number: 54292
Gerrit-PatchSet: 1
Gerrit-Owner: John Zhao <john.zhao(a)intel.com>
Gerrit-MessageType: newchange
Attention is currently required from: Hung-Te Lin.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54269 )
Change subject: mb/google/cherry: Add fast calibration support
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/54269/comment/fe118a53_7e9a04d6
PS4, Line 7: Add fast calibration support
> We're not just doing fast calibration right? […]
this patch is only for dram-k.
File src/mainboard/google/cherry/sdram_configs.c:
https://review.coreboot.org/c/coreboot/+/54269/comment/4dcc9cd5_8faac4d4
PS4, Line 8: Currently ddr_geometry and ddr_type are not used in Cherry.
> Do we need those info in future? […]
ddr_geometry and ddr_type are only used on 8192 and not used on 8195.
--
To view, visit https://review.coreboot.org/c/coreboot/+/54269
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib7677baef126ee60bf35da3a4eaf720eaa118a27
Gerrit-Change-Number: 54269
Gerrit-PatchSet: 5
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Comment-Date: Fri, 14 May 2021 05:54:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Rex-BC Chen.
Hello Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/54269
to look at the new patch set (#5).
Change subject: mb/google/cherry: Add fast calibration support
......................................................................
mb/google/cherry: Add fast calibration support
Signed-off-by: Ryan Chuang <ryan.chuang(a)mediatek.com>
Change-Id: Ib7677baef126ee60bf35da3a4eaf720eaa118a27
---
M src/mainboard/google/cherry/Makefile.inc
A src/mainboard/google/cherry/boardid.c
M src/mainboard/google/cherry/romstage.c
A src/mainboard/google/cherry/sdram_configs.c
4 files changed, 30 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/54269/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/54269
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib7677baef126ee60bf35da3a4eaf720eaa118a27
Gerrit-Change-Number: 54269
Gerrit-PatchSet: 5
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Angel Pons, Arthur Heymans, Patrick Rudolph.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54280 )
Change subject: nb/intel/gm45: Guard even more macro parameters
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/54280
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icb9d6e8bdafdac7ad820b1629d04e7bdfbcd4b3f
Gerrit-Change-Number: 54280
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Fri, 14 May 2021 05:49:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Henry Sun, Tim Wawrzynczak, Karthik Ramasubramanian.
Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54057 )
Change subject: mb/google/dedede/var/cret: Enable/disable LTE function based on FW_CONFIG
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> Furquan, we need your ACPI shutdown patches 😠[…]
A question for fw_config. Do we already deliver fw_config to ACPI now?
--
To view, visit https://review.coreboot.org/c/coreboot/+/54057
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib926e99aaf9df433a7cff71180ee55431d69f718
Gerrit-Change-Number: 54057
Gerrit-PatchSet: 3
Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Fri, 14 May 2021 05:26:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Duncan Laurie.
Hello build bot (Jenkins), Duncan Laurie, Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52714
to look at the new patch set (#2).
Change subject: mb/google/volteer: Update mainboard properties
......................................................................
mb/google/volteer: Update mainboard properties
This changes updates mainboard properties by adding DFP number, PLD
and power_gpio for each DFP.
BUG=b:186521258
TEST=Validated Retimer firmware upgrade along with upstream kerenl under
no device attached scenario.
Signed-off-by: John Zhao <john.zhao(a)intel.com>
Change-Id: I18f29ce5f8450a8b0f8208a60b8b607f9f0d8817
---
M src/mainboard/google/volteer/variants/voxel/overridetree.cb
1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/52714/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/52714
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I18f29ce5f8450a8b0f8208a60b8b607f9f0d8817
Gerrit-Change-Number: 52714
Gerrit-PatchSet: 2
Gerrit-Owner: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: Duncan Laurie
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Duncan Laurie
Gerrit-MessageType: newpatchset
Attention is currently required from: Tim Wawrzynczak, Duncan Laurie.
John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52712 )
Change subject: drivers/intel/usb4: Update driver to support Retimer firmware upgrade
......................................................................
Patch Set 4:
(15 comments)
Patchset:
PS3:
> Thanks for your patience John!! […]
Thanks.
File src/drivers/intel/usb4/retimer/chip.h:
https://review.coreboot.org/c/coreboot/+/52712/comment/21caec30_8a2a1691
PS2, Line 14: uint8_t dfp_num;
> This could be dropped and the code could instead loop through DFP_NUM_MAX and ignore entries that ha […]
Ack
File src/drivers/intel/usb4/retimer/retimer.c:
https://review.coreboot.org/c/coreboot/+/52712/comment/4926628f_57d2e843
PS3, Line 27: usb4_retimer_iteration_num
> USB4_RETIMER_ITERATION_NUM
Ack
https://review.coreboot.org/c/coreboot/+/52712/comment/7d1a7953_23338980
PS3, Line 28: usb4_retimer_poll_cycle
> USB4_RETIMER_POLL_CYCLE_MS
Ack
https://review.coreboot.org/c/coreboot/+/52712/comment/6d56b648_ac9480e9
PS3, Line 29: match
> suggestion: rename this to `expected_return_value` or similar
Sure, "expected_value" is used.
https://review.coreboot.org/c/coreboot/+/52712/comment/f84f217a_f6dee249
PS3, Line 32: uint8_t
> nit: const
Ack
https://review.coreboot.org/c/coreboot/+/52712/comment/3628ec84_2685c00e
PS3, Line 38: acpigen_write_return_integer
> this takes a `uint64_t` as an arg, so it will write out as a QWORD of 0xFFFFFFFFFFFFFFFF, will the k […]
Yes, it is agreed kernel will properly interpret the returned value -1.
https://review.coreboot.org/c/coreboot/+/52712/comment/8a713e88_75323917
PS3, Line 98: match = USB_PD_MUX_NONE;
: usb4_retimer_execute_ec_cmd(port, USB_RETIMER_FW_UPDATE_GET_MUX, match);
:
: /*
: * Suspend PD
: * Command: USB_RETIMER_FW_UPDATE_SUSPEND_PD
: * Expect return value: 0
: */
: match = 0;
: usb4_retimer_execute_ec_cmd(port, USB_RETIMER_FW_UPDATE_SUSPEND_PD, match);
:
: /*
: * Set MUX USB Mode
: * Command: USB_RETIMER_FW_UPDATE_SUSPEND_PD
: * Expect return value: USB_PD_MUX_USB_ENABLED
: */
: match = USB_PD_MUX_USB_ENABLED;
: usb4_retimer_execute_ec_cmd(port, USB_RETIMER_FW_UPDATE_SET_USB, match);
:
: /*
: * Set MUX Safe Mode
: * Command: USB_RETIMER_FW_UPDATE_SET_SAFE
: * Expect return value: USB_PD_MUX_SAFE_MODE
: */
: match = USB_PD_MUX_SAFE_MODE;
: usb4_retimer_execute_ec_cmd(port, USB_RETIMER_FW_UPDATE_SET_SAFE, match);
:
: /*
: * Set MUX TBT Mode
: * Command: USB_RETIMER_FW_UPDATE_SET_TBT
: * Expect return value: USB_PD_MUX_USB4_ENABLED or USB_PD_MUX_TBT_COMPAT_ENABLED
: */
: match = USB_PD_MUX_USB4_ENABLED;
: usb4_retimer_execute_ec_cmd(port, USB_RETIMER_FW_UPDATE_SET_TBT, match);
: }
> chrome EC can handle these commands to RFWU ?
Yes. Whenever a command set is sent to RFWU, EC will be triggered to process accordingly for those online and offline sequential operations.
https://review.coreboot.org/c/coreboot/+/52712/comment/10c66666_8e38cf1d
PS3, Line 141: Resuem
> Resume
Ack
https://review.coreboot.org/c/coreboot/+/52712/comment/fd5c7882_1f3aa6bc
PS3, Line 171: poewr
> power
Ack
https://review.coreboot.org/c/coreboot/+/52712/comment/3b212939_0c7f9265
PS3, Line 200: snprintf(pwr, sizeof(pwr), "HR.DFP%d%c%s", port, '.', "PWR");
> suggestion: […]
Ack
https://review.coreboot.org/c/coreboot/+/52712/comment/bc218123_343c2b53
PS3, Line 230: snprintf(pwr, sizeof(pwr), "HR.DFP%d%c%s", port, '.', "PWR");
> snprintf(pwr, sizeof(pwr), "HR.DFP%1d. […]
Ack
https://review.coreboot.org/c/coreboot/+/52712/comment/8c4c4d59_6f250c43
PS3, Line 322: LOCAL1_OP
> nit: start with LOCAL0_OP
Ack
https://review.coreboot.org/c/coreboot/+/52712/comment/1f8608a3_5493d7c1
PS3, Line 353: 0xf
> ACPI_STATUS_DEVICE_ALL_ON
Ack
https://review.coreboot.org/c/coreboot/+/52712/comment/6fcf4cb5_1aa20023
PS3, Line 363: UPC_TYPE_PROPRIETARY
> why PROPRIETARY?
There seems no specific PLD for usb4 in the latest ACPI 6.4 and the framework acpi_pld_fill_usb does not have address property for usb4. So here just simply refer to UPC_TYPE_PROPRIETARY and late update its features like shape and visibility.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52712
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I81bef80729f6df57119f5523358620cb015e5406
Gerrit-Change-Number: 52712
Gerrit-PatchSet: 4
Gerrit-Owner: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: Duncan Laurie
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Duncan Laurie
Gerrit-Comment-Date: Fri, 14 May 2021 05:19:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment