coreboot-gerrit May 2021

coreboot-gerrit@coreboot.org

1 participants
6048 discussions

Change in coreboot[master]: Makefile.inc: Drop unused `cbfs-files-processor-vsa`
by Angel Pons (Code Review) 17 May '21

17 May '21

Attention is currently required from: Martin Roth. Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/54360 ) Change subject: Makefile.inc: Drop unused `cbfs-files-processor-vsa` ...................................................................... Makefile.inc: Drop unused `cbfs-files-processor-vsa` VSA (Virtual System Architecture) is specific to AMD Geode CPUs, which are no longer supported in current coreboot. Drop this remnant. Change-Id: I28bf61cb953e3352b59aa91059341e4de8f84f23 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M Makefile.inc 1 file changed, 0 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/54360/1 diff --git a/Makefile.inc b/Makefile.inc index ce70a30..da54e3b 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -308,16 +308,6 @@ mv $(2).tmp $(2)) ####################################################################### -# Link VSA binary to ELF-ish stage -# arg1: source file -# arg2: binary file name -cbfs-files-processor-vsa= \ - $(eval $(2): $(1) ; \ - printf " CREATE $(2) (from $(1))\n"; \ - $(OBJCOPY_ramstage) --set-start 0x20 --adjust-vma 0x60000 -I binary -O elf32-i386 -B i386 $(1) $(2).tmp && \ - $(LD_ramstage) -m elf_i386 -e 0x60020 --section-start .data=0x60000 $(2).tmp -o $(2)) - -####################################################################### # Reduce a .config file to its minimal representation # arg1: input # arg2: output -- To view, visit https://review.coreboot.org/c/coreboot/+/54360 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I28bf61cb953e3352b59aa91059341e4de8f84f23 Gerrit-Change-Number: 54360 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mainboard: Use decimal for `device lapic 0x0 on`
by Angel Pons (Code Review) 17 May '21

17 May '21

Attention is currently required from: Tristan Corrick, Evgeny Zinoviev, Alexander Couzens, Patrick Rudolph. Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/54359 ) Change subject: mainboard: Use decimal for `device lapic 0x0 on` ...................................................................... mainboard: Use decimal for `device lapic 0x0 on` Most boards use `device lapic 0 on` with zero written in decimal. For the sake of consistency, update the remaining boards to follow suit. Change-Id: I1d3b1ac107e33aae11189cdd5e719b8e48b10f08 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/apple/macbookair4_2/devicetree.cb M src/mainboard/asrock/b75pro3-m/devicetree.cb M src/mainboard/asus/maximus_iv_gene-z/devicetree.cb M src/mainboard/asus/p8h61-m_lx/devicetree.cb M src/mainboard/asus/p8h61-m_pro/devicetree.cb M src/mainboard/asus/p8z77-m_pro/devicetree.cb M src/mainboard/compulab/intense_pc/devicetree.cb M src/mainboard/gigabyte/ga-b75m-d3h/devicetree.cb M src/mainboard/google/butterfly/devicetree.cb M src/mainboard/google/link/devicetree.cb M src/mainboard/google/parrot/devicetree.cb M src/mainboard/google/stout/devicetree.cb M src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb M src/mainboard/hp/snb_ivb_laptops/devicetree.cb M src/mainboard/hp/z220_sff_workstation/devicetree.cb M src/mainboard/intel/dcp847ske/devicetree.cb M src/mainboard/intel/emeraldlake2/devicetree.cb M src/mainboard/kontron/ktqm77/devicetree.cb M src/mainboard/lenovo/l520/devicetree.cb M src/mainboard/lenovo/s230u/devicetree.cb M src/mainboard/lenovo/t420/devicetree.cb M src/mainboard/lenovo/t420s/devicetree.cb M src/mainboard/lenovo/t430/devicetree.cb M src/mainboard/lenovo/t430s/devicetree.cb M src/mainboard/lenovo/t440p/devicetree.cb M src/mainboard/lenovo/t520/devicetree.cb M src/mainboard/lenovo/t530/devicetree.cb M src/mainboard/lenovo/x131e/devicetree.cb M src/mainboard/lenovo/x1_carbon_gen1/devicetree.cb M src/mainboard/lenovo/x220/devicetree.cb M src/mainboard/lenovo/x230/devicetree.cb M src/mainboard/msi/ms7707/devicetree.cb M src/mainboard/roda/rv11/variants/rv11/devicetree.cb M src/mainboard/roda/rv11/variants/rw11/devicetree.cb M src/mainboard/samsung/lumpy/devicetree.cb M src/mainboard/samsung/stumpy/devicetree.cb M src/mainboard/sapphire/pureplatinumh61/devicetree.cb M src/mainboard/supermicro/x9scl/devicetree.cb 38 files changed, 38 insertions(+), 38 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/54359/1 diff --git a/src/mainboard/apple/macbookair4_2/devicetree.cb b/src/mainboard/apple/macbookair4_2/devicetree.cb index 4ecc023..3689926 100644 --- a/src/mainboard/apple/macbookair4_2/devicetree.cb +++ b/src/mainboard/apple/macbookair4_2/devicetree.cb @@ -18,7 +18,7 @@ register "acpi_c1" = "1" register "acpi_c2" = "3" register "acpi_c3" = "5" - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end end end diff --git a/src/mainboard/asrock/b75pro3-m/devicetree.cb b/src/mainboard/asrock/b75pro3-m/devicetree.cb index 60816ae..eb0c944 100644 --- a/src/mainboard/asrock/b75pro3-m/devicetree.cb +++ b/src/mainboard/asrock/b75pro3-m/devicetree.cb @@ -18,7 +18,7 @@ register "acpi_c1" = "1" register "acpi_c2" = "3" register "acpi_c3" = "5" - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end end end diff --git a/src/mainboard/asus/maximus_iv_gene-z/devicetree.cb b/src/mainboard/asus/maximus_iv_gene-z/devicetree.cb index 22b474d..5860556 100644 --- a/src/mainboard/asus/maximus_iv_gene-z/devicetree.cb +++ b/src/mainboard/asus/maximus_iv_gene-z/devicetree.cb @@ -6,7 +6,7 @@ register "acpi_c1" = "1" register "acpi_c2" = "3" register "acpi_c3" = "5" - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end end end diff --git a/src/mainboard/asus/p8h61-m_lx/devicetree.cb b/src/mainboard/asus/p8h61-m_lx/devicetree.cb index 73671ee..2761190 100644 --- a/src/mainboard/asus/p8h61-m_lx/devicetree.cb +++ b/src/mainboard/asus/p8h61-m_lx/devicetree.cb @@ -6,7 +6,7 @@ register "acpi_c1" = "1" register "acpi_c2" = "3" register "acpi_c3" = "5" - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end end end diff --git a/src/mainboard/asus/p8h61-m_pro/devicetree.cb b/src/mainboard/asus/p8h61-m_pro/devicetree.cb index 0491f87..a0221fe 100644 --- a/src/mainboard/asus/p8h61-m_pro/devicetree.cb +++ b/src/mainboard/asus/p8h61-m_pro/devicetree.cb @@ -6,7 +6,7 @@ register "acpi_c1" = "1" register "acpi_c2" = "3" register "acpi_c3" = "5" - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end end end diff --git a/src/mainboard/asus/p8z77-m_pro/devicetree.cb b/src/mainboard/asus/p8z77-m_pro/devicetree.cb index 1be5947..a915499 100644 --- a/src/mainboard/asus/p8z77-m_pro/devicetree.cb +++ b/src/mainboard/asus/p8z77-m_pro/devicetree.cb @@ -6,7 +6,7 @@ register "acpi_c1" = "1" register "acpi_c2" = "3" register "acpi_c3" = "5" - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end end end diff --git a/src/mainboard/compulab/intense_pc/devicetree.cb b/src/mainboard/compulab/intense_pc/devicetree.cb index c678bd7..536eef7 100644 --- a/src/mainboard/compulab/intense_pc/devicetree.cb +++ b/src/mainboard/compulab/intense_pc/devicetree.cb @@ -11,7 +11,7 @@ register "acpi_c1" = "1" register "acpi_c2" = "3" register "acpi_c3" = "5" - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end end end diff --git a/src/mainboard/gigabyte/ga-b75m-d3h/devicetree.cb b/src/mainboard/gigabyte/ga-b75m-d3h/devicetree.cb index d753411..8816f10 100644 --- a/src/mainboard/gigabyte/ga-b75m-d3h/devicetree.cb +++ b/src/mainboard/gigabyte/ga-b75m-d3h/devicetree.cb @@ -6,7 +6,7 @@ register "acpi_c2" = "3" register "acpi_c3" = "5" # Magic APIC ID to locate this chip - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end end end diff --git a/src/mainboard/google/butterfly/devicetree.cb b/src/mainboard/google/butterfly/devicetree.cb index 2b9753a..7cdb8a3 100644 --- a/src/mainboard/google/butterfly/devicetree.cb +++ b/src/mainboard/google/butterfly/devicetree.cb @@ -23,7 +23,7 @@ device cpu_cluster 0 on chip cpu/intel/model_206ax # Magic APIC ID to locate this chip - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end register "acpi_c1" = "1" # ACPI(C1) = MWAIT(C1) diff --git a/src/mainboard/google/link/devicetree.cb b/src/mainboard/google/link/devicetree.cb index a99d618..33ef305 100644 --- a/src/mainboard/google/link/devicetree.cb +++ b/src/mainboard/google/link/devicetree.cb @@ -22,7 +22,7 @@ device cpu_cluster 0 on chip cpu/intel/model_206ax # Magic APIC ID to locate this chip - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end register "acpi_c1" = "1" # ACPI(C1) = MWAIT(C1) diff --git a/src/mainboard/google/parrot/devicetree.cb b/src/mainboard/google/parrot/devicetree.cb index a384d87..dbbb5cd 100644 --- a/src/mainboard/google/parrot/devicetree.cb +++ b/src/mainboard/google/parrot/devicetree.cb @@ -22,7 +22,7 @@ device cpu_cluster 0 on chip cpu/intel/model_206ax # Magic APIC ID to locate this chip - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end register "acpi_c1" = "1" # ACPI(C1) = MWAIT(C1) diff --git a/src/mainboard/google/stout/devicetree.cb b/src/mainboard/google/stout/devicetree.cb index 73dce98..1ec596e 100644 --- a/src/mainboard/google/stout/devicetree.cb +++ b/src/mainboard/google/stout/devicetree.cb @@ -22,7 +22,7 @@ device cpu_cluster 0 on chip cpu/intel/model_206ax # Magic APIC ID to locate this chip - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end register "tcc_offset" = "5" # TCC of 95C diff --git a/src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb b/src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb index 8b9a093..0d83267 100644 --- a/src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb +++ b/src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb @@ -11,7 +11,7 @@ register "acpi_c1" = "1" register "acpi_c2" = "3" register "acpi_c3" = "5" - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end end end diff --git a/src/mainboard/hp/snb_ivb_laptops/devicetree.cb b/src/mainboard/hp/snb_ivb_laptops/devicetree.cb index 4cdda4e..7fc936d 100644 --- a/src/mainboard/hp/snb_ivb_laptops/devicetree.cb +++ b/src/mainboard/hp/snb_ivb_laptops/devicetree.cb @@ -20,7 +20,7 @@ register "acpi_c1" = "1" register "acpi_c2" = "3" register "acpi_c3" = "5" - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end end end diff --git a/src/mainboard/hp/z220_sff_workstation/devicetree.cb b/src/mainboard/hp/z220_sff_workstation/devicetree.cb index fd75b1a..0aca0a6 100644 --- a/src/mainboard/hp/z220_sff_workstation/devicetree.cb +++ b/src/mainboard/hp/z220_sff_workstation/devicetree.cb @@ -11,7 +11,7 @@ register "acpi_c1" = "1" register "acpi_c2" = "3" register "acpi_c3" = "5" - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end end end diff --git a/src/mainboard/intel/dcp847ske/devicetree.cb b/src/mainboard/intel/dcp847ske/devicetree.cb index 29c188e..c554b6c 100644 --- a/src/mainboard/intel/dcp847ske/devicetree.cb +++ b/src/mainboard/intel/dcp847ske/devicetree.cb @@ -14,7 +14,7 @@ device cpu_cluster 0 on chip cpu/intel/model_206ax # Magic APIC ID to locate this chip - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end register "acpi_c1" = "1" diff --git a/src/mainboard/intel/emeraldlake2/devicetree.cb b/src/mainboard/intel/emeraldlake2/devicetree.cb index b2f4e6b..80ae789 100644 --- a/src/mainboard/intel/emeraldlake2/devicetree.cb +++ b/src/mainboard/intel/emeraldlake2/devicetree.cb @@ -14,7 +14,7 @@ device cpu_cluster 0 on chip cpu/intel/model_206ax # Magic APIC ID to locate this chip - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end register "acpi_c1" = "3" # ACPI(C1) = MWAIT(C3) diff --git a/src/mainboard/kontron/ktqm77/devicetree.cb b/src/mainboard/kontron/ktqm77/devicetree.cb index 71c9611..950d68a 100644 --- a/src/mainboard/kontron/ktqm77/devicetree.cb +++ b/src/mainboard/kontron/ktqm77/devicetree.cb @@ -5,7 +5,7 @@ device cpu_cluster 0 on chip cpu/intel/model_206ax # Magic APIC ID to locate this chip - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end register "acpi_c1" = "1" # ACPI(C1) = MWAIT(C1) diff --git a/src/mainboard/lenovo/l520/devicetree.cb b/src/mainboard/lenovo/l520/devicetree.cb index 6505d13..4655baa 100644 --- a/src/mainboard/lenovo/l520/devicetree.cb +++ b/src/mainboard/lenovo/l520/devicetree.cb @@ -17,7 +17,7 @@ register "acpi_c1" = "1" register "acpi_c2" = "3" register "acpi_c3" = "5" - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end end end diff --git a/src/mainboard/lenovo/s230u/devicetree.cb b/src/mainboard/lenovo/s230u/devicetree.cb index 7e96054..fbf54d4 100644 --- a/src/mainboard/lenovo/s230u/devicetree.cb +++ b/src/mainboard/lenovo/s230u/devicetree.cb @@ -16,7 +16,7 @@ register "acpi_c1" = "1" register "acpi_c2" = "3" register "acpi_c3" = "5" - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end end end diff --git a/src/mainboard/lenovo/t420/devicetree.cb b/src/mainboard/lenovo/t420/devicetree.cb index 441abf2b..3ba3a2d 100644 --- a/src/mainboard/lenovo/t420/devicetree.cb +++ b/src/mainboard/lenovo/t420/devicetree.cb @@ -18,7 +18,7 @@ device cpu_cluster 0 on chip cpu/intel/model_206ax # Magic APIC ID to locate this chip - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end register "acpi_c1" = "1" # ACPI(C1) = MWAIT(C1) diff --git a/src/mainboard/lenovo/t420s/devicetree.cb b/src/mainboard/lenovo/t420s/devicetree.cb index 6b7c6a2..cfe8929 100644 --- a/src/mainboard/lenovo/t420s/devicetree.cb +++ b/src/mainboard/lenovo/t420s/devicetree.cb @@ -18,7 +18,7 @@ device cpu_cluster 0 on chip cpu/intel/model_206ax # Magic APIC ID to locate this chip - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end register "acpi_c1" = "1" # ACPI(C1) = MWAIT(C1) diff --git a/src/mainboard/lenovo/t430/devicetree.cb b/src/mainboard/lenovo/t430/devicetree.cb index 146eecf..950e83d 100644 --- a/src/mainboard/lenovo/t430/devicetree.cb +++ b/src/mainboard/lenovo/t430/devicetree.cb @@ -19,7 +19,7 @@ register "acpi_c1" = "1" register "acpi_c2" = "3" register "acpi_c3" = "5" - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end end end diff --git a/src/mainboard/lenovo/t430s/devicetree.cb b/src/mainboard/lenovo/t430s/devicetree.cb index 925bfb9..7f95170 100644 --- a/src/mainboard/lenovo/t430s/devicetree.cb +++ b/src/mainboard/lenovo/t430s/devicetree.cb @@ -17,7 +17,7 @@ device cpu_cluster 0 on chip cpu/intel/model_206ax # Magic APIC ID to locate this chip - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end register "acpi_c1" = "1" # ACPI(C1) = MWAIT(C1) diff --git a/src/mainboard/lenovo/t440p/devicetree.cb b/src/mainboard/lenovo/t440p/devicetree.cb index c7af35f..09821be 100644 --- a/src/mainboard/lenovo/t440p/devicetree.cb +++ b/src/mainboard/lenovo/t440p/devicetree.cb @@ -15,7 +15,7 @@ register "ec_present" = "true" device cpu_cluster 0 on chip cpu/intel/haswell - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end end end diff --git a/src/mainboard/lenovo/t520/devicetree.cb b/src/mainboard/lenovo/t520/devicetree.cb index 48d5791..40b005d 100644 --- a/src/mainboard/lenovo/t520/devicetree.cb +++ b/src/mainboard/lenovo/t520/devicetree.cb @@ -18,7 +18,7 @@ device cpu_cluster 0 on chip cpu/intel/model_206ax # Magic APIC ID to locate this chip - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end register "acpi_c1" = "1" # ACPI(C1) = MWAIT(C1) diff --git a/src/mainboard/lenovo/t530/devicetree.cb b/src/mainboard/lenovo/t530/devicetree.cb index 23744e1..b179f4f 100644 --- a/src/mainboard/lenovo/t530/devicetree.cb +++ b/src/mainboard/lenovo/t530/devicetree.cb @@ -18,7 +18,7 @@ device cpu_cluster 0 on chip cpu/intel/model_206ax # Magic APIC ID to locate this chip - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end register "acpi_c1" = "1" # ACPI(C1) = MWAIT(C1) diff --git a/src/mainboard/lenovo/x131e/devicetree.cb b/src/mainboard/lenovo/x131e/devicetree.cb index 7ee982f..dc9e037 100644 --- a/src/mainboard/lenovo/x131e/devicetree.cb +++ b/src/mainboard/lenovo/x131e/devicetree.cb @@ -17,7 +17,7 @@ device cpu_cluster 0 on chip cpu/intel/model_206ax # Magic APIC ID to locate this chip - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end register "acpi_c1" = "1" diff --git a/src/mainboard/lenovo/x1_carbon_gen1/devicetree.cb b/src/mainboard/lenovo/x1_carbon_gen1/devicetree.cb index 5f1ea6b..2707197 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/devicetree.cb +++ b/src/mainboard/lenovo/x1_carbon_gen1/devicetree.cb @@ -15,7 +15,7 @@ device cpu_cluster 0 on chip cpu/intel/model_206ax # Magic APIC ID to locate this chip - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end register "acpi_c1" = "1" # ACPI(C1) = MWAIT(C1) diff --git a/src/mainboard/lenovo/x220/devicetree.cb b/src/mainboard/lenovo/x220/devicetree.cb index de0c9a2..a41cfea 100644 --- a/src/mainboard/lenovo/x220/devicetree.cb +++ b/src/mainboard/lenovo/x220/devicetree.cb @@ -18,7 +18,7 @@ device cpu_cluster 0 on chip cpu/intel/model_206ax # Magic APIC ID to locate this chip - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end register "acpi_c1" = "1" # ACPI(C1) = MWAIT(C1) diff --git a/src/mainboard/lenovo/x230/devicetree.cb b/src/mainboard/lenovo/x230/devicetree.cb index e0557ca..a774d84 100644 --- a/src/mainboard/lenovo/x230/devicetree.cb +++ b/src/mainboard/lenovo/x230/devicetree.cb @@ -18,7 +18,7 @@ device cpu_cluster 0 on chip cpu/intel/model_206ax # Magic APIC ID to locate this chip - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end register "acpi_c1" = "1" # ACPI(C1) = MWAIT(C1) diff --git a/src/mainboard/msi/ms7707/devicetree.cb b/src/mainboard/msi/ms7707/devicetree.cb index a5c7249..083c427 100644 --- a/src/mainboard/msi/ms7707/devicetree.cb +++ b/src/mainboard/msi/ms7707/devicetree.cb @@ -4,7 +4,7 @@ register "acpi_c1" = "1" register "acpi_c2" = "3" register "acpi_c3" = "5" - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end end end diff --git a/src/mainboard/roda/rv11/variants/rv11/devicetree.cb b/src/mainboard/roda/rv11/variants/rv11/devicetree.cb index dc30775..8ba2697 100644 --- a/src/mainboard/roda/rv11/variants/rv11/devicetree.cb +++ b/src/mainboard/roda/rv11/variants/rv11/devicetree.cb @@ -20,7 +20,7 @@ device cpu_cluster 0 on chip cpu/intel/model_206ax # Magic APIC ID to locate this chip - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end register "acpi_c1" = "1" # ACPI(C1) = MWAIT(C1) diff --git a/src/mainboard/roda/rv11/variants/rw11/devicetree.cb b/src/mainboard/roda/rv11/variants/rw11/devicetree.cb index fdba671..7e5555b 100644 --- a/src/mainboard/roda/rv11/variants/rw11/devicetree.cb +++ b/src/mainboard/roda/rv11/variants/rw11/devicetree.cb @@ -20,7 +20,7 @@ device cpu_cluster 0 on chip cpu/intel/model_206ax # Magic APIC ID to locate this chip - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end register "acpi_c1" = "1" # ACPI(C1) = MWAIT(C1) diff --git a/src/mainboard/samsung/lumpy/devicetree.cb b/src/mainboard/samsung/lumpy/devicetree.cb index 6cda62b..85d140c 100644 --- a/src/mainboard/samsung/lumpy/devicetree.cb +++ b/src/mainboard/samsung/lumpy/devicetree.cb @@ -22,7 +22,7 @@ device cpu_cluster 0 on chip cpu/intel/model_206ax # Magic APIC ID to locate this chip - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end register "acpi_c1" = "1" # ACPI(C1) = MWAIT(C1) diff --git a/src/mainboard/samsung/stumpy/devicetree.cb b/src/mainboard/samsung/stumpy/devicetree.cb index 6f49cfe..6ee21af 100644 --- a/src/mainboard/samsung/stumpy/devicetree.cb +++ b/src/mainboard/samsung/stumpy/devicetree.cb @@ -14,7 +14,7 @@ device cpu_cluster 0 on chip cpu/intel/model_206ax # Magic APIC ID to locate this chip - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end register "acpi_c1" = "3" # ACPI(C1) = MWAIT(C3) diff --git a/src/mainboard/sapphire/pureplatinumh61/devicetree.cb b/src/mainboard/sapphire/pureplatinumh61/devicetree.cb index 253e5ed..35c77aa 100644 --- a/src/mainboard/sapphire/pureplatinumh61/devicetree.cb +++ b/src/mainboard/sapphire/pureplatinumh61/devicetree.cb @@ -6,7 +6,7 @@ register "acpi_c1" = "1" register "acpi_c2" = "3" register "acpi_c3" = "5" - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end end end diff --git a/src/mainboard/supermicro/x9scl/devicetree.cb b/src/mainboard/supermicro/x9scl/devicetree.cb index e1924c1..13b2043 100644 --- a/src/mainboard/supermicro/x9scl/devicetree.cb +++ b/src/mainboard/supermicro/x9scl/devicetree.cb @@ -4,7 +4,7 @@ register "acpi_c1" = "1" register "acpi_c2" = "3" register "acpi_c3" = "5" - device lapic 0x0 on end + device lapic 0 on end device lapic 0xacac off end end end -- To view, visit https://review.coreboot.org/c/coreboot/+/54359 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1d3b1ac107e33aae11189cdd5e719b8e48b10f08 Gerrit-Change-Number: 54359 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Attention: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mainboard: Use decimal for `device domain 0x0 on`
by Angel Pons (Code Review) 17 May '21

17 May '21

Attention is currently required from: Evgeny Zinoviev, Alexander Couzens, Patrick Rudolph. Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/54358 ) Change subject: mainboard: Use decimal for `device domain 0x0 on` ...................................................................... mainboard: Use decimal for `device domain 0x0 on` Most boards use `device domain 0 on` with zero written in decimal. For the sake of consistency, update the remaining boards to follow suit. Change-Id: I6e2f0a19d57cfe6fc4e4ac4d14310133ad6b01d8 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/apple/macbookair4_2/devicetree.cb M src/mainboard/asrock/b75pro3-m/devicetree.cb M src/mainboard/asus/h61m-cs/devicetree.cb M src/mainboard/asus/p8h61-m_pro/devicetree.cb M src/mainboard/asus/p8z77-m_pro/devicetree.cb M src/mainboard/compulab/intense_pc/devicetree.cb M src/mainboard/dell/optiplex_9010/devicetree.cb M src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb M src/mainboard/hp/folio_9480m/devicetree.cb M src/mainboard/hp/snb_ivb_laptops/devicetree.cb M src/mainboard/hp/snb_ivb_laptops/variants/2570p/overridetree.cb M src/mainboard/hp/snb_ivb_laptops/variants/2760p/overridetree.cb M src/mainboard/hp/snb_ivb_laptops/variants/8460p/overridetree.cb M src/mainboard/hp/snb_ivb_laptops/variants/8470p/overridetree.cb M src/mainboard/hp/snb_ivb_laptops/variants/8770w/overridetree.cb M src/mainboard/hp/snb_ivb_laptops/variants/folio_9470m/overridetree.cb M src/mainboard/hp/snb_ivb_laptops/variants/revolve_810_g1/overridetree.cb M src/mainboard/hp/z220_sff_workstation/devicetree.cb M src/mainboard/intel/dcp847ske/devicetree.cb M src/mainboard/lenovo/s230u/devicetree.cb M src/mainboard/lenovo/t430/devicetree.cb M src/mainboard/lenovo/t440p/devicetree.cb M src/mainboard/lenovo/x131e/devicetree.cb M src/mainboard/msi/ms7707/devicetree.cb M src/mainboard/sapphire/pureplatinumh61/devicetree.cb 25 files changed, 25 insertions(+), 25 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/54358/1 diff --git a/src/mainboard/apple/macbookair4_2/devicetree.cb b/src/mainboard/apple/macbookair4_2/devicetree.cb index b9c9c15..4ecc023 100644 --- a/src/mainboard/apple/macbookair4_2/devicetree.cb +++ b/src/mainboard/apple/macbookair4_2/devicetree.cb @@ -23,7 +23,7 @@ end end - device domain 0x0 on + device domain 0 on chip southbridge/intel/bd82x6x # Intel Series 6 Cougar Point PCH register "c2_latency" = "0x0065" register "docking_supported" = "0" diff --git a/src/mainboard/asrock/b75pro3-m/devicetree.cb b/src/mainboard/asrock/b75pro3-m/devicetree.cb index 6333c16..60816ae 100644 --- a/src/mainboard/asrock/b75pro3-m/devicetree.cb +++ b/src/mainboard/asrock/b75pro3-m/devicetree.cb @@ -22,7 +22,7 @@ device lapic 0xacac off end end end - device domain 0x0 on + device domain 0 on device pci 00.0 on subsystemid 0x1849 0x0150 end diff --git a/src/mainboard/asus/h61m-cs/devicetree.cb b/src/mainboard/asus/h61m-cs/devicetree.cb index adb39a7..3ec5e5f 100644 --- a/src/mainboard/asus/h61m-cs/devicetree.cb +++ b/src/mainboard/asus/h61m-cs/devicetree.cb @@ -10,7 +10,7 @@ device lapic 0xacac off end end end - device domain 0x0 on + device domain 0 on subsystemid 0x1043 0x844d inherit device pci 00.0 on end # Host bridge device pci 01.0 on end # PCIe Bridge for discrete graphics diff --git a/src/mainboard/asus/p8h61-m_pro/devicetree.cb b/src/mainboard/asus/p8h61-m_pro/devicetree.cb index 804f272..0491f87 100644 --- a/src/mainboard/asus/p8h61-m_pro/devicetree.cb +++ b/src/mainboard/asus/p8h61-m_pro/devicetree.cb @@ -10,7 +10,7 @@ device lapic 0xacac off end end end - device domain 0x0 on + device domain 0 on device pci 00.0 on end # Host bridge device pci 01.0 on end # PCIe bridge for discrete graphics (PCIEX16_1) device pci 02.0 on end # Internal graphics VGA controller diff --git a/src/mainboard/asus/p8z77-m_pro/devicetree.cb b/src/mainboard/asus/p8z77-m_pro/devicetree.cb index 330fa0d..1be5947 100644 --- a/src/mainboard/asus/p8z77-m_pro/devicetree.cb +++ b/src/mainboard/asus/p8z77-m_pro/devicetree.cb @@ -10,7 +10,7 @@ device lapic 0xacac off end end end - device domain 0x0 on + device domain 0 on subsystemid 0x1043 0x84ca inherit device pci 00.0 on end # Host bridge device pci 01.0 on end # PCIe Bridge for discrete graphics diff --git a/src/mainboard/compulab/intense_pc/devicetree.cb b/src/mainboard/compulab/intense_pc/devicetree.cb index 9f28a14..c678bd7 100644 --- a/src/mainboard/compulab/intense_pc/devicetree.cb +++ b/src/mainboard/compulab/intense_pc/devicetree.cb @@ -15,7 +15,7 @@ device lapic 0xacac off end end end - device domain 0x0 on + device domain 0 on device pci 00.0 on # Host bridge subsystemid 0x8086 0x2010 end diff --git a/src/mainboard/dell/optiplex_9010/devicetree.cb b/src/mainboard/dell/optiplex_9010/devicetree.cb index c805b1f..c85f2e4 100644 --- a/src/mainboard/dell/optiplex_9010/devicetree.cb +++ b/src/mainboard/dell/optiplex_9010/devicetree.cb @@ -9,7 +9,7 @@ device lapic 0xacac off end end end - device domain 0x0 on + device domain 0 on subsystemid 0x1028 0x052c inherit device pci 00.0 on end # Host bridge Host bridge diff --git a/src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb b/src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb index b3b670e..8b9a093 100644 --- a/src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb +++ b/src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb @@ -16,7 +16,7 @@ end end - device domain 0x0 on + device domain 0 on subsystemid 0x103c 0x1495 inherit device pci 00.0 on end # Host bridge Host bridge diff --git a/src/mainboard/hp/folio_9480m/devicetree.cb b/src/mainboard/hp/folio_9480m/devicetree.cb index a56a48b..fca4f16 100644 --- a/src/mainboard/hp/folio_9480m/devicetree.cb +++ b/src/mainboard/hp/folio_9480m/devicetree.cb @@ -19,7 +19,7 @@ device lapic 0xacac off end end end - device domain 0x0 on + device domain 0 on subsystemid 0x103c 0x22da inherit device pci 00.0 on end # Host bridge device pci 02.0 on end # Internal graphics VGA controller diff --git a/src/mainboard/hp/snb_ivb_laptops/devicetree.cb b/src/mainboard/hp/snb_ivb_laptops/devicetree.cb index c57ffb6..4cdda4e 100644 --- a/src/mainboard/hp/snb_ivb_laptops/devicetree.cb +++ b/src/mainboard/hp/snb_ivb_laptops/devicetree.cb @@ -24,7 +24,7 @@ device lapic 0xacac off end end end - device domain 0x0 on + device domain 0 on device pci 00.0 on end # Host bridge diff --git a/src/mainboard/hp/snb_ivb_laptops/variants/2570p/overridetree.cb b/src/mainboard/hp/snb_ivb_laptops/variants/2570p/overridetree.cb index 216fe2e..d89492f 100644 --- a/src/mainboard/hp/snb_ivb_laptops/variants/2570p/overridetree.cb +++ b/src/mainboard/hp/snb_ivb_laptops/variants/2570p/overridetree.cb @@ -4,7 +4,7 @@ register "gpu_cpu_backlight" = "0x00000437" register "gpu_panel_power_backlight_off_delay" = "2300" register "gpu_pch_backlight" = "0x0d9c0d9c" - device domain 0x0 on + device domain 0 on subsystemid 0x103c 0x17df inherit device pci 01.0 off end # PCIe Bridge for discrete graphics diff --git a/src/mainboard/hp/snb_ivb_laptops/variants/2760p/overridetree.cb b/src/mainboard/hp/snb_ivb_laptops/variants/2760p/overridetree.cb index 5f2adfa..d911112 100644 --- a/src/mainboard/hp/snb_ivb_laptops/variants/2760p/overridetree.cb +++ b/src/mainboard/hp/snb_ivb_laptops/variants/2760p/overridetree.cb @@ -4,7 +4,7 @@ register "gpu_cpu_backlight" = "0x00000129" register "gpu_panel_power_backlight_off_delay" = "2000" register "gpu_pch_backlight" = "0x02880288" - device domain 0x0 on + device domain 0 on subsystemid 0x103c 0x162a inherit device pci 01.0 off end # PCIe Bridge for discrete graphics diff --git a/src/mainboard/hp/snb_ivb_laptops/variants/8460p/overridetree.cb b/src/mainboard/hp/snb_ivb_laptops/variants/8460p/overridetree.cb index 357e24a..02dc6a4 100644 --- a/src/mainboard/hp/snb_ivb_laptops/variants/8460p/overridetree.cb +++ b/src/mainboard/hp/snb_ivb_laptops/variants/8460p/overridetree.cb @@ -4,7 +4,7 @@ register "gpu_cpu_backlight" = "0x00000129" register "gpu_panel_power_backlight_off_delay" = "2000" register "gpu_pch_backlight" = "0x02880288" - device domain 0x0 on + device domain 0 on subsystemid 0x103c 0x161c inherit device pci 01.0 on end # PCIe Bridge for discrete graphics diff --git a/src/mainboard/hp/snb_ivb_laptops/variants/8470p/overridetree.cb b/src/mainboard/hp/snb_ivb_laptops/variants/8470p/overridetree.cb index b710b25..729db13 100644 --- a/src/mainboard/hp/snb_ivb_laptops/variants/8470p/overridetree.cb +++ b/src/mainboard/hp/snb_ivb_laptops/variants/8470p/overridetree.cb @@ -4,7 +4,7 @@ register "gpu_cpu_backlight" = "0x00000385" register "gpu_panel_power_backlight_off_delay" = "2000" register "gpu_pch_backlight" = "0x0d9c0d9c" - device domain 0x0 on + device domain 0 on subsystemid 0x103c 0x179b inherit device pci 01.0 on end # PCIe Bridge for discrete graphics diff --git a/src/mainboard/hp/snb_ivb_laptops/variants/8770w/overridetree.cb b/src/mainboard/hp/snb_ivb_laptops/variants/8770w/overridetree.cb index 7bffd68..7244acd 100644 --- a/src/mainboard/hp/snb_ivb_laptops/variants/8770w/overridetree.cb +++ b/src/mainboard/hp/snb_ivb_laptops/variants/8770w/overridetree.cb @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-or-later chip northbridge/intel/sandybridge - device domain 0x0 on + device domain 0 on subsystemid 0x103c 0x176c inherit device pci 01.0 on # PCIe Bridge for discrete graphics diff --git a/src/mainboard/hp/snb_ivb_laptops/variants/folio_9470m/overridetree.cb b/src/mainboard/hp/snb_ivb_laptops/variants/folio_9470m/overridetree.cb index b8ddd69..1eb9c4c 100644 --- a/src/mainboard/hp/snb_ivb_laptops/variants/folio_9470m/overridetree.cb +++ b/src/mainboard/hp/snb_ivb_laptops/variants/folio_9470m/overridetree.cb @@ -4,7 +4,7 @@ register "gpu_cpu_backlight" = "0x00000d9c" register "gpu_panel_power_backlight_off_delay" = "2000" register "gpu_pch_backlight" = "0x0d9c0d9c" - device domain 0x0 on + device domain 0 on subsystemid 0x103c 0x18df inherit device pci 01.0 off end # PCIe Bridge for discrete graphics diff --git a/src/mainboard/hp/snb_ivb_laptops/variants/revolve_810_g1/overridetree.cb b/src/mainboard/hp/snb_ivb_laptops/variants/revolve_810_g1/overridetree.cb index af43af7..68b6daa 100644 --- a/src/mainboard/hp/snb_ivb_laptops/variants/revolve_810_g1/overridetree.cb +++ b/src/mainboard/hp/snb_ivb_laptops/variants/revolve_810_g1/overridetree.cb @@ -4,7 +4,7 @@ register "gpu_cpu_backlight" = "0x00000263" register "gpu_panel_power_backlight_off_delay" = "2000" register "gpu_pch_backlight" = "0x02880288" - device domain 0x0 on + device domain 0 on subsystemid 0x103c 0x18f8 inherit device pci 01.0 off end # PCIe Bridge for discrete graphics diff --git a/src/mainboard/hp/z220_sff_workstation/devicetree.cb b/src/mainboard/hp/z220_sff_workstation/devicetree.cb index d884635..fd75b1a 100644 --- a/src/mainboard/hp/z220_sff_workstation/devicetree.cb +++ b/src/mainboard/hp/z220_sff_workstation/devicetree.cb @@ -16,7 +16,7 @@ end end - device domain 0x0 on + device domain 0 on subsystemid 0x103c 0x1791 inherit device pci 00.0 on end # Host bridge Host bridge diff --git a/src/mainboard/intel/dcp847ske/devicetree.cb b/src/mainboard/intel/dcp847ske/devicetree.cb index 0075b94..29c188e 100644 --- a/src/mainboard/intel/dcp847ske/devicetree.cb +++ b/src/mainboard/intel/dcp847ske/devicetree.cb @@ -22,7 +22,7 @@ register "acpi_c3" = "5" end end - device domain 0x0 on + device domain 0 on device pci 00.0 on end # Host bridge device pci 01.0 off end # PCIe Bridge for discrete graphics device pci 02.0 on end # Internal graphics VGA controller diff --git a/src/mainboard/lenovo/s230u/devicetree.cb b/src/mainboard/lenovo/s230u/devicetree.cb index 9546c3e..7e96054 100644 --- a/src/mainboard/lenovo/s230u/devicetree.cb +++ b/src/mainboard/lenovo/s230u/devicetree.cb @@ -20,7 +20,7 @@ device lapic 0xacac off end end end - device domain 0x0 on + device domain 0 on subsystemid 0x17aa 0x2205 inherit device pci 00.0 on end # Host bridge Host bridge diff --git a/src/mainboard/lenovo/t430/devicetree.cb b/src/mainboard/lenovo/t430/devicetree.cb index 3c5c3c3..146eecf 100644 --- a/src/mainboard/lenovo/t430/devicetree.cb +++ b/src/mainboard/lenovo/t430/devicetree.cb @@ -24,7 +24,7 @@ end end - device domain 0x0 on + device domain 0 on subsystemid 0x17aa 0x21f3 inherit chip southbridge/intel/bd82x6x # Intel Series 6 Cougar Point PCH diff --git a/src/mainboard/lenovo/t440p/devicetree.cb b/src/mainboard/lenovo/t440p/devicetree.cb index 590004a..c7af35f 100644 --- a/src/mainboard/lenovo/t440p/devicetree.cb +++ b/src/mainboard/lenovo/t440p/devicetree.cb @@ -19,7 +19,7 @@ device lapic 0xacac off end end end - device domain 0x0 on + device domain 0 on subsystemid 0x17aa 0x220e inherit device pci 00.0 on end # Host bridge Host bridge diff --git a/src/mainboard/lenovo/x131e/devicetree.cb b/src/mainboard/lenovo/x131e/devicetree.cb index 00b5574..7ee982f 100644 --- a/src/mainboard/lenovo/x131e/devicetree.cb +++ b/src/mainboard/lenovo/x131e/devicetree.cb @@ -26,7 +26,7 @@ end end - device domain 0x0 on + device domain 0 on subsystemid 0x17aa 0x21fe inherit device pci 00.0 on end # Host bridge diff --git a/src/mainboard/msi/ms7707/devicetree.cb b/src/mainboard/msi/ms7707/devicetree.cb index f006e13..a5c7249 100644 --- a/src/mainboard/msi/ms7707/devicetree.cb +++ b/src/mainboard/msi/ms7707/devicetree.cb @@ -8,7 +8,7 @@ device lapic 0xacac off end end end - device domain 0x0 on + device domain 0 on subsystemid 0x1462 0x7707 inherit device pci 00.0 on end # Host bridge diff --git a/src/mainboard/sapphire/pureplatinumh61/devicetree.cb b/src/mainboard/sapphire/pureplatinumh61/devicetree.cb index adc65cf..253e5ed 100644 --- a/src/mainboard/sapphire/pureplatinumh61/devicetree.cb +++ b/src/mainboard/sapphire/pureplatinumh61/devicetree.cb @@ -10,7 +10,7 @@ device lapic 0xacac off end end end - device domain 0x0 on + device domain 0 on chip southbridge/intel/bd82x6x # Intel Series 6 Cougar Point PCH register "c2_latency" = "0x0065" register "gen1_dec" = "0x000c0291" -- To view, visit https://review.coreboot.org/c/coreboot/+/54358 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e2f0a19d57cfe6fc4e4ac4d14310133ad6b01d8 Gerrit-Change-Number: 54358 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mainboard: Use decimal for `device cpu_cluster 0x0 on`
by Angel Pons (Code Review) 17 May '21

17 May '21

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/54357 ) Change subject: mainboard: Use decimal for `device cpu_cluster 0x0 on` ...................................................................... mainboard: Use decimal for `device cpu_cluster 0x0 on` Most boards use `device cpu_cluster 0 on` with zero written in decimal. For the sake of consistency, update the remaining boards to follow suit. Change-Id: I083c8f8e9b38ddcc217dc8bf17ae3c9473ba77e9 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/apple/macbookair4_2/devicetree.cb M src/mainboard/asrock/b75pro3-m/devicetree.cb M src/mainboard/asus/h61m-cs/devicetree.cb M src/mainboard/asus/p8h61-m_pro/devicetree.cb M src/mainboard/asus/p8z77-m_pro/devicetree.cb M src/mainboard/compulab/intense_pc/devicetree.cb M src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb M src/mainboard/hp/snb_ivb_laptops/devicetree.cb M src/mainboard/hp/z220_sff_workstation/devicetree.cb M src/mainboard/intel/dcp847ske/devicetree.cb M src/mainboard/lenovo/s230u/devicetree.cb M src/mainboard/lenovo/t430/devicetree.cb M src/mainboard/lenovo/t440p/devicetree.cb M src/mainboard/lenovo/x131e/devicetree.cb M src/mainboard/msi/ms7707/devicetree.cb M src/mainboard/sapphire/pureplatinumh61/devicetree.cb 16 files changed, 16 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/54357/1 diff --git a/src/mainboard/apple/macbookair4_2/devicetree.cb b/src/mainboard/apple/macbookair4_2/devicetree.cb index ee192cf..b9c9c15 100644 --- a/src/mainboard/apple/macbookair4_2/devicetree.cb +++ b/src/mainboard/apple/macbookair4_2/devicetree.cb @@ -13,7 +13,7 @@ register "gpu_panel_power_down_delay" = "500" register "gpu_panel_power_up_delay" = "2000" register "gpu_pch_backlight" = "0x13121312" - device cpu_cluster 0x0 on + device cpu_cluster 0 on chip cpu/intel/model_206ax register "acpi_c1" = "1" register "acpi_c2" = "3" diff --git a/src/mainboard/asrock/b75pro3-m/devicetree.cb b/src/mainboard/asrock/b75pro3-m/devicetree.cb index af69d58..6333c16 100644 --- a/src/mainboard/asrock/b75pro3-m/devicetree.cb +++ b/src/mainboard/asrock/b75pro3-m/devicetree.cb @@ -13,7 +13,7 @@ register "gpu_panel_power_down_delay" = "0" register "gpu_panel_power_up_delay" = "0" register "gpu_pch_backlight" = "0x00000000" - device cpu_cluster 0x0 on + device cpu_cluster 0 on chip cpu/intel/model_206ax register "acpi_c1" = "1" register "acpi_c2" = "3" diff --git a/src/mainboard/asus/h61m-cs/devicetree.cb b/src/mainboard/asus/h61m-cs/devicetree.cb index 60f8191..adb39a7 100644 --- a/src/mainboard/asus/h61m-cs/devicetree.cb +++ b/src/mainboard/asus/h61m-cs/devicetree.cb @@ -1,7 +1,7 @@ ## SPDX-License-Identifier: GPL-2.0-or-later chip northbridge/intel/sandybridge - device cpu_cluster 0x0 on + device cpu_cluster 0 on chip cpu/intel/model_206ax register "acpi_c1" = "1" register "acpi_c2" = "3" diff --git a/src/mainboard/asus/p8h61-m_pro/devicetree.cb b/src/mainboard/asus/p8h61-m_pro/devicetree.cb index 60e54ae..804f272 100644 --- a/src/mainboard/asus/p8h61-m_pro/devicetree.cb +++ b/src/mainboard/asus/p8h61-m_pro/devicetree.cb @@ -1,7 +1,7 @@ ## SPDX-License-Identifier: GPL-2.0-only chip northbridge/intel/sandybridge - device cpu_cluster 0x0 on + device cpu_cluster 0 on chip cpu/intel/model_206ax register "acpi_c1" = "1" register "acpi_c2" = "3" diff --git a/src/mainboard/asus/p8z77-m_pro/devicetree.cb b/src/mainboard/asus/p8z77-m_pro/devicetree.cb index 1d1a244..330fa0d 100644 --- a/src/mainboard/asus/p8z77-m_pro/devicetree.cb +++ b/src/mainboard/asus/p8z77-m_pro/devicetree.cb @@ -1,7 +1,7 @@ ## SPDX-License-Identifier: GPL-2.0-only chip northbridge/intel/sandybridge - device cpu_cluster 0x0 on + device cpu_cluster 0 on chip cpu/intel/model_206ax register "acpi_c1" = "1" register "acpi_c2" = "3" diff --git a/src/mainboard/compulab/intense_pc/devicetree.cb b/src/mainboard/compulab/intense_pc/devicetree.cb index b48dae3..9f28a14 100644 --- a/src/mainboard/compulab/intense_pc/devicetree.cb +++ b/src/mainboard/compulab/intense_pc/devicetree.cb @@ -6,7 +6,7 @@ register "gpu_dp_c_hotplug" = "4" register "gpu_dp_d_hotplug" = "4" - device cpu_cluster 0x0 on + device cpu_cluster 0 on chip cpu/intel/model_206ax # FIXME: check all registers register "acpi_c1" = "1" register "acpi_c2" = "3" diff --git a/src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb b/src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb index db902be..b3b670e 100644 --- a/src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb +++ b/src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb @@ -6,7 +6,7 @@ register "gpu_dp_c_hotplug" = "0" register "gpu_dp_d_hotplug" = "0" - device cpu_cluster 0x0 on + device cpu_cluster 0 on chip cpu/intel/model_206ax register "acpi_c1" = "1" register "acpi_c2" = "3" diff --git a/src/mainboard/hp/snb_ivb_laptops/devicetree.cb b/src/mainboard/hp/snb_ivb_laptops/devicetree.cb index a449200..c57ffb6 100644 --- a/src/mainboard/hp/snb_ivb_laptops/devicetree.cb +++ b/src/mainboard/hp/snb_ivb_laptops/devicetree.cb @@ -15,7 +15,7 @@ register "gpu_panel_power_down_delay" = "230" register "gpu_panel_power_up_delay" = "300" register "gpu_pch_backlight" = "0x02880288" - device cpu_cluster 0x0 on + device cpu_cluster 0 on chip cpu/intel/model_206ax register "acpi_c1" = "1" register "acpi_c2" = "3" diff --git a/src/mainboard/hp/z220_sff_workstation/devicetree.cb b/src/mainboard/hp/z220_sff_workstation/devicetree.cb index f1ec5e7..d884635 100644 --- a/src/mainboard/hp/z220_sff_workstation/devicetree.cb +++ b/src/mainboard/hp/z220_sff_workstation/devicetree.cb @@ -6,7 +6,7 @@ register "gpu_dp_c_hotplug" = "0" register "gpu_dp_d_hotplug" = "0" - device cpu_cluster 0x0 on + device cpu_cluster 0 on chip cpu/intel/model_206ax register "acpi_c1" = "1" register "acpi_c2" = "3" diff --git a/src/mainboard/intel/dcp847ske/devicetree.cb b/src/mainboard/intel/dcp847ske/devicetree.cb index 7a56844..0075b94 100644 --- a/src/mainboard/intel/dcp847ske/devicetree.cb +++ b/src/mainboard/intel/dcp847ske/devicetree.cb @@ -11,7 +11,7 @@ # Enable DVI Hotplug with 6ms pulse register "gpu_dp_b_hotplug" = "0x06" - device cpu_cluster 0x0 on + device cpu_cluster 0 on chip cpu/intel/model_206ax # Magic APIC ID to locate this chip device lapic 0x0 on end diff --git a/src/mainboard/lenovo/s230u/devicetree.cb b/src/mainboard/lenovo/s230u/devicetree.cb index eb92d78..9546c3e 100644 --- a/src/mainboard/lenovo/s230u/devicetree.cb +++ b/src/mainboard/lenovo/s230u/devicetree.cb @@ -11,7 +11,7 @@ register "gpu_panel_power_down_delay" = "500" register "gpu_panel_power_up_delay" = "600" register "gpu_pch_backlight" = "0x041e041e" - device cpu_cluster 0x0 on + device cpu_cluster 0 on chip cpu/intel/model_206ax register "acpi_c1" = "1" register "acpi_c2" = "3" diff --git a/src/mainboard/lenovo/t430/devicetree.cb b/src/mainboard/lenovo/t430/devicetree.cb index cafc2df..3c5c3c3 100644 --- a/src/mainboard/lenovo/t430/devicetree.cb +++ b/src/mainboard/lenovo/t430/devicetree.cb @@ -14,7 +14,7 @@ register "gpu_cpu_backlight" = "0x1155" register "gpu_pch_backlight" = "0x11551155" - device cpu_cluster 0x0 on + device cpu_cluster 0 on chip cpu/intel/model_206ax # FIXME: check all registers register "acpi_c1" = "1" register "acpi_c2" = "3" diff --git a/src/mainboard/lenovo/t440p/devicetree.cb b/src/mainboard/lenovo/t440p/devicetree.cb index 8db28cb..590004a 100644 --- a/src/mainboard/lenovo/t440p/devicetree.cb +++ b/src/mainboard/lenovo/t440p/devicetree.cb @@ -13,7 +13,7 @@ .backlight_pwm_hz = 220, }" register "ec_present" = "true" - device cpu_cluster 0x0 on + device cpu_cluster 0 on chip cpu/intel/haswell device lapic 0x0 on end device lapic 0xacac off end diff --git a/src/mainboard/lenovo/x131e/devicetree.cb b/src/mainboard/lenovo/x131e/devicetree.cb index 2627fae..00b5574 100644 --- a/src/mainboard/lenovo/x131e/devicetree.cb +++ b/src/mainboard/lenovo/x131e/devicetree.cb @@ -14,7 +14,7 @@ register "gpu_cpu_backlight" = "0x1155" register "gpu_pch_backlight" = "0x11551155" - device cpu_cluster 0x0 on + device cpu_cluster 0 on chip cpu/intel/model_206ax # Magic APIC ID to locate this chip device lapic 0x0 on end diff --git a/src/mainboard/msi/ms7707/devicetree.cb b/src/mainboard/msi/ms7707/devicetree.cb index 2ccf7c6..f006e13 100644 --- a/src/mainboard/msi/ms7707/devicetree.cb +++ b/src/mainboard/msi/ms7707/devicetree.cb @@ -1,5 +1,5 @@ chip northbridge/intel/sandybridge - device cpu_cluster 0x0 on + device cpu_cluster 0 on chip cpu/intel/model_206ax register "acpi_c1" = "1" register "acpi_c2" = "3" diff --git a/src/mainboard/sapphire/pureplatinumh61/devicetree.cb b/src/mainboard/sapphire/pureplatinumh61/devicetree.cb index 82117fb..adc65cf 100644 --- a/src/mainboard/sapphire/pureplatinumh61/devicetree.cb +++ b/src/mainboard/sapphire/pureplatinumh61/devicetree.cb @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-or-later chip northbridge/intel/sandybridge - device cpu_cluster 0x0 on + device cpu_cluster 0 on chip cpu/intel/model_206ax register "acpi_c1" = "1" register "acpi_c2" = "3" -- To view, visit https://review.coreboot.org/c/coreboot/+/54357 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I083c8f8e9b38ddcc217dc8bf17ae3c9473ba77e9 Gerrit-Change-Number: 54357 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/dedede: To support ELAN Touchpad device on I2C0
by Kirk Wang (Code Review) 17 May '21

17 May '21

Attention is currently required from: Alex1 Kao, Karthik Ramasubramanian. Kirk Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52936 ) Change subject: mb/google/dedede: To support ELAN Touchpad device on I2C0 ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/52936 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15b9cb0d0276b5e2dd06694530cc35e5643efb9d Gerrit-Change-Number: 52936 Gerrit-PatchSet: 5 Gerrit-Owner: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Kirk Wang <kirk_wang(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Paul2 Huang <paul2_huang(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ariel Chang <ariel_chang(a)pegatron.corp-partner.google.com> Gerrit-CC: Hao Chou <hao_chou(a)pegatron.corp-partner.google.com> Gerrit-CC: Wayne3 Wang <wayne3_wang(a)pegatron.corp-partner.google.com> Gerrit-Attention: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 17 May 2021 10:18:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede: To support ELAN Touchpad device on I2C0
by Alex1 Kao (Code Review) 17 May '21

17 May '21

Attention is currently required from: Karthik Ramasubramanian. Alex1 Kao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52936 ) Change subject: mb/google/dedede: To support ELAN Touchpad device on I2C0 ...................................................................... Patch Set 5: (2 comments) File src/mainboard/google/dedede/variants/pirika/overridetree.cb: https://review.coreboot.org/c/coreboot/+/52936/comment/10cc1e2e_18bd89ca PS2, Line 21: .speed_config[0] = { : .speed = I2C_SPEED_FAST, : .scl_lcnt = 190, : .scl_hcnt = 100, : .sda_hold = 40, : } > The recommendation is to configure the measured rise_time_ns and fall_time_ns here instead of scl_lc […] Thanks for your advice. I will create another issue for I2C clock tuning. Now I re-uploaded this CL for support ELAN Touchpad device on I2C0. https://review.coreboot.org/c/coreboot/+/52936/comment/d0c1f76f_43aa61cb PS2, Line 52: device domain 0 on > Prefer to split this CL into 4 parts […] Got it, thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/52936 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15b9cb0d0276b5e2dd06694530cc35e5643efb9d Gerrit-Change-Number: 52936 Gerrit-PatchSet: 5 Gerrit-Owner: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Kirk Wang <kirk_wang(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Paul2 Huang <paul2_huang(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ariel Chang <ariel_chang(a)pegatron.corp-partner.google.com> Gerrit-CC: Hao Chou <hao_chou(a)pegatron.corp-partner.google.com> Gerrit-CC: Wayne3 Wang <wayne3_wang(a)pegatron.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 17 May 2021 10:16:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede: To support ELAN Touchpad device on I2C0
by Alex1 Kao (Code Review) 17 May '21

17 May '21

Alex1 Kao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52936 ) Change subject: mb/google/dedede: To support ELAN Touchpad device on I2C0 ...................................................................... Patch Set 4: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/52936 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15b9cb0d0276b5e2dd06694530cc35e5643efb9d Gerrit-Change-Number: 52936 Gerrit-PatchSet: 4 Gerrit-Owner: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Kirk Wang <kirk_wang(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Paul2 Huang <paul2_huang(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ariel Chang <ariel_chang(a)pegatron.corp-partner.google.com> Gerrit-CC: Hao Chou <hao_chou(a)pegatron.corp-partner.google.com> Gerrit-CC: Wayne3 Wang <wayne3_wang(a)pegatron.corp-partner.google.com> Gerrit-Comment-Date: Mon, 17 May 2021 10:00:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/x86/smm: Fix uintptr_t type mismatches in print statements
by Werner Zeh (Code Review) 17 May '21

17 May '21

Attention is currently required from: Paul Menzel. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54341 ) Change subject: cpu/x86/smm: Fix uintptr_t type mismatches in print statements ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I think the problem is, that’s it’s dependent on the host build system, how uintptr_t is defined. Isn't this target code which we are looking at? If yes, it is compiled with the cross-gcc coreboot provides with a well-defined context. How does the host-gcc act here? -- To view, visit https://review.coreboot.org/c/coreboot/+/54341 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I32bff397c8a033fe34390e6c1a7dfe773707a4e8 Gerrit-Change-Number: 54341 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 17 May 2021 09:58:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede: To support ELAN Touchpad device on I2C0
by Alex1 Kao (Code Review) 17 May '21

17 May '21

Attention is currently required from: Paul2 Huang, Shou-Chieh Hsu. Alex1 Kao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52936 ) Change subject: mb/google/dedede: To support ELAN Touchpad device on I2C0 ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/52936 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15b9cb0d0276b5e2dd06694530cc35e5643efb9d Gerrit-Change-Number: 52936 Gerrit-PatchSet: 4 Gerrit-Owner: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Kirk Wang <kirk_wang(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Paul2 Huang <paul2_huang(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ariel Chang <ariel_chang(a)pegatron.corp-partner.google.com> Gerrit-CC: Hao Chou <hao_chou(a)pegatron.corp-partner.google.com> Gerrit-CC: Wayne3 Wang <wayne3_wang(a)pegatron.corp-partner.google.com> Gerrit-Attention: Paul2 Huang <paul2_huang(a)pegatron.corp-partner.google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Comment-Date: Mon, 17 May 2021 09:56:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede: To support ELAN Touchpad device on I2C0
by Alex1 Kao (Code Review) 17 May '21

17 May '21

Attention is currently required from: Paul2 Huang, Alex1 Kao, Shou-Chieh Hsu. Hello build bot (Jenkins), Henry Sun, Paul2 Huang, Kirk Wang, Shou-Chieh Hsu, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52936 to look at the new patch set (#4). Change subject: mb/google/dedede: To support ELAN Touchpad device on I2C0 ...................................................................... mb/google/dedede: To support ELAN Touchpad device on I2C0 Add ELAN Touchpad device under I2C0 BUG=b:1883731661 BRANCH=dedede TEST=emerge-dedede coreboot Signed-off-by: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com> Change-Id: I15b9cb0d0276b5e2dd06694530cc35e5643efb9d --- M src/mainboard/google/dedede/variants/pirika/overridetree.cb 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/52936/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/52936 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15b9cb0d0276b5e2dd06694530cc35e5643efb9d Gerrit-Change-Number: 52936 Gerrit-PatchSet: 4 Gerrit-Owner: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Kirk Wang <kirk_wang(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Paul2 Huang <paul2_huang(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ariel Chang <ariel_chang(a)pegatron.corp-partner.google.com> Gerrit-CC: Hao Chou <hao_chou(a)pegatron.corp-partner.google.com> Gerrit-CC: Wayne3 Wang <wayne3_wang(a)pegatron.corp-partner.google.com> Gerrit-Attention: Paul2 Huang <paul2_huang(a)pegatron.corp-partner.google.com> Gerrit-Attention: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2021